)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"eda5c879043611034fefef017395930c782aed67","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix warning messages in check_remote_connectivity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A RemoteClient object has no \"host\" attribute, so currently we cause an"},{"line_number":10,"context_line":"exception when trying to handle an error in the"},{"line_number":11,"context_line":"check_remote_connectivity function. Add a new message parameter to be"},{"line_number":12,"context_line":"used in the warning that is logged."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_25921558","line":9,"range":{"start_line":9,"start_character":2,"end_line":9,"end_character":14},"updated":"2017-06-06 08:05:57.000000000","message":"check_remote_connectivity is not expected to take RemoteClient right now. if you want to change it in a patch, this patch should be a part of that patch.","commit_id":"c4c79a1e60dfe7fe66956c7466f4faeabdd74c2c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1c6529553ece7709c1816db29b1ad6f284e60f16","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix warning messages in check_remote_connectivity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A RemoteClient object has no \"host\" attribute, so currently we cause an"},{"line_number":10,"context_line":"exception when trying to handle an error in the"},{"line_number":11,"context_line":"check_remote_connectivity function. Add a new message parameter to be"},{"line_number":12,"context_line":"used in the warning that is logged."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_a7616914","line":9,"in_reply_to":"df140735_0eb720f7","updated":"2017-06-07 02:41:04.000000000","message":"you\u0027re right about the comment and the tempest version.\n(i haven\u0027t noticed the comment. thank you for pointing out.)\nhowever, as far as i see, all existing callers of this method in our tree are using ssh.Client.\ni guess either the comment or those callers should be fixed.\nhow do you think?","commit_id":"c4c79a1e60dfe7fe66956c7466f4faeabdd74c2c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a76e19a2539c6980adddd43082600e30f415593c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix warning messages in check_remote_connectivity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A RemoteClient object has no \"host\" attribute, so currently we cause an"},{"line_number":10,"context_line":"exception when trying to handle an error in the"},{"line_number":11,"context_line":"check_remote_connectivity function. Add a new message parameter to be"},{"line_number":12,"context_line":"used in the warning that is logged."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_0eb720f7","line":9,"in_reply_to":"df140735_25921558","updated":"2017-06-06 16:05:51.000000000","message":"It isn\u0027t? The comment at the start of the function seems to indicate otherwise.\n\nThe patch where I am using it is https://review.openstack.org/#/c/469074/5 which copies a lot of code from tempest, instead of doing this patch I could copy even more code, but I don\u0027t think that that would be the right direction.","commit_id":"c4c79a1e60dfe7fe66956c7466f4faeabdd74c2c"}],"neutron/tests/tempest/scenario/base.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a76e19a2539c6980adddd43082600e30f415593c","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                                   nic\u003dNone):"},{"line_number":229,"context_line":"        \"\"\"check ping server via source ssh connection"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        :param source: RemoteClient: an ssh connection from which to ping"},{"line_number":232,"context_line":"        :param dest: and IP to ping against"},{"line_number":233,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":234,"context_line":"        :param nic: specific network interface to ping from"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_6e39fca1","side":"PARENT","line":231,"updated":"2017-06-06 16:05:51.000000000","message":"This says that \"source\" is a RemoteClient object, that would match what tempest does.","commit_id":"a4ed05dcad3eb8563bbbc212358a4ec01d1c59d9"}]}
