)]}'
{"neutron/services/trunk/drivers/openvswitch/agent/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0d5c5baf11fdb10b8265ffc2ec5dfff65ee67239","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # we could check for incompatibilities and abort the creation request"},{"line_number":87,"context_line":"        # only if the trunk is indeed associated with ports that have security"},{"line_number":88,"context_line":"        # groups and QoS rules, though this would be a lot more work."},{"line_number":89,"context_line":"        if \"iptables_hybrid\" in cfg.CONF.securitygroup.firewall_driver:"},{"line_number":90,"context_line":"            LOG.warning(_LW("},{"line_number":91,"context_line":"                \"Firewall driver iptables_hybrid is not compatible with \""},{"line_number":92,"context_line":"                \"trunk ports. Trunk %(trunk_id)s may be insecure.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_38b46ef1","line":89,"updated":"2017-06-06 15:23:10.000000000","message":"any reason not to do this at init?","commit_id":"e9b3e0ac44ae130e53b646f2e74978df3e6fce3a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"295d4504d43d2014f21faaf09e48fd1095319fe2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # we could check for incompatibilities and abort the creation request"},{"line_number":87,"context_line":"        # only if the trunk is indeed associated with ports that have security"},{"line_number":88,"context_line":"        # groups and QoS rules, though this would be a lot more work."},{"line_number":89,"context_line":"        if \"iptables_hybrid\" in cfg.CONF.securitygroup.firewall_driver:"},{"line_number":90,"context_line":"            LOG.warning(_LW("},{"line_number":91,"context_line":"                \"Firewall driver iptables_hybrid is not compatible with \""},{"line_number":92,"context_line":"                \"trunk ports. Trunk %(trunk_id)s may be insecure.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_53e265d6","line":89,"in_reply_to":"df140735_38b46ef1","updated":"2017-06-06 15:45:59.000000000","message":"Init of the agent startup? At that point we don\u0027t know whether a trunk request is ever going into the system (let alone know the trunk ID) so the warning is going to fall on deaf ears.\n\nThat said, should trunks exist in the system, this warning will show again at startup because of the agent will attempt to synchronize trunk states with the server and thus catch the misconfiguration.","commit_id":"e9b3e0ac44ae130e53b646f2e74978df3e6fce3a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7217b749e61ec03803c5e7db0dd69d55cd4051eb","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # we could check for incompatibilities and abort the creation request"},{"line_number":87,"context_line":"        # only if the trunk is indeed associated with ports that have security"},{"line_number":88,"context_line":"        # groups and QoS rules, though this would be a lot more work."},{"line_number":89,"context_line":"        if \"iptables_hybrid\" in cfg.CONF.securitygroup.firewall_driver:"},{"line_number":90,"context_line":"            LOG.warning(_LW("},{"line_number":91,"context_line":"                \"Firewall driver iptables_hybrid is not compatible with \""},{"line_number":92,"context_line":"                \"trunk ports. Trunk %(trunk_id)s may be insecure.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_8e61e714","line":89,"in_reply_to":"df140735_53e265d6","updated":"2017-06-06 20:52:41.000000000","message":"ok. understood","commit_id":"e9b3e0ac44ae130e53b646f2e74978df3e6fce3a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"c44a7782668f6e1722202e75e6de3016c6a384a5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                    \"%(subports)s: %(err)s\"),"},{"line_number":77,"context_line":"                    {\u0027event\u0027: event_type, \u0027subports\u0027: subports, \u0027err\u0027: e})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @local_registry.receives(constants.TRUNK, [local_events.BEFORE_READ])"},{"line_number":80,"context_line":"    def check_trunk_dependencies("},{"line_number":81,"context_line":"        self, resource, event, trigger, **kwargs):"},{"line_number":82,"context_line":"        # The OVS trunk driver does not work with iptables firewall and QoS."}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_40883f1e","line":79,"updated":"2017-06-09 22:20:00.000000000","message":"this subscribes to BEFORE_READ and you add a BEFORE_CREATE event. Is that right?","commit_id":"e2bb928732027a0720fcb752774a515faf7e0e7e"}]}