)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b97188f3d64d999c8a54b0a12345750508e56101","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When l3 agent node is rebooted, if HA network port status is already"},{"line_number":10,"context_line":"ACTIVE in DB, agent will get this status from server and then spawn"},{"line_number":11,"context_line":"the keepalived (though l2 agent might not have wired the port),"},{"line_number":12,"context_line":"resulting in multiple HA masters active at the same time."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To fix this, when the L3 agent starts up we can have it explicitly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf091321_717d331b","line":11,"range":{"start_line":11,"start_character":16,"end_line":11,"end_character":61},"updated":"2017-06-08 19:01:40.000000000","message":"how is it possible? don\u0027t we have provisioning blocks that ensure that no port become ACTIVE until all participating components (l2 agent included) clear their blocks?","commit_id":"500b255278ab41974fe6febd9a3ed13de5ddf3f6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fc98a78a332d9f306ef4fcd3979ae016345d53e4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When l3 agent node is rebooted, if HA network port status is already"},{"line_number":10,"context_line":"ACTIVE in DB, agent will get this status from server and then spawn"},{"line_number":11,"context_line":"the keepalived (though l2 agent might not have wired the port),"},{"line_number":12,"context_line":"resulting in multiple HA masters active at the same time."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To fix this, when the L3 agent starts up we can have it explicitly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf091321_8ff8a2c4","line":11,"range":{"start_line":11,"start_character":16,"end_line":11,"end_character":61},"in_reply_to":"bf091321_54857dac","updated":"2017-06-08 19:58:32.000000000","message":"OK, I get the scenario now, thanks.","commit_id":"500b255278ab41974fe6febd9a3ed13de5ddf3f6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1e6911027d2f2295c868088cd05675d5e9e8b922","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When l3 agent node is rebooted, if HA network port status is already"},{"line_number":10,"context_line":"ACTIVE in DB, agent will get this status from server and then spawn"},{"line_number":11,"context_line":"the keepalived (though l2 agent might not have wired the port),"},{"line_number":12,"context_line":"resulting in multiple HA masters active at the same time."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To fix this, when the L3 agent starts up we can have it explicitly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf091321_54857dac","line":11,"range":{"start_line":11,"start_character":16,"end_line":11,"end_character":61},"in_reply_to":"bf091321_717d331b","updated":"2017-06-08 19:45:38.000000000","message":"The issue this is addressing is after a system reboot that has wiped out flows, etc and the L2 agent hasn\u0027t started up yet. The port will still be ACTIVE in the data model and the L3 agent will use that info to mistakenly think the L2 network is ready.\n\nBy forcing into DOWN, we will require the L2 agent to essentially ack that the port is indeed ACTIVE by reacting to the port update and calling update_device_up.","commit_id":"500b255278ab41974fe6febd9a3ed13de5ddf3f6"}],"neutron/api/rpc/handlers/l3_rpc.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"91e01c04f46b941a334e21c2714b3ec985dccf4f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027status\u0027: [constants.PORT_STATUS_ACTIVE]}"},{"line_number":67,"context_line":"        ports \u003d self.plugin.get_ports(context, filters\u003ddevice_filter)"},{"line_number":68,"context_line":"        for p in ports:"},{"line_number":69,"context_line":"            if p.get(portbindings.HOST_ID) \u003d\u003d host_id:"},{"line_number":70,"context_line":"                LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":71,"context_line":"                          \"HA network port %(port)s status to DOWN.\","},{"line_number":72,"context_line":"                          {\"host\": host_id, \"port\": p[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_483419de","line":69,"updated":"2017-06-05 13:50:30.000000000","message":"Can we specify host_id in the filter?","commit_id":"30d7a6f55a0a44c85b936bb2b7766b3505c58dc4"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"0e35f3e2f6bbb25b79631e8426e5ad11e394ea31","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027status\u0027: [constants.PORT_STATUS_ACTIVE]}"},{"line_number":67,"context_line":"        ports \u003d self.plugin.get_ports(context, filters\u003ddevice_filter)"},{"line_number":68,"context_line":"        for p in ports:"},{"line_number":69,"context_line":"            if p.get(portbindings.HOST_ID) \u003d\u003d host_id:"},{"line_number":70,"context_line":"                LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":71,"context_line":"                          \"HA network port %(port)s status to DOWN.\","},{"line_number":72,"context_line":"                          {\"host\": host_id, \"port\": p[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_d389fe74","line":69,"in_reply_to":"df140735_483419de","updated":"2017-06-05 14:26:20.000000000","message":"No. _get_ports_query[1] is applying filters on Port and IPAllocation models. Then _make_port_dict[2] is calling port binding extension [3] [4].\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L1352\n[2] https://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L1380\n[3] https://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_common.py#L195\n[4]https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L609","commit_id":"30d7a6f55a0a44c85b936bb2b7766b3505c58dc4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"189a9bb199628462490474c9642cc3e105b613e6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027status\u0027: [constants.PORT_STATUS_ACTIVE]}"},{"line_number":67,"context_line":"        ports \u003d self.plugin.get_ports(context, filters\u003ddevice_filter)"},{"line_number":68,"context_line":"        for p in ports:"},{"line_number":69,"context_line":"            if p.get(portbindings.HOST_ID) \u003d\u003d host_id:"},{"line_number":70,"context_line":"                LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":71,"context_line":"                          \"HA network port %(port)s status to DOWN.\","},{"line_number":72,"context_line":"                          {\"host\": host_id, \"port\": p[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_f39762eb","line":69,"in_reply_to":"df140735_d389fe74","updated":"2017-06-05 14:45:11.000000000","message":"Sigh, forgot that was an extension.","commit_id":"30d7a6f55a0a44c85b936bb2b7766b3505c58dc4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"91e01c04f46b941a334e21c2714b3ec985dccf4f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if p.get(portbindings.HOST_ID) \u003d\u003d host_id:"},{"line_number":70,"context_line":"                LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":71,"context_line":"                          \"HA network port %(port)s status to DOWN.\","},{"line_number":72,"context_line":"                          {\"host\": host_id, \"port\": p[\u0027id\u0027]})"},{"line_number":73,"context_line":"                self.plugin.update_port("},{"line_number":74,"context_line":"                    context,"},{"line_number":75,"context_line":"                    p[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_68ac7dec","line":72,"updated":"2017-06-05 13:50:30.000000000","message":"This is going to be printed out a lot on a restart, perhaps putting this outside the loop is better, even though the port id will not be printed.","commit_id":"30d7a6f55a0a44c85b936bb2b7766b3505c58dc4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"189a9bb199628462490474c9642cc3e105b613e6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if p.get(portbindings.HOST_ID) \u003d\u003d host_id:"},{"line_number":70,"context_line":"                LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":71,"context_line":"                          \"HA network port %(port)s status to DOWN.\","},{"line_number":72,"context_line":"                          {\"host\": host_id, \"port\": p[\u0027id\u0027]})"},{"line_number":73,"context_line":"                self.plugin.update_port("},{"line_number":74,"context_line":"                    context,"},{"line_number":75,"context_line":"                    p[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_93eb8676","line":72,"in_reply_to":"df140735_33e5da38","updated":"2017-06-05 14:45:11.000000000","message":"Right, just print one more generic message without %(port)s in it.","commit_id":"30d7a6f55a0a44c85b936bb2b7766b3505c58dc4"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"0e35f3e2f6bbb25b79631e8426e5ad11e394ea31","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if p.get(portbindings.HOST_ID) \u003d\u003d host_id:"},{"line_number":70,"context_line":"                LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":71,"context_line":"                          \"HA network port %(port)s status to DOWN.\","},{"line_number":72,"context_line":"                          {\"host\": host_id, \"port\": p[\u0027id\u0027]})"},{"line_number":73,"context_line":"                self.plugin.update_port("},{"line_number":74,"context_line":"                    context,"},{"line_number":75,"context_line":"                    p[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_33e5da38","line":72,"in_reply_to":"df140735_68ac7dec","updated":"2017-06-05 14:26:20.000000000","message":"You mean one print for all ports?","commit_id":"30d7a6f55a0a44c85b936bb2b7766b3505c58dc4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b97188f3d64d999c8a54b0a12345750508e56101","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    if p.get(portbindings.HOST_ID) \u003d\u003d host_id]"},{"line_number":70,"context_line":"        if not ha_ports:"},{"line_number":71,"context_line":"            return"},{"line_number":72,"context_line":"        LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":73,"context_line":"                  \"HA network ports %(ha_ports)s status to DOWN.\","},{"line_number":74,"context_line":"                  {\"host\": host_id, \"ha_ports\": ha_ports})"},{"line_number":75,"context_line":"        for p in ha_ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_b1e62be8","line":72,"updated":"2017-06-08 19:01:40.000000000","message":"that\u0027s not always correct. fullsync may be triggered by e.g. server side agent update.","commit_id":"500b255278ab41974fe6febd9a3ed13de5ddf3f6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"283d0038b129c4ee3bd86509a47d75057f1feedc","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    if p.get(portbindings.HOST_ID) \u003d\u003d host_id]"},{"line_number":70,"context_line":"        if not ha_ports:"},{"line_number":71,"context_line":"            return"},{"line_number":72,"context_line":"        LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":73,"context_line":"                  \"HA network ports %(ha_ports)s status to DOWN.\","},{"line_number":74,"context_line":"                  {\"host\": host_id, \"ha_ports\": ha_ports})"},{"line_number":75,"context_line":"        for p in ha_ports:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_712413c7","line":72,"in_reply_to":"bf091321_b1e62be8","updated":"2017-06-08 19:15:15.000000000","message":"True, or when there is an exception thrown when syncing.","commit_id":"500b255278ab41974fe6febd9a3ed13de5ddf3f6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b97188f3d64d999c8a54b0a12345750508e56101","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                  \"HA network ports %(ha_ports)s status to DOWN.\","},{"line_number":74,"context_line":"                  {\"host\": host_id, \"ha_ports\": ha_ports})"},{"line_number":75,"context_line":"        for p in ha_ports:"},{"line_number":76,"context_line":"            self.plugin.update_port("},{"line_number":77,"context_line":"                context, p, {\u0027port\u0027: {\u0027status\u0027: constants.PORT_STATUS_DOWN}})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def get_router_ids(self, context, host):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_9104477d","line":76,"updated":"2017-06-08 19:01:40.000000000","message":"it seems to me that instead of piggy-backing on get_router_ids, if agent really wants to switch all ports to DOWN, it should do that explicitly (update_port_statuses?), and maybe do it by utilizing provisioning blocks mechanism.\n\nThough my general question still stands first: how come we get ports in ACTIVE when l2 agent is not ready?","commit_id":"500b255278ab41974fe6febd9a3ed13de5ddf3f6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1ed105b21f479476b8e5941ffba50073fcf77360","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                  \"HA network ports %(ha_ports)s status to DOWN.\","},{"line_number":74,"context_line":"                  {\"host\": host_id, \"ha_ports\": ha_ports})"},{"line_number":75,"context_line":"        for p in ha_ports:"},{"line_number":76,"context_line":"            self.plugin.update_port("},{"line_number":77,"context_line":"                context, p, {\u0027port\u0027: {\u0027status\u0027: constants.PORT_STATUS_DOWN}})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def get_router_ids(self, context, host):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_f14b8384","line":76,"in_reply_to":"bf091321_9104477d","updated":"2017-06-08 19:12:01.000000000","message":"Nevermind this, I now see https://review.openstack.org/#/c/471575","commit_id":"500b255278ab41974fe6febd9a3ed13de5ddf3f6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f0d7e20ffa10b512d9d32457f3fc3c532f250283","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\"Returns IDs of routers scheduled to l3 agent on \u003chost\u003e"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        This will autoschedule unhosted routers to l3 agent on \u003chost\u003e and then"},{"line_number":83,"context_line":"        return all ids of routers scheduled to it."},{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":"        if utils.is_extension_supported("},{"line_number":86,"context_line":"            self.plugin, constants.PORT_BINDING_EXT_ALIAS):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_94f795f6","line":83,"updated":"2017-06-08 19:20:58.000000000","message":"maybe also update the docstring to reflect new behavior.","commit_id":"500b255278ab41974fe6febd9a3ed13de5ddf3f6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5ca2c5b29a26cca7701e6df0422852a5ee313bda","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    if p.get(portbindings.HOST_ID) \u003d\u003d host_id]"},{"line_number":70,"context_line":"        if not ha_ports:"},{"line_number":71,"context_line":"            return"},{"line_number":72,"context_line":"        LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":73,"context_line":"                  \"HA network ports %(ha_ports)s status to DOWN.\","},{"line_number":74,"context_line":"                  {\"host\": host_id, \"ha_ports\": ha_ports})"},{"line_number":75,"context_line":"        for p in ha_ports:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_bf75fbfc","line":72,"updated":"2017-06-09 17:45:51.000000000","message":"you still have stated here that the agent restarted, but fullsync can be triggered in other cases (agent record updated; sync failed).","commit_id":"6c6a8ad9f8ae36430bd1bf55b7910ca15f6fd609"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"bda9e420fa8d66bb113e52e452b38c97336ddd60","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    if p.get(portbindings.HOST_ID) \u003d\u003d host_id]"},{"line_number":70,"context_line":"        if not ha_ports:"},{"line_number":71,"context_line":"            return"},{"line_number":72,"context_line":"        LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":73,"context_line":"                  \"HA network ports %(ha_ports)s status to DOWN.\","},{"line_number":74,"context_line":"                  {\"host\": host_id, \"ha_ports\": ha_ports})"},{"line_number":75,"context_line":"        for p in ha_ports:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_93ed8827","line":72,"in_reply_to":"7f231b9d_45e9747e","updated":"2017-06-11 06:12:26.000000000","message":"I have updated it","commit_id":"6c6a8ad9f8ae36430bd1bf55b7910ca15f6fd609"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"251b9a1fad66b290194a45c44ebe1dad736fa5ec","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    if p.get(portbindings.HOST_ID) \u003d\u003d host_id]"},{"line_number":70,"context_line":"        if not ha_ports:"},{"line_number":71,"context_line":"            return"},{"line_number":72,"context_line":"        LOG.debug(\"L3 agent on host %(host)s restarted, so setting \""},{"line_number":73,"context_line":"                  \"HA network ports %(ha_ports)s status to DOWN.\","},{"line_number":74,"context_line":"                  {\"host\": host_id, \"ha_ports\": ha_ports})"},{"line_number":75,"context_line":"        for p in ha_ports:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_45e9747e","line":72,"in_reply_to":"7f231b9d_bf75fbfc","updated":"2017-06-09 19:29:16.000000000","message":"What is the suggestion? Should I write L3 agent on host restarted/updated/sync failed i.e \n\nLOG.debug(\"L3 agent on host %(host)s restarted/updated/sync failed, so setting HA network ports %(ha_ports)s status to DOWN.\"\n\nor\n\nLOG.debug(\"L3 agent on host %(host)s requested for get_router_ids, so setting HA network ports %(ha_ports)s status to DOWN.\"","commit_id":"6c6a8ad9f8ae36430bd1bf55b7910ca15f6fd609"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b97188f3d64d999c8a54b0a12345750508e56101","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"        def bind_port(context):"},{"line_number":1050,"context_line":"            binding \u003d context._binding"},{"line_number":1051,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_OVS"},{"line_number":1052,"context_line":"        self.core_plugin.mechanism_manager.bind_port \u003d bind_port"},{"line_number":1053,"context_line":"        router \u003d self._create_router(ha\u003dTrue)"},{"line_number":1054,"context_line":"        callback \u003d l3_rpc.L3RpcCallback()"},{"line_number":1055,"context_line":"        callback._l3plugin \u003d self.plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_b134eb4b","line":1052,"updated":"2017-06-08 19:01:40.000000000","message":"you modify FakeL3PluginWithAgents in place, and never restore the original value. please mock instead.","commit_id":"500b255278ab41974fe6febd9a3ed13de5ddf3f6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"283d0038b129c4ee3bd86509a47d75057f1feedc","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"        def bind_port(context):"},{"line_number":1050,"context_line":"            binding \u003d context._binding"},{"line_number":1051,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_OVS"},{"line_number":1052,"context_line":"        self.core_plugin.mechanism_manager.bind_port \u003d bind_port"},{"line_number":1053,"context_line":"        router \u003d self._create_router(ha\u003dTrue)"},{"line_number":1054,"context_line":"        callback \u003d l3_rpc.L3RpcCallback()"},{"line_number":1055,"context_line":"        callback._l3plugin \u003d self.plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_31e45bac","line":1052,"in_reply_to":"bf091321_b134eb4b","updated":"2017-06-08 19:15:15.000000000","message":"Ouch, I should have noticed that","commit_id":"500b255278ab41974fe6febd9a3ed13de5ddf3f6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"26131caa0eacce139b999961c0b555da8df73b6a","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"            binding \u003d context._binding"},{"line_number":1051,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_OVS"},{"line_number":1052,"context_line":"        with mock.patch.object(self.core_plugin.mechanism_manager,"},{"line_number":1053,"context_line":"                               \u0027bind_port\u0027, side_effect\u003dbind_port):"},{"line_number":1054,"context_line":"            router \u003d self._create_router(ha\u003dTrue)"},{"line_number":1055,"context_line":"            callback \u003d l3_rpc.L3RpcCallback()"},{"line_number":1056,"context_line":"            callback._l3plugin \u003d self.plugin"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_eae28f01","line":1053,"updated":"2017-06-09 18:14:48.000000000","message":"Should do the setup - create router, etc, then just have the mock.patch() around just the code that needs it.","commit_id":"6c6a8ad9f8ae36430bd1bf55b7910ca15f6fd609"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"bda9e420fa8d66bb113e52e452b38c97336ddd60","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"            binding \u003d context._binding"},{"line_number":1051,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_OVS"},{"line_number":1052,"context_line":"        with mock.patch.object(self.core_plugin.mechanism_manager,"},{"line_number":1053,"context_line":"                               \u0027bind_port\u0027, side_effect\u003dbind_port):"},{"line_number":1054,"context_line":"            router \u003d self._create_router(ha\u003dTrue)"},{"line_number":1055,"context_line":"            callback \u003d l3_rpc.L3RpcCallback()"},{"line_number":1056,"context_line":"            callback._l3plugin \u003d self.plugin"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_73f2ec08","line":1053,"in_reply_to":"7f231b9d_a5f9684e","updated":"2017-06-11 06:12:26.000000000","message":"done","commit_id":"6c6a8ad9f8ae36430bd1bf55b7910ca15f6fd609"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"251b9a1fad66b290194a45c44ebe1dad736fa5ec","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"            binding \u003d context._binding"},{"line_number":1051,"context_line":"            binding.vif_type \u003d portbindings.VIF_TYPE_OVS"},{"line_number":1052,"context_line":"        with mock.patch.object(self.core_plugin.mechanism_manager,"},{"line_number":1053,"context_line":"                               \u0027bind_port\u0027, side_effect\u003dbind_port):"},{"line_number":1054,"context_line":"            router \u003d self._create_router(ha\u003dTrue)"},{"line_number":1055,"context_line":"            callback \u003d l3_rpc.L3RpcCallback()"},{"line_number":1056,"context_line":"            callback._l3plugin \u003d self.plugin"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_a5f9684e","line":1053,"in_reply_to":"7f231b9d_eae28f01","updated":"2017-06-09 19:29:16.000000000","message":"sure","commit_id":"6c6a8ad9f8ae36430bd1bf55b7910ca15f6fd609"}]}
