)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0d92ce4d642034a72f82f5eaeeb4e48c3a0f4851","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cuong Nguyen \u003ccuongnv@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-03 14:27:17 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add netlink-lib to manage conntrack entries"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Authored-By: Cao Xuan Hoang \u003choangcx@vn.fujitsu.com\u003e"},{"line_number":10,"context_line":"Change-Id: I7503c87900eb0f7bc5386f915b925bb2576502cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3f1d235d_150d8a36","line":7,"updated":"2017-07-03 13:59:45.000000000","message":"Can you please add some explanations here and explain how this can be used and consumed.","commit_id":"70feb24c08593f432d31e58322d13ad09a09cb35"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"1dd01aad9156f9a5bc091e03099705d9c8bef541","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cuong Nguyen \u003ccuongnv@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-03 14:27:17 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add netlink-lib to manage conntrack entries"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Co-Authored-By: Cao Xuan Hoang \u003choangcx@vn.fujitsu.com\u003e"},{"line_number":10,"context_line":"Change-Id: I7503c87900eb0f7bc5386f915b925bb2576502cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3f1d235d_08855e5a","line":7,"in_reply_to":"3f1d235d_150d8a36","updated":"2017-07-04 08:08:30.000000000","message":"Done","commit_id":"70feb24c08593f432d31e58322d13ad09a09cb35"}],"neutron/privileged/agent/linux/netlink_constants.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cf53b8937a5cf1809780ddeef26581c2bcc50b84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"ff346bd7_21bcd1b9","updated":"2017-07-26 01:04:06.000000000","message":"Same comments for netlink_lib.","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"}],"neutron/privileged/agent/linux/netlink_lib.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"e8a6254b71feb2f731346ea8c0092c0db405e8e8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Some parts are based on python-conntrack:"},{"line_number":17,"context_line":"# Copyright (c) 2009-2011,2015 Andrew Grigorev \u003candrew@ei-grad.ru\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ctypes"},{"line_number":20,"context_line":"from ctypes import util"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_824510b6","line":17,"updated":"2017-06-12 16:18:12.000000000","message":"This original code is BSD licensed [1] and requires that the copyright be retained, so cannot switch out for Apache2.\n\n[1] https://github.com/ei-grad/python-conntrack/blob/master/Conntrack.py#L12","commit_id":"e9c1226b912c0f99515b9e1e518093fd20e35e24"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"35cae50d50d4cf4c53afa75e35b41b61c5f68e10","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Some parts are based on python-conntrack:"},{"line_number":17,"context_line":"# Copyright (c) 2009-2011,2015 Andrew Grigorev \u003candrew@ei-grad.ru\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ctypes"},{"line_number":20,"context_line":"from ctypes import util"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_e2da5d15","line":17,"in_reply_to":"7f231b9d_0d2fe5a1","updated":"2017-06-13 15:18:18.000000000","message":"Yes the code should contain the original copyright notice from the original project to comply with the BSD license.  If we don\u0027t include the original BSD copyright we are relicensing the code under Apache2 which are rights we do not have without consent of Andrew.","commit_id":"e9c1226b912c0f99515b9e1e518093fd20e35e24"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63bdeb4dd57a897d97312375a9f2bfab4aacd6ea","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Some parts are based on python-conntrack:"},{"line_number":17,"context_line":"# Copyright (c) 2009-2011,2015 Andrew Grigorev \u003candrew@ei-grad.ru\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ctypes"},{"line_number":20,"context_line":"from ctypes import util"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_0d2fe5a1","line":17,"in_reply_to":"7f231b9d_824510b6","updated":"2017-06-13 02:12:06.000000000","message":"\u003eThis original code is BSD licensed [1] and requires that the copyright be retained, \n\nYou mean we need to add license something like this [1]?\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/common/test_lib.py#L17-L36\n\n\n\u003eso cannot switch out for Apache2.\n\nI don\u0027t understand what you mean about this point. Could you please explain more about this? Thank you","commit_id":"e9c1226b912c0f99515b9e1e518093fd20e35e24"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"0a75de2343fd1113c1874a64c4bb0574802a7cd3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Some parts are based on python-conntrack:"},{"line_number":17,"context_line":"# Copyright (c) 2009-2011,2015 Andrew Grigorev \u003candrew@ei-grad.ru\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ctypes"},{"line_number":20,"context_line":"from ctypes import util"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_45eb1b12","line":17,"in_reply_to":"7f231b9d_e2da5d15","updated":"2017-06-15 09:25:12.000000000","message":"Done","commit_id":"e9c1226b912c0f99515b9e1e518093fd20e35e24"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"3857cf4c19f9fafb43419643e54ea31d2b60b204","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Some parts are based on python-conntrack:"},{"line_number":17,"context_line":"# Copyright (c) 2009-2011,2015 Andrew Grigorev \u003candrew@ei-grad.ru\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ctypes"},{"line_number":20,"context_line":"from ctypes import util"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_f381034c","line":17,"in_reply_to":"7f231b9d_e2da5d15","updated":"2017-06-14 01:35:16.000000000","message":"I see. We will append the original copyright as it in next revision. Thanks for your explanation.","commit_id":"e9c1226b912c0f99515b9e1e518093fd20e35e24"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3b7e197441b45837968dbea8aa5866961e565068","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron_lib import constants"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron._i18n import _, _LW"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_304571b4","line":24,"updated":"2017-06-12 13:11:36.000000000","message":"nit both of these are 3rd part so they can be in the same section","commit_id":"e9c1226b912c0f99515b9e1e518093fd20e35e24"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"0a75de2343fd1113c1874a64c4bb0574802a7cd3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron_lib import constants"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron._i18n import _, _LW"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_c5de0b6c","line":24,"in_reply_to":"7f231b9d_304571b4","updated":"2017-06-15 09:25:12.000000000","message":"Done","commit_id":"e9c1226b912c0f99515b9e1e518093fd20e35e24"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3b7e197441b45837968dbea8aa5866961e565068","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                 ctypes.c_void_p, ctypes.c_void_p)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class ConntrackOpenFailedExit(SystemExit):"},{"line_number":74,"context_line":"    \"\"\"Raised if we fail to open a new conntrack or conntrack handler\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_50ab4d1c","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":40},"updated":"2017-06-12 13:11:36.000000000","message":"why are you not using a neutron exception","commit_id":"e9c1226b912c0f99515b9e1e518093fd20e35e24"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"0a75de2343fd1113c1874a64c4bb0574802a7cd3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                 ctypes.c_void_p, ctypes.c_void_p)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class ConntrackOpenFailedExit(SystemExit):"},{"line_number":74,"context_line":"    \"\"\"Raised if we fail to open a new conntrack or conntrack handler\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7f231b9d_65e1772a","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":40},"in_reply_to":"7f231b9d_50ab4d1c","updated":"2017-06-15 09:25:12.000000000","message":"Done","commit_id":"e9c1226b912c0f99515b9e1e518093fd20e35e24"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3f1d90386763cc6baff30eb7f000a19fb3c5581e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                           \u0027id\u0027: libc.htons,"},{"line_number":123,"context_line":"                           \u0027sport\u0027: libc.htons,"},{"line_number":124,"context_line":"                           \u0027dport\u0027: libc.htons,"},{"line_number":125,"context_line":"                           \u0027zone\u0027: int,"},{"line_number":126,"context_line":"                           }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def list_entries(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_53162957","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":39},"updated":"2017-06-16 04:46:20.000000000","message":"IIUC, it should be libc.ntohs. But i\u0027m not sure, Please wait for others.","commit_id":"d32adc99ba3dc873f2bdc96ec72257bf8b5caa2d"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"ec36116323d977d403b417066a86bdb711a2495e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027zone\u0027: {4: nfct.nfct_set_attr_u16,"},{"line_number":116,"context_line":"                     6: nfct.nfct_set_attr_u16}"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        self.converters_v4 \u003d {\u0027src\u0027: libc.inet_addr,"},{"line_number":119,"context_line":"                              \u0027dst\u0027: libc.inet_addr,"},{"line_number":120,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":121,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":122,"context_line":"                              \u0027code\u0027: int,"},{"line_number":123,"context_line":"                              \u0027type\u0027: int,"},{"line_number":124,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":125,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":126,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":127,"context_line":"                              \u0027zone\u0027: int"},{"line_number":128,"context_line":"                              }"},{"line_number":129,"context_line":"        self.converters_v6 \u003d {\u0027src\u0027: str,"},{"line_number":130,"context_line":"                              \u0027dst\u0027: str,"},{"line_number":131,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":132,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":133,"context_line":"                              \u0027code\u0027: int,"},{"line_number":134,"context_line":"                              \u0027type\u0027: int,"},{"line_number":135,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":136,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":137,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":138,"context_line":"                              \u0027zone\u0027: int"},{"line_number":139,"context_line":"                              }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def list_entries(self):"},{"line_number":142,"context_line":"        entries \u003d []"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_0c0d52e7","line":139,"range":{"start_line":118,"start_character":0,"end_line":139,"end_character":31},"updated":"2017-07-05 08:15:35.000000000","message":"Can we use \u0027inet_pton\u0027[1] function for IPv4 and IPv6?\nThen we can avoid duplicating code for convert function for IPv4 and IPv6.\n[1] http://man7.org/linux/man-pages/man3/inet_pton.3.html","commit_id":"986fbe84561d4ca0ae452b2a8c5dae217149c897"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8da95d5c2a9561b7c75761c6d3745e7c9c5649b7","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027zone\u0027: {4: nfct.nfct_set_attr_u16,"},{"line_number":116,"context_line":"                     6: nfct.nfct_set_attr_u16}"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        self.converters_v4 \u003d {\u0027src\u0027: libc.inet_addr,"},{"line_number":119,"context_line":"                              \u0027dst\u0027: libc.inet_addr,"},{"line_number":120,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":121,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":122,"context_line":"                              \u0027code\u0027: int,"},{"line_number":123,"context_line":"                              \u0027type\u0027: int,"},{"line_number":124,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":125,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":126,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":127,"context_line":"                              \u0027zone\u0027: int"},{"line_number":128,"context_line":"                              }"},{"line_number":129,"context_line":"        self.converters_v6 \u003d {\u0027src\u0027: str,"},{"line_number":130,"context_line":"                              \u0027dst\u0027: str,"},{"line_number":131,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":132,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":133,"context_line":"                              \u0027code\u0027: int,"},{"line_number":134,"context_line":"                              \u0027type\u0027: int,"},{"line_number":135,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":136,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":137,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":138,"context_line":"                              \u0027zone\u0027: int"},{"line_number":139,"context_line":"                              }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def list_entries(self):"},{"line_number":142,"context_line":"        entries \u003d []"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_2ca80e8b","line":139,"range":{"start_line":118,"start_character":0,"end_line":139,"end_character":31},"in_reply_to":"3f1d235d_0c0d52e7","updated":"2017-07-05 08:19:43.000000000","message":"No, we can\u0027t use inet_pton for both in this situation. Because ipv4\u0027s src and dst use nfct_set_attr_u32 function which required int in case we use inet_pton but ipv6\u0027s src and dst use nfct_set_attr function which required str.","commit_id":"986fbe84561d4ca0ae452b2a8c5dae217149c897"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"d4a603f2ede3932ef947c166e6b2ad1179ea6553","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027zone\u0027: {4: nfct.nfct_set_attr_u16,"},{"line_number":116,"context_line":"                     6: nfct.nfct_set_attr_u16}"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        self.converters_v4 \u003d {\u0027src\u0027: libc.inet_addr,"},{"line_number":119,"context_line":"                              \u0027dst\u0027: libc.inet_addr,"},{"line_number":120,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":121,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":122,"context_line":"                              \u0027code\u0027: int,"},{"line_number":123,"context_line":"                              \u0027type\u0027: int,"},{"line_number":124,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":125,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":126,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":127,"context_line":"                              \u0027zone\u0027: int"},{"line_number":128,"context_line":"                              }"},{"line_number":129,"context_line":"        self.converters_v6 \u003d {\u0027src\u0027: str,"},{"line_number":130,"context_line":"                              \u0027dst\u0027: str,"},{"line_number":131,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":132,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":133,"context_line":"                              \u0027code\u0027: int,"},{"line_number":134,"context_line":"                              \u0027type\u0027: int,"},{"line_number":135,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":136,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":137,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":138,"context_line":"                              \u0027zone\u0027: int"},{"line_number":139,"context_line":"                              }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def list_entries(self):"},{"line_number":142,"context_line":"        entries \u003d []"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_8ca96225","line":139,"range":{"start_line":118,"start_character":0,"end_line":139,"end_character":31},"in_reply_to":"3f1d235d_0ce552dc","updated":"2017-07-05 08:30:11.000000000","message":"\u003e No, we can\u0027t use inet_pton for both in this situation. Because ipv4\u0027s src and dst use nfct_set_attr_u32 function which required int in case we use inet_pton but ipv6\u0027s src and dst use nfct_set_attr function which required str.\n\nWhy we don\u0027t use nfct_set_attr for both?","commit_id":"986fbe84561d4ca0ae452b2a8c5dae217149c897"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"2bfd3fbcf629e29e5d84e10579aa296113e2fd63","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027zone\u0027: {4: nfct.nfct_set_attr_u16,"},{"line_number":116,"context_line":"                     6: nfct.nfct_set_attr_u16}"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        self.converters_v4 \u003d {\u0027src\u0027: libc.inet_addr,"},{"line_number":119,"context_line":"                              \u0027dst\u0027: libc.inet_addr,"},{"line_number":120,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":121,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":122,"context_line":"                              \u0027code\u0027: int,"},{"line_number":123,"context_line":"                              \u0027type\u0027: int,"},{"line_number":124,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":125,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":126,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":127,"context_line":"                              \u0027zone\u0027: int"},{"line_number":128,"context_line":"                              }"},{"line_number":129,"context_line":"        self.converters_v6 \u003d {\u0027src\u0027: str,"},{"line_number":130,"context_line":"                              \u0027dst\u0027: str,"},{"line_number":131,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":132,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":133,"context_line":"                              \u0027code\u0027: int,"},{"line_number":134,"context_line":"                              \u0027type\u0027: int,"},{"line_number":135,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":136,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":137,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":138,"context_line":"                              \u0027zone\u0027: int"},{"line_number":139,"context_line":"                              }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def list_entries(self):"},{"line_number":142,"context_line":"        entries \u003d []"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_0ce552dc","line":139,"range":{"start_line":118,"start_character":0,"end_line":139,"end_character":31},"in_reply_to":"3f1d235d_2ca80e8b","updated":"2017-07-05 08:22:29.000000000","message":"In addition, If we want to use inet_pton for both, We need to do more converting step and L118 and L119 require int instead of inet_addr.","commit_id":"986fbe84561d4ca0ae452b2a8c5dae217149c897"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"d45a70cab7ff6d15aec4b5765880e8b8e5648e92","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027zone\u0027: {4: nfct.nfct_set_attr_u16,"},{"line_number":116,"context_line":"                     6: nfct.nfct_set_attr_u16}"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        self.converters_v4 \u003d {\u0027src\u0027: libc.inet_addr,"},{"line_number":119,"context_line":"                              \u0027dst\u0027: libc.inet_addr,"},{"line_number":120,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":121,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":122,"context_line":"                              \u0027code\u0027: int,"},{"line_number":123,"context_line":"                              \u0027type\u0027: int,"},{"line_number":124,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":125,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":126,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":127,"context_line":"                              \u0027zone\u0027: int"},{"line_number":128,"context_line":"                              }"},{"line_number":129,"context_line":"        self.converters_v6 \u003d {\u0027src\u0027: str,"},{"line_number":130,"context_line":"                              \u0027dst\u0027: str,"},{"line_number":131,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":132,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":133,"context_line":"                              \u0027code\u0027: int,"},{"line_number":134,"context_line":"                              \u0027type\u0027: int,"},{"line_number":135,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":136,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":137,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":138,"context_line":"                              \u0027zone\u0027: int"},{"line_number":139,"context_line":"                              }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def list_entries(self):"},{"line_number":142,"context_line":"        entries \u003d []"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_bd1f7806","line":139,"range":{"start_line":118,"start_character":0,"end_line":139,"end_character":31},"in_reply_to":"3f1d235d_627badbd","updated":"2017-07-06 09:33:50.000000000","message":"Thank you both, I updated new code and performance looks good.","commit_id":"986fbe84561d4ca0ae452b2a8c5dae217149c897"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"690e64fd251f6dd06e5b1f5b2f03069ab361e727","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027zone\u0027: {4: nfct.nfct_set_attr_u16,"},{"line_number":116,"context_line":"                     6: nfct.nfct_set_attr_u16}"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        self.converters_v4 \u003d {\u0027src\u0027: libc.inet_addr,"},{"line_number":119,"context_line":"                              \u0027dst\u0027: libc.inet_addr,"},{"line_number":120,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":121,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":122,"context_line":"                              \u0027code\u0027: int,"},{"line_number":123,"context_line":"                              \u0027type\u0027: int,"},{"line_number":124,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":125,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":126,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":127,"context_line":"                              \u0027zone\u0027: int"},{"line_number":128,"context_line":"                              }"},{"line_number":129,"context_line":"        self.converters_v6 \u003d {\u0027src\u0027: str,"},{"line_number":130,"context_line":"                              \u0027dst\u0027: str,"},{"line_number":131,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":132,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":133,"context_line":"                              \u0027code\u0027: int,"},{"line_number":134,"context_line":"                              \u0027type\u0027: int,"},{"line_number":135,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":136,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":137,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":138,"context_line":"                              \u0027zone\u0027: int"},{"line_number":139,"context_line":"                              }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def list_entries(self):"},{"line_number":142,"context_line":"        entries \u003d []"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_627badbd","line":139,"range":{"start_line":118,"start_character":0,"end_line":139,"end_character":31},"in_reply_to":"3f1d235d_6754df21","updated":"2017-07-05 09:47:16.000000000","message":"\u003eWhy we don\u0027t use nfct_set_attr for both?\n\u003e\nI misunderstand this comment. Basically, we can use nfct_set_attr for both. But in case IPv4, I want to use nfct_set_attr_u32 with built-in inet_addr function right away rather than need more step (1. create a buffer. 2. Use inet_pton to convert and then 3. push it.) like ipv6.\n\nIn case IPv6, we don\u0027t have any built-in function like inet_addr and we need to do further steps above.\n\nOn the other hand, I think built-in function usually has higher performance. And it is suitable for the purpose of the feature. Though?\n\nAnyway, let see what other reviewers (especially Cedric, Kevin and ???) want. I\u0027m OK for your suggestion.","commit_id":"986fbe84561d4ca0ae452b2a8c5dae217149c897"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"a5f3a1a64479bfc9543d9db47e52fe46550933df","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027zone\u0027: {4: nfct.nfct_set_attr_u16,"},{"line_number":116,"context_line":"                     6: nfct.nfct_set_attr_u16}"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        self.converters_v4 \u003d {\u0027src\u0027: libc.inet_addr,"},{"line_number":119,"context_line":"                              \u0027dst\u0027: libc.inet_addr,"},{"line_number":120,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":121,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":122,"context_line":"                              \u0027code\u0027: int,"},{"line_number":123,"context_line":"                              \u0027type\u0027: int,"},{"line_number":124,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":125,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":126,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":127,"context_line":"                              \u0027zone\u0027: int"},{"line_number":128,"context_line":"                              }"},{"line_number":129,"context_line":"        self.converters_v6 \u003d {\u0027src\u0027: str,"},{"line_number":130,"context_line":"                              \u0027dst\u0027: str,"},{"line_number":131,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":132,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":133,"context_line":"                              \u0027code\u0027: int,"},{"line_number":134,"context_line":"                              \u0027type\u0027: int,"},{"line_number":135,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":136,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":137,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":138,"context_line":"                              \u0027zone\u0027: int"},{"line_number":139,"context_line":"                              }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def list_entries(self):"},{"line_number":142,"context_line":"        entries \u003d []"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_e7110f06","line":139,"range":{"start_line":118,"start_character":0,"end_line":139,"end_character":31},"in_reply_to":"3f1d235d_8ca96225","updated":"2017-07-05 08:40:35.000000000","message":"You may want to check original libnetfilter_conntrack [1].\n\n[1] https://github.com/threatstack/libnetfilter_conntrack/","commit_id":"986fbe84561d4ca0ae452b2a8c5dae217149c897"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"2746b04d4c641995346cf31956535cc81a68e004","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027zone\u0027: {4: nfct.nfct_set_attr_u16,"},{"line_number":116,"context_line":"                     6: nfct.nfct_set_attr_u16}"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"        self.converters_v4 \u003d {\u0027src\u0027: libc.inet_addr,"},{"line_number":119,"context_line":"                              \u0027dst\u0027: libc.inet_addr,"},{"line_number":120,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":121,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":122,"context_line":"                              \u0027code\u0027: int,"},{"line_number":123,"context_line":"                              \u0027type\u0027: int,"},{"line_number":124,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":125,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":126,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":127,"context_line":"                              \u0027zone\u0027: int"},{"line_number":128,"context_line":"                              }"},{"line_number":129,"context_line":"        self.converters_v6 \u003d {\u0027src\u0027: str,"},{"line_number":130,"context_line":"                              \u0027dst\u0027: str,"},{"line_number":131,"context_line":"                              \u0027ipversion\u0027: nl_constants.IPVERSION_SOCKET.get,"},{"line_number":132,"context_line":"                              \u0027protocol\u0027: constants.IP_PROTOCOL_MAP.get,"},{"line_number":133,"context_line":"                              \u0027code\u0027: int,"},{"line_number":134,"context_line":"                              \u0027type\u0027: int,"},{"line_number":135,"context_line":"                              \u0027id\u0027: libc.htons,"},{"line_number":136,"context_line":"                              \u0027sport\u0027: libc.htons,"},{"line_number":137,"context_line":"                              \u0027dport\u0027: libc.htons,"},{"line_number":138,"context_line":"                              \u0027zone\u0027: int"},{"line_number":139,"context_line":"                              }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def list_entries(self):"},{"line_number":142,"context_line":"        entries \u003d []"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_6754df21","line":139,"range":{"start_line":118,"start_character":0,"end_line":139,"end_character":31},"in_reply_to":"3f1d235d_e7110f06","updated":"2017-07-05 08:50:25.000000000","message":"Sorry. I don\u0027t found any reason why we can\u0027t use same a converts function for IPv4 or IPv6. Could you please explain more?","commit_id":"986fbe84561d4ca0ae452b2a8c5dae217149c897"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cf53b8937a5cf1809780ddeef26581c2bcc50b84","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Some parts are based on python-conntrack:"},{"line_number":17,"context_line":"# Copyright (c) 2009-2011,2015 Andrew Grigorev \u003candrew@ei-grad.ru\u003e"},{"line_number":18,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_e187e90e","line":15,"updated":"2017-07-26 01:04:06.000000000","message":"License question: python-conntrack is MIT license. From the legal point of view, is it okay to import MIT license and publish it as Apache 2 license? We should be SUPER CAREFUL to do like this.\nAt least it should be described on how license topic is not a problem or how we can address it.\n\nGenerally speaking, you should improve python-conntrack itself rather than importing it into neutron.\n\nIn addition, is python-conntack you mentioned https://pypi.python.org/pypi/Conntrack/ ? (for confirmation)","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"eee4ef8381021841783ddb8486f606098dfa5267","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Some parts are based on python-conntrack:"},{"line_number":17,"context_line":"# Copyright (c) 2009-2011,2015 Andrew Grigorev \u003candrew@ei-grad.ru\u003e"},{"line_number":18,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_1cbc96b9","line":15,"updated":"2017-07-26 01:46:43.000000000","message":"oh, good point. we should get someone from the foundation to weigh in","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"fe9458bd9dcd898bb1ee01404b7da1d7e8fb22d4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Some parts are based on python-conntrack:"},{"line_number":17,"context_line":"# Copyright (c) 2009-2011,2015 Andrew Grigorev \u003candrew@ei-grad.ru\u003e"},{"line_number":18,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_5c8e9ed0","line":15,"in_reply_to":"ff346bd7_1cbc96b9","updated":"2017-07-26 02:02:02.000000000","message":"We (I and Mark Mcclain) discussed about this point at PS7 [1]. I see current existing neutron code has already the same thing [2]. So, I would like to confirm whether do I need to send email to legal team about this?\n\n[1] https://review.openstack.org/#/c/470911/7/neutron/privileged/agent/linux/netlink_lib.py@17\n\n[2] https://github.com/openstack/neutron/blob/master/neutron/common/test_lib.py#L17-L36","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"ba4f47fbcaa3c0482a2c5937e8c722041b580e9d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Some parts are based on python-conntrack:"},{"line_number":17,"context_line":"# Copyright (c) 2009-2011,2015 Andrew Grigorev \u003candrew@ei-grad.ru\u003e"},{"line_number":18,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_d2039572","line":15,"in_reply_to":"ff346bd7_5c8e9ed0","updated":"2017-07-26 03:47:31.000000000","message":"I think I found the answer for your consideration. It is defined in wiki page [1]. So, I think this is OK as mcclain mentioned before.\n\n[1] https://wiki.openstack.org/wiki/LegalIssuesFAQ#Incorporating_BSD.2FMIT_Licensed_Code","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a29af85ad5b1ff0b9a6ed47d21d3c052ef044265","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# Some parts are based on python-conntrack:"},{"line_number":17,"context_line":"# Copyright (c) 2009-2011,2015 Andrew Grigorev \u003candrew@ei-grad.ru\u003e"},{"line_number":18,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_a1d681c2","line":15,"in_reply_to":"ff346bd7_e187e90e","updated":"2017-07-26 01:09:33.000000000","message":"My main questions are:\n\n- Can we mix MIT license and Apache 2 license in a same file?\n- We have LICENSE file at the top directory. Is it okay to have a file with some different license under the tree and publish it as part of neutron distribution?\n\nI am not so familiar with this area, so I would like to clarify the situation before merging it.","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e89872bc06546337195db89116a384d9e6171cd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from ctypes import util"},{"line_number":40,"context_line":"import re"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"from oslo_log import log as logging"},{"line_number":43,"context_line":"from neutron._i18n import _, _LW"},{"line_number":44,"context_line":"from neutron.common import exceptions"},{"line_number":45,"context_line":"from neutron import privileged"},{"line_number":46,"context_line":"from neutron.privileged.agent.linux import netlink_constants as nl_constants"},{"line_number":47,"context_line":"from neutron_lib import constants"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_a16bef82","line":47,"range":{"start_line":42,"start_character":0,"end_line":47,"end_character":33},"updated":"2017-07-27 06:39:30.000000000","message":"could you split these into two groups? neutron (project imports) and others (third-party imports)","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"1a7493499db1baddf0b70f9f3d221af5da2b3ce1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from ctypes import util"},{"line_number":40,"context_line":"import re"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"from oslo_log import log as logging"},{"line_number":43,"context_line":"from neutron._i18n import _, _LW"},{"line_number":44,"context_line":"from neutron.common import exceptions"},{"line_number":45,"context_line":"from neutron import privileged"},{"line_number":46,"context_line":"from neutron.privileged.agent.linux import netlink_constants as nl_constants"},{"line_number":47,"context_line":"from neutron_lib import constants"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_de3251f2","line":47,"range":{"start_line":42,"start_character":0,"end_line":47,"end_character":33},"in_reply_to":"ff346bd7_a16bef82","updated":"2017-07-27 07:00:10.000000000","message":"Done","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"}],"neutron/tests/functional/agent/linux/test_netlink_lib.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e89872bc06546337195db89116a384d9e6171cd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.privileged.agent.linux.netlink_lib as nl_lib"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.agent.linux import utils as linux_utils"},{"line_number":19,"context_line":"from neutron.tests.functional import base as functional_base"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_618ce735","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":59},"updated":"2017-07-27 06:39:30.000000000","message":"Consider using \"from neutron.... import .....\" style\n\n from neutron.privileged.agent.linux import netlink_lib\n\n(nl_lib alias is needed then?)","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"1a7493499db1baddf0b70f9f3d221af5da2b3ce1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.privileged.agent.linux.netlink_lib as nl_lib"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.agent.linux import utils as linux_utils"},{"line_number":19,"context_line":"from neutron.tests.functional import base as functional_base"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_7e2ec592","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":59},"in_reply_to":"ff346bd7_618ce735","updated":"2017-07-27 07:00:10.000000000","message":"Done","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e89872bc06546337195db89116a384d9e6171cd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.privileged.agent.linux.netlink_lib as nl_lib"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.agent.linux import utils as linux_utils"},{"line_number":19,"context_line":"from neutron.tests.functional import base as functional_base"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_21825f01","line":17,"updated":"2017-07-27 06:39:30.000000000","message":"no blank line here.","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"1a7493499db1baddf0b70f9f3d221af5da2b3ce1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.privileged.agent.linux.netlink_lib as nl_lib"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.agent.linux import utils as linux_utils"},{"line_number":19,"context_line":"from neutron.tests.functional import base as functional_base"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_5e1f815a","line":17,"in_reply_to":"ff346bd7_21825f01","updated":"2017-07-27 07:00:10.000000000","message":"Done","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"}],"neutron/tests/unit/privileged/agent/linux/test_netlink_lib.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e89872bc06546337195db89116a384d9e6171cd","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import testtools"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron_lib import constants"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.common import exceptions"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_210dbfe7","line":19,"updated":"2017-07-27 06:39:30.000000000","message":"nit: no blank line is needed here","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"1a7493499db1baddf0b70f9f3d221af5da2b3ce1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import testtools"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron_lib import constants"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.common import exceptions"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_1e3d79c3","line":19,"in_reply_to":"ff346bd7_210dbfe7","updated":"2017-07-27 07:00:10.000000000","message":"Done","commit_id":"f59420085ce24d5138cdd1a4875059f7eb5f1564"}]}
