)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"628eadeb7ebecefb6e2cff277b54802f8f907513","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New RPC to set HA network port status to DOWN"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In commit 500b255278ab41974fe6febd9a3ed13de5ddf3f6 we are using"},{"line_number":10,"context_line":"\"get_router_ids\" RPC to update HA network port status. But that"},{"line_number":11,"context_line":"was needed to backport that commit to other branches."},{"line_number":12,"context_line":"As \"get_router_ids\" RPC is expected to fetch only router ids and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf091321_b13aabe4","line":9,"updated":"2017-06-08 19:20:12.000000000","message":"does it mean that when the server is upgraded, old agents will again not set DOWN until upgraded? The mixed version setup is supported for rolling upgrades, so we should support it.\n\nThat\u0027s probably valid only if we are going to release the 1st patch but not the 2nd in a major release. So probably not a big deal.","commit_id":"dbd4711d7f5fc291b5e57dc5130f6c0a166a62d8"}],"neutron/api/rpc/handlers/l3_rpc.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"628eadeb7ebecefb6e2cff277b54802f8f907513","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            self._l3plugin \u003d directory.get_plugin(constants.L3)"},{"line_number":61,"context_line":"        return self._l3plugin"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def update_ha_network_port_status(self, context, host):"},{"line_number":64,"context_line":"        \"\"\"Set HA network port to DOWN for HA routers hosted on \u003chost\u003e"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        This will update HA network port status to down for all HA routers"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_14194578","line":63,"range":{"start_line":63,"start_character":31,"end_line":63,"end_character":32},"updated":"2017-06-08 19:20:12.000000000","message":"since it updates multiple ports, maybe rename to update_all_ha_network_port_statuses?","commit_id":"dbd4711d7f5fc291b5e57dc5130f6c0a166a62d8"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"50a2971771e8c65e0b59d3666dd845aeac577ee3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            self._l3plugin \u003d directory.get_plugin(constants.L3)"},{"line_number":61,"context_line":"        return self._l3plugin"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def update_ha_network_port_status(self, context, host):"},{"line_number":64,"context_line":"        \"\"\"Set HA network port to DOWN for HA routers hosted on \u003chost\u003e"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        This will update HA network port status to down for all HA routers"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_7bf06591","line":63,"range":{"start_line":63,"start_character":31,"end_line":63,"end_character":32},"in_reply_to":"bf091321_14194578","updated":"2017-06-09 04:54:47.000000000","message":"or update_all_ha_network_ports_status?","commit_id":"dbd4711d7f5fc291b5e57dc5130f6c0a166a62d8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"427137d9d11cc0998e9126f857e8501f2c8c88ed","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            self._l3plugin \u003d directory.get_plugin(constants.L3)"},{"line_number":61,"context_line":"        return self._l3plugin"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def update_ha_network_port_status(self, context, host):"},{"line_number":64,"context_line":"        \"\"\"Set HA network port to DOWN for HA routers hosted on \u003chost\u003e"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        This will update HA network port status to down for all HA routers"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_9f4b5faf","line":63,"range":{"start_line":63,"start_character":31,"end_line":63,"end_character":32},"in_reply_to":"bf091321_7bf06591","updated":"2017-06-09 17:46:59.000000000","message":"I am not a native speaker, so hard to say. But both are better at describing semantics of the method.","commit_id":"dbd4711d7f5fc291b5e57dc5130f6c0a166a62d8"}]}
