)]}'
{"neutron/agent/firewall.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0e225f17924b81fe9bfec0922e70a60248474dad","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# List of ICMPv6 types that should be permitted (ingress) by default. This list"},{"line_number":34,"context_line":"# depends on iptables conntrack behavior of recognizing ICMP errors (types 1-4)"},{"line_number":35,"context_line":"# as related traffic."},{"line_number":36,"context_line":"ICMPV6_ALLOWED_INGRESS_TYPES \u003d [n_const.ICMPV6_TYPE_MLD_QUERY,"},{"line_number":37,"context_line":"                                n_const.ICMPV6_TYPE_RA,"},{"line_number":38,"context_line":"                                n_const.ICMPV6_TYPE_NS,"},{"line_number":39,"context_line":"                                n_const.ICMPV6_TYPE_NA]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f0e0f27_cb76b53f","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":28},"updated":"2017-06-09 09:35:01.000000000","message":"Nit: As we\u0027re technically introducing a new constant here, a tuple makes imho more sense as this constant enumeration is supposed to be i immutable. Or is there a reason for having it mutable?","commit_id":"528b9f63458e0b7bad75b9186cac3f33a93435b3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1772088b29f0001ba7caedab987e909d1e520477","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# List of ICMPv6 types that should be permitted (ingress) by default. This list"},{"line_number":34,"context_line":"# depends on iptables conntrack behavior of recognizing ICMP errors (types 1-4)"},{"line_number":35,"context_line":"# as related traffic."},{"line_number":36,"context_line":"ICMPV6_ALLOWED_INGRESS_TYPES \u003d [n_const.ICMPV6_TYPE_MLD_QUERY,"},{"line_number":37,"context_line":"                                n_const.ICMPV6_TYPE_RA,"},{"line_number":38,"context_line":"                                n_const.ICMPV6_TYPE_NS,"},{"line_number":39,"context_line":"                                n_const.ICMPV6_TYPE_NA]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_30eb58b1","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":28},"in_reply_to":"9f0e0f27_cb76b53f","updated":"2017-06-09 20:11:38.000000000","message":"Will change.","commit_id":"528b9f63458e0b7bad75b9186cac3f33a93435b3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bdabbaa1737c0216801578c7267522ed9ad558ed","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                n_const.ICMPV6_TYPE_NS,"},{"line_number":39,"context_line":"                                n_const.ICMPV6_TYPE_NA)"},{"line_number":40,"context_line":"# for backwards-compatibility"},{"line_number":41,"context_line":"ICMPV6_ALLOWED_TYPES \u003d ICMPV6_ALLOWED_INGRESS_TYPES"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# List of ICMPv6 types that should be permitted (egress) by default."},{"line_number":44,"context_line":"ICMPV6_ALLOWED_EGRESS_TYPES \u003d (n_const.ICMPV6_TYPE_MLD_QUERY,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_67b58dee","line":41,"updated":"2017-06-10 11:29:26.000000000","message":"Is there any users of IPV6_ALLOWED_TYPES outside of neutron?\nIf you assume users outside of neutron, at least it is better to mark it as deprecated (for example using debtcollector).","commit_id":"b5aa6e7734c0e68fe290a25faf912df75edd7581"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"857e832e93be7db46b67d57b91b9ea4dffc7c222","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                n_const.ICMPV6_TYPE_NS,"},{"line_number":39,"context_line":"                                n_const.ICMPV6_TYPE_NA)"},{"line_number":40,"context_line":"# for backwards-compatibility"},{"line_number":41,"context_line":"ICMPV6_ALLOWED_TYPES \u003d ICMPV6_ALLOWED_INGRESS_TYPES"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# List of ICMPv6 types that should be permitted (egress) by default."},{"line_number":44,"context_line":"ICMPV6_ALLOWED_EGRESS_TYPES \u003d (n_const.ICMPV6_TYPE_MLD_QUERY,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_a3cf047e","line":41,"in_reply_to":"7f231b9d_2121b7fc","updated":"2017-06-12 08:30:28.000000000","message":"+1 to drop","commit_id":"b5aa6e7734c0e68fe290a25faf912df75edd7581"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"20c6ed7439c8db52fe14e9c2f7436779a2f6a72e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                n_const.ICMPV6_TYPE_NS,"},{"line_number":39,"context_line":"                                n_const.ICMPV6_TYPE_NA)"},{"line_number":40,"context_line":"# for backwards-compatibility"},{"line_number":41,"context_line":"ICMPV6_ALLOWED_TYPES \u003d ICMPV6_ALLOWED_INGRESS_TYPES"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# List of ICMPv6 types that should be permitted (egress) by default."},{"line_number":44,"context_line":"ICMPV6_ALLOWED_EGRESS_TYPES \u003d (n_const.ICMPV6_TYPE_MLD_QUERY,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_c7bb3ee3","line":41,"in_reply_to":"7f231b9d_47e60e19","updated":"2017-06-10 17:09:06.000000000","message":"So maybe we could delete that var - is there a reason for backward compat if noone uses it?","commit_id":"b5aa6e7734c0e68fe290a25faf912df75edd7581"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8c9ba4561a53fa1cde5055a77dfdc28a3a9889c4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                n_const.ICMPV6_TYPE_NS,"},{"line_number":39,"context_line":"                                n_const.ICMPV6_TYPE_NA)"},{"line_number":40,"context_line":"# for backwards-compatibility"},{"line_number":41,"context_line":"ICMPV6_ALLOWED_TYPES \u003d ICMPV6_ALLOWED_INGRESS_TYPES"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# List of ICMPv6 types that should be permitted (egress) by default."},{"line_number":44,"context_line":"ICMPV6_ALLOWED_EGRESS_TYPES \u003d (n_const.ICMPV6_TYPE_MLD_QUERY,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_47e60e19","line":41,"in_reply_to":"7f231b9d_67b58dee","updated":"2017-06-10 17:07:26.000000000","message":"There are not: http://codesearch.openstack.org/?q\u003dICMPV6_ALLOWED_TYPES\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"b5aa6e7734c0e68fe290a25faf912df75edd7581"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"73c87885bb731a91b688ee7d9cf4408388767a9f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                n_const.ICMPV6_TYPE_NS,"},{"line_number":39,"context_line":"                                n_const.ICMPV6_TYPE_NA)"},{"line_number":40,"context_line":"# for backwards-compatibility"},{"line_number":41,"context_line":"ICMPV6_ALLOWED_TYPES \u003d ICMPV6_ALLOWED_INGRESS_TYPES"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# List of ICMPv6 types that should be permitted (egress) by default."},{"line_number":44,"context_line":"ICMPV6_ALLOWED_EGRESS_TYPES \u003d (n_const.ICMPV6_TYPE_MLD_QUERY,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_57069c88","line":41,"in_reply_to":"7f231b9d_a3cf047e","updated":"2017-06-12 15:52:08.000000000","message":"Done","commit_id":"b5aa6e7734c0e68fe290a25faf912df75edd7581"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a87666bd5ceea3b9e830d04e42399892fdc55341","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                n_const.ICMPV6_TYPE_NS,"},{"line_number":39,"context_line":"                                n_const.ICMPV6_TYPE_NA)"},{"line_number":40,"context_line":"# for backwards-compatibility"},{"line_number":41,"context_line":"ICMPV6_ALLOWED_TYPES \u003d ICMPV6_ALLOWED_INGRESS_TYPES"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# List of ICMPv6 types that should be permitted (egress) by default."},{"line_number":44,"context_line":"ICMPV6_ALLOWED_EGRESS_TYPES \u003d (n_const.ICMPV6_TYPE_MLD_QUERY,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_2121b7fc","line":41,"in_reply_to":"7f231b9d_c7bb3ee3","updated":"2017-06-11 23:30:50.000000000","message":"+1 to drop it. We are the beginning of Pike-3 and even though it breaks out-of-tree codes they have enough time to catch up with the change.","commit_id":"b5aa6e7734c0e68fe290a25faf912df75edd7581"}]}
