)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8b8b7c7046d060529e3f0a289ca1a34c4718d48e","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                        raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":473,"context_line":"                    if (p.get(\u0027device_owner\u0027) \u003d\u003d"},{"line_number":474,"context_line":"                        constants.DEVICE_OWNER_ROUTER_GW):"},{"line_number":475,"context_line":"                        router_subnets.append(ip[\u0027subnet_id\u0027])"},{"line_number":476,"context_line":"            self._check_for_dup_router_subnets(context, router,"},{"line_number":477,"context_line":"                                               new_network_id,"},{"line_number":478,"context_line":"                                               subnets,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_160d9836","line":475,"updated":"2017-06-13 18:53:15.000000000","message":"I\u0027d rather not duplicate this code in three locations.  I think you could just pass a flag to _check_for_dup_router_subnets() and have it match/not match the device_owner instead.","commit_id":"d9760cdf81b1fe4346e7a8b1e1b08413bcf3ad71"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"f59165b17562fa556434da050c8c28c1173c8760","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                        raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":473,"context_line":"                    if (p.get(\u0027device_owner\u0027) \u003d\u003d"},{"line_number":474,"context_line":"                        constants.DEVICE_OWNER_ROUTER_GW):"},{"line_number":475,"context_line":"                        router_subnets.append(ip[\u0027subnet_id\u0027])"},{"line_number":476,"context_line":"            self._check_for_dup_router_subnets(context, router,"},{"line_number":477,"context_line":"                                               new_network_id,"},{"line_number":478,"context_line":"                                               subnets,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_53f1d76a","line":475,"in_reply_to":"7f231b9d_160d9836","updated":"2017-06-14 02:13:37.000000000","message":"Done, thanks.","commit_id":"d9760cdf81b1fe4346e7a8b1e1b08413bcf3ad71"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8887836f595401e205f85a8c76826e490d808b37","unresolved":false,"context_lines":[{"line_number":599,"context_line":"                else:"},{"line_number":600,"context_line":"                    if (p.get(\u0027device_owner\u0027) !\u003d"},{"line_number":601,"context_line":"                        constants.DEVICE_OWNER_ROUTER_GW):"},{"line_number":602,"context_line":"                        router_subnets.append(ip[\u0027subnet_id\u0027])"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"        # Ignore temporary Prefix Delegation CIDRs"},{"line_number":605,"context_line":"        new_subnets \u003d [s for s in new_subnets"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_a17f9513","line":602,"updated":"2017-06-14 19:30:04.000000000","message":"I think this could be a little cleaner, let me post a follow-up.","commit_id":"21375f6a9bb86d3d592b0d493a37e1d5c5c07611"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"6f3c268adec63aab3c88b4b566d5c84f14347a31","unresolved":false,"context_lines":[{"line_number":599,"context_line":"                else:"},{"line_number":600,"context_line":"                    if (p.get(\u0027device_owner\u0027) !\u003d"},{"line_number":601,"context_line":"                        constants.DEVICE_OWNER_ROUTER_GW):"},{"line_number":602,"context_line":"                        router_subnets.append(ip[\u0027subnet_id\u0027])"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"        # Ignore temporary Prefix Delegation CIDRs"},{"line_number":605,"context_line":"        new_subnets \u003d [s for s in new_subnets"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_032f668e","line":602,"in_reply_to":"7f231b9d_a17f9513","updated":"2017-06-15 01:46:04.000000000","message":"Thanks.","commit_id":"21375f6a9bb86d3d592b0d493a37e1d5c5c07611"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"911f9f939d694b6ecaf17b6e77f2462a2dbbdae7","unresolved":false,"context_lines":[{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    def _check_for_dup_router_subnets(self, context, router,"},{"line_number":583,"context_line":"                                      network_id, new_subnets,"},{"line_number":584,"context_line":"                                      match_owner\u003dFalse):"},{"line_number":585,"context_line":"        # It\u0027s possible these ports are on the same network, but"},{"line_number":586,"context_line":"        # different subnets."},{"line_number":587,"context_line":"        new_subnet_ids \u003d {s[\u0027id\u0027] for s in new_subnets}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_89131b67","line":584,"updated":"2017-06-21 00:23:04.000000000","message":"can you please change \u0027match_owner\u0027 to \u0027include_gateway\u0027?","commit_id":"7323a6cbac88fc01bc1e6050b904be7df10bfd9e"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"67e87e31033a876e34b8cf5cdb2f960df51deec9","unresolved":false,"context_lines":[{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    def _check_for_dup_router_subnets(self, context, router,"},{"line_number":583,"context_line":"                                      network_id, new_subnets,"},{"line_number":584,"context_line":"                                      match_owner\u003dFalse):"},{"line_number":585,"context_line":"        # It\u0027s possible these ports are on the same network, but"},{"line_number":586,"context_line":"        # different subnets."},{"line_number":587,"context_line":"        new_subnet_ids \u003d {s[\u0027id\u0027] for s in new_subnets}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_acf4a55c","line":584,"in_reply_to":"5f201791_89131b67","updated":"2017-06-21 00:58:11.000000000","message":"Done","commit_id":"7323a6cbac88fc01bc1e6050b904be7df10bfd9e"}]}