)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2f4b23e9f0362027bd4b9fb5b97f04e0663aec18","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Salvatore Orlando \u003csalv.orlando@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-19 05:02:12 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NVP plugin: Set default max_lp_per_bridged_ls to 5000"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch increases the default value from 64 to 5000"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAS3%2F%2Fxz8%3D","line":7,"updated":"2013-09-19 14:20:05.000000000","message":"To me this is borderline between a feature and a bug...I am on the fence...","commit_id":"ac9c47545245b70e58772e36d4ff86c4789cfb43"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"0ff57244973d720b4e5d490d2ec61fa072eaa535","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Salvatore Orlando \u003csalv.orlando@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-19 05:02:12 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NVP plugin: Set default max_lp_per_bridged_ls to 5000"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch increases the default value from 64 to 5000"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAS3%2F%2FxfA%3D","line":7,"in_reply_to":"AAAAS3%2F%2Fxz8%3D","updated":"2013-09-19 15:38:49.000000000","message":"I don\u0027t think this is adding new functionalities or deeply changing the way in which a functionality works.\n\nAnyway, if you feel we should block this go for it.","commit_id":"ac9c47545245b70e58772e36d4ff86c4789cfb43"}],"etc/neutron/plugins/nicira/nvp.ini":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2f4b23e9f0362027bd4b9fb5b97f04e0663aec18","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# NVP 2.x -\u003e 64"},{"line_number":74,"context_line":"# NVP 3.0, 3.1 -\u003e 5000"},{"line_number":75,"context_line":"# NVP 3.2 -\u003e 10000"},{"line_number":76,"context_line":"# max_lp_per_bridged_ls \u003d 5000"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Maximum number of ports for each overlay (stt, gre) logical switch"},{"line_number":79,"context_line":"# max_lp_per_overlay_ls \u003d 256"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAS3%2F%2Fx0s%3D","line":76,"updated":"2013-09-19 14:20:05.000000000","message":"Have you considered setting the value to \u0027unspecified\u0027 and let the plugin override the value based on the NVP version? This would avoid touching the opt at every NVP release. Also, bringing this to 5000 could potentially break existing deployments that have older versions of NVP.","commit_id":"ac9c47545245b70e58772e36d4ff86c4789cfb43"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"0ff57244973d720b4e5d490d2ec61fa072eaa535","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# NVP 2.x -\u003e 64"},{"line_number":74,"context_line":"# NVP 3.0, 3.1 -\u003e 5000"},{"line_number":75,"context_line":"# NVP 3.2 -\u003e 10000"},{"line_number":76,"context_line":"# max_lp_per_bridged_ls \u003d 5000"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Maximum number of ports for each overlay (stt, gre) logical switch"},{"line_number":79,"context_line":"# max_lp_per_overlay_ls \u003d 256"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAS3%2F%2FxfY%3D","line":76,"in_reply_to":"AAAAS3%2F%2Fx0s%3D","updated":"2013-09-19 15:38:49.000000000","message":"This has been documented in the related documentation patch.\nExisting deployment will be broken only if they update their configuration files, which normally the would not be doing.\nNew deployments using NVP 2.x should be aware of the limitation which has been documented.\n\nAutomatic version-based setting can be done, but is a larger and probably unnecessary work at this stage.","commit_id":"ac9c47545245b70e58772e36d4ff86c4789cfb43"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2f4b23e9f0362027bd4b9fb5b97f04e0663aec18","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# max_lp_per_bridged_ls \u003d 5000"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Maximum number of ports for each overlay (stt, gre) logical switch"},{"line_number":79,"context_line":"# max_lp_per_overlay_ls \u003d 256"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Number of connects to each controller node."},{"line_number":82,"context_line":"# default is 5"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAS3%2F%2Fx0M%3D","line":79,"updated":"2013-09-19 14:20:05.000000000","message":"would this need to be touched, maybe in another patchset?","commit_id":"ac9c47545245b70e58772e36d4ff86c4789cfb43"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"0ff57244973d720b4e5d490d2ec61fa072eaa535","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# max_lp_per_bridged_ls \u003d 5000"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Maximum number of ports for each overlay (stt, gre) logical switch"},{"line_number":79,"context_line":"# max_lp_per_overlay_ls \u003d 256"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Number of connects to each controller node."},{"line_number":82,"context_line":"# default is 5"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAS3%2F%2FxgE%3D","line":79,"in_reply_to":"AAAAS3%2F%2Fx0M%3D","updated":"2013-09-19 15:38:49.000000000","message":"note that I have been informed of.","commit_id":"ac9c47545245b70e58772e36d4ff86c4789cfb43"}],"neutron/plugins/nicira/common/config.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"9852392b5135199de9f673da03eb797ffe408076","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                      \"bridged transport zone (default 5000)\")),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027max_lp_per_overlay_ls\u0027, default\u003d256,"},{"line_number":37,"context_line":"               help\u003d_(\"Maximum number of ports of a logical switch on an \""},{"line_number":38,"context_line":"                      \"overlay transport zone (default 64)\")),"},{"line_number":39,"context_line":"    cfg.IntOpt(\u0027concurrent_connections\u0027, default\u003d5,"},{"line_number":40,"context_line":"               help\u003d_(\"Maximum concurrent connections\")),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027nvp_gen_timeout\u0027, default\u003d-1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fw%2FA%3D","line":38,"updated":"2013-09-19 17:58:11.000000000","message":"nit: might as well fix this typo in this patch set as well. default 64-\u003e256","commit_id":"ac9c47545245b70e58772e36d4ff86c4789cfb43"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"96f1d1690a4c16874fb7cd0614f7380409795ea0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                      \"bridged transport zone (default 5000)\")),"},{"line_number":36,"context_line":"    cfg.IntOpt(\u0027max_lp_per_overlay_ls\u0027, default\u003d256,"},{"line_number":37,"context_line":"               help\u003d_(\"Maximum number of ports of a logical switch on an \""},{"line_number":38,"context_line":"                      \"overlay transport zone (default 64)\")),"},{"line_number":39,"context_line":"    cfg.IntOpt(\u0027concurrent_connections\u0027, default\u003d5,"},{"line_number":40,"context_line":"               help\u003d_(\"Maximum concurrent connections\")),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027nvp_gen_timeout\u0027, default\u003d-1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fw2k%3D","line":38,"in_reply_to":"AAAAS3%2F%2Fw%2FA%3D","updated":"2013-09-19 18:32:21.000000000","message":"ok","commit_id":"ac9c47545245b70e58772e36d4ff86c4789cfb43"}]}