)]}'
{"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"36bfa4e4c9146f0dce7c2d991fccfb1a7bd10e47","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        retrieved_policy \u003d retrieved_policy[\u0027policy\u0027]"},{"line_number":91,"context_line":"        self.assertEqual(\u0027test policy desc2\u0027, retrieved_policy[\u0027description\u0027])"},{"line_number":92,"context_line":"        self.assertTrue(retrieved_policy[\u0027shared\u0027])"},{"line_number":93,"context_line":"        self.assertEmpty(retrieved_policy[\u0027rules\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @decorators.idempotent_id(\u00276e880e0f-bbfc-4e54-87c6-680f90e1b618\u0027)"},{"line_number":96,"context_line":"    def test_policy_update_forbidden_for_regular_tenants_own_policy(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_8184ce5f","line":93,"range":{"start_line":93,"start_character":13,"end_line":93,"end_character":24},"updated":"2017-06-13 12:53:57.000000000","message":"Which is the recommended way assertFalse or assertEmpty?\nThe implementation of assertEmpty uses assertFalse.\nIn general, we use assertFalse when we want to check a value is empty, and most developers tend to use assertFalse.\n\nSo, my questions are:\n\n- what is the reason of introducing assertEmpty rather than assertFalse?\n- should we enforce assertEmpty rather than assertFalse in tempest tests?\n\nWe would like to have a clear guideline for better reviews.","commit_id":"45df02d170ac196ae3011b34cdd30b848661b194"}]}
