)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d25f6537f282872ff4990a85f615b1de8c4acec8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"the agent would process it as a removed port to mark it as DOWN."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This fixes the bug by making the agent force the port to DOWN whenever"},{"line_number":20,"context_line":"it\u0027s VLAN changes. Watching for the VLAN change was introduced to detect"},{"line_number":21,"context_line":"these fast unplug/plug events before."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1694371"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_4f370ae5","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":17},"updated":"2017-06-13 08:23:45.000000000","message":"will local vlan always be changed? Like if there are other ports in the same vlan on the node? Would ofport be a better indicator of port replug?","commit_id":"05dcb9a13f4232a9054a62fb7d5ad3615176b538"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ae787546fb1d066273797d141117091ee4cca018","unresolved":false,"context_lines":[{"line_number":17,"context_line":"the agent would process it as a removed port to mark it as DOWN."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This fixes the bug by making the agent force the port to DOWN whenever"},{"line_number":20,"context_line":"it\u0027s VLAN changes. Watching for the VLAN change was introduced to detect"},{"line_number":21,"context_line":"these fast unplug/plug events before."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1694371"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_20548dfe","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":17},"in_reply_to":"7f231b9d_0512c362","updated":"2017-06-15 09:47:45.000000000","message":"Ah, definitely.","commit_id":"05dcb9a13f4232a9054a62fb7d5ad3615176b538"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a4d4602092e956c34253fdfcdfbcb9ac4704c211","unresolved":false,"context_lines":[{"line_number":17,"context_line":"the agent would process it as a removed port to mark it as DOWN."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This fixes the bug by making the agent force the port to DOWN whenever"},{"line_number":20,"context_line":"it\u0027s VLAN changes. Watching for the VLAN change was introduced to detect"},{"line_number":21,"context_line":"these fast unplug/plug events before."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1694371"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_0512c362","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":17},"in_reply_to":"7f231b9d_0c6ea400","updated":"2017-06-15 09:44:00.000000000","message":"I see, thanks. Is it better to say \u0027loss\u0027 instead of \u0027change\u0027 in the commit message then?","commit_id":"05dcb9a13f4232a9054a62fb7d5ad3615176b538"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"0c773b76fb1d34e65c0182571f95d7666b8644ee","unresolved":false,"context_lines":[{"line_number":17,"context_line":"the agent would process it as a removed port to mark it as DOWN."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This fixes the bug by making the agent force the port to DOWN whenever"},{"line_number":20,"context_line":"it\u0027s VLAN changes. Watching for the VLAN change was introduced to detect"},{"line_number":21,"context_line":"these fast unplug/plug events before."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1694371"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_cad737ee","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":17},"in_reply_to":"7f231b9d_20548dfe","updated":"2017-06-15 10:46:08.000000000","message":"Thanks!","commit_id":"05dcb9a13f4232a9054a62fb7d5ad3615176b538"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"fd0dbc5b94e686c40787cfedb206519d99f7c56b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"the agent would process it as a removed port to mark it as DOWN."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This fixes the bug by making the agent force the port to DOWN whenever"},{"line_number":20,"context_line":"it\u0027s VLAN changes. Watching for the VLAN change was introduced to detect"},{"line_number":21,"context_line":"these fast unplug/plug events before."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1694371"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_260cf039","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":17},"in_reply_to":"7f231b9d_209cd85b","updated":"2017-06-13 12:20:40.000000000","message":"Ok, it\u0027s about losing local vlan tag, which is detected, not about changing to some another, I missed that, sorry.\n\nAfter agent handles re-added port, it will assign same local vlan (at least if there are other ports from the same net on the node) - that was my concern. Or, am I wrong here as well?","commit_id":"05dcb9a13f4232a9054a62fb7d5ad3615176b538"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4b3db3eacd66476feb80de41abcb5760f061dcc6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"the agent would process it as a removed port to mark it as DOWN."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This fixes the bug by making the agent force the port to DOWN whenever"},{"line_number":20,"context_line":"it\u0027s VLAN changes. Watching for the VLAN change was introduced to detect"},{"line_number":21,"context_line":"these fast unplug/plug events before."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1694371"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_0c6ea400","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":17},"in_reply_to":"7f231b9d_260cf039","updated":"2017-06-13 21:54:20.000000000","message":"Yeah, it will re-assign the local VLAN, but that would be after this logic has detected that it has been lost or after it was gone long enough for the regular loop to treat it as a removed device.","commit_id":"05dcb9a13f4232a9054a62fb7d5ad3615176b538"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0b72b81cf46084317ad9556fc68555ac600ffd4f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"the agent would process it as a removed port to mark it as DOWN."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This fixes the bug by making the agent force the port to DOWN whenever"},{"line_number":20,"context_line":"it\u0027s VLAN changes. Watching for the VLAN change was introduced to detect"},{"line_number":21,"context_line":"these fast unplug/plug events before."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1694371"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f231b9d_209cd85b","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":17},"in_reply_to":"7f231b9d_4f370ae5","updated":"2017-06-13 11:40:32.000000000","message":"Yes, if a port is removed and re-added it loses it\u0027s local VLAN. At least this is what was observed back when the local VLAN change function was added before. Do you have a test environment where you can confirm?\n\nofport is risky because I don\u0027t think we are guaranteed that they constantly increment.","commit_id":"05dcb9a13f4232a9054a62fb7d5ad3615176b538"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"93787483648bb30bed26c06975b90ecb53c05ef5","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"            # explicitly mark these DOWN on the server since they have been"},{"line_number":1386,"context_line":"            # manipulated (likely a nova unplug/replug) and need to be rewired"},{"line_number":1387,"context_line":"            devices_down \u003d self.plugin_rpc.update_device_list(self.context,"},{"line_number":1388,"context_line":"                                                              [],"},{"line_number":1389,"context_line":"                                                              changed_ports,"},{"line_number":1390,"context_line":"                                                              self.agent_id,"},{"line_number":1391,"context_line":"                                                              self.conf.host)"},{"line_number":1392,"context_line":"            failed_devices \u003d set(devices_down.get(\u0027failed_devices_down\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_7e66a5c3","line":1389,"range":{"start_line":1388,"start_character":62,"end_line":1389,"end_character":76},"updated":"2017-06-15 13:19:06.000000000","message":"From the perspective of code readability, it is nice if we use named arguments like\n\n  devices_up\u003d[], devices_down\u003dchanged_ports\n\nHowever, we already use this style when calling update_device_list() in other places, so I am okay with this.","commit_id":"0d7952400be3e60973a30fae76a82ec5c8259ffc"}]}