)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c3c90bb42b2ff79f69ddbd6868a90386512bd755","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"so need to check whether the existence of ip, to avoid this error."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"bug: https://bugs.launchpad.net/neutron/+bug/1697926"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9aae3b4f0fab053e8c215887f58b983d9549582d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_a187a30f","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":52},"updated":"2017-06-14 12:45:08.000000000","message":"Could you use the below instead?\n\n  Closes-Bug: #1697926\n\nIt is documented in the developer guide.\nhttps://docs.openstack.org/infra/manual/developers.html","commit_id":"ff8a3ad231da11e3806598436dbe892b552c92a5"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a114fef5fe17824c89dc4596a35ba8cb4d32e910","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                # otherwise will report error"},{"line_number":360,"context_line":"                ret_ip \u003d dst_device.addr.list(scope\u003d\u0027global\u0027, to\u003dip[\u0027cidr\u0027])"},{"line_number":361,"context_line":"                if len(ret_ip) \u003e 0:"},{"line_number":362,"context_line":"                    continue"},{"line_number":363,"context_line":"                dst_device.addr.add(cidr\u003dip[\u0027cidr\u0027])"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        if gateway:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_69e851e1","line":362,"updated":"2017-06-14 14:09:48.000000000","message":"I would make this:\n\nif not dst_device.addr.list(to\u003dip[\u0027cidr\u0027]):\n   \"add IP\"\n\nThis is what is done in other code.","commit_id":"ff8a3ad231da11e3806598436dbe892b552c92a5"}],"neutron/tests/unit/plugins/ml2/drivers/linuxbridge/agent/test_linuxbridge_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"46a5fdbede018fe2df3459807ff21dc862da4836","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            self.assertTrue(list_fn.called)"},{"line_number":446,"context_line":"            self.assertTrue(del_fn.called)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        with mock.patch.object(ip_lib.IpRouteCommand,"},{"line_number":449,"context_line":"                               \u0027add_gateway\u0027) as addgw_fn,\\"},{"line_number":450,"context_line":"                mock.patch.object(ip_lib.IpRouteCommand,"},{"line_number":451,"context_line":"                                  \u0027delete_gateway\u0027) as delgw_fn:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_8fb6f43d","line":448,"updated":"2017-06-15 08:12:51.000000000","message":"I think you want to move these patch calls as part of the same \u0027with\u0027 block on L441. Otherwise the patches on L441 will have no effect after the with block exits on L447.","commit_id":"d6ca0507e1d8e23e4710fba49a1af74fce7ffc76"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"76c87ac09c3d9159792b02ca8365dba7beee4b3b","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                      dynamic\u003dFalse)"},{"line_number":439,"context_line":"        with mock.patch.object(ip_lib.IpAddrCommand, \u0027add\u0027) as add_fn,\\"},{"line_number":440,"context_line":"                mock.patch.object(ip_lib.IpAddrCommand, \u0027delete\u0027) as del_fn,\\"},{"line_number":441,"context_line":"                mock.patch.object(ip_lib.IpAddrCommand, \u0027list\u0027) as list_fn:"},{"line_number":442,"context_line":"            self.lbm._update_interface_ip_details(\"br0\", \"eth0\","},{"line_number":443,"context_line":"                                                  [ipdict], None)"},{"line_number":444,"context_line":"            self.assertFalse(add_fn.called)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_e271e145","line":441,"updated":"2017-06-16 02:06:10.000000000","message":"Could actually just add all this to the test above, I\u0027ll send an update.","commit_id":"c908603e65519450c04017880b45e4ad19996294"}]}