)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"f8924974ebcba93e4a553ed8a5b4faff77e13bcc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This patch begins to move us onto the payload objects by updating"},{"line_number":16,"context_line":"BEFORE_INIT and AFTER_INIT event types to use the payloads."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"NB: This change needs to be in sync with consumers using the events"},{"line_number":19,"context_line":"herein. Once publish() is used with payloads, callback functions must"},{"line_number":20,"context_line":"also define the payload kwarg to follow suit. Therefore such consumers"},{"line_number":21,"context_line":"need to depend on this patch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f231b9d_a9e789ac","line":18,"updated":"2017-06-14 14:20:59.000000000","message":"I\u0027m not crazy about this approach, but don\u0027t see another (easy) way to provide backwards-compat.\n\n\nThoughts welcome.","commit_id":"6b479707cd19e5349260c49e8edabc71d9ec9591"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c9c965b5fec33b679774dc3f1c68c44e009fd6f4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"NB: This change needs to be in sync with consumers using the events"},{"line_number":19,"context_line":"herein. Once publish() is used with payloads, callback functions must"},{"line_number":20,"context_line":"also define the payload kwarg to follow suit. Therefore such consumers"},{"line_number":21,"context_line":"need to depend on this patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_6a06c41e","line":21,"updated":"2017-06-27 10:39:44.000000000","message":"how about introducing another set of events for notifications with payload?\nthat way we can retain compatibility.","commit_id":"89bbfc8eb916201501df953a9134c6cb2998eca1"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"88887ec871f768eaac6c2227b4d994c4c9023a2a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"NB: This change needs to be in sync with consumers using the events"},{"line_number":19,"context_line":"herein. Once publish() is used with payloads, callback functions must"},{"line_number":20,"context_line":"also define the payload kwarg to follow suit. Therefore such consumers"},{"line_number":21,"context_line":"need to depend on this patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_a6bccb6c","line":21,"in_reply_to":"3f1d235d_b7df6c64","updated":"2017-07-20 12:28:09.000000000","message":"Waiting for Kevin and/or other cores for additional input on this one. Kevin said he\u0027d think about it and comment when he gets a chance.","commit_id":"89bbfc8eb916201501df953a9134c6cb2998eca1"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"eb9604fef291f26f6e869456c8e66ff9416d9355","unresolved":false,"context_lines":[{"line_number":18,"context_line":"NB: This change needs to be in sync with consumers using the events"},{"line_number":19,"context_line":"herein. Once publish() is used with payloads, callback functions must"},{"line_number":20,"context_line":"also define the payload kwarg to follow suit. Therefore such consumers"},{"line_number":21,"context_line":"need to depend on this patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_1fce4162","line":21,"in_reply_to":"5f201791_171ab815","updated":"2017-06-28 13:24:02.000000000","message":"Just for clarity; the API is backwards compatible when using notify(..., **kwargs). Neutron is using it today. What we are talking about here is consuming a new aspect/enhancement of the API which is obviously the payload object published via publish(..., payload\u003dpayload_obj).","commit_id":"89bbfc8eb916201501df953a9134c6cb2998eca1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1f7b302aa72a12de3d7c49f8911546546d23e33e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"NB: This change needs to be in sync with consumers using the events"},{"line_number":19,"context_line":"herein. Once publish() is used with payloads, callback functions must"},{"line_number":20,"context_line":"also define the payload kwarg to follow suit. Therefore such consumers"},{"line_number":21,"context_line":"need to depend on this patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f1d235d_b7df6c64","line":21,"in_reply_to":"5f201791_1fce4162","updated":"2017-07-07 06:59:00.000000000","message":"yes, the switch from notify() to publish() is the breaking change.  it breaks even an in-tree consumer. [1]\n\n[1] neutron.services.trunk.drivers.openvswitch.agent.driver.init_handler","commit_id":"89bbfc8eb916201501df953a9134c6cb2998eca1"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b3316d4b6dcc19dcae13f507f8ab7fb61ada2acf","unresolved":false,"context_lines":[{"line_number":18,"context_line":"NB: This change needs to be in sync with consumers using the events"},{"line_number":19,"context_line":"herein. Once publish() is used with payloads, callback functions must"},{"line_number":20,"context_line":"also define the payload kwarg to follow suit. Therefore such consumers"},{"line_number":21,"context_line":"need to depend on this patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_db947d39","line":21,"in_reply_to":"5f201791_6a06c41e","updated":"2017-06-27 18:08:16.000000000","message":"Are you saying introduce a new set of events (e.g. BEFORE_CREATE_PAYLOAD, ...) to signify the callback wants a payload object (new style) vs kwarg (existing) style?\n\n\nThe way things work today, once a publisher switches and starts using the payload event; all consumers for that event must support the payload style. If we want to support both styles of callbacks for a single event, then we either need the publishers to handle both cases (calling with kwargs as well as building and calling with payload object) or we need a way to construct the payload objects from kwargs so the callback system knows how to handle it for the publishers. This seems like quite a bit of \"overhead\", but perhaps it\u0027s warranted?","commit_id":"89bbfc8eb916201501df953a9134c6cb2998eca1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bab49823eb4a01bd75c621e2c40c07b4062ded6a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"NB: This change needs to be in sync with consumers using the events"},{"line_number":19,"context_line":"herein. Once publish() is used with payloads, callback functions must"},{"line_number":20,"context_line":"also define the payload kwarg to follow suit. Therefore such consumers"},{"line_number":21,"context_line":"need to depend on this patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_171ab815","line":21,"in_reply_to":"5f201791_db947d39","updated":"2017-06-28 06:38:14.000000000","message":"yes.\n\ni agree it might be overkill.\nbut i guess we should try to keep compatibility when possible when changing an api possibly consumed by external projects.\notoh, we have a history making incompatible changes for event callback consumers.\nactually i\u0027m on the fence.\nhow others think?","commit_id":"89bbfc8eb916201501df953a9134c6cb2998eca1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"91404d6608c70be83d4f4f896090f0a6b94d5c58","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] https://github.com/openstack/neutron-lib/blob/master/doc/source/devref/callbacks.rst#event-payloads"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I9194c7857f10392149159071cda8e080e93adc10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f515b1d_759de055","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":103},"updated":"2017-10-06 21:56:36.000000000","message":"This is the correct link: https://github.com/openstack/neutron-lib/blob/master/doc/source/contributor/callbacks.rst#event-payloads","commit_id":"a81bcbff3ef7d537ec4e0c16158a3901e5738370"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9ae5038a695d0de84748075c5e76a01861e0e641","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NeutronLibImpact"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] https://github.com/openstack/neutron-lib/blob/master/doc/source/devref/callbacks.rst#event-payloads"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I9194c7857f10392149159071cda8e080e93adc10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f515b1d_40f436f1","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":103},"in_reply_to":"7f515b1d_759de055","updated":"2017-10-09 14:40:12.000000000","message":"Technically it may be best just to point to the openstack docs site which is what I\u0027ve done in the updated patch.","commit_id":"a81bcbff3ef7d537ec4e0c16158a3901e5738370"}]}