)]}'
{"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3d2d99b8d9960e845b9ad84bceb062ecfc4a7326","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    def __init__(self, cmd, *args, **kwargs):"},{"line_number":269,"context_line":"        for arg in (\u0027stdin\u0027, \u0027stdout\u0027, \u0027stderr\u0027):"},{"line_number":270,"context_line":"            kwargs.setdefault(arg, subprocess.PIPE)"},{"line_number":271,"context_line":"        kwargs.setdefault(\u0027universal_newlines\u0027, True)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        self.namespace \u003d kwargs.pop(\u0027namespace\u0027, None)"},{"line_number":274,"context_line":"        self.cmd \u003d cmd"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_248a5abe","line":271,"range":{"start_line":271,"start_character":8,"end_line":271,"end_character":53},"updated":"2017-06-15 14:12:52.000000000","message":"setdefault() just sets the default value of universal_newlines.\nI think we always need universal_newlines \u003d\u003d True.\nIf so, I think we need to set universal_newlines to True explicitly.\n\n kwargs[\u0027universal_newlines\u0027] \u003d True\n\nIs there a case where we need to use False?","commit_id":"5d619e54e2d51e6dafbdb4f9ac58e26dfc7b14a8"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"75372b17dbb595fbe1ee8fb1e1b2407f33b50119","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    def __init__(self, cmd, *args, **kwargs):"},{"line_number":269,"context_line":"        for arg in (\u0027stdin\u0027, \u0027stdout\u0027, \u0027stderr\u0027):"},{"line_number":270,"context_line":"            kwargs.setdefault(arg, subprocess.PIPE)"},{"line_number":271,"context_line":"        kwargs.setdefault(\u0027universal_newlines\u0027, True)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        self.namespace \u003d kwargs.pop(\u0027namespace\u0027, None)"},{"line_number":274,"context_line":"        self.cmd \u003d cmd"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_310cdbea","line":271,"range":{"start_line":271,"start_character":8,"end_line":271,"end_character":53},"in_reply_to":"7f231b9d_248a5abe","updated":"2017-06-15 14:57:21.000000000","message":"I want to keep compatibility with Popen.__init__, which means all parameters that Popen consumes can be defined for RootHelperProcess too.\n\nThis just sets the True as default for Popen and it lets the caller to override.\n\nI don\u0027t think we currently use binary (False value) anywhere.","commit_id":"5d619e54e2d51e6dafbdb4f9ac58e26dfc7b14a8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5ef5d19e731e23cc9356abb6eacc444f91ae8362","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    def __init__(self, cmd, *args, **kwargs):"},{"line_number":269,"context_line":"        for arg in (\u0027stdin\u0027, \u0027stdout\u0027, \u0027stderr\u0027):"},{"line_number":270,"context_line":"            kwargs.setdefault(arg, subprocess.PIPE)"},{"line_number":271,"context_line":"        kwargs.setdefault(\u0027universal_newlines\u0027, True)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        self.namespace \u003d kwargs.pop(\u0027namespace\u0027, None)"},{"line_number":274,"context_line":"        self.cmd \u003d cmd"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_602ef792","line":271,"range":{"start_line":271,"start_character":8,"end_line":271,"end_character":53},"in_reply_to":"7f231b9d_310cdbea","updated":"2017-06-15 17:09:34.000000000","message":"Sounds reasonable. Thanks.","commit_id":"5d619e54e2d51e6dafbdb4f9ac58e26dfc7b14a8"}]}