)]}'
{"neutron/tests/tempest/api/test_routers.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"033529ff728cc113f9ff432a8b09f9bf7234cae1","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            **router_args)"},{"line_number":250,"context_line":"        self.addCleanup(self.admin_client.delete_router,"},{"line_number":251,"context_line":"                        router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":252,"context_line":"        self.assertNotIn(\u0027distributed\u0027, router)"},{"line_number":253,"context_line":"        self.assertNotIn(\u0027ha\u0027, router)"},{"line_number":254,"context_line":"        update_body \u003d self.admin_client.update_router(router[\u0027id\u0027],"},{"line_number":255,"context_line":"                                                      distributed\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_a39aafb5","line":252,"range":{"start_line":252,"start_character":40,"end_line":252,"end_character":46},"updated":"2017-06-16 23:36:05.000000000","message":"I think this also has to change to router[\u0027router\u0027]","commit_id":"54b77440681d7b9a21be710965e74047094fb4c6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f2fef386810d9a2b99eb9134c68635e3b607410d","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            **router_args)"},{"line_number":250,"context_line":"        self.addCleanup(self.admin_client.delete_router,"},{"line_number":251,"context_line":"                        router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":252,"context_line":"        self.assertNotIn(\u0027distributed\u0027, router)"},{"line_number":253,"context_line":"        self.assertNotIn(\u0027ha\u0027, router)"},{"line_number":254,"context_line":"        update_body \u003d self.admin_client.update_router(router[\u0027id\u0027],"},{"line_number":255,"context_line":"                                                      distributed\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_927a2d86","line":252,"range":{"start_line":252,"start_character":40,"end_line":252,"end_character":46},"in_reply_to":"7f231b9d_a39aafb5","updated":"2017-06-20 18:36:24.000000000","message":"Right, let me look at the other review I just did, don\u0027t know how I messed this up.","commit_id":"54b77440681d7b9a21be710965e74047094fb4c6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"033529ff728cc113f9ff432a8b09f9bf7234cae1","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        self.addCleanup(self.admin_client.delete_router,"},{"line_number":251,"context_line":"                        router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":252,"context_line":"        self.assertNotIn(\u0027distributed\u0027, router)"},{"line_number":253,"context_line":"        self.assertNotIn(\u0027ha\u0027, router)"},{"line_number":254,"context_line":"        update_body \u003d self.admin_client.update_router(router[\u0027id\u0027],"},{"line_number":255,"context_line":"                                                      distributed\u003dTrue)"},{"line_number":256,"context_line":"        self.assertTrue(update_body[\u0027router\u0027][\u0027distributed\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_83957389","line":253,"range":{"start_line":253,"start_character":31,"end_line":253,"end_character":37},"updated":"2017-06-16 23:36:05.000000000","message":"I think this also has to change to router[\u0027router\u0027]","commit_id":"54b77440681d7b9a21be710965e74047094fb4c6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3c9b993221d923b3b206aec5a15dc3d2d029c81d","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                        router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":252,"context_line":"        self.assertNotIn(\u0027distributed\u0027, router)"},{"line_number":253,"context_line":"        self.assertNotIn(\u0027ha\u0027, router)"},{"line_number":254,"context_line":"        update_body \u003d self.admin_client.update_router(router[\u0027id\u0027],"},{"line_number":255,"context_line":"                                                      distributed\u003dTrue)"},{"line_number":256,"context_line":"        self.assertTrue(update_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":257,"context_line":"        show_body \u003d self.admin_client.show_router(router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_716fc42a","line":254,"range":{"start_line":254,"start_character":54,"end_line":254,"end_character":66},"updated":"2017-06-16 23:07:48.000000000","message":"Since now you are calling the admin_client instead of the helper function _create_router in line 247, here you need router[\u0027router\u0027][\u0027id\u0027]","commit_id":"54b77440681d7b9a21be710965e74047094fb4c6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a4e6ed0c343807e95f1a785001a378972c49491","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        update_body \u003d self.admin_client.update_router(router[\u0027id\u0027],"},{"line_number":255,"context_line":"                                                      distributed\u003dTrue)"},{"line_number":256,"context_line":"        self.assertTrue(update_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":257,"context_line":"        show_body \u003d self.admin_client.show_router(router[\u0027id\u0027])"},{"line_number":258,"context_line":"        self.assertTrue(show_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":259,"context_line":"        show_body \u003d self.client.show_router(router[\u0027id\u0027])"},{"line_number":260,"context_line":"        self.assertNotIn(\u0027distributed\u0027, show_body[\u0027router\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_11709007","line":257,"range":{"start_line":257,"start_character":50,"end_line":257,"end_character":62},"updated":"2017-06-16 23:09:25.000000000","message":"Ditto","commit_id":"54b77440681d7b9a21be710965e74047094fb4c6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a4e6ed0c343807e95f1a785001a378972c49491","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        self.assertTrue(update_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":257,"context_line":"        show_body \u003d self.admin_client.show_router(router[\u0027id\u0027])"},{"line_number":258,"context_line":"        self.assertTrue(show_body[\u0027router\u0027][\u0027distributed\u0027])"},{"line_number":259,"context_line":"        show_body \u003d self.client.show_router(router[\u0027id\u0027])"},{"line_number":260,"context_line":"        self.assertNotIn(\u0027distributed\u0027, show_body[\u0027router\u0027])"},{"line_number":261,"context_line":"        self.assertNotIn(\u0027ha\u0027, show_body[\u0027router\u0027])"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_f164f44b","line":259,"range":{"start_line":259,"start_character":44,"end_line":259,"end_character":56},"updated":"2017-06-16 23:09:25.000000000","message":"Ditto","commit_id":"54b77440681d7b9a21be710965e74047094fb4c6"}]}
