)]}'
{"neutron/tests/contrib/hooks/availability_zone":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"96703c90d3af8a8581179d0bc89fb74de8d8bbe1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-extra|$TEMPEST_CONFIG]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[neutron_plugin_options]"},{"line_number":4,"context_line":"agent_availability_zone \u003d nova"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3f4b6375_724ebd97","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":12},"updated":"2017-11-06 07:07:36.000000000","message":"test-config is more appropriate i guess","commit_id":"fa5121ab3c0796bc7f032a898cc2d85c812c36a8"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"285edf16cc253f45382045cd577d94940925da25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-extra|$TEMPEST_CONFIG]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[neutron_plugin_options]"},{"line_number":4,"context_line":"agent_availability_zone \u003d nova"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3f4b6375_2d3fca87","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":12},"in_reply_to":"3f4b6375_724ebd97","updated":"2017-11-06 07:37:07.000000000","message":"Done","commit_id":"fa5121ab3c0796bc7f032a898cc2d85c812c36a8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"96703c90d3af8a8581179d0bc89fb74de8d8bbe1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-extra|$TEMPEST_CONFIG]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[neutron_plugin_options]"},{"line_number":4,"context_line":"agent_availability_zone \u003d nova"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[[post-config|/$NEUTRON_L3_CONF]]"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3f4b6375_721c7d77","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":30},"updated":"2017-11-06 07:07:36.000000000","message":"this doesn\u0027t seem working in legacy-neutron-dsvm-api. can you debug?","commit_id":"fa5121ab3c0796bc7f032a898cc2d85c812c36a8"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"285edf16cc253f45382045cd577d94940925da25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-extra|$TEMPEST_CONFIG]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[neutron_plugin_options]"},{"line_number":4,"context_line":"agent_availability_zone \u003d nova"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[[post-config|/$NEUTRON_L3_CONF]]"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3f4b6375_ad529adc","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":30},"in_reply_to":"3f4b6375_721c7d77","updated":"2017-11-06 07:37:07.000000000","message":"It seems related to test-config in L1.","commit_id":"fa5121ab3c0796bc7f032a898cc2d85c812c36a8"}],"neutron/tests/tempest/api/admin/test_agent_availability_zone.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"45c29fa73203f4ab1a644f8a5602f4fffcffd662","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class AgentAvailabilityZoneTestBase(base.BaseAdminNetworkTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    @test.requires_ext(extension\u003d\"agent\", service\u003d\"network\")"},{"line_number":26,"context_line":"    @test.requires_ext(extension\u003d\"availability_zone\", service\u003d\"network\")"},{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(AgentAvailabilityZoneTestBase, cls).resource_setup()"},{"line_number":29,"context_line":"        body \u003d cls.admin_client.list_agents()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_f4514d64","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":72},"updated":"2017-06-29 10:53:59.000000000","message":"consider to use required_extensions class attribute","commit_id":"032fdf5f0355595e5af5571b86ebaf4c4ff4d5cd"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"d2f2c8bd9f01d541c84b24d90d5a948b35b3de21","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class AgentAvailabilityZoneTestBase(base.BaseAdminNetworkTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    @test.requires_ext(extension\u003d\"agent\", service\u003d\"network\")"},{"line_number":26,"context_line":"    @test.requires_ext(extension\u003d\"availability_zone\", service\u003d\"network\")"},{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(AgentAvailabilityZoneTestBase, cls).resource_setup()"},{"line_number":29,"context_line":"        body \u003d cls.admin_client.list_agents()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_2fdc1273","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":72},"in_reply_to":"3f1d235d_f4514d64","updated":"2017-06-29 11:26:23.000000000","message":"Done","commit_id":"032fdf5f0355595e5af5571b86ebaf4c4ff4d5cd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"45c29fa73203f4ab1a644f8a5602f4fffcffd662","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        body \u003d cls.admin_client.list_agents()"},{"line_number":30,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":31,"context_line":"        agents_type \u003d [agent.get(\u0027agent_type\u0027) for agent in agents]"},{"line_number":32,"context_line":"        if (constants.AGENT_TYPE_L3 not in agents_type"},{"line_number":33,"context_line":"            and constants.AGENT_TYPE_DHCP not in agents_type):"},{"line_number":34,"context_line":"            msg \u003d \u0027availability_zone supported agent not found.\u0027"},{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_34eea588","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":62},"updated":"2017-06-29 10:53:59.000000000","message":"use AZ_SUPPORTED_AGENTS rather than inlining it","commit_id":"032fdf5f0355595e5af5571b86ebaf4c4ff4d5cd"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"d2f2c8bd9f01d541c84b24d90d5a948b35b3de21","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        body \u003d cls.admin_client.list_agents()"},{"line_number":30,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":31,"context_line":"        agents_type \u003d [agent.get(\u0027agent_type\u0027) for agent in agents]"},{"line_number":32,"context_line":"        if (constants.AGENT_TYPE_L3 not in agents_type"},{"line_number":33,"context_line":"            and constants.AGENT_TYPE_DHCP not in agents_type):"},{"line_number":34,"context_line":"            msg \u003d \u0027availability_zone supported agent not found.\u0027"},{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_0f1ef60b","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":62},"in_reply_to":"3f1d235d_34eea588","updated":"2017-06-29 11:26:23.000000000","message":"Done","commit_id":"032fdf5f0355595e5af5571b86ebaf4c4ff4d5cd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"45c29fa73203f4ab1a644f8a5602f4fffcffd662","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":45,"context_line":"        for agent in agents:"},{"line_number":46,"context_line":"            if agent.get(\u0027agent_type\u0027) in AZ_SUPPORTED_AGENTS:"},{"line_number":47,"context_line":"                self.assertEqual(agent.get(\u0027availability_zone\u0027), \u0027nova\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_b4f9954e","line":47,"range":{"start_line":47,"start_character":66,"end_line":47,"end_character":70},"updated":"2017-06-29 10:53:59.000000000","message":"it varies among deployments, doesn\u0027t it?","commit_id":"032fdf5f0355595e5af5571b86ebaf4c4ff4d5cd"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"d2f2c8bd9f01d541c84b24d90d5a948b35b3de21","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":45,"context_line":"        for agent in agents:"},{"line_number":46,"context_line":"            if agent.get(\u0027agent_type\u0027) in AZ_SUPPORTED_AGENTS:"},{"line_number":47,"context_line":"                self.assertEqual(agent.get(\u0027availability_zone\u0027), \u0027nova\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_4fe18efe","line":47,"range":{"start_line":47,"start_character":66,"end_line":47,"end_character":70},"in_reply_to":"3f1d235d_b4f9954e","updated":"2017-06-29 11:26:23.000000000","message":"Yes, we can change this value, but default is \u0027nova\u0027.","commit_id":"032fdf5f0355595e5af5571b86ebaf4c4ff4d5cd"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ea93bc7b679762305967fd1c365ea3a5d6e40a89","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":45,"context_line":"        for agent in agents:"},{"line_number":46,"context_line":"            if agent.get(\u0027agent_type\u0027) in AZ_SUPPORTED_AGENTS:"},{"line_number":47,"context_line":"                self.assertEqual(agent.get(\u0027availability_zone\u0027), DEFAULT_AZ)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_5aaf0394","line":47,"range":{"start_line":47,"start_character":65,"end_line":47,"end_character":75},"updated":"2017-06-29 15:32:50.000000000","message":"tempest tests should be deployment agnostic when possible.\ndo not assert a specific configuration, even if it\u0027s the default.","commit_id":"c4e72ea75239cbd8b9a61788cc105ef4684740d7"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"2620334a0ae713d8f7dce41b4ade0a79e26963a9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":45,"context_line":"        for agent in agents:"},{"line_number":46,"context_line":"            if agent.get(\u0027agent_type\u0027) in AZ_SUPPORTED_AGENTS:"},{"line_number":47,"context_line":"                self.assertEqual(agent.get(\u0027availability_zone\u0027), DEFAULT_AZ)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_06c1032f","line":47,"range":{"start_line":47,"start_character":65,"end_line":47,"end_character":75},"in_reply_to":"3f1d235d_5aaf0394","updated":"2017-07-01 11:07:05.000000000","message":"I\u0027m not sure how to modify it, do we depends on Devstack for tempest tests? If so, the default value is set.","commit_id":"c4e72ea75239cbd8b9a61788cc105ef4684740d7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6fec2fa70d44a03f6a6f92ea4e07560aaee1e15e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":31,"context_line":"        agents_type \u003d [agent.get(\u0027agent_type\u0027) for agent in agents]"},{"line_number":32,"context_line":"        if (AZ_SUPPORTED_AGENTS[0] not in agents_type"},{"line_number":33,"context_line":"            and AZ_SUPPORTED_AGENTS[1] not in agents_type):"},{"line_number":34,"context_line":"            msg \u003d \u0027availability_zone supported agent not found.\u0027"},{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_a648bc86","line":33,"updated":"2017-09-14 14:39:28.000000000","message":"I would do it with for loop rather than \"and\" in if condition. It would be easier if some day You will need to add another agent to this list maybe :)","commit_id":"549484c685ca3e142f5de38828f5c81033a9e6cc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6a3cc12689e17ef680cea44bb2127da098fd4547","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":31,"context_line":"        agents_type \u003d [agent.get(\u0027agent_type\u0027) for agent in agents]"},{"line_number":32,"context_line":"        if (AZ_SUPPORTED_AGENTS[0] not in agents_type"},{"line_number":33,"context_line":"            and AZ_SUPPORTED_AGENTS[1] not in agents_type):"},{"line_number":34,"context_line":"            msg \u003d \u0027availability_zone supported agent not found.\u0027"},{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_edb9eb78","line":33,"in_reply_to":"5f2577a7_0cf20f71","updated":"2017-10-09 06:45:40.000000000","message":"what about something like:\n\nfor az_agent in AZ_SUPPORTED_AGENTS:\n    if ag_agent in agents_type:\n        return\nraise cls.skipException(msg)","commit_id":"549484c685ca3e142f5de38828f5c81033a9e6cc"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4539298d6f9ce9bba5911805e1040f0c6c3f3653","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":31,"context_line":"        agents_type \u003d [agent.get(\u0027agent_type\u0027) for agent in agents]"},{"line_number":32,"context_line":"        if (AZ_SUPPORTED_AGENTS[0] not in agents_type"},{"line_number":33,"context_line":"            and AZ_SUPPORTED_AGENTS[1] not in agents_type):"},{"line_number":34,"context_line":"            msg \u003d \u0027availability_zone supported agent not found.\u0027"},{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_0cf20f71","line":33,"in_reply_to":"5f2577a7_a648bc86","updated":"2017-10-09 02:15:03.000000000","message":"Do you mean：\nfor az_agent in AZ_SUPPORTED_AGENTS:\n    if ag_agent not in agents_type:\n        msg \u003d \u0027availability_zone supported agent not found.\u0027\n        raise cls.skipException(msg)\n\nI think this is different from the logic in L32 and L33.","commit_id":"549484c685ca3e142f5de38828f5c81033a9e6cc"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"8e3c3bae9aad58f115930c46e621b86625e54b0f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":31,"context_line":"        agents_type \u003d [agent.get(\u0027agent_type\u0027) for agent in agents]"},{"line_number":32,"context_line":"        if (AZ_SUPPORTED_AGENTS[0] not in agents_type"},{"line_number":33,"context_line":"            and AZ_SUPPORTED_AGENTS[1] not in agents_type):"},{"line_number":34,"context_line":"            msg \u003d \u0027availability_zone supported agent not found.\u0027"},{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_b8d0d320","line":33,"in_reply_to":"7f515b1d_edb9eb78","updated":"2017-10-09 07:16:14.000000000","message":"Thanks, this seems much more readable.","commit_id":"549484c685ca3e142f5de38828f5c81033a9e6cc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6fec2fa70d44a03f6a6f92ea4e07560aaee1e15e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @decorators.idempotent_id(\u00273ffa661e-cfcc-417d-8b63-1c5ec4a22e54\u0027)"},{"line_number":38,"context_line":"    def test_list_agent_availability_zone(self):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        Test list agent availability_zone, only L3 and DHCP agent support"},{"line_number":41,"context_line":"        availability_zone, default availability_zone is \"nova\"."}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_86614008","line":38,"updated":"2017-09-14 14:39:28.000000000","message":"Maybe it\u0027s only me but this name of test is not perfect IMO. It suggest me that this will test list of all agents which belongs to some AZ.\nMaybe better would be something like \"test_agents_availability_zone\" or something like that?","commit_id":"549484c685ca3e142f5de38828f5c81033a9e6cc"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4539298d6f9ce9bba5911805e1040f0c6c3f3653","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @decorators.idempotent_id(\u00273ffa661e-cfcc-417d-8b63-1c5ec4a22e54\u0027)"},{"line_number":38,"context_line":"    def test_list_agent_availability_zone(self):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        Test list agent availability_zone, only L3 and DHCP agent support"},{"line_number":41,"context_line":"        availability_zone, default availability_zone is \"nova\"."}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_d706d41c","line":38,"in_reply_to":"5f2577a7_86614008","updated":"2017-10-09 02:15:03.000000000","message":"Done","commit_id":"549484c685ca3e142f5de38828f5c81033a9e6cc"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"74a50539cce6160abc37a7858432c19e3d3e9edb","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    required_extensions \u003d [\u0027agent\u0027, \u0027availability_zone\u0027]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(AgentAvailabilityZoneTestBase, cls).resource_setup()"},{"line_number":29,"context_line":"        body \u003d cls.admin_client.list_agents()"},{"line_number":30,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":31,"context_line":"        agents_type \u003d [agent.get(\u0027agent_type\u0027) for agent in agents]"},{"line_number":32,"context_line":"        if (AZ_SUPPORTED_AGENTS[0] not in agents_type"},{"line_number":33,"context_line":"            and AZ_SUPPORTED_AGENTS[1] not in agents_type):"},{"line_number":34,"context_line":"            msg \u003d \u0027availability_zone supported agent not found.\u0027"},{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @decorators.idempotent_id(\u00273ffa661e-cfcc-417d-8b63-1c5ec4a22e54\u0027)"},{"line_number":38,"context_line":"    def test_agents_availability_zone(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_b01ac3c2","line":35,"range":{"start_line":26,"start_character":0,"end_line":35,"end_character":40},"updated":"2017-10-03 08:20:46.000000000","message":"is this check necessary?\nit seems test_agents_availability_zone would pass even if there are no relevant agents.","commit_id":"2aff4a9210ad9015ee87092fb5528548c38a4716"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"039b59ac78e3df9c295b7ab8cc3da972c278354c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    required_extensions \u003d [\u0027agent\u0027, \u0027availability_zone\u0027]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(AgentAvailabilityZoneTestBase, cls).resource_setup()"},{"line_number":29,"context_line":"        body \u003d cls.admin_client.list_agents()"},{"line_number":30,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":31,"context_line":"        agents_type \u003d [agent.get(\u0027agent_type\u0027) for agent in agents]"},{"line_number":32,"context_line":"        if (AZ_SUPPORTED_AGENTS[0] not in agents_type"},{"line_number":33,"context_line":"            and AZ_SUPPORTED_AGENTS[1] not in agents_type):"},{"line_number":34,"context_line":"            msg \u003d \u0027availability_zone supported agent not found.\u0027"},{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @decorators.idempotent_id(\u00273ffa661e-cfcc-417d-8b63-1c5ec4a22e54\u0027)"},{"line_number":38,"context_line":"    def test_agents_availability_zone(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_2d49ce8a","line":35,"range":{"start_line":26,"start_character":0,"end_line":35,"end_character":40},"in_reply_to":"7f515b1d_b01ac3c2","updated":"2017-10-03 19:33:04.000000000","message":"IMHO it\u0027s better to have strict info that test is skipped and why it is skipped rather than have test which pass but not checks anything in fact.","commit_id":"2aff4a9210ad9015ee87092fb5528548c38a4716"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4539298d6f9ce9bba5911805e1040f0c6c3f3653","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    required_extensions \u003d [\u0027agent\u0027, \u0027availability_zone\u0027]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def resource_setup(cls):"},{"line_number":28,"context_line":"        super(AgentAvailabilityZoneTestBase, cls).resource_setup()"},{"line_number":29,"context_line":"        body \u003d cls.admin_client.list_agents()"},{"line_number":30,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":31,"context_line":"        agents_type \u003d [agent.get(\u0027agent_type\u0027) for agent in agents]"},{"line_number":32,"context_line":"        if (AZ_SUPPORTED_AGENTS[0] not in agents_type"},{"line_number":33,"context_line":"            and AZ_SUPPORTED_AGENTS[1] not in agents_type):"},{"line_number":34,"context_line":"            msg \u003d \u0027availability_zone supported agent not found.\u0027"},{"line_number":35,"context_line":"            raise cls.skipException(msg)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @decorators.idempotent_id(\u00273ffa661e-cfcc-417d-8b63-1c5ec4a22e54\u0027)"},{"line_number":38,"context_line":"    def test_agents_availability_zone(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_e42348a6","line":35,"range":{"start_line":26,"start_character":0,"end_line":35,"end_character":40},"in_reply_to":"7f515b1d_b01ac3c2","updated":"2017-10-09 02:15:03.000000000","message":"Yes, if other agents does not supports availability_zone, we should raise a skipped info here.","commit_id":"2aff4a9210ad9015ee87092fb5528548c38a4716"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"74a50539cce6160abc37a7858432c19e3d3e9edb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":45,"context_line":"        for agent in agents:"},{"line_number":46,"context_line":"            if agent.get(\u0027agent_type\u0027) in AZ_SUPPORTED_AGENTS:"},{"line_number":47,"context_line":"                self.assertEqual(agent.get(\u0027availability_zone\u0027),"},{"line_number":48,"context_line":"                    config.CONF.neutron_plugin_options.agent_availability_zone)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_500caf92","line":48,"range":{"start_line":47,"start_character":33,"end_line":48,"end_character":78},"updated":"2017-10-03 08:20:46.000000000","message":"expected, observed","commit_id":"2aff4a9210ad9015ee87092fb5528548c38a4716"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"039b59ac78e3df9c295b7ab8cc3da972c278354c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":45,"context_line":"        for agent in agents:"},{"line_number":46,"context_line":"            if agent.get(\u0027agent_type\u0027) in AZ_SUPPORTED_AGENTS:"},{"line_number":47,"context_line":"                self.assertEqual(agent.get(\u0027availability_zone\u0027),"},{"line_number":48,"context_line":"                    config.CONF.neutron_plugin_options.agent_availability_zone)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_cd57da26","line":48,"range":{"start_line":47,"start_character":33,"end_line":48,"end_character":78},"in_reply_to":"7f515b1d_500caf92","updated":"2017-10-03 19:33:04.000000000","message":"+1","commit_id":"2aff4a9210ad9015ee87092fb5528548c38a4716"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4539298d6f9ce9bba5911805e1040f0c6c3f3653","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":45,"context_line":"        for agent in agents:"},{"line_number":46,"context_line":"            if agent.get(\u0027agent_type\u0027) in AZ_SUPPORTED_AGENTS:"},{"line_number":47,"context_line":"                self.assertEqual(agent.get(\u0027availability_zone\u0027),"},{"line_number":48,"context_line":"                    config.CONF.neutron_plugin_options.agent_availability_zone)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_a439d0d7","line":48,"range":{"start_line":47,"start_character":33,"end_line":48,"end_character":78},"in_reply_to":"7f515b1d_500caf92","updated":"2017-10-09 02:15:03.000000000","message":"Done","commit_id":"2aff4a9210ad9015ee87092fb5528548c38a4716"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4539298d6f9ce9bba5911805e1040f0c6c3f3653","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        agents \u003d body[\u0027agents\u0027]"},{"line_number":45,"context_line":"        for agent in agents:"},{"line_number":46,"context_line":"            if agent.get(\u0027agent_type\u0027) in AZ_SUPPORTED_AGENTS:"},{"line_number":47,"context_line":"                self.assertEqual(agent.get(\u0027availability_zone\u0027),"},{"line_number":48,"context_line":"                    config.CONF.neutron_plugin_options.agent_availability_zone)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_843254f1","line":48,"range":{"start_line":47,"start_character":33,"end_line":48,"end_character":78},"in_reply_to":"7f515b1d_cd57da26","updated":"2017-10-09 02:15:03.000000000","message":"Done","commit_id":"2aff4a9210ad9015ee87092fb5528548c38a4716"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"703e7d13ebe5edb2f745f59c7791b63935e8b1a2","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class AgentAvailabilityZoneTestBase(base.BaseAdminNetworkTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    required_extensions \u003d [\u0027agent\u0027, \u0027availability_zone\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_ea1ea672","line":25,"updated":"2017-11-01 04:56:03.000000000","message":"i think you should check router_availability_zone and network_availability_zone as well, depending on the type of agents.","commit_id":"2b08800c9365d1874c42b2e19a25155f20e2518b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"07e0f5b02ed0b5c1da520558f30b7f35cb128976","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class AgentAvailabilityZoneTestBase(base.BaseAdminNetworkTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    required_extensions \u003d [\u0027agent\u0027, \u0027availability_zone\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_b3394640","line":25,"in_reply_to":"3f4b6375_1099306d","updated":"2017-11-01 06:04:05.000000000","message":"i was a bit confused when making this comment. never mind.","commit_id":"2b08800c9365d1874c42b2e19a25155f20e2518b"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"501def320dda85ca730ebb81faa0a8a7ab38f640","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class AgentAvailabilityZoneTestBase(base.BaseAdminNetworkTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    required_extensions \u003d [\u0027agent\u0027, \u0027availability_zone\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_1099306d","line":25,"in_reply_to":"3f4b6375_ea1ea672","updated":"2017-11-01 05:38:19.000000000","message":"I will add router_availability_zone and router_availability_zone tests in following patch. So I marked it as Partial-Bug.","commit_id":"2b08800c9365d1874c42b2e19a25155f20e2518b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"703e7d13ebe5edb2f745f59c7791b63935e8b1a2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        raise cls.skipException(msg)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @decorators.idempotent_id(\u00273ffa661e-cfcc-417d-8b63-1c5ec4a22e54\u0027)"},{"line_number":40,"context_line":"    def test_agents_availability_zone(self):"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        Test list agents availability_zone, only L3 and DHCP agent support"},{"line_number":43,"context_line":"        availability_zone, default availability_zone is \"nova\"."}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_302b0c83","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":37},"updated":"2017-11-01 04:56:03.000000000","message":"can you make this skip unless the assumption (single az) is true.  either via run-time detection or conf.","commit_id":"2b08800c9365d1874c42b2e19a25155f20e2518b"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"501def320dda85ca730ebb81faa0a8a7ab38f640","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        raise cls.skipException(msg)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @decorators.idempotent_id(\u00273ffa661e-cfcc-417d-8b63-1c5ec4a22e54\u0027)"},{"line_number":40,"context_line":"    def test_agents_availability_zone(self):"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        Test list agents availability_zone, only L3 and DHCP agent support"},{"line_number":43,"context_line":"        availability_zone, default availability_zone is \"nova\"."}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_73306ee9","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":37},"in_reply_to":"3f4b6375_302b0c83","updated":"2017-11-01 05:38:19.000000000","message":"Do you mean add a skipUnless decorator here?","commit_id":"2b08800c9365d1874c42b2e19a25155f20e2518b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"07e0f5b02ed0b5c1da520558f30b7f35cb128976","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        raise cls.skipException(msg)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @decorators.idempotent_id(\u00273ffa661e-cfcc-417d-8b63-1c5ec4a22e54\u0027)"},{"line_number":40,"context_line":"    def test_agents_availability_zone(self):"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        Test list agents availability_zone, only L3 and DHCP agent support"},{"line_number":43,"context_line":"        availability_zone, default availability_zone is \"nova\"."}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_5379f2f9","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":37},"in_reply_to":"3f4b6375_73306ee9","updated":"2017-11-01 06:04:05.000000000","message":"yes. but i guess a conf is more realistic.","commit_id":"2b08800c9365d1874c42b2e19a25155f20e2518b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"96703c90d3af8a8581179d0bc89fb74de8d8bbe1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class AgentAvailabilityZoneTestBase(base.BaseAdminNetworkTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    required_extensions \u003d [\u0027agent\u0027, \u0027availability_zone\u0027]"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_b290b5ee","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":35},"updated":"2017-11-06 07:07:36.000000000","message":"it seems confusing as it isn\u0027t used as a base class.","commit_id":"fa5121ab3c0796bc7f032a898cc2d85c812c36a8"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"285edf16cc253f45382045cd577d94940925da25","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class AgentAvailabilityZoneTestBase(base.BaseAdminNetworkTest):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    required_extensions \u003d [\u0027agent\u0027, \u0027availability_zone\u0027]"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_6d6262b0","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":35},"in_reply_to":"3f4b6375_b290b5ee","updated":"2017-11-06 07:37:07.000000000","message":"Done","commit_id":"fa5121ab3c0796bc7f032a898cc2d85c812c36a8"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"edd93ad6a18766831be5ca1355a12a44e9c4df17","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"import testtools"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from neutron_lib import constants"},{"line_number":15,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f485f77_3799ce6d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":16},"updated":"2017-11-14 07:38:23.000000000","message":"This library is third party library so it should be set below \"from tempest.lib....\".","commit_id":"e6f808f704ad4d85e4fbd04fb025aa7f0d90f175"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"d3974294ba9da41e77227150c6f97213e0a931bc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"import testtools"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from neutron_lib import constants"},{"line_number":15,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f485f77_32579c05","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":16},"in_reply_to":"1f485f77_3799ce6d","updated":"2017-11-14 07:59:09.000000000","message":"Done","commit_id":"e6f808f704ad4d85e4fbd04fb025aa7f0d90f175"}],"neutron/tests/tempest/config.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"74a50539cce6160abc37a7858432c19e3d3e9edb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027nova\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Agent availability zone of the node.\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_709a0b14","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":60},"updated":"2017-10-03 08:20:46.000000000","message":"this assumes that the deployment has only a single az?","commit_id":"2aff4a9210ad9015ee87092fb5528548c38a4716"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4539298d6f9ce9bba5911805e1040f0c6c3f3653","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027nova\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Agent availability zone of the node.\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_c46a8cb1","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":60},"in_reply_to":"7f515b1d_709a0b14","updated":"2017-10-09 02:15:03.000000000","message":"Yes, this assumes that the agent in a single az, this is for test.","commit_id":"2aff4a9210ad9015ee87092fb5528548c38a4716"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a77d53903b74449f50a6dfedf818f2a6c80d8723","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027nova\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Agent availability zone of the node.\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_569560e3","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":28},"updated":"2017-11-01 06:57:25.000000000","message":"i\u0027d suggest to make the default None and skip the test if it\u0027s None.","commit_id":"52c4fe5135a9f3059ec500b5ed2f5d75aef747c6"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"40a135ac24c9aaf083fec78228cca0daa812fba8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027nova\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Agent availability zone of the node.\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_59d2335e","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":28},"in_reply_to":"3f4b6375_569560e3","updated":"2017-11-01 07:16:08.000000000","message":"OK, how about make the default None and skip the test if it\u0027s not equal to \u0027nova\u0027, because L3 and DHCP agent default\navailability_zone is \u0027nova\u0027.","commit_id":"52c4fe5135a9f3059ec500b5ed2f5d75aef747c6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8994b305fade2b5a0b61b1a79a4e8e962a70d49e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027nova\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Agent availability zone of the node.\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_99fd4b3c","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":28},"in_reply_to":"3f4b6375_59d2335e","updated":"2017-11-01 07:36:14.000000000","message":"i don\u0027t see any benefit to restrict it to \"nova\". can you explain?\n\nactually you made neutron/tests/contrib/hooks/availability_zone set it to \"nova\", rather than using the default, right?","commit_id":"52c4fe5135a9f3059ec500b5ed2f5d75aef747c6"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"df713e388802742e925d0b32779cce8e76c41299","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027nova\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Agent availability zone of the node.\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_04e0d2f9","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":28},"in_reply_to":"3f4b6375_99fd4b3c","updated":"2017-11-01 07:56:12.000000000","message":"Done","commit_id":"52c4fe5135a9f3059ec500b5ed2f5d75aef747c6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bb13944a6565158b72094e1af334619c2eb2ad45","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027nova\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Agent availability zone of the node.\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_3666642b","line":39,"range":{"start_line":39,"start_character":21,"end_line":39,"end_character":57},"updated":"2017-11-01 07:00:19.000000000","message":"and add description accordingly.\neg. \"configure this only when the single value is used by all agents in the deployment.\"","commit_id":"52c4fe5135a9f3059ec500b5ed2f5d75aef747c6"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"40a135ac24c9aaf083fec78228cca0daa812fba8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027nova\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Agent availability zone of the node.\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_39d53744","line":39,"range":{"start_line":39,"start_character":21,"end_line":39,"end_character":57},"in_reply_to":"3f4b6375_3666642b","updated":"2017-11-01 07:16:08.000000000","message":"Done","commit_id":"52c4fe5135a9f3059ec500b5ed2f5d75aef747c6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"96703c90d3af8a8581179d0bc89fb74de8d8bbe1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Configure this only when the single value is used by \u0027"},{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_b2e2f59e","line":38,"range":{"start_line":38,"start_character":23,"end_line":38,"end_character":25},"updated":"2017-11-06 07:07:36.000000000","message":"i guess None is better.  ie. just remove the default argument","commit_id":"fa5121ab3c0796bc7f032a898cc2d85c812c36a8"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"285edf16cc253f45382045cd577d94940925da25","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d\u0027Image that supports features that cirros does not, like\u0027"},{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Configure this only when the single value is used by \u0027"},{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_0d5beef5","line":38,"range":{"start_line":38,"start_character":23,"end_line":38,"end_character":25},"in_reply_to":"3f4b6375_b2e2f59e","updated":"2017-11-06 07:37:07.000000000","message":"Done","commit_id":"fa5121ab3c0796bc7f032a898cc2d85c812c36a8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"96703c90d3af8a8581179d0bc89fb74de8d8bbe1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Configure this only when the single value is used by \u0027"},{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_72c91d24","line":40,"range":{"start_line":39,"start_character":20,"end_line":40,"end_character":51},"updated":"2017-11-06 07:07:36.000000000","message":"how about:\n\u0027The availability zone for all agents in the deployment.  Configure this only when ...\u0027","commit_id":"fa5121ab3c0796bc7f032a898cc2d85c812c36a8"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"285edf16cc253f45382045cd577d94940925da25","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                     \u0027 Ubuntu or CentOS supporting advanced features\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027agent_availability_zone\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027Configure this only when the single value is used by \u0027"},{"line_number":40,"context_line":"                    \u0027all agents in the deployment.\u0027),"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_ed753265","line":40,"range":{"start_line":39,"start_character":20,"end_line":40,"end_character":51},"in_reply_to":"3f4b6375_72c91d24","updated":"2017-11-06 07:37:07.000000000","message":"Done","commit_id":"fa5121ab3c0796bc7f032a898cc2d85c812c36a8"}]}