)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ece225cc883316858e91aaf10efdaa30e119dabe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"security group: pass update value to precommit_update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is follow up for [1]."},{"line_number":10,"context_line":"When updating security group, pass updated value to precommit,"},{"line_number":11,"context_line":"When deleting security group rule, don\u0027t update security_group_id"},{"line_number":12,"context_line":"unnecessarily."},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/448420/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_8af1cd04","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":48},"updated":"2017-06-20 07:29:02.000000000","message":"you don\u0027t need to access the old value?\n\ncan you consider to add/update test cases?","commit_id":"648c4dc2fdcb67c099f20aac1e072c97afe1eac9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"704facffb73ce8f9cdafdefa1e65e2628db8ce6f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"security group: pass update value to precommit_update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is follow up for [1]."},{"line_number":10,"context_line":"When updating security group, pass updated value to precommit,"},{"line_number":11,"context_line":"When deleting security group rule, don\u0027t update security_group_id"},{"line_number":12,"context_line":"unnecessarily."},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/448420/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f201791_18c2b386","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":48},"in_reply_to":"5f201791_69f79ff7","updated":"2017-06-21 04:13:54.000000000","message":"if you\u0027re going to pass both of old and new, i\u0027d suggest original_foo as ml2 does.","commit_id":"648c4dc2fdcb67c099f20aac1e072c97afe1eac9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"9e5fdae14ab43dfbd66eaf0889d21c2f9b0ee494","unresolved":false,"context_lines":[{"line_number":7,"context_line":"security group: pass update value to precommit_update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is follow up for [1]."},{"line_number":10,"context_line":"When updating security group, pass updated value to precommit,"},{"line_number":11,"context_line":"When deleting security group rule, don\u0027t update security_group_id"},{"line_number":12,"context_line":"unnecessarily."},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/448420/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f201791_69f79ff7","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":48},"in_reply_to":"7f231b9d_8af1cd04","updated":"2017-06-20 23:52:22.000000000","message":"Then in order to keep old behavior\nhow about passing old value keyed \u0027security_group\u0027 and new value keyed \u0027security_group_updated\u0027.\n\nalthough it will be unified with EventPayload eventually, we need to unbreak decomposed modules.","commit_id":"648c4dc2fdcb67c099f20aac1e072c97afe1eac9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"717ade2862495651d59420dded51b76eaf964d0a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is follow up for [1]."},{"line_number":10,"context_line":"When updating security group, pass updated value to precommit."},{"line_number":11,"context_line":"In order to keep argument compatibility, old value is passed as"},{"line_number":12,"context_line":"security_group and new value is passed as security_group_updated."},{"line_number":13,"context_line":"When deleting security group rule, don\u0027t update security_group_id"},{"line_number":14,"context_line":"unnecessarily."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f201791_38f8cfc2","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":39},"updated":"2017-06-21 04:25:21.000000000","message":"compatibility with what?\nthe original behaviour (before the OVO change in question) was to pass the requested updates as \"security_group\".\n\ni\u0027d suggest to pass the new one as \"security_group\" and the old one as \"original_security_group\", if you want to pass both of them.","commit_id":"00c7c8f9ddf0795351b7e6e9d02781cfa73e3051"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d2063b9cab98e1abe84ba57a5821492f536c2ed2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is follow up for [1]."},{"line_number":10,"context_line":"When updating security group, pass updated value to precommit."},{"line_number":11,"context_line":"In order to keep argument compatibility, old value is passed as"},{"line_number":12,"context_line":"security_group and new value is passed as security_group_updated."},{"line_number":13,"context_line":"When deleting security group rule, don\u0027t update security_group_id"},{"line_number":14,"context_line":"unnecessarily."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f201791_8ca9e4e0","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":39},"in_reply_to":"5f201791_38f8cfc2","updated":"2017-06-21 05:15:47.000000000","message":"Done","commit_id":"00c7c8f9ddf0795351b7e6e9d02781cfa73e3051"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"717ade2862495651d59420dded51b76eaf964d0a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"When updating security group, pass updated value to precommit."},{"line_number":11,"context_line":"In order to keep argument compatibility, old value is passed as"},{"line_number":12,"context_line":"security_group and new value is passed as security_group_updated."},{"line_number":13,"context_line":"When deleting security group rule, don\u0027t update security_group_id"},{"line_number":14,"context_line":"unnecessarily."},{"line_number":15,"context_line":"[1] https://review.openstack.org/#/c/448420/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Although argument to callbacks will be unified by EventPayload"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f201791_58e14bfe","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":14},"updated":"2017-06-21 04:25:21.000000000","message":"why is it unnecessary?\nthe original behavior was to pass security_group_id for AFTER_DELETE.","commit_id":"00c7c8f9ddf0795351b7e6e9d02781cfa73e3051"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d2063b9cab98e1abe84ba57a5821492f536c2ed2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"When updating security group, pass updated value to precommit."},{"line_number":11,"context_line":"In order to keep argument compatibility, old value is passed as"},{"line_number":12,"context_line":"security_group and new value is passed as security_group_updated."},{"line_number":13,"context_line":"When deleting security group rule, don\u0027t update security_group_id"},{"line_number":14,"context_line":"unnecessarily."},{"line_number":15,"context_line":"[1] https://review.openstack.org/#/c/448420/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Although argument to callbacks will be unified by EventPayload"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f201791_9835a3fa","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":14},"in_reply_to":"5f201791_58e14bfe","updated":"2017-06-21 05:15:47.000000000","message":"Done","commit_id":"00c7c8f9ddf0795351b7e6e9d02781cfa73e3051"}]}