)]}'
{"neutron/tests/unit/test_manager.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3e4bc93a7fb83905c641b4d5e9a94a6d8dae2e9c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron import manager"},{"line_number":24,"context_line":"from neutron.plugins.common import constants"},{"line_number":25,"context_line":"from neutron.tests import base"},{"line_number":26,"context_line":"from neutron.tests.unit import dummy_plugin"},{"line_number":27,"context_line":"from neutron.tests.unit import testlib_api"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_b8b468d2","line":24,"range":{"start_line":24,"start_character":35,"end_line":24,"end_character":44},"updated":"2017-06-26 04:23:29.000000000","message":"how about this?","commit_id":"a6ff82930d46ebf542a3d43e681cc5fd4d5da4bb"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5b23685f51c58b48fb1edc7b959bee98f4e1a9f9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron import manager"},{"line_number":24,"context_line":"from neutron.plugins.common import constants"},{"line_number":25,"context_line":"from neutron.tests import base"},{"line_number":26,"context_line":"from neutron.tests.unit import dummy_plugin"},{"line_number":27,"context_line":"from neutron.tests.unit import testlib_api"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_d3ac74a0","line":24,"range":{"start_line":24,"start_character":35,"end_line":24,"end_character":44},"in_reply_to":"5f201791_73900096","updated":"2017-06-27 12:31:48.000000000","message":"Sorry [2] above is incorrect. The proper link is: https://review.openstack.org/#/c/469495/","commit_id":"a6ff82930d46ebf542a3d43e681cc5fd4d5da4bb"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"63a5ca11353a3a35ae4645d9b0053ec88865c0df","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron import manager"},{"line_number":24,"context_line":"from neutron.plugins.common import constants"},{"line_number":25,"context_line":"from neutron.tests import base"},{"line_number":26,"context_line":"from neutron.tests.unit import dummy_plugin"},{"line_number":27,"context_line":"from neutron.tests.unit import testlib_api"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_73900096","line":24,"range":{"start_line":24,"start_character":35,"end_line":24,"end_character":44},"in_reply_to":"5f201791_b8b468d2","updated":"2017-06-27 12:26:18.000000000","message":"The intent of this patch is simply to address the CORE and L3 neutron_lib.constants that are stragglers as per [1]. For consumption of the other service type constants please see [2].\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L353\n[2] https://review.openstack.org/#/c/476980/","commit_id":"a6ff82930d46ebf542a3d43e681cc5fd4d5da4bb"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b21a614060d68e234f7591676b5ea8d8c770ffab","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron import manager"},{"line_number":24,"context_line":"from neutron.plugins.common import constants"},{"line_number":25,"context_line":"from neutron.tests import base"},{"line_number":26,"context_line":"from neutron.tests.unit import dummy_plugin"},{"line_number":27,"context_line":"from neutron.tests.unit import testlib_api"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_20b1ffe1","line":24,"range":{"start_line":24,"start_character":35,"end_line":24,"end_character":44},"in_reply_to":"5f201791_d3ac74a0","updated":"2017-06-27 17:23:58.000000000","message":"ok, i got it.","commit_id":"a6ff82930d46ebf542a3d43e681cc5fd4d5da4bb"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"05b7d63ac7bc212fe68f2eb268e74af7dc2005bb","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.assertEqual(3, len(svc_plugins))"},{"line_number":112,"context_line":"        self.assertIn(lib_const.CORE, svc_plugins.keys())"},{"line_number":113,"context_line":"        self.assertIn(constants.LOADBALANCER, svc_plugins.keys())"},{"line_number":114,"context_line":"        self.assertIn(constants.DUMMY, svc_plugins.keys())"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_load_default_service_plugins(self):"},{"line_number":117,"context_line":"        self.patched_default_svc_plugins.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_425e7a12","line":114,"range":{"start_line":114,"start_character":22,"end_line":114,"end_character":37},"updated":"2017-06-26 09:20:23.000000000","message":"Indeed https://github.com/openstack/neutron-lib/blob/master/neutron_lib/plugins/constants.py doesn\u0027t contain DUMMY, but it does contain LOADBALANCER. Is the rest of stuff from https://github.com/openstack/neutron/blob/master/neutron/plugins/common/constants.py going to be moved to neutron-lib? Should https://review.openstack.org/#/c/470369/ address plugin constants too?","commit_id":"a6ff82930d46ebf542a3d43e681cc5fd4d5da4bb"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"63a5ca11353a3a35ae4645d9b0053ec88865c0df","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.assertEqual(3, len(svc_plugins))"},{"line_number":112,"context_line":"        self.assertIn(lib_const.CORE, svc_plugins.keys())"},{"line_number":113,"context_line":"        self.assertIn(constants.LOADBALANCER, svc_plugins.keys())"},{"line_number":114,"context_line":"        self.assertIn(constants.DUMMY, svc_plugins.keys())"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_load_default_service_plugins(self):"},{"line_number":117,"context_line":"        self.patched_default_svc_plugins.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_33ecc828","line":114,"range":{"start_line":114,"start_character":22,"end_line":114,"end_character":37},"in_reply_to":"5f201791_425e7a12","updated":"2017-06-27 12:26:18.000000000","message":"Please see my comment/response above.","commit_id":"a6ff82930d46ebf542a3d43e681cc5fd4d5da4bb"}]}
