)]}'
{"neutron/tests/tempest/scenario/test_trunk.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a61b5f71bb8f072f32dd7825661c2b1b4542eb3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \u0027sudo su -c \u0027"},{"line_number":43,"context_line":"    \u0027\"ip l a link $IFACE name $IFACE.%(tag)d type vlan id %(tag)d \u0026\u0026\u0027"},{"line_number":44,"context_line":"    \u0027ip l s up dev $IFACE.%(tag)d \u0026\u0026 \u0027"},{"line_number":45,"context_line":"    \u0027ip l s up dev $IFACE.%(tag)d address %(SPMAC)s \u0026\u0026 \u0027"},{"line_number":46,"context_line":"    \u0027dhclient $IFACE.%(tag)d\"\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def get_next_subnet(cidr):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_736e9e00","line":45,"updated":"2017-07-06 17:35:04.000000000","message":"this is the only line that is different. can\u0027t we reuse the existing command string to construct the new command? just leave a space in the first template for an additional command, and pass \u0027\u0027 in first case, and \u0027ip l s up dev .... mac \u0026\u0026 \u0027 in the second case.","commit_id":"1dba652eba60f57d08d2691f14d252c348067be2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a61b5f71bb8f072f32dd7825661c2b1b4542eb3","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        self.check_remote_connectivity("},{"line_number":324,"context_line":"            servers[0][\u0027ssh_client\u0027],"},{"line_number":325,"context_line":"            servers[1][\u0027subport\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":326,"context_line":"            should_succeed\u003dTrue"},{"line_number":327,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_f38bcebc","line":326,"updated":"2017-07-06 17:35:04.000000000","message":"am I right to say that the only difference here is different command executed inside the instance, and same_macs in line 293? if so, please spin off the common code into a separate method that will behave depending on an argument passed into it, and just call it from two test cases.","commit_id":"1dba652eba60f57d08d2691f14d252c348067be2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"395f2c0c945efd566a3c90a41b5cc149e64f5e9c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        def is_port_detached():"},{"line_number":94,"context_line":"            p \u003d self.client.show_port(trunk[\u0027port_id\u0027])[\u0027port\u0027]"},{"line_number":95,"context_line":"            return p[\u0027device_id\u0027] \u003d\u003d \u0027\u0027"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        utils.wait_until_true(is_port_detached)"},{"line_number":98,"context_line":"        self.client.delete_trunk(trunk[\u0027id\u0027])"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_d4702cdf","line":96,"updated":"2017-07-14 23:29:28.000000000","message":"Gratuitous change not related to this patchset. Please remove","commit_id":"b0d6d336c8178214df53436e9d1c17e0c553b4ed"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"395f2c0c945efd566a3c90a41b5cc149e64f5e9c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            port_for_subport \u003d self.create_port("},{"line_number":123,"context_line":"                vlan_network,"},{"line_number":124,"context_line":"                security_groups\u003d[self.secgroup[\u0027security_group\u0027][\u0027id\u0027]])"},{"line_number":125,"context_line":"            self.spmac \u003d port_for_subport[\u0027mac_address\u0027]"},{"line_number":126,"context_line":"            self.sp_macs_list.append(self.spmac)"},{"line_number":127,"context_line":"        subport \u003d {"},{"line_number":128,"context_line":"            \u0027port_id\u0027: port_for_subport[\u0027id\u0027],"},{"line_number":129,"context_line":"            \u0027segmentation_type\u0027: \u0027vlan\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_b7ddb271","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":48},"updated":"2017-07-14 23:29:28.000000000","message":"I don\u0027t think you need this. Please see L146. You are returning port_for_subport in the dictionary that describes the created server. Therefore, you have will have access to port_for_subport[\u0027mac_address\u0027] in mac_based_if_config below. Please see my comments to that method","commit_id":"b0d6d336c8178214df53436e9d1c17e0c553b4ed"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"395f2c0c945efd566a3c90a41b5cc149e64f5e9c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":155,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def mac_based_if_config(self, same_macs\u003dTrue):"},{"line_number":158,"context_line":"        vlan_tag \u003d 10"},{"line_number":159,"context_line":"        used_mac \u003d None"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_3738829e","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":27},"updated":"2017-07-14 23:29:28.000000000","message":"This is a private method. So please call it _mac_based_if_config. Even better, how about calling it _create_test_configuration?","commit_id":"b0d6d336c8178214df53436e9d1c17e0c553b4ed"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"395f2c0c945efd566a3c90a41b5cc149e64f5e9c","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def mac_based_if_config(self, same_macs\u003dTrue):"},{"line_number":158,"context_line":"        vlan_tag \u003d 10"},{"line_number":159,"context_line":"        used_mac \u003d None"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        if same_macs is False:"},{"line_number":162,"context_line":"            self.sp_macs_list \u003d []"},{"line_number":163,"context_line":"            used_mac \u003d False"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        vlan_network \u003d self.create_network()"},{"line_number":166,"context_line":"        new_subnet_cidr \u003d get_next_subnet("}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_7755dac5","line":163,"range":{"start_line":159,"start_character":0,"end_line":163,"end_character":28},"updated":"2017-07-14 23:29:28.000000000","message":"I don\u0027t think you this. Please see my comment to L179-183","commit_id":"b0d6d336c8178214df53436e9d1c17e0c553b4ed"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"395f2c0c945efd566a3c90a41b5cc149e64f5e9c","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        for server in servers:"},{"line_number":176,"context_line":"            self._wait_for_server(server)"},{"line_number":177,"context_line":"            use_mac \u003d \u0027\u0027"},{"line_number":178,"context_line":"            # Configure VLAN interfaces on server"},{"line_number":179,"context_line":"            if used_mac is False:"},{"line_number":180,"context_line":"                use_mac \u003d self.sp_macs_list[0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_77f15acd","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":24},"updated":"2017-07-14 23:29:28.000000000","message":"You don\u0027t need this","commit_id":"b0d6d336c8178214df53436e9d1c17e0c553b4ed"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"395f2c0c945efd566a3c90a41b5cc149e64f5e9c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            self._wait_for_server(server)"},{"line_number":177,"context_line":"            use_mac \u003d \u0027\u0027"},{"line_number":178,"context_line":"            # Configure VLAN interfaces on server"},{"line_number":179,"context_line":"            if used_mac is False:"},{"line_number":180,"context_line":"                use_mac \u003d self.sp_macs_list[0]"},{"line_number":181,"context_line":"                used_mac \u003d True"},{"line_number":182,"context_line":"            elif used_mac is True:"},{"line_number":183,"context_line":"                use_mac \u003d self.sp_macs_list[1]"},{"line_number":184,"context_line":"            command \u003d self.command_build(same_macs, vlan_tag, use_mac)"},{"line_number":185,"context_line":"            server[\u0027ssh_client\u0027].exec_command(command)"},{"line_number":186,"context_line":"            out \u003d server[\u0027ssh_client\u0027].exec_command("},{"line_number":187,"context_line":"                \u0027PATH\u003d$PATH:/usr/sbin;ip addr list\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_97ccf661","line":184,"range":{"start_line":179,"start_character":0,"end_line":184,"end_character":70},"updated":"2017-07-14 23:29:28.000000000","message":"You can replace these lines with:\n\nif same_macs:\n    command \u003d self._build_command(same_macs, vlan_tag)\nelse:\n    command \u003d self._build_command(same_macs, vlan_tag, server[\u0027subport\u0027][\u0027mac_address\u0027])","commit_id":"b0d6d336c8178214df53436e9d1c17e0c553b4ed"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"395f2c0c945efd566a3c90a41b5cc149e64f5e9c","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            LOG.debug(\"Interfaces on server %s: %s\", server, out)"},{"line_number":189,"context_line":"        return servers"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def command_build(self, same_macs\u003dTrue, vlan_tag\u003d10, use_mac\u003d\u0027\u0027):"},{"line_number":192,"context_line":"        if same_macs is True:"},{"line_number":193,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":194,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_97f51686","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":69},"updated":"2017-07-14 23:29:28.000000000","message":"Given that this method is private and you don\u0027t need to provide default values for same_macs and vlan_tag, you can replace this line with:\n\ndef _build_command(self, same_macs, vlan_tag, use_mac\u003dNone):","commit_id":"b0d6d336c8178214df53436e9d1c17e0c553b4ed"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"395f2c0c945efd566a3c90a41b5cc149e64f5e9c","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        return servers"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def command_build(self, same_macs\u003dTrue, vlan_tag\u003d10, use_mac\u003d\u0027\u0027):"},{"line_number":192,"context_line":"        if same_macs is True:"},{"line_number":193,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":194,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"},{"line_number":195,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_5773fe4d","line":192,"range":{"start_line":192,"start_character":8,"end_line":192,"end_character":29},"updated":"2017-07-14 23:29:28.000000000","message":"if same_macs:","commit_id":"b0d6d336c8178214df53436e9d1c17e0c553b4ed"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"395f2c0c945efd566a3c90a41b5cc149e64f5e9c","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                          vlan_tag) + \u0027 address \u0027 + use_mac + \u0027 \u0026\u0026 \u0027}"},{"line_number":199,"context_line":"        return command"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def connectivity_check(self, servers):"},{"line_number":202,"context_line":"        # Ping from server1 to server2 via VLAN interface should fail because"},{"line_number":203,"context_line":"        # we haven\u0027t allowed ICMP"},{"line_number":204,"context_line":"        self.check_remote_connectivity("}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_77771a04","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":26},"updated":"2017-07-14 23:29:28.000000000","message":"Please name this _check_connectivity","commit_id":"b0d6d336c8178214df53436e9d1c17e0c553b4ed"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d7685bddb393fc38c68470d0c819a2eeb9143c9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                             same_macs\u003dTrue):"},{"line_number":113,"context_line":"        parent_port \u003d self.create_port(self.network, security_groups\u003d["},{"line_number":114,"context_line":"            self.secgroup[\u0027security_group\u0027][\u0027id\u0027]])"},{"line_number":115,"context_line":"        if same_macs is True:"},{"line_number":116,"context_line":"            port_for_subport \u003d self.create_port("},{"line_number":117,"context_line":"                vlan_network,"},{"line_number":118,"context_line":"                security_groups\u003d[self.secgroup[\u0027security_group\u0027][\u0027id\u0027]],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_58761d72","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":29},"updated":"2017-07-19 11:03:11.000000000","message":"if same_macs","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":18746,"name":"Alex Stafeyev","email":"alexo101087@gmail.com","username":"AlexSTafeyev"},"change_message_id":"9bbd0198264f7e0822e1367836f4278ac0a8468f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                             same_macs\u003dTrue):"},{"line_number":113,"context_line":"        parent_port \u003d self.create_port(self.network, security_groups\u003d["},{"line_number":114,"context_line":"            self.secgroup[\u0027security_group\u0027][\u0027id\u0027]])"},{"line_number":115,"context_line":"        if same_macs is True:"},{"line_number":116,"context_line":"            port_for_subport \u003d self.create_port("},{"line_number":117,"context_line":"                vlan_network,"},{"line_number":118,"context_line":"                security_groups\u003d[self.secgroup[\u0027security_group\u0027][\u0027id\u0027]],"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_8fcbff1c","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":29},"in_reply_to":"1f1a1f67_58761d72","updated":"2017-09-24 07:52:33.000000000","message":"Done","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d7685bddb393fc38c68470d0c819a2eeb9143c9","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":152,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _create_test_configuration(self, same_macs\u003dTrue):"},{"line_number":155,"context_line":"        vlan_tag \u003d 10"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        vlan_network \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_d8beadd3","line":154,"range":{"start_line":154,"start_character":41,"end_line":154,"end_character":55},"updated":"2017-07-19 11:03:11.000000000","message":"This is always passed, no need for default argument.","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":18746,"name":"Alex Stafeyev","email":"alexo101087@gmail.com","username":"AlexSTafeyev"},"change_message_id":"9bbd0198264f7e0822e1367836f4278ac0a8468f","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":152,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _create_test_configuration(self, same_macs\u003dTrue):"},{"line_number":155,"context_line":"        vlan_tag \u003d 10"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        vlan_network \u003d self.create_network()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_f8192288","line":154,"range":{"start_line":154,"start_character":41,"end_line":154,"end_character":55},"in_reply_to":"1f1a1f67_d8beadd3","updated":"2017-09-24 07:52:33.000000000","message":"Done","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d7685bddb393fc38c68470d0c819a2eeb9143c9","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                                      same_macs)"},{"line_number":165,"context_line":"            for i in range(2)]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        for server in servers:"},{"line_number":168,"context_line":"            self._wait_for_server(server)"},{"line_number":169,"context_line":"            if same_macs:"},{"line_number":170,"context_line":"                command \u003d self._build_command(same_macs, vlan_tag)"},{"line_number":171,"context_line":"            else:"},{"line_number":172,"context_line":"                command \u003d self._build_command(same_macs, vlan_tag, server["},{"line_number":173,"context_line":"                    \u0027subport\u0027][\u0027mac_address\u0027])"},{"line_number":174,"context_line":"            server[\u0027ssh_client\u0027].exec_command(command)"},{"line_number":175,"context_line":"            out \u003d server[\u0027ssh_client\u0027].exec_command("},{"line_number":176,"context_line":"                \u0027PATH\u003d$PATH:/usr/sbin;ip addr list\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_780f9987","line":173,"range":{"start_line":167,"start_character":0,"end_line":173,"end_character":46},"updated":"2017-07-19 11:03:11.000000000","message":"vm_mac_addr \u003d server[\u0027subport\u0027][\u0027mac_address\u0027] if same_macs else None\n for server in servers:\n     self._wait_for_server(server)\n     command \u003d _get_configure_nic_command(vlan_tag, vm_mac_addr)\n\nno need to check for same_macs twice :)","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":18746,"name":"Alex Stafeyev","email":"alexo101087@gmail.com","username":"AlexSTafeyev"},"change_message_id":"9bbd0198264f7e0822e1367836f4278ac0a8468f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                                      same_macs)"},{"line_number":165,"context_line":"            for i in range(2)]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        for server in servers:"},{"line_number":168,"context_line":"            self._wait_for_server(server)"},{"line_number":169,"context_line":"            if same_macs:"},{"line_number":170,"context_line":"                command \u003d self._build_command(same_macs, vlan_tag)"},{"line_number":171,"context_line":"            else:"},{"line_number":172,"context_line":"                command \u003d self._build_command(same_macs, vlan_tag, server["},{"line_number":173,"context_line":"                    \u0027subport\u0027][\u0027mac_address\u0027])"},{"line_number":174,"context_line":"            server[\u0027ssh_client\u0027].exec_command(command)"},{"line_number":175,"context_line":"            out \u003d server[\u0027ssh_client\u0027].exec_command("},{"line_number":176,"context_line":"                \u0027PATH\u003d$PATH:/usr/sbin;ip addr list\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_afc6c315","line":173,"range":{"start_line":167,"start_character":0,"end_line":173,"end_character":46},"in_reply_to":"1f1a1f67_780f9987","updated":"2017-09-24 07:52:33.000000000","message":"for server in servers:\n    vm_mac_addr \u003d server[\u0027subport\u0027][\u0027mac_address\u0027] if \n    not same_macs else None\n    self._wait_for_server(server)\n    command \u003d _get_configure_nic_command(vlan_tag, \n    vm_mac_addr)","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d7685bddb393fc38c68470d0c819a2eeb9143c9","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            LOG.debug(\"Interfaces on server %s: %s\", server, out)"},{"line_number":178,"context_line":"        return servers"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _build_command(self, same_macs, vlan_tag, use_mac\u003dNone):"},{"line_number":181,"context_line":"        if same_macs:"},{"line_number":182,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":183,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_189d4565","line":180,"range":{"start_line":180,"start_character":0,"end_line":180,"end_character":22},"updated":"2017-07-19 11:03:11.000000000","message":"Consider moving this method to a function on module level. Also consider better name like _get_configure_nic_command()","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d7685bddb393fc38c68470d0c819a2eeb9143c9","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            LOG.debug(\"Interfaces on server %s: %s\", server, out)"},{"line_number":178,"context_line":"        return servers"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _build_command(self, same_macs, vlan_tag, use_mac\u003dNone):"},{"line_number":181,"context_line":"        if same_macs:"},{"line_number":182,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":183,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_b80bf18b","line":180,"range":{"start_line":180,"start_character":29,"end_line":180,"end_character":62},"updated":"2017-07-19 11:03:11.000000000","message":"same_macs and use_mac seems redundant, consider just passing mac parameter.\n\n if mac:\n     \u003ccommand using mac parameter\u003e\n else:\n     \u003ccommand without setting a mac\u003e","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":18746,"name":"Alex Stafeyev","email":"alexo101087@gmail.com","username":"AlexSTafeyev"},"change_message_id":"9bbd0198264f7e0822e1367836f4278ac0a8468f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            LOG.debug(\"Interfaces on server %s: %s\", server, out)"},{"line_number":178,"context_line":"        return servers"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _build_command(self, same_macs, vlan_tag, use_mac\u003dNone):"},{"line_number":181,"context_line":"        if same_macs:"},{"line_number":182,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":183,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_6fd0dbca","line":180,"range":{"start_line":180,"start_character":0,"end_line":180,"end_character":22},"in_reply_to":"1f1a1f67_189d4565","updated":"2017-09-24 07:52:33.000000000","message":"For now changed the name","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d7685bddb393fc38c68470d0c819a2eeb9143c9","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _build_command(self, same_macs, vlan_tag, use_mac\u003dNone):"},{"line_number":181,"context_line":"        if same_macs:"},{"line_number":182,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":183,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":186,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027ip l s up dev $IFACE.\u0027 + str("}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_b8941138","line":183,"range":{"start_line":182,"start_character":0,"end_line":183,"end_character":52},"updated":"2017-07-19 11:03:11.000000000","message":"command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS \u0026 {\n    \u0027tag\u0027: ... }\n\nno need for \\","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":18746,"name":"Alex Stafeyev","email":"alexo101087@gmail.com","username":"AlexSTafeyev"},"change_message_id":"9bbd0198264f7e0822e1367836f4278ac0a8468f","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _build_command(self, same_macs, vlan_tag, use_mac\u003dNone):"},{"line_number":181,"context_line":"        if same_macs:"},{"line_number":182,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":183,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":186,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027ip l s up dev $IFACE.\u0027 + str("}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_8f509f34","line":183,"range":{"start_line":182,"start_character":0,"end_line":183,"end_character":52},"in_reply_to":"1f1a1f67_b8941138","updated":"2017-09-24 07:52:33.000000000","message":"File \"/home/centos/tempest-upstream/neutron/neutron/tests/tempest/scenario/test_trunk.py\", line 188, in _get_configure_nic_command\n    \u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}\nTypeError: unsupported operand type(s) for \u0026: \u0027str\u0027 and \u0027dict\u0027","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d7685bddb393fc38c68470d0c819a2eeb9143c9","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":183,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":186,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027ip l s up dev $IFACE.\u0027 + str("},{"line_number":187,"context_line":"                          vlan_tag) + \u0027 address \u0027 + use_mac + \u0027 \u0026\u0026 \u0027}"},{"line_number":188,"context_line":"        return command"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_9897153b","line":185,"updated":"2017-07-19 11:03:11.000000000","message":"ditto","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":18746,"name":"Alex Stafeyev","email":"alexo101087@gmail.com","username":"AlexSTafeyev"},"change_message_id":"9bbd0198264f7e0822e1367836f4278ac0a8468f","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":183,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":186,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027ip l s up dev $IFACE.\u0027 + str("},{"line_number":187,"context_line":"                          vlan_tag) + \u0027 address \u0027 + use_mac + \u0027 \u0026\u0026 \u0027}"},{"line_number":188,"context_line":"        return command"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_2bc99277","line":185,"in_reply_to":"1f1a1f67_9897153b","updated":"2017-09-24 07:52:33.000000000","message":"Done","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d7685bddb393fc38c68470d0c819a2eeb9143c9","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":186,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027ip l s up dev $IFACE.\u0027 + str("},{"line_number":187,"context_line":"                          vlan_tag) + \u0027 address \u0027 + use_mac + \u0027 \u0026\u0026 \u0027}"},{"line_number":188,"context_line":"        return command"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _check_connectivity(self, servers):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_f8be09ac","line":187,"range":{"start_line":186,"start_character":49,"end_line":187,"end_character":68},"updated":"2017-07-19 11:03:11.000000000","message":"SPMAC: \u0027ip l s up dev $IFACE %(tag)s address %(mac)s \u0026\u0026 \u0027 % {\u0027tag\u0027: vlan_tag, \u0027mac\u0027: use_mac\u0027}","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":18746,"name":"Alex Stafeyev","email":"alexo101087@gmail.com","username":"AlexSTafeyev"},"change_message_id":"9bbd0198264f7e0822e1367836f4278ac0a8468f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027\u0027}"},{"line_number":184,"context_line":"        else:"},{"line_number":185,"context_line":"            command \u003d CONFIGURE_VLAN_INTERFACE_COMMANDS % \\"},{"line_number":186,"context_line":"                      {\u0027tag\u0027: vlan_tag, \u0027SPMAC\u0027: \u0027ip l s up dev $IFACE.\u0027 + str("},{"line_number":187,"context_line":"                          vlan_tag) + \u0027 address \u0027 + use_mac + \u0027 \u0026\u0026 \u0027}"},{"line_number":188,"context_line":"        return command"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _check_connectivity(self, servers):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_4bccd688","line":187,"range":{"start_line":186,"start_character":49,"end_line":187,"end_character":68},"in_reply_to":"1f1a1f67_f8be09ac","updated":"2017-09-24 07:52:33.000000000","message":"Done","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d7685bddb393fc38c68470d0c819a2eeb9143c9","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        self._check_connectivity(servers\u003dservers)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-80a2-cce7da67aafc\u0027)"},{"line_number":292,"context_line":"    def test_subport_connectivity_different_macs(self):"},{"line_number":293,"context_line":"        servers \u003d self._create_test_configuration(same_macs\u003dFalse)"},{"line_number":294,"context_line":"        self._check_connectivity(servers\u003dservers)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_7829d934","line":292,"range":{"start_line":292,"start_character":8,"end_line":292,"end_character":48},"updated":"2017-07-19 11:03:11.000000000","message":"Nit: I\u0027d do it vice-versa as different macs is default:\n\n test_subport_connectivity_same_macs(self):\n    ...\n\n test_subport_connectivity(self):\n    ...","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"},{"author":{"_account_id":18746,"name":"Alex Stafeyev","email":"alexo101087@gmail.com","username":"AlexSTafeyev"},"change_message_id":"9bbd0198264f7e0822e1367836f4278ac0a8468f","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        self._check_connectivity(servers\u003dservers)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    @decorators.idempotent_id(\u0027a8a02c9b-b453-49b5-80a2-cce7da67aafc\u0027)"},{"line_number":292,"context_line":"    def test_subport_connectivity_different_macs(self):"},{"line_number":293,"context_line":"        servers \u003d self._create_test_configuration(same_macs\u003dFalse)"},{"line_number":294,"context_line":"        self._check_connectivity(servers\u003dservers)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_4fbcf768","line":292,"range":{"start_line":292,"start_character":8,"end_line":292,"end_character":48},"in_reply_to":"1f1a1f67_7829d934","updated":"2017-09-24 07:52:33.000000000","message":"Done","commit_id":"5cd294a9480f4304a51f763e21653a0edd2f714b"}]}
