)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"98dd1f32e7654fc84a5a799895b716bb98043a9d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[log] [doc] Include logging for security groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the initial logging for security groups documentation"},{"line_number":10,"context_line":"to the admin guide"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibc8d0004ec42c1491fdc2ef556d7c5ca0b4b4f63"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f1a1f67_b6e5263b","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":18},"updated":"2017-07-12 08:26:20.000000000","message":"Networking guide?","commit_id":"e202d98ea752754c87626b1d4665fa7691095171"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"92ca0f28baa7c0cff618acb370beac2ea38ef695","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[log] [doc] Include logging for security groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the initial logging for security groups documentation"},{"line_number":10,"context_line":"to the admin guide"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibc8d0004ec42c1491fdc2ef556d7c5ca0b4b4f63"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f1a1f67_7630ae08","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":18},"in_reply_to":"1f1a1f67_76942ee9","updated":"2017-07-12 08:46:54.000000000","message":"Done","commit_id":"e202d98ea752754c87626b1d4665fa7691095171"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"49d07ec242915bd60d1e61652e3130740a12c863","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[log] [doc] Include logging for security groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the initial logging for security groups documentation"},{"line_number":10,"context_line":"to the admin guide"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibc8d0004ec42c1491fdc2ef556d7c5ca0b4b4f63"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f1a1f67_d6c78245","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":18},"in_reply_to":"1f1a1f67_b6e5263b","updated":"2017-07-12 08:35:07.000000000","message":"I see it build to admin guide [1]\n\n[1] http://docs-draft.openstack.org/17/480117/5/check/gate-neutron-docs-ubuntu-xenial/709c1df//doc/build/html/admin/config-logging.html","commit_id":"e202d98ea752754c87626b1d4665fa7691095171"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d390cd4008c5869c3815c5a2dbdc446af07f3c47","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[log] [doc] Include logging for security groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the initial logging for security groups documentation"},{"line_number":10,"context_line":"to the admin guide"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibc8d0004ec42c1491fdc2ef556d7c5ca0b4b4f63"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f1a1f67_76942ee9","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":18},"in_reply_to":"1f1a1f67_d6c78245","updated":"2017-07-12 08:42:46.000000000","message":"Sorry for confusing.  What I\u0027d like to say is if you add description into Networking-guide, how about changing as follows?\ne.g.\n\n Add a new section for Networking guide for \u0027logging for security groups\u0027 into admin guide","commit_id":"e202d98ea752754c87626b1d4665fa7691095171"}],"doc/source/admin/config-logging-api.rst":[{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"1af4c778430664bbb442cf4ede929560f753cac7","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. note::"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"   As of the Mitaka release, the ``security_group`` option is supported."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_cb0bc721","line":27,"range":{"start_line":27,"start_character":13,"end_line":27,"end_character":19},"updated":"2017-07-05 03:55:26.000000000","message":"nit: Pike :)","commit_id":"f475e6caa9d6c7f18621794d98a7d5453928ef01"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"758caba9b953ca31089e652e358af06f5c74fe2d","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. note::"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"   As of the Mitaka release, the ``security_group`` option is supported."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_eb7b2378","line":27,"range":{"start_line":27,"start_character":13,"end_line":27,"end_character":19},"in_reply_to":"3f1d235d_cb0bc721","updated":"2017-07-05 04:50:35.000000000","message":"Done","commit_id":"f475e6caa9d6c7f18621794d98a7d5453928ef01"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"1af4c778430664bbb442cf4ede929560f753cac7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"         enable \u003d True"},{"line_number":72,"context_line":"         rate_limit \u003d 100"},{"line_number":73,"context_line":"         rate_burst \u003d 25"},{"line_number":74,"context_line":"         #local_output_log_base \u003d \u003cNone\u003e"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":".. note::"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_cb24e7b1","line":74,"range":{"start_line":74,"start_character":9,"end_line":74,"end_character":40},"updated":"2017-07-05 03:55:26.000000000","message":"It should be clearer. If we don\u0027t specify local_output_log_base, log_data will stored at syslog, ...","commit_id":"f475e6caa9d6c7f18621794d98a7d5453928ef01"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"758caba9b953ca31089e652e358af06f5c74fe2d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"         enable \u003d True"},{"line_number":72,"context_line":"         rate_limit \u003d 100"},{"line_number":73,"context_line":"         rate_burst \u003d 25"},{"line_number":74,"context_line":"         #local_output_log_base \u003d \u003cNone\u003e"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":".. note::"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_2beb5b13","line":74,"range":{"start_line":74,"start_character":9,"end_line":74,"end_character":40},"in_reply_to":"3f1d235d_cb24e7b1","updated":"2017-07-05 04:50:35.000000000","message":"Yes. I explained about this point at L143-L145. But it is also better to explained here.","commit_id":"f475e6caa9d6c7f18621794d98a7d5453928ef01"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"758caba9b953ca31089e652e358af06f5c74fe2d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"      +-----------------+------------------------------------------------+"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"   If the ``enabled`` field is specified, the logging is enabled and"},{"line_number":144,"context_line":"   log information is written to the destionation if configured in"},{"line_number":145,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_abde4b6a","line":144,"range":{"start_line":144,"start_character":37,"end_line":144,"end_character":49},"updated":"2017-07-05 04:50:35.000000000","message":"nit: I will update later","commit_id":"f475e6caa9d6c7f18621794d98a7d5453928ef01"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"1af4c778430664bbb442cf4ede929560f753cac7","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Rule modification"},{"line_number":157,"context_line":"-----------------"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"You can modify logging rules at runtime. Rule modifications will be propagated"},{"line_number":160,"context_line":"to any attached port."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"For example:"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_0b7d3f7e","line":160,"range":{"start_line":159,"start_character":0,"end_line":160,"end_character":21},"updated":"2017-07-05 03:55:26.000000000","message":"Sorry, I couldn\u0027t get your point here. Could you please make it more clearly?","commit_id":"f475e6caa9d6c7f18621794d98a7d5453928ef01"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"758caba9b953ca31089e652e358af06f5c74fe2d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Rule modification"},{"line_number":157,"context_line":"-----------------"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"You can modify logging rules at runtime. Rule modifications will be propagated"},{"line_number":160,"context_line":"to any attached port."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"For example:"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_abc76b96","line":160,"range":{"start_line":159,"start_character":0,"end_line":160,"end_character":21},"in_reply_to":"3f1d235d_0b7d3f7e","updated":"2017-07-05 04:50:35.000000000","message":"I mean, when the rule is updated. It will be able to apply to all current attached ports with the logging rule immediately. Am I Right?","commit_id":"f475e6caa9d6c7f18621794d98a7d5453928ef01"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"095ea745df0c2a58fdd54e4a39587ad62946d748","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Rule modification"},{"line_number":157,"context_line":"-----------------"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"You can modify logging rules at runtime. Rule modifications will be propagated"},{"line_number":160,"context_line":"to any attached port."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"For example:"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_f372f5ac","line":160,"range":{"start_line":159,"start_character":0,"end_line":160,"end_character":21},"in_reply_to":"3f1d235d_abc76b96","updated":"2017-07-05 06:31:44.000000000","message":"I think it\u0027s better use \"logging object\" instead of \"logging rule\" to avoid confusing. Please note that, we only update \"name\", \"description\", and \"enabled\", So I think session should be enable/disable log. What do you think?","commit_id":"f475e6caa9d6c7f18621794d98a7d5453928ef01"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"e0e1f2cc0d62af85e369ae3eb14b7fe7f9684586","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Rule modification"},{"line_number":157,"context_line":"-----------------"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"You can modify logging rules at runtime. Rule modifications will be propagated"},{"line_number":160,"context_line":"to any attached port."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"For example:"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f1d235d_fc85cbad","line":160,"range":{"start_line":159,"start_character":0,"end_line":160,"end_character":21},"in_reply_to":"3f1d235d_f372f5ac","updated":"2017-07-07 06:44:57.000000000","message":"Done","commit_id":"f475e6caa9d6c7f18621794d98a7d5453928ef01"}],"doc/source/admin/config-logging.rst":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d0a99bc20325b9f954888c70b71cda7d3db319c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Logging for security groups"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The Logging is designed as a service plug-in that captures events for"},{"line_number":8,"context_line":"relevant resources (for example, security groups or firewalls) when they occur."},{"line_number":9,"context_line":"It is implemented as an agent extension."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f1d235d_45d4cdbd","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":12},"updated":"2017-07-07 19:55:37.000000000","message":"insert \"API\" or remove the word \"The\"","commit_id":"3988f91661f32805db9d7d9e6200e9073d5d8007"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"41dca5701a45182b1af181c0650b6e90fa648b6c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Logging for security groups"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The Logging is designed as a service plug-in that captures events for"},{"line_number":8,"context_line":"relevant resources (for example, security groups or firewalls) when they occur."},{"line_number":9,"context_line":"It is implemented as an agent extension."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f1d235d_12d60051","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":12},"in_reply_to":"3f1d235d_45d4cdbd","updated":"2017-07-10 09:42:24.000000000","message":"I will remove \"The\"","commit_id":"3988f91661f32805db9d7d9e6200e9073d5d8007"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"d0a99bc20325b9f954888c70b71cda7d3db319c5","unresolved":false,"context_lines":[{"line_number":138,"context_line":"      | Type            | security_group                                 |"},{"line_number":139,"context_line":"      | created_at      | 2017-07-05T02:56:43Z                           |"},{"line_number":140,"context_line":"      | revision_number | 0                                              |"},{"line_number":141,"context_line":"      | tenant_id       | 02568bd62b414221956f15dbe9527d16               |"},{"line_number":142,"context_line":"      | updated_at      | 2017-07-05T02:56:43Z                           |"},{"line_number":143,"context_line":"      +-----------------+------------------------------------------------+"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f1d235d_65122965","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":17},"updated":"2017-07-07 19:55:37.000000000","message":"Is this tenant_id or project_id?","commit_id":"3988f91661f32805db9d7d9e6200e9073d5d8007"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"41dca5701a45182b1af181c0650b6e90fa648b6c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"      | Type            | security_group                                 |"},{"line_number":139,"context_line":"      | created_at      | 2017-07-05T02:56:43Z                           |"},{"line_number":140,"context_line":"      | revision_number | 0                                              |"},{"line_number":141,"context_line":"      | tenant_id       | 02568bd62b414221956f15dbe9527d16               |"},{"line_number":142,"context_line":"      | updated_at      | 2017-07-05T02:56:43Z                           |"},{"line_number":143,"context_line":"      +-----------------+------------------------------------------------+"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f1d235d_f2ca649f","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":17},"in_reply_to":"3f1d235d_65122965","updated":"2017-07-10 09:42:24.000000000","message":"I think this should be \"project_id\". I will check with server side and update this later","commit_id":"3988f91661f32805db9d7d9e6200e9073d5d8007"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"a95babf96fcd3be3c270ee21f735892e938a4377","unresolved":false,"context_lines":[{"line_number":138,"context_line":"      | Type            | security_group                                 |"},{"line_number":139,"context_line":"      | created_at      | 2017-07-05T02:56:43Z                           |"},{"line_number":140,"context_line":"      | revision_number | 0                                              |"},{"line_number":141,"context_line":"      | tenant_id       | 02568bd62b414221956f15dbe9527d16               |"},{"line_number":142,"context_line":"      | updated_at      | 2017-07-05T02:56:43Z                           |"},{"line_number":143,"context_line":"      +-----------------+------------------------------------------------+"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f1d235d_526e9196","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":17},"in_reply_to":"3f1d235d_f2ca649f","updated":"2017-07-11 07:03:44.000000000","message":"I have just double checked. project_id is specified in L135. And we keep tenant_id info the same also. So, There is no problem with it at the moment.","commit_id":"3988f91661f32805db9d7d9e6200e9073d5d8007"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3d08c2a5276d38721619978b0db0c614aee2b0ba","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Logging is designed as a service plug-in that captures events for"},{"line_number":8,"context_line":"relevant resources (for example, security groups or firewalls) when they occur."},{"line_number":9,"context_line":"It is implemented as an agent extension."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Details about the DB models, API extension, and use cases are out of the scope"},{"line_number":12,"context_line":"of this guide but can be found in the specification."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_9a97cd91","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":40},"updated":"2017-07-13 01:19:08.000000000","message":"I think it\u0027s not need in a document guide. Do you think so?","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"78d4e4f1510e664d02e3f7615e0ca12e44694828","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Logging is designed as a service plug-in that captures events for"},{"line_number":8,"context_line":"relevant resources (for example, security groups or firewalls) when they occur."},{"line_number":9,"context_line":"It is implemented as an agent extension."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Details about the DB models, API extension, and use cases are out of the scope"},{"line_number":12,"context_line":"of this guide but can be found in the specification."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_fdd6bb4f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":40},"in_reply_to":"1f1a1f67_7a8511ad","updated":"2017-07-13 01:51:37.000000000","message":"IMO, It should be remove. Because it\u0027s not relate to the introduction of API. You can move it to line 11 if you want.","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b3aa5a4f4b64e43cc323a829add1facee1b92ec8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Logging is designed as a service plug-in that captures events for"},{"line_number":8,"context_line":"relevant resources (for example, security groups or firewalls) when they occur."},{"line_number":9,"context_line":"It is implemented as an agent extension."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Details about the DB models, API extension, and use cases are out of the scope"},{"line_number":12,"context_line":"of this guide but can be found in the specification."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_7a8511ad","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":40},"in_reply_to":"1f1a1f67_9a97cd91","updated":"2017-07-13 01:40:07.000000000","message":"This section just something related to introduction. So I think there no problem.","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3d08c2a5276d38721619978b0db0c614aee2b0ba","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Supported logging resource types"},{"line_number":18,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Any plug-in or ML2 mechanism driver can claim support for logging types"},{"line_number":21,"context_line":"by providing a plug-in or driver class property called"},{"line_number":22,"context_line":"``supported_logging_types`` that returns a list of strings that correspond"},{"line_number":23,"context_line":"to logging resource types."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_1ae97d19","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":14},"updated":"2017-07-13 01:19:08.000000000","message":"please remove it.","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b3aa5a4f4b64e43cc323a829add1facee1b92ec8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Supported logging resource types"},{"line_number":18,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Any plug-in or ML2 mechanism driver can claim support for logging types"},{"line_number":21,"context_line":"by providing a plug-in or driver class property called"},{"line_number":22,"context_line":"``supported_logging_types`` that returns a list of strings that correspond"},{"line_number":23,"context_line":"to logging resource types."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_dab78586","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":14},"in_reply_to":"1f1a1f67_1ae97d19","updated":"2017-07-13 01:40:07.000000000","message":"Consider it done :-)","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3d08c2a5276d38721619978b0db0c614aee2b0ba","unresolved":false,"context_lines":[{"line_number":18,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Any plug-in or ML2 mechanism driver can claim support for logging types"},{"line_number":21,"context_line":"by providing a plug-in or driver class property called"},{"line_number":22,"context_line":"``supported_logging_types`` that returns a list of strings that correspond"},{"line_number":23,"context_line":"to logging resource types."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_daf2e506","line":21,"range":{"start_line":21,"start_character":15,"end_line":21,"end_character":25},"updated":"2017-07-13 01:19:08.000000000","message":"ditto!","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b3aa5a4f4b64e43cc323a829add1facee1b92ec8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Any plug-in or ML2 mechanism driver can claim support for logging types"},{"line_number":21,"context_line":"by providing a plug-in or driver class property called"},{"line_number":22,"context_line":"``supported_logging_types`` that returns a list of strings that correspond"},{"line_number":23,"context_line":"to logging resource types."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_babcc969","line":21,"range":{"start_line":21,"start_character":15,"end_line":21,"end_character":25},"in_reply_to":"1f1a1f67_daf2e506","updated":"2017-07-13 01:40:07.000000000","message":"ditto","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3d08c2a5276d38721619978b0db0c614aee2b0ba","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      .. code-block:: none"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"         service_plugins \u003d"},{"line_number":43,"context_line":"         neutron.services.l3_router.l3_router_plugin.L3RouterPlugin,"},{"line_number":44,"context_line":"         neutron.services.metering.metering_plugin.MeteringPlugin,"},{"line_number":45,"context_line":"         neutron.services.logapi.logging_plugin.LoggingPlugin"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"   #. Add the Logging extension to the ``extensions`` setting in"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_3ae31936","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":66},"updated":"2017-07-13 01:19:08.000000000","message":"How about replace them with ...?","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b3aa5a4f4b64e43cc323a829add1facee1b92ec8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      .. code-block:: none"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"         service_plugins \u003d"},{"line_number":43,"context_line":"         neutron.services.l3_router.l3_router_plugin.L3RouterPlugin,"},{"line_number":44,"context_line":"         neutron.services.metering.metering_plugin.MeteringPlugin,"},{"line_number":45,"context_line":"         neutron.services.logapi.logging_plugin.LoggingPlugin"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"   #. Add the Logging extension to the ``extensions`` setting in"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_3a7d59b1","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":66},"in_reply_to":"1f1a1f67_3ae31936","updated":"2017-07-13 01:40:07.000000000","message":"I referenced this kind of example from other ones (example from QoS [1]) and there is no problem to keep. Reader can easy to understand what they need to input in their our real configuration.\n\n[1] https://docs.openstack.org/neutron/latest/admin/config-qos.html","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3d08c2a5276d38721619978b0db0c614aee2b0ba","unresolved":false,"context_lines":[{"line_number":76,"context_line":".. note::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":79,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, log data will be stored"},{"line_number":80,"context_line":"     at syslog file like ``/var/log/syslog``."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Trusted projects policy.json configuration"},{"line_number":83,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_5a6db596","line":80,"range":{"start_line":79,"start_character":5,"end_line":80,"end_character":45},"updated":"2017-07-13 01:19:08.000000000","message":"Basically, logging api supported both syslog and journal[1], So please update that.\n[1] https://review.openstack.org/#/c/468281/15/neutron/services/logapi/agent/drivers/openvswitch/ovs_firewall_log.py@50","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b3aa5a4f4b64e43cc323a829add1facee1b92ec8","unresolved":false,"context_lines":[{"line_number":76,"context_line":".. note::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":79,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, log data will be stored"},{"line_number":80,"context_line":"     at syslog file like ``/var/log/syslog``."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Trusted projects policy.json configuration"},{"line_number":83,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_9a5fcd40","line":80,"range":{"start_line":79,"start_character":5,"end_line":80,"end_character":45},"in_reply_to":"1f1a1f67_5a6db596","updated":"2017-07-13 01:40:07.000000000","message":"Sure. Thanks for your updating","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3d08c2a5276d38721619978b0db0c614aee2b0ba","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Administrator enforcement"},{"line_number":151,"context_line":"-------------------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Administrators are able to enforce policies on VM ports or router ports."},{"line_number":154,"context_line":"As long as the policy is not shared, the project can not detach"},{"line_number":155,"context_line":"any policy attached to a port."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Enable/Disable log"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_5ac93576","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":30},"updated":"2017-07-13 01:19:08.000000000","message":"It\u0027s relate to logging? right?","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"0b766fa820b9d5566f1147cd82292695b85b237f","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Administrator enforcement"},{"line_number":151,"context_line":"-------------------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Administrators are able to enforce policies on VM ports or router ports."},{"line_number":154,"context_line":"As long as the policy is not shared, the project can not detach"},{"line_number":155,"context_line":"any policy attached to a port."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Enable/Disable log"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_7d662bf0","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":30},"in_reply_to":"1f1a1f67_3a56792b","updated":"2017-07-13 01:46:14.000000000","message":"I think it\u0027s not related to logging. what\u0027s is policies? It\u0027s logging policies, right?","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b3aa5a4f4b64e43cc323a829add1facee1b92ec8","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Administrator enforcement"},{"line_number":151,"context_line":"-------------------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Administrators are able to enforce policies on VM ports or router ports."},{"line_number":154,"context_line":"As long as the policy is not shared, the project can not detach"},{"line_number":155,"context_line":"any policy attached to a port."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Enable/Disable log"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f1a1f67_3a56792b","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":30},"in_reply_to":"1f1a1f67_5ac93576","updated":"2017-07-13 01:40:07.000000000","message":"Don\u0027t you think so?","commit_id":"00ce82c0d4f2968079f9e5bce88766f92683a2a6"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"1c08aadfb8f58c7a69af3d638e261cbe411e018c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      .. code-block:: ini"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"         [agent]"},{"line_number":51,"context_line":"         extensions \u003d logapi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"#.  On compute nodes:"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf3e73b7_9f6faac4","line":51,"updated":"2017-08-07 08:20:43.000000000","message":"can you update this to `log` instead of `logapi`, AnNP updated latest code with extension name here https://review.openstack.org/#/c/396116/18/setup.cfg","commit_id":"5d16a8b9414db5296cf9ab9d0a1db4303639b873"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"a39a3df48aa0c358b7e0bb74315f56024bf6b480","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      .. code-block:: ini"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"         [agent]"},{"line_number":51,"context_line":"         extensions \u003d logapi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"#.  On compute nodes:"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf3e73b7_3f9f9e51","line":51,"in_reply_to":"bf3e73b7_9f6faac4","updated":"2017-08-07 08:44:17.000000000","message":"Done","commit_id":"5d16a8b9414db5296cf9ab9d0a1db4303639b873"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"ea176e31fe0c06919de1577471e4a61657604610","unresolved":false,"context_lines":[{"line_number":148,"context_line":"Enable/Disable log"},{"line_number":149,"context_line":"------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"We can enable or disable logging objects at runtime. It means that It will"},{"line_number":152,"context_line":"be able to apply to all current attached ports with the logging object"},{"line_number":153,"context_line":"immediately."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1f1a1f67_352ff188","line":151,"range":{"start_line":151,"start_character":67,"end_line":151,"end_character":69},"updated":"2017-07-19 07:54:04.000000000","message":"s/It/it","commit_id":"5d16a8b9414db5296cf9ab9d0a1db4303639b873"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"a39a3df48aa0c358b7e0bb74315f56024bf6b480","unresolved":false,"context_lines":[{"line_number":148,"context_line":"Enable/Disable log"},{"line_number":149,"context_line":"------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"We can enable or disable logging objects at runtime. It means that It will"},{"line_number":152,"context_line":"be able to apply to all current attached ports with the logging object"},{"line_number":153,"context_line":"immediately."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf3e73b7_ffa8f677","line":151,"range":{"start_line":151,"start_character":67,"end_line":151,"end_character":69},"in_reply_to":"1f1a1f67_352ff188","updated":"2017-08-07 08:44:17.000000000","message":"Done","commit_id":"5d16a8b9414db5296cf9ab9d0a1db4303639b873"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9e88eb43640397fb92a9dd9a4efc71c43b0daa4b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Supported logging resource types"},{"line_number":17,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Any ML2 mechanism driver can claim to support for logging types by providing"},{"line_number":20,"context_line":"a driver class property called ``supported_logging_types`` that returns a list"},{"line_number":21,"context_line":"of strings that correspond to logging resource types."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_0130f455","line":19,"range":{"start_line":19,"start_character":46,"end_line":19,"end_character":49},"updated":"2017-08-07 16:43:06.000000000","message":"Not needed, please remove","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b9f1e42351b5aafcb2c8d27bf1ecc63e36f6f0df","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Supported logging resource types"},{"line_number":17,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Any ML2 mechanism driver can claim to support for logging types by providing"},{"line_number":20,"context_line":"a driver class property called ``supported_logging_types`` that returns a list"},{"line_number":21,"context_line":"of strings that correspond to logging resource types."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_7289f624","line":19,"range":{"start_line":19,"start_character":46,"end_line":19,"end_character":49},"in_reply_to":"bf3e73b7_0130f455","updated":"2017-08-08 02:09:01.000000000","message":"Done","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9e88eb43640397fb92a9dd9a4efc71c43b0daa4b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Any ML2 mechanism driver can claim to support for logging types by providing"},{"line_number":20,"context_line":"a driver class property called ``supported_logging_types`` that returns a list"},{"line_number":21,"context_line":"of strings that correspond to logging resource types."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. note::"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_61f340a0","line":21,"range":{"start_line":21,"start_character":16,"end_line":21,"end_character":26},"updated":"2017-08-07 16:43:06.000000000","message":"corresponds","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b9f1e42351b5aafcb2c8d27bf1ecc63e36f6f0df","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Any ML2 mechanism driver can claim to support for logging types by providing"},{"line_number":20,"context_line":"a driver class property called ``supported_logging_types`` that returns a list"},{"line_number":21,"context_line":"of strings that correspond to logging resource types."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. note::"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_528ef22e","line":21,"range":{"start_line":21,"start_character":16,"end_line":21,"end_character":26},"in_reply_to":"bf3e73b7_61f340a0","updated":"2017-08-08 02:09:01.000000000","message":"Done","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9e88eb43640397fb92a9dd9a4efc71c43b0daa4b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      .. code-block:: none"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"         service_plugins \u003d"},{"line_number":41,"context_line":"         neutron.services.l3_router.l3_router_plugin.L3RouterPlugin,"},{"line_number":42,"context_line":"         neutron.services.metering.metering_plugin.MeteringPlugin,"},{"line_number":43,"context_line":"         neutron.services.logapi.logging_plugin.LoggingPlugin"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"   #. Add the Logging extension to the ``extensions`` setting in"},{"line_number":46,"context_line":"      ``/etc/neutron/plugins/ml2/ml2_conf.ini``. For example:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_4104bc17","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":61},"updated":"2017-08-07 16:43:06.000000000","message":"We have a namespace for service plugins here that includes the logging api: https://github.com/openstack/neutron/blob/master/setup.cfg#L71.\n\nSo this should be:\n\nservice_plugins \u003d router,metering,logapi","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b9f1e42351b5aafcb2c8d27bf1ecc63e36f6f0df","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      .. code-block:: none"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"         service_plugins \u003d"},{"line_number":41,"context_line":"         neutron.services.l3_router.l3_router_plugin.L3RouterPlugin,"},{"line_number":42,"context_line":"         neutron.services.metering.metering_plugin.MeteringPlugin,"},{"line_number":43,"context_line":"         neutron.services.logapi.logging_plugin.LoggingPlugin"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"   #. Add the Logging extension to the ``extensions`` setting in"},{"line_number":46,"context_line":"      ``/etc/neutron/plugins/ml2/ml2_conf.ini``. For example:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_f27cc621","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":61},"in_reply_to":"bf3e73b7_4104bc17","updated":"2017-08-08 02:09:01.000000000","message":"Done.\n\nActually, this is referred from qos one :-)","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9e88eb43640397fb92a9dd9a4efc71c43b0daa4b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"       .. code-block:: ini"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"          [agent]"},{"line_number":61,"context_line":"          extensions \u003d log"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    #. In ``/etc/neutron/plugins/ml2/ml2_conf.ini``, add configuration options"},{"line_number":64,"context_line":"       for logging feature in the ``[log]`` section. For example:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_f34ca377","line":61,"range":{"start_line":61,"start_character":10,"end_line":61,"end_character":26},"updated":"2017-08-07 16:43:06.000000000","message":"Is this correct. This contradicts what is said in L55-56","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b9f1e42351b5aafcb2c8d27bf1ecc63e36f6f0df","unresolved":false,"context_lines":[{"line_number":58,"context_line":"       .. code-block:: ini"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"          [agent]"},{"line_number":61,"context_line":"          extensions \u003d log"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    #. In ``/etc/neutron/plugins/ml2/ml2_conf.ini``, add configuration options"},{"line_number":64,"context_line":"       for logging feature in the ``[log]`` section. For example:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_72dc5618","line":61,"range":{"start_line":61,"start_character":10,"end_line":61,"end_character":26},"in_reply_to":"bf3e73b7_f34ca377","updated":"2017-08-08 02:09:01.000000000","message":"Yes. This is latest update and L55-56 need to update accordingly.","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9e88eb43640397fb92a9dd9a4efc71c43b0daa4b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Operator workflow"},{"line_number":97,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The logging policies are created by administrators with the default"},{"line_number":100,"context_line":"``policy.json``. You should have the cloud operator set them up on"},{"line_number":101,"context_line":"behalf of the cloud projects."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"If projects are trusted to create their own policies, check the trusted"},{"line_number":104,"context_line":"projects ``policy.json`` configuration section:"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"#. Confirm supported logging resources:"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_f3d14359","line":104,"range":{"start_line":99,"start_character":0,"end_line":104,"end_character":47},"updated":"2017-08-07 16:43:06.000000000","message":"I would move these lines under L79. IMO, the explanation will be clearer. Of course the wording and paragraphs would need to be adjusted to make sense","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b9f1e42351b5aafcb2c8d27bf1ecc63e36f6f0df","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Operator workflow"},{"line_number":97,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The logging policies are created by administrators with the default"},{"line_number":100,"context_line":"``policy.json``. You should have the cloud operator set them up on"},{"line_number":101,"context_line":"behalf of the cloud projects."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"If projects are trusted to create their own policies, check the trusted"},{"line_number":104,"context_line":"projects ``policy.json`` configuration section:"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"#. Confirm supported logging resources:"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_92e0da98","line":104,"range":{"start_line":99,"start_character":0,"end_line":104,"end_character":47},"in_reply_to":"bf3e73b7_f3d14359","updated":"2017-08-08 02:09:01.000000000","message":"Done","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9e88eb43640397fb92a9dd9a4efc71c43b0daa4b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      | updated_at      | 2017-07-05T02:56:43Z                           |"},{"line_number":140,"context_line":"      +-----------------+------------------------------------------------+"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   If the ``enable`` field is specified, the logging is enabled and"},{"line_number":143,"context_line":"   log information is written to the destination if configured in"},{"line_number":144,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Enable/Disable log"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf3e73b7_b3405b09","line":144,"range":{"start_line":142,"start_character":0,"end_line":144,"end_character":76},"updated":"2017-08-07 16:43:06.000000000","message":"Maybe this should go in a note, like L73","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b9f1e42351b5aafcb2c8d27bf1ecc63e36f6f0df","unresolved":false,"context_lines":[{"line_number":139,"context_line":"      | updated_at      | 2017-07-05T02:56:43Z                           |"},{"line_number":140,"context_line":"      +-----------------+------------------------------------------------+"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   If the ``enable`` field is specified, the logging is enabled and"},{"line_number":143,"context_line":"   log information is written to the destination if configured in"},{"line_number":144,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Enable/Disable log"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f436f4f_f202863e","line":144,"range":{"start_line":142,"start_character":0,"end_line":144,"end_character":76},"in_reply_to":"bf3e73b7_b3405b09","updated":"2017-08-08 02:09:01.000000000","message":"Done","commit_id":"e9ff18b70d88db8525c9bfde5d84ac2fb2e03785"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"2527ce2134b163ca6e68de3e84c5707661ac2afb","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"       .. code-block:: ini"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"         [log]"},{"line_number":66,"context_line":"         rate_limit \u003d 100"},{"line_number":67,"context_line":"         burst_limit \u003d 25"},{"line_number":68,"context_line":"         #local_output_log_base \u003d \u003cNone\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f436f4f_fb0eda30","line":65,"updated":"2017-08-08 08:40:29.000000000","message":"isn\u0027t it `network_log`?","commit_id":"35ce3abc453736b14eb823c0f2cea03d9d61c9d4"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"5b168c7b173a50a72d009feba238c861baa3f9ea","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"       .. code-block:: ini"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"         [log]"},{"line_number":66,"context_line":"         rate_limit \u003d 100"},{"line_number":67,"context_line":"         burst_limit \u003d 25"},{"line_number":68,"context_line":"         #local_output_log_base \u003d \u003cNone\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f436f4f_db5316e2","line":65,"in_reply_to":"9f436f4f_fb0eda30","updated":"2017-08-08 08:49:33.000000000","message":"Done","commit_id":"35ce3abc453736b14eb823c0f2cea03d9d61c9d4"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"371aa3351b28ea866a018488cf6b6e7fea4356c8","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. note::"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"   As of the Pike release, the ``security_group`` option is supported."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_2cc08150","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":17},"updated":"2017-08-18 23:21:28.000000000","message":"Is this correct or should we change this to Queens now?","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"882893e5e854453a853659595f51fb9cddda216b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. note::"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"   As of the Pike release, the ``security_group`` option is supported."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_db151be7","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":17},"in_reply_to":"9f436f4f_2cc08150","updated":"2017-08-21 02:23:38.000000000","message":"Done","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"371aa3351b28ea866a018488cf6b6e7fea4356c8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Trusted projects policy.json configuration"},{"line_number":77,"context_line":"------------------------------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"The logging policies are created by administrators with the default"},{"line_number":80,"context_line":"``policy.json``. You should have the cloud operator set them up on"},{"line_number":81,"context_line":"behalf of the cloud projects."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"If projects are trusted to create their own policies, modify ``policy.json``"},{"line_number":84,"context_line":"to administer the logging policies in your cloud."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_6c720914","line":81,"range":{"start_line":79,"start_character":0,"end_line":81,"end_character":29},"updated":"2017-08-18 23:21:28.000000000","message":"I think it is a little confusing that you refer first to administrators and later to the cloud operator. Aren\u0027t they the same person / group? Consider rewriting this paragraph as:\n\nThe logging policies are set up by the cloud administrator in ``/etc/neutron/policy.json``","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b3ce70b2861ecd563072692254fd22d7714d0456","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Trusted projects policy.json configuration"},{"line_number":77,"context_line":"------------------------------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"The logging policies are created by administrators with the default"},{"line_number":80,"context_line":"``policy.json``. You should have the cloud operator set them up on"},{"line_number":81,"context_line":"behalf of the cloud projects."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"If projects are trusted to create their own policies, modify ``policy.json``"},{"line_number":84,"context_line":"to administer the logging policies in your cloud."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_ec171951","line":81,"range":{"start_line":79,"start_character":0,"end_line":81,"end_character":29},"in_reply_to":"9f436f4f_6c720914","updated":"2017-08-18 23:41:02.000000000","message":"I think I understand now. I think this should read as follows:\n\nWith the default ``/etc/neutron/policy.json``, administrators must set up logging policies on behalf of the cloud projects.","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"882893e5e854453a853659595f51fb9cddda216b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Trusted projects policy.json configuration"},{"line_number":77,"context_line":"------------------------------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"The logging policies are created by administrators with the default"},{"line_number":80,"context_line":"``policy.json``. You should have the cloud operator set them up on"},{"line_number":81,"context_line":"behalf of the cloud projects."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"If projects are trusted to create their own policies, modify ``policy.json``"},{"line_number":84,"context_line":"to administer the logging policies in your cloud."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_9bd5531e","line":81,"range":{"start_line":79,"start_character":0,"end_line":81,"end_character":29},"in_reply_to":"9f436f4f_973416e0","updated":"2017-08-21 02:23:38.000000000","message":"Done","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"dd8b84ba949e99809da3c9bfb9695a0ad24d8bac","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Trusted projects policy.json configuration"},{"line_number":77,"context_line":"------------------------------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"The logging policies are created by administrators with the default"},{"line_number":80,"context_line":"``policy.json``. You should have the cloud operator set them up on"},{"line_number":81,"context_line":"behalf of the cloud projects."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"If projects are trusted to create their own policies, modify ``policy.json``"},{"line_number":84,"context_line":"to administer the logging policies in your cloud."}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_973416e0","line":81,"range":{"start_line":79,"start_character":0,"end_line":81,"end_character":29},"in_reply_to":"9f436f4f_ec171951","updated":"2017-08-18 23:44:32.000000000","message":"Maybe even get rid of this \u0027logging policies\u0027 term and use \u0027resource logging\u0027 instead","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b3ce70b2861ecd563072692254fd22d7714d0456","unresolved":false,"context_lines":[{"line_number":80,"context_line":"``policy.json``. You should have the cloud operator set them up on"},{"line_number":81,"context_line":"behalf of the cloud projects."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"If projects are trusted to create their own policies, modify ``policy.json``"},{"line_number":84,"context_line":"to administer the logging policies in your cloud."},{"line_number":85,"context_line":"Currently, only the administrator can modify these policies."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Modify the ``/etc/neutron/policy.json`` policy entries as follows:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_d7117e55","line":85,"range":{"start_line":83,"start_character":44,"end_line":85,"end_character":60},"updated":"2017-08-18 23:41:02.000000000","message":"logging policies, modify ``/etc/neutron/policy.json`` as follows:","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"dd8b84ba949e99809da3c9bfb9695a0ad24d8bac","unresolved":false,"context_lines":[{"line_number":80,"context_line":"``policy.json``. You should have the cloud operator set them up on"},{"line_number":81,"context_line":"behalf of the cloud projects."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"If projects are trusted to create their own policies, modify ``policy.json``"},{"line_number":84,"context_line":"to administer the logging policies in your cloud."},{"line_number":85,"context_line":"Currently, only the administrator can modify these policies."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Modify the ``/etc/neutron/policy.json`` policy entries as follows:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_d73f3eb3","line":85,"range":{"start_line":83,"start_character":44,"end_line":85,"end_character":60},"in_reply_to":"9f436f4f_d7117e55","updated":"2017-08-18 23:44:32.000000000","message":"same here. How about this:\n\nresource logging, modify ``/etc/neutron/policy.json`` as follows:","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"882893e5e854453a853659595f51fb9cddda216b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"``policy.json``. You should have the cloud operator set them up on"},{"line_number":81,"context_line":"behalf of the cloud projects."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"If projects are trusted to create their own policies, modify ``policy.json``"},{"line_number":84,"context_line":"to administer the logging policies in your cloud."},{"line_number":85,"context_line":"Currently, only the administrator can modify these policies."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Modify the ``/etc/neutron/policy.json`` policy entries as follows:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_3bcf8780","line":85,"range":{"start_line":83,"start_character":44,"end_line":85,"end_character":60},"in_reply_to":"9f436f4f_d73f3eb3","updated":"2017-08-21 02:23:38.000000000","message":"Done","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"371aa3351b28ea866a018488cf6b6e7fea4356c8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"to administer the logging policies in your cloud."},{"line_number":85,"context_line":"Currently, only the administrator can modify these policies."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Modify the ``/etc/neutron/policy.json`` policy entries as follows:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. code-block:: none"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   \"get_loggable_resources\": \"rule:admin_only\","},{"line_number":92,"context_line":"   \"create_log\": \"rule:admin_only\","},{"line_number":93,"context_line":"   \"update_log\": \"rule:admin_only\","},{"line_number":94,"context_line":"   \"delete_log\": \"rule:admin_only\","},{"line_number":95,"context_line":"   \"get_logs\": \"rule:admin_only\","},{"line_number":96,"context_line":"   \"get_log\": \"rule:admin_only\","},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Operator workflow"},{"line_number":99,"context_line":"~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_ccd9f5f4","line":96,"range":{"start_line":87,"start_character":0,"end_line":96,"end_character":32},"updated":"2017-08-18 23:21:28.000000000","message":"Looking at the devstack I built yesterday, these entries are already in my policy.json file. Under what conditions would the operator change them?","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"882893e5e854453a853659595f51fb9cddda216b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"to administer the logging policies in your cloud."},{"line_number":85,"context_line":"Currently, only the administrator can modify these policies."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Modify the ``/etc/neutron/policy.json`` policy entries as follows:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. code-block:: none"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   \"get_loggable_resources\": \"rule:admin_only\","},{"line_number":92,"context_line":"   \"create_log\": \"rule:admin_only\","},{"line_number":93,"context_line":"   \"update_log\": \"rule:admin_only\","},{"line_number":94,"context_line":"   \"delete_log\": \"rule:admin_only\","},{"line_number":95,"context_line":"   \"get_logs\": \"rule:admin_only\","},{"line_number":96,"context_line":"   \"get_log\": \"rule:admin_only\","},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Operator workflow"},{"line_number":99,"context_line":"~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_dbc3db56","line":96,"range":{"start_line":87,"start_character":0,"end_line":96,"end_character":32},"in_reply_to":"9f436f4f_5727ceb7","updated":"2017-08-21 02:23:38.000000000","message":"Done","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b3ce70b2861ecd563072692254fd22d7714d0456","unresolved":false,"context_lines":[{"line_number":84,"context_line":"to administer the logging policies in your cloud."},{"line_number":85,"context_line":"Currently, only the administrator can modify these policies."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Modify the ``/etc/neutron/policy.json`` policy entries as follows:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. code-block:: none"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   \"get_loggable_resources\": \"rule:admin_only\","},{"line_number":92,"context_line":"   \"create_log\": \"rule:admin_only\","},{"line_number":93,"context_line":"   \"update_log\": \"rule:admin_only\","},{"line_number":94,"context_line":"   \"delete_log\": \"rule:admin_only\","},{"line_number":95,"context_line":"   \"get_logs\": \"rule:admin_only\","},{"line_number":96,"context_line":"   \"get_log\": \"rule:admin_only\","},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Operator workflow"},{"line_number":99,"context_line":"~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f436f4f_5727ceb7","line":96,"range":{"start_line":87,"start_character":0,"end_line":96,"end_character":32},"in_reply_to":"9f436f4f_ccd9f5f4","updated":"2017-08-18 23:41:02.000000000","message":"What you are showing here is the default, where only admins can create logging policies. I suggest showing an example where projects are trusted to create their own logging policies","commit_id":"783a1be4b1de6120b3234c0bab5ad6b0b4680bf1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"473ad5c76687ca925c0c9adeec2f2e2f8759a579","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To enable the service, follow the steps below."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#. On network nodes:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   #. Add the Logging service to the ``service_plugins`` setting in"},{"line_number":36,"context_line":"      ``/etc/neutron/neutron.conf``. For example:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_060864d7","line":33,"range":{"start_line":33,"start_character":6,"end_line":33,"end_character":13},"updated":"2017-09-30 00:06:58.000000000","message":"Shouldn\u0027t this be the Neutron server node? Service plugins are loaded by the neutron server, right?","commit_id":"59b0ce90fc25709c5e9129955971d4c1ab57de13"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"07c3f82b216a32e5d8c3e232e4f39d98d284bb28","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To enable the service, follow the steps below."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#. On network nodes:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   #. Add the Logging service to the ``service_plugins`` setting in"},{"line_number":36,"context_line":"      ``/etc/neutron/neutron.conf``. For example:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_abcf0d27","line":33,"range":{"start_line":33,"start_character":6,"end_line":33,"end_character":13},"in_reply_to":"7f515b1d_060864d7","updated":"2017-10-02 04:03:57.000000000","message":"Yes. I was think to use \"Neutron server\". But when looking at existed QoS document, I see they are using \"network\" instead. So, I use the word for consistence.\n\nI will update \"network\" to \"Neutron server\" as your suggestion.","commit_id":"59b0ce90fc25709c5e9129955971d4c1ab57de13"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"473ad5c76687ca925c0c9adeec2f2e2f8759a579","unresolved":false,"context_lines":[{"line_number":143,"context_line":"------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"We can enable or disable logging objects at runtime. It means that it will"},{"line_number":146,"context_line":"be able to apply to all current attached ports with the logging object"},{"line_number":147,"context_line":"immediately."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_8697b448","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":10},"updated":"2017-09-30 00:06:58.000000000","message":"IMO, these words are not necessary","commit_id":"59b0ce90fc25709c5e9129955971d4c1ab57de13"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"473ad5c76687ca925c0c9adeec2f2e2f8759a579","unresolved":false,"context_lines":[{"line_number":143,"context_line":"------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"We can enable or disable logging objects at runtime. It means that it will"},{"line_number":146,"context_line":"be able to apply to all current attached ports with the logging object"},{"line_number":147,"context_line":"immediately."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_66927859","line":146,"range":{"start_line":146,"start_character":24,"end_line":146,"end_character":31},"updated":"2017-09-30 00:06:58.000000000","message":"currently","commit_id":"59b0ce90fc25709c5e9129955971d4c1ab57de13"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"07c3f82b216a32e5d8c3e232e4f39d98d284bb28","unresolved":false,"context_lines":[{"line_number":143,"context_line":"------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"We can enable or disable logging objects at runtime. It means that it will"},{"line_number":146,"context_line":"be able to apply to all current attached ports with the logging object"},{"line_number":147,"context_line":"immediately."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_6bdd95de","line":146,"range":{"start_line":146,"start_character":24,"end_line":146,"end_character":31},"in_reply_to":"7f515b1d_66927859","updated":"2017-10-02 04:03:57.000000000","message":"Done","commit_id":"59b0ce90fc25709c5e9129955971d4c1ab57de13"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"07c3f82b216a32e5d8c3e232e4f39d98d284bb28","unresolved":false,"context_lines":[{"line_number":143,"context_line":"------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"We can enable or disable logging objects at runtime. It means that it will"},{"line_number":146,"context_line":"be able to apply to all current attached ports with the logging object"},{"line_number":147,"context_line":"immediately."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_4bd899ed","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":10},"in_reply_to":"7f515b1d_8697b448","updated":"2017-10-02 04:03:57.000000000","message":"Done","commit_id":"59b0ce90fc25709c5e9129955971d4c1ab57de13"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"489472bbad692a7c75ad56027243f09555027b72","unresolved":false,"context_lines":[{"line_number":173,"context_line":"Events collected description"},{"line_number":174,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Logging will collect ACCEPT or DROP or both events related on port(s),"},{"line_number":177,"context_line":"with the following general characteristics:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Log every DROP event: Exactly one DROP security event must be generated when"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f515b1d_7680dcf5","line":176,"range":{"start_line":176,"start_character":59,"end_line":176,"end_character":69},"updated":"2017-10-02 04:30:38.000000000","message":"to security group.","commit_id":"236faee50b27d0d152995baa2b590e70b66e8753"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"f903d2ba27b718d28da0ab9fa59a531148e5d5ee","unresolved":false,"context_lines":[{"line_number":173,"context_line":"Events collected description"},{"line_number":174,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Logging will collect ACCEPT or DROP or both events related on port(s),"},{"line_number":177,"context_line":"with the following general characteristics:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Log every DROP event: Exactly one DROP security event must be generated when"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f515b1d_112f7288","line":176,"range":{"start_line":176,"start_character":59,"end_line":176,"end_character":69},"in_reply_to":"7f515b1d_7680dcf5","updated":"2017-10-02 06:03:36.000000000","message":"Done","commit_id":"236faee50b27d0d152995baa2b590e70b66e8753"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"489472bbad692a7c75ad56027243f09555027b72","unresolved":false,"context_lines":[{"line_number":176,"context_line":"Logging will collect ACCEPT or DROP or both events related on port(s),"},{"line_number":177,"context_line":"with the following general characteristics:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Log every DROP event: Exactly one DROP security event must be generated when"},{"line_number":180,"context_line":"  a new incoming or outgoing session is dropped, that is the new session is"},{"line_number":181,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":182,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f515b1d_d6943039","line":180,"range":{"start_line":179,"start_character":23,"end_line":180,"end_character":47},"updated":"2017-10-02 04:30:38.000000000","message":"It seems conflict with \u0027every DROP event\u0027, right?","commit_id":"236faee50b27d0d152995baa2b590e70b66e8753"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"f903d2ba27b718d28da0ab9fa59a531148e5d5ee","unresolved":false,"context_lines":[{"line_number":176,"context_line":"Logging will collect ACCEPT or DROP or both events related on port(s),"},{"line_number":177,"context_line":"with the following general characteristics:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Log every DROP event: Exactly one DROP security event must be generated when"},{"line_number":180,"context_line":"  a new incoming or outgoing session is dropped, that is the new session is"},{"line_number":181,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":182,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f515b1d_f14f3668","line":180,"range":{"start_line":179,"start_character":23,"end_line":180,"end_character":47},"in_reply_to":"7f515b1d_d6943039","updated":"2017-10-02 06:03:36.000000000","message":"Done","commit_id":"236faee50b27d0d152995baa2b590e70b66e8753"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"489472bbad692a7c75ad56027243f09555027b72","unresolved":false,"context_lines":[{"line_number":204,"context_line":"General data requirements: The security event should include:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* The status of the flow ACCEPT/DROP."},{"line_number":207,"context_line":"* An indication of the originator of the flow."},{"line_number":208,"context_line":"* The timestamp of the flow."},{"line_number":209,"context_line":"* An identifier of the associated virtual machine interface."},{"line_number":210,"context_line":"* An identifier of the matching security group rule."}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f515b1d_f6ba8cbe","line":207,"range":{"start_line":207,"start_character":0,"end_line":207,"end_character":46},"updated":"2017-10-02 04:30:38.000000000","message":"Sorry, I couldn\u0027t get your point here. Could you please add more explanation?","commit_id":"236faee50b27d0d152995baa2b590e70b66e8753"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"f903d2ba27b718d28da0ab9fa59a531148e5d5ee","unresolved":false,"context_lines":[{"line_number":204,"context_line":"General data requirements: The security event should include:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* The status of the flow ACCEPT/DROP."},{"line_number":207,"context_line":"* An indication of the originator of the flow."},{"line_number":208,"context_line":"* The timestamp of the flow."},{"line_number":209,"context_line":"* An identifier of the associated virtual machine interface."},{"line_number":210,"context_line":"* An identifier of the matching security group rule."}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f515b1d_513e0ab8","line":207,"range":{"start_line":207,"start_character":0,"end_line":207,"end_character":46},"in_reply_to":"7f515b1d_f6ba8cbe","updated":"2017-10-02 06:03:36.000000000","message":"I mean information which we can identify where it be generated like project_id, log_resource_ids","commit_id":"236faee50b27d0d152995baa2b590e70b66e8753"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"489472bbad692a7c75ad56027243f09555027b72","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      TCPOptionNoOperation(kind\u003d1,length\u003d1), TCPOptionWindowScale(kind\u003d3,length\u003d3,shift_cnt\u003d3)],"},{"line_number":248,"context_line":"      seq\u003d3284890090,src_port\u003d47825,urgent\u003d0,window_size\u003d14600)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"* Consuming logs: There are several way to consume the collected log."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  * A Request/Reply HTTP API directed at Neutron. In this case it"},{"line_number":253,"context_line":"    must be possible to easily request non-overlapping log segments"},{"line_number":254,"context_line":"    where no events are missed."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"  * A pub/sub subscription mechanism, e.g. Kafka."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"  * A file based mechanism to transfer security events in bulk."}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f515b1d_d6e2f0d4","line":258,"range":{"start_line":250,"start_character":0,"end_line":258,"end_character":63},"updated":"2017-10-02 04:30:38.000000000","message":"How about monasca?","commit_id":"236faee50b27d0d152995baa2b590e70b66e8753"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"f903d2ba27b718d28da0ab9fa59a531148e5d5ee","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      TCPOptionNoOperation(kind\u003d1,length\u003d1), TCPOptionWindowScale(kind\u003d3,length\u003d3,shift_cnt\u003d3)],"},{"line_number":248,"context_line":"      seq\u003d3284890090,src_port\u003d47825,urgent\u003d0,window_size\u003d14600)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"* Consuming logs: There are several way to consume the collected log."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  * A Request/Reply HTTP API directed at Neutron. In this case it"},{"line_number":253,"context_line":"    must be possible to easily request non-overlapping log segments"},{"line_number":254,"context_line":"    where no events are missed."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"  * A pub/sub subscription mechanism, e.g. Kafka."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"  * A file based mechanism to transfer security events in bulk."}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f515b1d_917122ab","line":258,"range":{"start_line":250,"start_character":0,"end_line":258,"end_character":63},"in_reply_to":"7f515b1d_d6e2f0d4","updated":"2017-10-02 06:03:36.000000000","message":"Done","commit_id":"236faee50b27d0d152995baa2b590e70b66e8753"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a4fd708e724857cbfcd886585c804c6786e270cd","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To enable the service, follow the steps below."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#. On Neutron server node:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   #. Add the Logging service to the ``service_plugins`` setting in"},{"line_number":36,"context_line":"      ``/etc/neutron/neutron.conf``. For example:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_789bc665","line":33,"updated":"2017-10-05 15:03:03.000000000","message":"Do the services have to be restarted to pick up these conf changes? If so, is that well known or does it need to be stated here?","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"27a35cfb2254db4d85357a249bcf2f676d75f9c5","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To enable the service, follow the steps below."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#. On Neutron server node:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   #. Add the Logging service to the ``service_plugins`` setting in"},{"line_number":36,"context_line":"      ``/etc/neutron/neutron.conf``. For example:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_62c2ab36","line":33,"in_reply_to":"7f515b1d_789bc665","updated":"2017-10-09 01:51:13.000000000","message":"Yes. I think it is well known as other existed documents like QoS one doesn\u0027t mention about it. But we known it needs to be restarted in order to pick up these conf changes.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a4fd708e724857cbfcd886585c804c6786e270cd","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":73,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, log data will be stored"},{"line_number":74,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Trusted projects policy.json configuration"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_58cfea7e","line":73,"range":{"start_line":73,"start_character":27,"end_line":73,"end_character":48},"updated":"2017-10-05 15:03:03.000000000","message":"It might be helpful if this could be a link to the configuration option for it. I couldn\u0027t find where it came from.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"27a35cfb2254db4d85357a249bcf2f676d75f9c5","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":73,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, log data will be stored"},{"line_number":74,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Trusted projects policy.json configuration"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_a2d1c3fd","line":73,"range":{"start_line":73,"start_character":27,"end_line":73,"end_character":48},"in_reply_to":"7f515b1d_58cfea7e","updated":"2017-10-09 01:51:13.000000000","message":"Yeah. I will add more description for this option in revision one.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Operator workflow"},{"line_number":97,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"#. Confirm supported logging resources:"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"   .. code-block:: console"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_4cbbc1e4","line":99,"range":{"start_line":99,"start_character":11,"end_line":99,"end_character":20},"updated":"2017-10-05 02:50:11.000000000","message":"supporting? or supported_logging_resources?","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Operator workflow"},{"line_number":97,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"#. Confirm supported logging resources:"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"   .. code-block:: console"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_e7cf26ae","line":99,"range":{"start_line":99,"start_character":11,"end_line":99,"end_character":20},"in_reply_to":"7f515b1d_4cbbc1e4","updated":"2017-10-05 03:18:00.000000000","message":"\"supported\" is correct. I think.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. note::"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   If the ``enable`` field is specified, the logging is enabled and"},{"line_number":138,"context_line":"   log information is written to the destination if configured in"},{"line_number":139,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_c151ba64","line":137,"range":{"start_line":137,"start_character":2,"end_line":137,"end_character":63},"updated":"2017-10-05 02:50:11.000000000","message":"It made me confused. Because \u0027enabled\u0027 is default True[1]. What will happen if don\u0027t specify enable option? Is there some modifying from CLI?\n[1] https://github.com/openstack/neutron/blob/master/neutron/extensions/logging.py#L62","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. note::"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   If the ``enable`` field is specified, the logging is enabled and"},{"line_number":138,"context_line":"   log information is written to the destination if configured in"},{"line_number":139,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_a746ce20","line":137,"range":{"start_line":137,"start_character":2,"end_line":137,"end_character":63},"in_reply_to":"7f515b1d_c151ba64","updated":"2017-10-05 03:18:00.000000000","message":"Good catch. I will update for this point accordingly.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":143,"context_line":"------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"We can enable or disable logging objects at runtime. It means that it will"},{"line_number":146,"context_line":"apply to all currently attached ports with the logging object immediately."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"For example:"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_c1ad3a32","line":146,"range":{"start_line":146,"start_character":13,"end_line":146,"end_character":22},"updated":"2017-10-05 02:50:11.000000000","message":"It should remove it. Because if a new vm_port is added, which belong a logging object then event related this vm_port will be logged also.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":143,"context_line":"------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"We can enable or disable logging objects at runtime. It means that it will"},{"line_number":146,"context_line":"apply to all currently attached ports with the logging object immediately."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"For example:"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_a76fee90","line":146,"range":{"start_line":146,"start_character":13,"end_line":146,"end_character":22},"in_reply_to":"7f515b1d_c1ad3a32","updated":"2017-10-05 03:18:00.000000000","message":"Consider it done","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a4fd708e724857cbfcd886585c804c6786e270cd","unresolved":false,"context_lines":[{"line_number":155,"context_line":"     | Field           | Value                                          |"},{"line_number":156,"context_line":"     +-----------------+------------------------------------------------+"},{"line_number":157,"context_line":"     | Description     | Collecting all security events in project demo |"},{"line_number":158,"context_line":"     | Enabled         | False                                          |"},{"line_number":159,"context_line":"     | Event           | ALL                                            |"},{"line_number":160,"context_line":"     | ID              | 8085c3e6-0fa2-4954-b5ce-ff6207931b6d           |"},{"line_number":161,"context_line":"     | Name            | Log_Created                                    |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_3839ce3e","line":158,"range":{"start_line":158,"start_character":7,"end_line":158,"end_character":8},"updated":"2017-10-05 15:03:03.000000000","message":"Do these all show up with the first letter capitalized or should they all be lower case?","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"27a35cfb2254db4d85357a249bcf2f676d75f9c5","unresolved":false,"context_lines":[{"line_number":155,"context_line":"     | Field           | Value                                          |"},{"line_number":156,"context_line":"     +-----------------+------------------------------------------------+"},{"line_number":157,"context_line":"     | Description     | Collecting all security events in project demo |"},{"line_number":158,"context_line":"     | Enabled         | False                                          |"},{"line_number":159,"context_line":"     | Event           | ALL                                            |"},{"line_number":160,"context_line":"     | ID              | 8085c3e6-0fa2-4954-b5ce-ff6207931b6d           |"},{"line_number":161,"context_line":"     | Name            | Log_Created                                    |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_0231b75a","line":158,"range":{"start_line":158,"start_character":7,"end_line":158,"end_character":8},"in_reply_to":"7f515b1d_3839ce3e","updated":"2017-10-09 01:51:13.000000000","message":"This is outputted from Client side [1]. Basically, these all should show up with the first letter capitalized. If you have concern about this, I think it should be discussed at client patch. Then I will update this document accordingly later.\n\n[1] https://review.openstack.org/#/c/409819/","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a4fd708e724857cbfcd886585c804c6786e270cd","unresolved":false,"context_lines":[{"line_number":173,"context_line":"Events collected description"},{"line_number":174,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Logging will collect ACCEPT or DROP or both events related to security group,"},{"line_number":177,"context_line":"with the following general characteristics:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Log every DROP event: Every DROP security event will be generated when"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_b8dffe0a","line":176,"range":{"start_line":176,"start_character":21,"end_line":176,"end_character":27},"updated":"2017-10-05 15:03:03.000000000","message":"Nit: I\u0027d opt to format these as code::\n\n   ``ACCEPT``\n   ``DROP```","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"27a35cfb2254db4d85357a249bcf2f676d75f9c5","unresolved":false,"context_lines":[{"line_number":173,"context_line":"Events collected description"},{"line_number":174,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Logging will collect ACCEPT or DROP or both events related to security group,"},{"line_number":177,"context_line":"with the following general characteristics:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Log every DROP event: Every DROP security event will be generated when"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_c236ff51","line":176,"range":{"start_line":176,"start_character":21,"end_line":176,"end_character":27},"in_reply_to":"7f515b1d_b8dffe0a","updated":"2017-10-09 01:51:13.000000000","message":"Consider it DONE.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":177,"context_line":"with the following general characteristics:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Log every DROP event: Every DROP security event will be generated when"},{"line_number":180,"context_line":"  a new incoming or outgoing session is dropped, that is the new session is"},{"line_number":181,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":182,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_e15ef643","line":180,"range":{"start_line":180,"start_character":4,"end_line":180,"end_character":7},"updated":"2017-10-05 02:50:11.000000000","message":"Please remove it. Because every incoming/outgoing of droping session will be logged.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":177,"context_line":"with the following general characteristics:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Log every DROP event: Every DROP security event will be generated when"},{"line_number":180,"context_line":"  a new incoming or outgoing session is dropped, that is the new session is"},{"line_number":181,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":182,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":183,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_876cf29c","line":180,"range":{"start_line":180,"start_character":4,"end_line":180,"end_character":7},"in_reply_to":"7f515b1d_e15ef643","updated":"2017-10-05 03:18:00.000000000","message":"Done","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":182,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"* Log an ACCEPT event: An ACCEPT security event will be generated for each"},{"line_number":185,"context_line":"  incoming or outgoing session that is allowed by the ports security group."},{"line_number":186,"context_line":"  Detail for the events as follow:"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  * North/South ACCEPT: For a North/South session there would be single ACCEPT"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_6130c608","line":185,"range":{"start_line":184,"start_character":65,"end_line":185,"end_character":30},"updated":"2017-10-05 02:50:11.000000000","message":"It should be \"for each *NEW* incoming/outgoing session\".","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":182,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"* Log an ACCEPT event: An ACCEPT security event will be generated for each"},{"line_number":185,"context_line":"  incoming or outgoing session that is allowed by the ports security group."},{"line_number":186,"context_line":"  Detail for the events as follow:"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  * North/South ACCEPT: For a North/South session there would be single ACCEPT"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_6769f689","line":185,"range":{"start_line":184,"start_character":65,"end_line":185,"end_character":30},"in_reply_to":"7f515b1d_6130c608","updated":"2017-10-05 03:18:00.000000000","message":"Done","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":185,"context_line":"  incoming or outgoing session that is allowed by the ports security group."},{"line_number":186,"context_line":"  Detail for the events as follow:"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  * North/South ACCEPT: For a North/South session there would be single ACCEPT"},{"line_number":189,"context_line":"    event irrespective of direction."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"  * East/West ACCEPT/ACCEPT: In an intra-project East/West session where the"},{"line_number":192,"context_line":"    security group on the originating port allows the session and the security"},{"line_number":193,"context_line":"    group on the destination port allows the session, i.e. the traffic is allowed,"},{"line_number":194,"context_line":"    there would be two ACCEPT security events generated, one from the perspective"},{"line_number":195,"context_line":"    of the originating port and one from the perspective of the destination port."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  * East/West ACCEPT/DROP: In an intra-project East/West session initiation"},{"line_number":198,"context_line":"    where the security group on the originating port allows the session and the"},{"line_number":199,"context_line":"    security group on the destination port does not allow the session there would"},{"line_number":200,"context_line":"    be one ACCEPT security event generated from the perspective of the originating"},{"line_number":201,"context_line":"    port and one DROP security event generated from the perspective of the"},{"line_number":202,"context_line":"    destination port."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"General data requirements: The security event should include:"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_8cc41942","line":202,"range":{"start_line":188,"start_character":0,"end_line":202,"end_character":21},"updated":"2017-10-05 02:50:11.000000000","message":"I\u0027m not sure it\u0027s correctly. Have you tested these case yet?","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"32b3040f9193d49be2eea56ce67ec2140cc033db","unresolved":false,"context_lines":[{"line_number":185,"context_line":"  incoming or outgoing session that is allowed by the ports security group."},{"line_number":186,"context_line":"  Detail for the events as follow:"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  * North/South ACCEPT: For a North/South session there would be single ACCEPT"},{"line_number":189,"context_line":"    event irrespective of direction."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"  * East/West ACCEPT/ACCEPT: In an intra-project East/West session where the"},{"line_number":192,"context_line":"    security group on the originating port allows the session and the security"},{"line_number":193,"context_line":"    group on the destination port allows the session, i.e. the traffic is allowed,"},{"line_number":194,"context_line":"    there would be two ACCEPT security events generated, one from the perspective"},{"line_number":195,"context_line":"    of the originating port and one from the perspective of the destination port."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  * East/West ACCEPT/DROP: In an intra-project East/West session initiation"},{"line_number":198,"context_line":"    where the security group on the originating port allows the session and the"},{"line_number":199,"context_line":"    security group on the destination port does not allow the session there would"},{"line_number":200,"context_line":"    be one ACCEPT security event generated from the perspective of the originating"},{"line_number":201,"context_line":"    port and one DROP security event generated from the perspective of the"},{"line_number":202,"context_line":"    destination port."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"General data requirements: The security event should include:"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_c7b0aa8e","line":202,"range":{"start_line":188,"start_character":0,"end_line":202,"end_character":21},"in_reply_to":"7f515b1d_870192b2","updated":"2017-10-05 03:35:37.000000000","message":"Sorry, I couldn\u0027t confirm it\u0027s correct or not. Actually, we expected logging API will log ACCEPT/DROP events related to security group in generally. Here is quite detail. If i remember correct, we don\u0027t mention about detail expectation as you state here. So I\u0027m not sure all information is correct or not. Could you please help us to exam these tests? Thanks in advance.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":185,"context_line":"  incoming or outgoing session that is allowed by the ports security group."},{"line_number":186,"context_line":"  Detail for the events as follow:"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  * North/South ACCEPT: For a North/South session there would be single ACCEPT"},{"line_number":189,"context_line":"    event irrespective of direction."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"  * East/West ACCEPT/ACCEPT: In an intra-project East/West session where the"},{"line_number":192,"context_line":"    security group on the originating port allows the session and the security"},{"line_number":193,"context_line":"    group on the destination port allows the session, i.e. the traffic is allowed,"},{"line_number":194,"context_line":"    there would be two ACCEPT security events generated, one from the perspective"},{"line_number":195,"context_line":"    of the originating port and one from the perspective of the destination port."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  * East/West ACCEPT/DROP: In an intra-project East/West session initiation"},{"line_number":198,"context_line":"    where the security group on the originating port allows the session and the"},{"line_number":199,"context_line":"    security group on the destination port does not allow the session there would"},{"line_number":200,"context_line":"    be one ACCEPT security event generated from the perspective of the originating"},{"line_number":201,"context_line":"    port and one DROP security event generated from the perspective of the"},{"line_number":202,"context_line":"    destination port."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"General data requirements: The security event should include:"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_870192b2","line":202,"range":{"start_line":188,"start_character":0,"end_line":202,"end_character":21},"in_reply_to":"7f515b1d_8cc41942","updated":"2017-10-05 03:18:00.000000000","message":"This is what I am understand about expectation of logging. Is it correct regarding to current status of development? Because you are mainly responsible for development.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"5c8c5a17580a7258fe3f5019459619c42e11aae5","unresolved":false,"context_lines":[{"line_number":185,"context_line":"  incoming or outgoing session that is allowed by the ports security group."},{"line_number":186,"context_line":"  Detail for the events as follow:"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  * North/South ACCEPT: For a North/South session there would be single ACCEPT"},{"line_number":189,"context_line":"    event irrespective of direction."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"  * East/West ACCEPT/ACCEPT: In an intra-project East/West session where the"},{"line_number":192,"context_line":"    security group on the originating port allows the session and the security"},{"line_number":193,"context_line":"    group on the destination port allows the session, i.e. the traffic is allowed,"},{"line_number":194,"context_line":"    there would be two ACCEPT security events generated, one from the perspective"},{"line_number":195,"context_line":"    of the originating port and one from the perspective of the destination port."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  * East/West ACCEPT/DROP: In an intra-project East/West session initiation"},{"line_number":198,"context_line":"    where the security group on the originating port allows the session and the"},{"line_number":199,"context_line":"    security group on the destination port does not allow the session there would"},{"line_number":200,"context_line":"    be one ACCEPT security event generated from the perspective of the originating"},{"line_number":201,"context_line":"    port and one DROP security event generated from the perspective of the"},{"line_number":202,"context_line":"    destination port."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"General data requirements: The security event should include:"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_eb3c30c9","line":202,"range":{"start_line":188,"start_character":0,"end_line":202,"end_character":21},"in_reply_to":"7f515b1d_926c329d","updated":"2017-10-09 09:45:29.000000000","message":"I have just verified with latest implementation. The \"East/West ACCEPT/DROP\" item need to be updated.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"2b05f4f05b1151f1e5176ebb0e7f698088e17abc","unresolved":false,"context_lines":[{"line_number":185,"context_line":"  incoming or outgoing session that is allowed by the ports security group."},{"line_number":186,"context_line":"  Detail for the events as follow:"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  * North/South ACCEPT: For a North/South session there would be single ACCEPT"},{"line_number":189,"context_line":"    event irrespective of direction."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"  * East/West ACCEPT/ACCEPT: In an intra-project East/West session where the"},{"line_number":192,"context_line":"    security group on the originating port allows the session and the security"},{"line_number":193,"context_line":"    group on the destination port allows the session, i.e. the traffic is allowed,"},{"line_number":194,"context_line":"    there would be two ACCEPT security events generated, one from the perspective"},{"line_number":195,"context_line":"    of the originating port and one from the perspective of the destination port."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  * East/West ACCEPT/DROP: In an intra-project East/West session initiation"},{"line_number":198,"context_line":"    where the security group on the originating port allows the session and the"},{"line_number":199,"context_line":"    security group on the destination port does not allow the session there would"},{"line_number":200,"context_line":"    be one ACCEPT security event generated from the perspective of the originating"},{"line_number":201,"context_line":"    port and one DROP security event generated from the perspective of the"},{"line_number":202,"context_line":"    destination port."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"General data requirements: The security event should include:"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_926c329d","line":202,"range":{"start_line":188,"start_character":0,"end_line":202,"end_character":21},"in_reply_to":"7f515b1d_c7b0aa8e","updated":"2017-10-05 03:43:43.000000000","message":"\u003e Is it correct regarding to current status of development? Because you are mainly responsible for development\n\nI\u0027m mainly for both spec and development. :)","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":207,"context_line":"* An indication of the originator of the flow, e.g which project or log resource"},{"line_number":208,"context_line":"  the event is generated."},{"line_number":209,"context_line":"* The timestamp of the flow."},{"line_number":210,"context_line":"* An identifier of the associated virtual machine interface."},{"line_number":211,"context_line":"* An identifier of the matching security group rule."},{"line_number":212,"context_line":"* The layer 3 and 4 information (address, port, protocol, etc)."},{"line_number":213,"context_line":"* The number of bytes and packets traversing the flow."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_2c03e50f","line":210,"range":{"start_line":210,"start_character":34,"end_line":210,"end_character":59},"updated":"2017-10-05 02:50:11.000000000","message":"How about add (neutron port id) to make it more clearly?","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":207,"context_line":"* An indication of the originator of the flow, e.g which project or log resource"},{"line_number":208,"context_line":"  the event is generated."},{"line_number":209,"context_line":"* The timestamp of the flow."},{"line_number":210,"context_line":"* An identifier of the associated virtual machine interface."},{"line_number":211,"context_line":"* An identifier of the matching security group rule."},{"line_number":212,"context_line":"* The layer 3 and 4 information (address, port, protocol, etc)."},{"line_number":213,"context_line":"* The number of bytes and packets traversing the flow."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_c720aa4c","line":210,"range":{"start_line":210,"start_character":34,"end_line":210,"end_character":59},"in_reply_to":"7f515b1d_2c03e50f","updated":"2017-10-05 03:18:00.000000000","message":"Consider it done.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":210,"context_line":"* An identifier of the associated virtual machine interface."},{"line_number":211,"context_line":"* An identifier of the matching security group rule."},{"line_number":212,"context_line":"* The layer 3 and 4 information (address, port, protocol, etc)."},{"line_number":213,"context_line":"* The number of bytes and packets traversing the flow."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. note::"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_4c4ce175","line":213,"range":{"start_line":213,"start_character":0,"end_line":213,"end_character":54},"updated":"2017-10-05 02:50:11.000000000","message":"Please remove it. Currently we don\u0027t have a statistics about bytes and packets per flow.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":210,"context_line":"* An identifier of the associated virtual machine interface."},{"line_number":211,"context_line":"* An identifier of the matching security group rule."},{"line_number":212,"context_line":"* The layer 3 and 4 information (address, port, protocol, etc)."},{"line_number":213,"context_line":"* The number of bytes and packets traversing the flow."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. note::"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_47d27a36","line":213,"range":{"start_line":213,"start_character":0,"end_line":213,"end_character":54},"in_reply_to":"7f515b1d_4c4ce175","updated":"2017-10-05 03:18:00.000000000","message":"Done","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. note::"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"   No other extraneous events are generated within the security event logs, e.g. no"},{"line_number":218,"context_line":"   flow data, no debugging data, etc."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"* Security event record format:"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_eca82ddc","line":218,"range":{"start_line":217,"start_character":80,"end_line":218,"end_character":12},"updated":"2017-10-05 02:50:11.000000000","message":"Sorry, I couldn\u0027t get this point. What does that mean? Could you please add more information or example about flow data?","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. note::"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"   No other extraneous events are generated within the security event logs, e.g. no"},{"line_number":218,"context_line":"   flow data, no debugging data, etc."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"* Security event record format:"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_c7e54a0c","line":218,"range":{"start_line":217,"start_character":80,"end_line":218,"end_character":12},"in_reply_to":"7f515b1d_eca82ddc","updated":"2017-10-05 03:18:00.000000000","message":"It\u0027s better to drop this one.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"* Consuming logs: There are several ways to consume the collected log."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"  * A Request/Reply HTTP API directed at Neutron. In this case it"},{"line_number":254,"context_line":"    must be possible to easily request non-overlapping log segments"},{"line_number":255,"context_line":"    where no events are missed."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"  * Third party services like Monasca."},{"line_number":258,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_ecf6edf9","line":255,"range":{"start_line":253,"start_character":0,"end_line":255,"end_character":31},"updated":"2017-10-05 02:50:11.000000000","message":"Actually, we don\u0027t have a plan to build a neutron api for consuming log-data. So I think we can remove it.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"* Consuming logs: There are several ways to consume the collected log."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"  * A Request/Reply HTTP API directed at Neutron. In this case it"},{"line_number":254,"context_line":"    must be possible to easily request non-overlapping log segments"},{"line_number":255,"context_line":"    where no events are missed."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"  * Third party services like Monasca."},{"line_number":258,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_87abd273","line":255,"range":{"start_line":253,"start_character":0,"end_line":255,"end_character":31},"in_reply_to":"7f515b1d_ecf6edf9","updated":"2017-10-05 03:18:00.000000000","message":"This is intention for log consuming even if we don\u0027t support any items in this section inside neutron perspective.\nIt\u0027s better to ask Miguel for advice about this point.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"204ccf02bb1921145267ddec52e577c53af4bd94","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"  * Third party services like Monasca."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"  * A pub/sub subscription mechanism, e.g. Kafka."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"  * A file based mechanism to transfer security events in bulk."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_0c270967","line":261,"range":{"start_line":259,"start_character":0,"end_line":261,"end_character":63},"updated":"2017-10-05 02:50:11.000000000","message":"I\u0027m not sure these items should be to add in this session.","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b27d7c9981c1afe13433e631034296bb99b66887","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"  * Third party services like Monasca."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"  * A pub/sub subscription mechanism, e.g. Kafka."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"  * A file based mechanism to transfer security events in bulk."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7f515b1d_47b71ada","line":261,"range":{"start_line":259,"start_character":0,"end_line":261,"end_character":63},"in_reply_to":"7f515b1d_0c270967","updated":"2017-10-05 03:18:00.000000000","message":"ditto","commit_id":"d08b8fec8eecb48aa2ce4693d011daa3ab0a521f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"496f3031324ada44140586bcb9aed54d2fbe0541","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":73,"context_line":"   - Logged data can be store at anywhere by using ``local_output_log_base`` option."},{"line_number":74,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"},{"line_number":75,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f515b1d_344bbc2b","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":32},"updated":"2017-10-09 17:09:53.000000000","message":"not needed","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"496f3031324ada44140586bcb9aed54d2fbe0541","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":73,"context_line":"   - Logged data can be store at anywhere by using ``local_output_log_base`` option."},{"line_number":74,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"},{"line_number":75,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f515b1d_5442b810","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":29},"updated":"2017-10-09 17:09:53.000000000","message":"stored","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"3eb6f56c0139cd06017b49c136ca8c02afd65d93","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":73,"context_line":"   - Logged data can be store at anywhere by using ``local_output_log_base`` option."},{"line_number":74,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"},{"line_number":75,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f4e5783_080de736","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":32},"in_reply_to":"7f515b1d_344bbc2b","updated":"2017-10-10 01:21:38.000000000","message":"Done","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"3eb6f56c0139cd06017b49c136ca8c02afd65d93","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":73,"context_line":"   - Logged data can be store at anywhere by using ``local_output_log_base`` option."},{"line_number":74,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"},{"line_number":75,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f4e5783_e8116b55","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":29},"in_reply_to":"7f515b1d_5442b810","updated":"2017-10-10 01:21:38.000000000","message":"Done","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"496f3031324ada44140586bcb9aed54d2fbe0541","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Operator workflow"},{"line_number":98,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#. Confirm supported logging resources:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   .. code-block:: console"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f515b1d_740b74d4","line":100,"range":{"start_line":100,"start_character":3,"end_line":100,"end_character":39},"updated":"2017-10-09 17:09:53.000000000","message":"Confirm logging resources are supported:","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"3eb6f56c0139cd06017b49c136ca8c02afd65d93","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Operator workflow"},{"line_number":98,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#. Confirm supported logging resources:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   .. code-block:: console"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f4e5783_6827bbb8","line":100,"range":{"start_line":100,"start_character":3,"end_line":100,"end_character":39},"in_reply_to":"7f515b1d_740b74d4","updated":"2017-10-10 01:21:38.000000000","message":"Done","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"496f3031324ada44140586bcb9aed54d2fbe0541","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":".. note::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"   The ``enable`` field is enabled by default. If enabled,"},{"line_number":139,"context_line":"   log information is written to the destination if configured in"},{"line_number":140,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f515b1d_54de383e","line":138,"range":{"start_line":138,"start_character":27,"end_line":138,"end_character":34},"updated":"2017-10-09 17:09:53.000000000","message":"IMO, the following would be nicer:\n\nset to ``True``","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"3eb6f56c0139cd06017b49c136ca8c02afd65d93","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":".. note::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"   The ``enable`` field is enabled by default. If enabled,"},{"line_number":139,"context_line":"   log information is written to the destination if configured in"},{"line_number":140,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f4e5783_482cff98","line":138,"range":{"start_line":138,"start_character":27,"end_line":138,"end_character":34},"in_reply_to":"7f515b1d_54de383e","updated":"2017-10-10 01:21:38.000000000","message":"Done","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"496f3031324ada44140586bcb9aed54d2fbe0541","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* Log an ``ACCEPT`` event: An ``ACCEPT`` security event will be generated for each"},{"line_number":186,"context_line":"  **NEW** incoming or outgoing session that is allowed by the ports security group."},{"line_number":187,"context_line":"  Detail for the events as follow:"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  * North/South ``ACCEPT``: For a North/South session there would be single ``ACCEPT``"},{"line_number":190,"context_line":"    event irrespective of direction."}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f515b1d_6f05dd0f","line":187,"range":{"start_line":187,"start_character":2,"end_line":187,"end_character":33},"updated":"2017-10-09 17:09:53.000000000","message":"More details for the events follow below:","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"3eb6f56c0139cd06017b49c136ca8c02afd65d93","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"* Log an ``ACCEPT`` event: An ``ACCEPT`` security event will be generated for each"},{"line_number":186,"context_line":"  **NEW** incoming or outgoing session that is allowed by the ports security group."},{"line_number":187,"context_line":"  Detail for the events as follow:"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  * North/South ``ACCEPT``: For a North/South session there would be single ``ACCEPT``"},{"line_number":190,"context_line":"    event irrespective of direction."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f4e5783_c837cfe3","line":187,"range":{"start_line":187,"start_character":2,"end_line":187,"end_character":33},"in_reply_to":"7f515b1d_6f05dd0f","updated":"2017-10-10 01:21:38.000000000","message":"Done","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"496f3031324ada44140586bcb9aed54d2fbe0541","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  **NEW** incoming or outgoing session that is allowed by the ports security group."},{"line_number":187,"context_line":"  Detail for the events as follow:"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  * North/South ``ACCEPT``: For a North/South session there would be single ``ACCEPT``"},{"line_number":190,"context_line":"    event irrespective of direction."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"  * East/West ``ACCEPT``/``ACCEPT``: In an intra-project East/West session where the"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f515b1d_0f10a94d","line":189,"range":{"start_line":189,"start_character":69,"end_line":189,"end_character":75},"updated":"2017-10-09 17:09:53.000000000","message":"a single","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"3eb6f56c0139cd06017b49c136ca8c02afd65d93","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  **NEW** incoming or outgoing session that is allowed by the ports security group."},{"line_number":187,"context_line":"  Detail for the events as follow:"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  * North/South ``ACCEPT``: For a North/South session there would be single ``ACCEPT``"},{"line_number":190,"context_line":"    event irrespective of direction."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"  * East/West ``ACCEPT``/``ACCEPT``: In an intra-project East/West session where the"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f4e5783_8831d7ef","line":189,"range":{"start_line":189,"start_character":69,"end_line":189,"end_character":75},"in_reply_to":"7f515b1d_0f10a94d","updated":"2017-10-10 01:21:38.000000000","message":"Done","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"496f3031324ada44140586bcb9aed54d2fbe0541","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"* The status of the flow ``ACCEPT``/``DROP``."},{"line_number":208,"context_line":"* An indication of the originator of the flow, e.g which project or log resource"},{"line_number":209,"context_line":"  the event is generated."},{"line_number":210,"context_line":"* The timestamp of the flow."},{"line_number":211,"context_line":"* An identifier of the associated virtual machine interface (neutron port id)."},{"line_number":212,"context_line":"* An identifier of the matching security group rule."}],"source_content_type":"text/x-rst","patch_set":14,"id":"7f515b1d_0f3e69b7","line":209,"range":{"start_line":209,"start_character":2,"end_line":209,"end_character":24},"updated":"2017-10-09 17:09:53.000000000","message":"generated the event.","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"3eb6f56c0139cd06017b49c136ca8c02afd65d93","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"* The status of the flow ``ACCEPT``/``DROP``."},{"line_number":208,"context_line":"* An indication of the originator of the flow, e.g which project or log resource"},{"line_number":209,"context_line":"  the event is generated."},{"line_number":210,"context_line":"* The timestamp of the flow."},{"line_number":211,"context_line":"* An identifier of the associated virtual machine interface (neutron port id)."},{"line_number":212,"context_line":"* An identifier of the matching security group rule."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f4e5783_a8493361","line":209,"range":{"start_line":209,"start_character":2,"end_line":209,"end_character":24},"in_reply_to":"7f515b1d_0f3e69b7","updated":"2017-10-10 01:21:38.000000000","message":"Done","commit_id":"83e2f5693a74da3a91828d6976b1ea8a3d9783be"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"487b0aac9bbf32fe6dc28e5636b2b9727bb60a06","unresolved":false,"context_lines":[{"line_number":63,"context_line":"       .. code-block:: ini"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"         [network_log]"},{"line_number":66,"context_line":"         rate_limit \u003d 100"},{"line_number":67,"context_line":"         burst_limit \u003d 25"},{"line_number":68,"context_line":"         #local_output_log_base \u003d \u003cNone\u003e"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f4e5783_b83f21d5","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":40},"updated":"2017-10-10 22:48:48.000000000","message":"I am sorry, I should have noted this before. I think we want to explain what these parameters are for. As far as I know, there is no other place where this might be explained and it is not self evident what they are for","commit_id":"7040f4bf781e71659ae3153666ce8c140d45be50"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"ee9ece950be3e1e7611daaf66302ff43d1466b00","unresolved":false,"context_lines":[{"line_number":63,"context_line":"       .. code-block:: ini"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"         [network_log]"},{"line_number":66,"context_line":"         rate_limit \u003d 100"},{"line_number":67,"context_line":"         burst_limit \u003d 25"},{"line_number":68,"context_line":"         #local_output_log_base \u003d \u003cNone\u003e"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":".. note::"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f4e5783_35f0d7c9","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":40},"in_reply_to":"5f4e5783_b83f21d5","updated":"2017-10-11 02:06:14.000000000","message":"Yes. I will add explainaton for these parameters.","commit_id":"7040f4bf781e71659ae3153666ce8c140d45be50"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f3aa1cdcce16b95293e0441b97f7060bfa2ac204","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":".. note::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"   The ``enable`` field is set to ``True`` by default. If enabled,"},{"line_number":139,"context_line":"   log information is written to the destination if configured in"},{"line_number":140,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f4e5783_f1add331","line":138,"range":{"start_line":138,"start_character":55,"end_line":138,"end_character":66},"updated":"2017-10-10 08:14:10.000000000","message":"[Nit] If it is set to ``True``","commit_id":"7040f4bf781e71659ae3153666ce8c140d45be50"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"81e0627aa04ce54677ecc501febaf9e84a315133","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":".. note::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"   The ``enable`` field is set to ``True`` by default. If enabled,"},{"line_number":139,"context_line":"   log information is written to the destination if configured in"},{"line_number":140,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f4e5783_3ebc3904","line":138,"range":{"start_line":138,"start_character":55,"end_line":138,"end_character":66},"in_reply_to":"5f4e5783_382b3195","updated":"2017-10-10 23:56:49.000000000","message":"Thanks Miguel.  So, Hoang, please keep it on.","commit_id":"7040f4bf781e71659ae3153666ce8c140d45be50"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"487b0aac9bbf32fe6dc28e5636b2b9727bb60a06","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":".. note::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"   The ``enable`` field is set to ``True`` by default. If enabled,"},{"line_number":139,"context_line":"   log information is written to the destination if configured in"},{"line_number":140,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f4e5783_382b3195","line":138,"range":{"start_line":138,"start_character":55,"end_line":138,"end_character":66},"in_reply_to":"5f4e5783_64091fdc","updated":"2017-10-10 22:48:48.000000000","message":"In my opinion, this is fine. No need to update","commit_id":"7040f4bf781e71659ae3153666ce8c140d45be50"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"d5f2474e193973ef4942413f839683429e92d50b","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":".. note::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"   The ``enable`` field is set to ``True`` by default. If enabled,"},{"line_number":139,"context_line":"   log information is written to the destination if configured in"},{"line_number":140,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f4e5783_64091fdc","line":138,"range":{"start_line":138,"start_character":55,"end_line":138,"end_character":66},"in_reply_to":"5f4e5783_f1add331","updated":"2017-10-10 08:25:04.000000000","message":"Yeah. But I think both have the same meaning. I mean \"enabled\" \u003d \"it is set to ``True``\".\n\nDo I need to update for it?","commit_id":"7040f4bf781e71659ae3153666ce8c140d45be50"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Logging is designed as a service plug-in that captures events for"},{"line_number":8,"context_line":"relevant resources (for example, security groups or firewalls) when they occur."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Details about the DB models, API extension, how it is implemented and use cases"},{"line_number":11,"context_line":"are out of the scope of this guide but can be found in the specification."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. seealso:: `Neutron logging specification \u003chttps://specs.openstack.org/openstack/neutron-specs/specs/pike/logging-API-for-security-group-rules.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_ff62ca15","line":10,"updated":"2017-11-01 22:09:23.000000000","message":"I don\u0027t think we mention any of that in any other places, maybe makes sense to just drop the notion of internals and spec link...","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Logging is designed as a service plug-in that captures events for"},{"line_number":8,"context_line":"relevant resources (for example, security groups or firewalls) when they occur."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Details about the DB models, API extension, how it is implemented and use cases"},{"line_number":11,"context_line":"are out of the scope of this guide but can be found in the specification."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. seealso:: `Neutron logging specification \u003chttps://specs.openstack.org/openstack/neutron-specs/specs/pike/logging-API-for-security-group-rules.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_b3e92981","line":10,"in_reply_to":"3f4b6375_ff62ca15","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Supported logging resource types"},{"line_number":17,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Any ML2 mechanism driver can claim to support logging types by providing"},{"line_number":20,"context_line":"a driver class property called ``supported_logging_types`` that returns a list"},{"line_number":21,"context_line":"of strings that corresponds to logging resource types."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_9f6f56fb","line":19,"updated":"2017-11-01 22:09:23.000000000","message":"This is really implementation internals that have no place in admin guide. It may go to devref though.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Supported logging resource types"},{"line_number":17,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Any ML2 mechanism driver can claim to support logging types by providing"},{"line_number":20,"context_line":"a driver class property called ``supported_logging_types`` that returns a list"},{"line_number":21,"context_line":"of strings that corresponds to logging resource types."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_3392d9f7","line":19,"in_reply_to":"3f4b6375_9f6f56fb","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#.  On compute nodes:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    #. In ``/etc/neutron/plugins/ml2/ml2_conf.ini``, add ``log`` to the"},{"line_number":53,"context_line":"       ``extensions`` setting in the ``[agent]`` section. For example:"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"       .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_9f487687","line":52,"updated":"2017-11-01 22:09:23.000000000","message":"compute nodes don\u0027t run neutron-server, and it\u0027s the only service that is supposed to read ml2_conf.ini (yeah I know that devstack loads the file into agents but that\u0027s wrong; instead, one should use openvswitch_agent.ini or linuxbridge_agent.ini).","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#.  On compute nodes:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    #. In ``/etc/neutron/plugins/ml2/ml2_conf.ini``, add ``log`` to the"},{"line_number":53,"context_line":"       ``extensions`` setting in the ``[agent]`` section. For example:"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"       .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_b345a972","line":52,"in_reply_to":"3f4b6375_9f487687","updated":"2017-11-02 02:39:13.000000000","message":"Thanks for your updating the correct info.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":57,"context_line":"          [agent]"},{"line_number":58,"context_line":"          extensions \u003d log"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    #. In ``/etc/neutron/plugins/ml2/ml2_conf.ini``, add configuration options"},{"line_number":61,"context_line":"       for logging feature in the ``[network_log]`` section. For example:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"       .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_9f3d16df","line":60,"updated":"2017-11-01 22:09:23.000000000","message":"ditto, probably belongs to compute nodes and hence into agent config file?","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"          [agent]"},{"line_number":58,"context_line":"          extensions \u003d log"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    #. In ``/etc/neutron/plugins/ml2/ml2_conf.ini``, add configuration options"},{"line_number":61,"context_line":"       for logging feature in the ``[network_log]`` section. For example:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"       .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_535af54f","line":60,"in_reply_to":"3f4b6375_9f3d16df","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":70,"context_line":"       In which, ``rate_limit`` is used to configure the maximum number of packets"},{"line_number":71,"context_line":"       to be logged per second (packets per second). When a high rate triggers"},{"line_number":72,"context_line":"       ``rate_limit``, logging queues packets to be logged. ``burst_limit`` is used"},{"line_number":73,"context_line":"       to configure the maximum of queued  packets. And logged data can be stored"},{"line_number":74,"context_line":"       anywhere by using ``local_output_log_base``."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_5f1f9e6f","line":73,"range":{"start_line":73,"start_character":41,"end_line":73,"end_character":43},"updated":"2017-11-01 22:09:23.000000000","message":"redundant space","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"       In which, ``rate_limit`` is used to configure the maximum number of packets"},{"line_number":71,"context_line":"       to be logged per second (packets per second). When a high rate triggers"},{"line_number":72,"context_line":"       ``rate_limit``, logging queues packets to be logged. ``burst_limit`` is used"},{"line_number":73,"context_line":"       to configure the maximum of queued  packets. And logged data can be stored"},{"line_number":74,"context_line":"       anywhere by using ``local_output_log_base``."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_d3338512","line":73,"range":{"start_line":73,"start_character":41,"end_line":73,"end_character":43},"in_reply_to":"3f4b6375_5f1f9e6f","updated":"2017-11-02 02:39:13.000000000","message":"wow.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"a3599992702f630c7dce5878aaabb99cbb9a5d40","unresolved":false,"context_lines":[{"line_number":71,"context_line":"       to be logged per second (packets per second). When a high rate triggers"},{"line_number":72,"context_line":"       ``rate_limit``, logging queues packets to be logged. ``burst_limit`` is used"},{"line_number":73,"context_line":"       to configure the maximum of queued  packets. And logged data can be stored"},{"line_number":74,"context_line":"       anywhere by using ``local_output_log_base``."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":".. note::"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f4e5783_3e140f4e","line":74,"range":{"start_line":74,"start_character":7,"end_line":74,"end_character":51},"updated":"2017-10-12 04:37:47.000000000","message":"Maybe it need more clear as \"a local file is specified by ``local_output_log_base``\". What about you?","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"2d34a41c17d8af596607ff81975276e891baacd7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"       to be logged per second (packets per second). When a high rate triggers"},{"line_number":72,"context_line":"       ``rate_limit``, logging queues packets to be logged. ``burst_limit`` is used"},{"line_number":73,"context_line":"       to configure the maximum of queued  packets. And logged data can be stored"},{"line_number":74,"context_line":"       anywhere by using ``local_output_log_base``."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":".. note::"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f4e5783_f5ae92e5","line":74,"range":{"start_line":74,"start_character":7,"end_line":74,"end_character":51},"in_reply_to":"5f4e5783_3e140f4e","updated":"2017-10-12 08:09:44.000000000","message":"I think the option name clears its meaning.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"c7359a5a573b5dcdacb628da591ac86a08ec0525","unresolved":false,"context_lines":[{"line_number":71,"context_line":"       to be logged per second (packets per second). When a high rate triggers"},{"line_number":72,"context_line":"       ``rate_limit``, logging queues packets to be logged. ``burst_limit`` is used"},{"line_number":73,"context_line":"       to configure the maximum of queued  packets. And logged data can be stored"},{"line_number":74,"context_line":"       anywhere by using ``local_output_log_base``."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":".. note::"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f4e5783_7e225e54","line":74,"range":{"start_line":74,"start_character":7,"end_line":74,"end_character":51},"in_reply_to":"5f4e5783_f5ae92e5","updated":"2017-10-13 08:43:33.000000000","message":"Ah, OK!","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":".. note::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":79,"context_line":"   - It requires at least 100 for ``rate_limit`` and at least 25 for ``burst_limit``."},{"line_number":80,"context_line":"   - If ``rate_limit`` is set to ``None``, logging will log unlimited."},{"line_number":81,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_ff19aa87","line":78,"range":{"start_line":78,"start_character":34,"end_line":78,"end_character":67},"updated":"2017-11-01 22:09:23.000000000","message":"-\u003e ``openvswitch`` firewall driver","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":".. note::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":79,"context_line":"   - It requires at least 100 for ``rate_limit`` and at least 25 for ``burst_limit``."},{"line_number":80,"context_line":"   - If ``rate_limit`` is set to ``None``, logging will log unlimited."},{"line_number":81,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_b33a49e4","line":78,"range":{"start_line":78,"start_character":34,"end_line":78,"end_character":67},"in_reply_to":"3f4b6375_ff19aa87","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":79,"context_line":"   - It requires at least 100 for ``rate_limit`` and at least 25 for ``burst_limit``."},{"line_number":80,"context_line":"   - If ``rate_limit`` is set to ``None``, logging will log unlimited."},{"line_number":81,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"},{"line_number":82,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_1f02460c","line":80,"range":{"start_line":80,"start_character":35,"end_line":80,"end_character":39},"updated":"2017-11-01 22:09:23.000000000","message":"You mean, \u0027unset\u0027? Because if I set it to None, it will trigger an error loading the value into oslo.config because it\u0027s not integer but string.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"   - Logging currently works with openvswitch firewall based driver only."},{"line_number":79,"context_line":"   - It requires at least 100 for ``rate_limit`` and at least 25 for ``burst_limit``."},{"line_number":80,"context_line":"   - If ``rate_limit`` is set to ``None``, logging will log unlimited."},{"line_number":81,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"},{"line_number":82,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_531f956f","line":80,"range":{"start_line":80,"start_character":35,"end_line":80,"end_character":39},"in_reply_to":"3f4b6375_1f02460c","updated":"2017-11-02 02:39:13.000000000","message":"Yes. \u0027unset\u0027 is what I mean. I will update this point.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":79,"context_line":"   - It requires at least 100 for ``rate_limit`` and at least 25 for ``burst_limit``."},{"line_number":80,"context_line":"   - If ``rate_limit`` is set to ``None``, logging will log unlimited."},{"line_number":81,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"},{"line_number":82,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Trusted projects policy.json configuration"},{"line_number":85,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_e2011106","line":82,"range":{"start_line":82,"start_character":5,"end_line":82,"end_character":7},"updated":"2017-11-01 22:09:23.000000000","message":"in","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":79,"context_line":"   - It requires at least 100 for ``rate_limit`` and at least 25 for ``burst_limit``."},{"line_number":80,"context_line":"   - If ``rate_limit`` is set to ``None``, logging will log unlimited."},{"line_number":81,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"},{"line_number":82,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Trusted projects policy.json configuration"},{"line_number":85,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_82125d57","line":82,"range":{"start_line":82,"start_character":19,"end_line":82,"end_character":30},"updated":"2017-11-01 22:09:23.000000000","message":"the fact that syslog messages are written in a file on your system is really implementation / configuration details of your syslog. It may as well write to a remote server. Please remove the notion of a file. Instead just say that logged data is stored in system journal.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"   - It requires at least 100 for ``rate_limit`` and at least 25 for ``burst_limit``."},{"line_number":80,"context_line":"   - If ``rate_limit`` is set to ``None``, logging will log unlimited."},{"line_number":81,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"},{"line_number":82,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Trusted projects policy.json configuration"},{"line_number":85,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_eefe9a03","line":82,"range":{"start_line":82,"start_character":19,"end_line":82,"end_character":30},"in_reply_to":"3f4b6375_82125d57","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"   - It requires at least 100 for ``rate_limit`` and at least 25 for ``burst_limit``."},{"line_number":80,"context_line":"   - If ``rate_limit`` is set to ``None``, logging will log unlimited."},{"line_number":81,"context_line":"   - If we don\u0027t specify ``local_output_log_base``, logged data will be stored"},{"line_number":82,"context_line":"     at journal or syslog file like ``/var/log/syslog``."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Trusted projects policy.json configuration"},{"line_number":85,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_ce019e06","line":82,"range":{"start_line":82,"start_character":5,"end_line":82,"end_character":7},"in_reply_to":"3f4b6375_e2011106","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":87,"context_line":"With the default ``/etc/neutron/policy.json``, administrators must"},{"line_number":88,"context_line":"set up resource logging on behalf of the cloud projects."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"If projects are trusted to administrate their own resource logging in your cloud,"},{"line_number":91,"context_line":"neutron\u0027s file ``policy.json`` can be modified to allow this."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Modify ``/etc/neutron/policy.json`` policy entries as follows:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_421c6569","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":39},"updated":"2017-11-01 22:09:23.000000000","message":"administer","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"With the default ``/etc/neutron/policy.json``, administrators must"},{"line_number":88,"context_line":"set up resource logging on behalf of the cloud projects."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"If projects are trusted to administrate their own resource logging in your cloud,"},{"line_number":91,"context_line":"neutron\u0027s file ``policy.json`` can be modified to allow this."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Modify ``/etc/neutron/policy.json`` policy entries as follows:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_8e0ba622","line":90,"range":{"start_line":90,"start_character":26,"end_line":90,"end_character":39},"in_reply_to":"3f4b6375_421c6569","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":".. note::"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   The ``enable`` field is set to ``True`` by default. If enabled,"},{"line_number":146,"context_line":"   log information is written to the destination if configured in"},{"line_number":147,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_423585d9","line":145,"range":{"start_line":145,"start_character":9,"end_line":145,"end_character":16},"updated":"2017-11-01 22:09:23.000000000","message":"you refer to it as ``enable`` but above it says ``Enabled``. It may confuse the reader.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":".. note::"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   The ``enable`` field is set to ``True`` by default. If enabled,"},{"line_number":146,"context_line":"   log information is written to the destination if configured in"},{"line_number":147,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_8e24c6b0","line":145,"range":{"start_line":145,"start_character":9,"end_line":145,"end_character":16},"in_reply_to":"3f4b6375_423585d9","updated":"2017-11-02 02:39:13.000000000","message":"Right. ``enable`` *option* in CLI and ``Enabled`` *field* in table showed. I will update.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   The ``enable`` field is set to ``True`` by default. If enabled,"},{"line_number":146,"context_line":"   log information is written to the destination if configured in"},{"line_number":147,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Enable/Disable log"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_024d4d71","line":147,"range":{"start_line":147,"start_character":33,"end_line":147,"end_character":50},"updated":"2017-11-01 22:09:23.000000000","message":"ditto for syslog *file*","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   The ``enable`` field is set to ``True`` by default. If enabled,"},{"line_number":146,"context_line":"   log information is written to the destination if configured in"},{"line_number":147,"context_line":"   ``local_output_log_base`` or to the syslog file like ``/var/log/syslog``."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Enable/Disable log"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_4e36cee9","line":147,"range":{"start_line":147,"start_character":33,"end_line":147,"end_character":50},"in_reply_to":"3f4b6375_024d4d71","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"a3599992702f630c7dce5878aaabb99cbb9a5d40","unresolved":false,"context_lines":[{"line_number":185,"context_line":"with the following general characteristics:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* Log every ``DROP`` event: Every ``DROP`` security event will be generated when"},{"line_number":188,"context_line":"  an incoming or outgoing session is dropped, that is the new session is"},{"line_number":189,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":190,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f4e5783_612b0882","line":188,"range":{"start_line":188,"start_character":58,"end_line":188,"end_character":61},"updated":"2017-10-12 04:37:47.000000000","message":"consider remove it.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b269e5e934513efc40955920359de1268e118cc3","unresolved":false,"context_lines":[{"line_number":185,"context_line":"with the following general characteristics:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* Log every ``DROP`` event: Every ``DROP`` security event will be generated when"},{"line_number":188,"context_line":"  an incoming or outgoing session is dropped, that is the new session is"},{"line_number":189,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":190,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f4e5783_abbbf66f","line":188,"range":{"start_line":188,"start_character":58,"end_line":188,"end_character":61},"in_reply_to":"5f4e5783_2bef06b1","updated":"2017-10-13 08:26:28.000000000","message":"Sorry. But I\u0027m confusing about that. Do you mean a existing dropping\u0027s session will be still logged?","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"ef7fa4c8bd464e96c27e1a775993b1204b44471d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"with the following general characteristics:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* Log every ``DROP`` event: Every ``DROP`` security event will be generated when"},{"line_number":188,"context_line":"  an incoming or outgoing session is dropped, that is the new session is"},{"line_number":189,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":190,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f4e5783_2bef06b1","line":188,"range":{"start_line":188,"start_character":58,"end_line":188,"end_character":61},"in_reply_to":"5f4e5783_612b0882","updated":"2017-10-13 08:18:42.000000000","message":"I think there is no problem to keep or remove it.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"434527d3cb9538aae4e5c3558060456272bf026c","unresolved":false,"context_lines":[{"line_number":185,"context_line":"with the following general characteristics:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* Log every ``DROP`` event: Every ``DROP`` security event will be generated when"},{"line_number":188,"context_line":"  an incoming or outgoing session is dropped, that is the new session is"},{"line_number":189,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":190,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f4e5783_de0832da","line":188,"range":{"start_line":188,"start_character":58,"end_line":188,"end_character":61},"in_reply_to":"5f4e5783_abbbf66f","updated":"2017-10-13 08:42:22.000000000","message":"Any session is logically non-compliant with security group posture that can be considered as *new* session or ** session.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"2a918975aafdfb84194c1f78b3b8cc71eccab5b3","unresolved":false,"context_lines":[{"line_number":185,"context_line":"with the following general characteristics:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* Log every ``DROP`` event: Every ``DROP`` security event will be generated when"},{"line_number":188,"context_line":"  an incoming or outgoing session is dropped, that is the new session is"},{"line_number":189,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":190,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f4e5783_be84560d","line":188,"range":{"start_line":188,"start_character":58,"end_line":188,"end_character":61},"in_reply_to":"5f4e5783_de0832da","updated":"2017-10-13 08:46:14.000000000","message":"If so. I\u0027m OK. Thanks for your explanation.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":187,"context_line":"* Log every ``DROP`` event: Every ``DROP`` security event will be generated when"},{"line_number":188,"context_line":"  an incoming or outgoing session is dropped, that is the new session is"},{"line_number":189,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":190,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"* Log an ``ACCEPT`` event: An ``ACCEPT`` security event will be generated for each"},{"line_number":193,"context_line":"  **NEW** incoming or outgoing session that is allowed by the ports security group."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_c26f35c3","line":190,"updated":"2017-11-01 22:09:23.000000000","message":"wow that\u0027s a lot of smart words :) consider simplifying, f.e.:\n\n... that is the new session is not allowed for the security group and because of that blocked.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":187,"context_line":"* Log every ``DROP`` event: Every ``DROP`` security event will be generated when"},{"line_number":188,"context_line":"  an incoming or outgoing session is dropped, that is the new session is"},{"line_number":189,"context_line":"  logically non-compliant with the security posture resulting from the security"},{"line_number":190,"context_line":"  groups applied to the Neutron port and the session is therefore blocked."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"* Log an ``ACCEPT`` event: An ``ACCEPT`` security event will be generated for each"},{"line_number":193,"context_line":"  **NEW** incoming or outgoing session that is allowed by the ports security group."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_8e596636","line":190,"in_reply_to":"3f4b6375_c26f35c3","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"General data requirements: The security event should include:"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"* The status of the flow ``ACCEPT``/``DROP``."},{"line_number":215,"context_line":"* An indication of the originator of the flow, e.g which project or log resource"},{"line_number":216,"context_line":"  generated the event."},{"line_number":217,"context_line":"* The timestamp of the flow."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_225e0912","line":214,"updated":"2017-11-01 22:09:23.000000000","message":"in the list below, sometimes you use \u0027A(n) article, sometimes \u0027The\u0027. Consider using same for all entries.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"General data requirements: The security event should include:"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"* The status of the flow ``ACCEPT``/``DROP``."},{"line_number":215,"context_line":"* An indication of the originator of the flow, e.g which project or log resource"},{"line_number":216,"context_line":"  generated the event."},{"line_number":217,"context_line":"* The timestamp of the flow."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_6e974a92","line":214,"in_reply_to":"3f4b6375_225e0912","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":215,"context_line":"* An indication of the originator of the flow, e.g which project or log resource"},{"line_number":216,"context_line":"  generated the event."},{"line_number":217,"context_line":"* The timestamp of the flow."},{"line_number":218,"context_line":"* An identifier of the associated virtual machine interface (neutron port id)."},{"line_number":219,"context_line":"* An identifier of the matching security group rule."},{"line_number":220,"context_line":"* The layer 3 and 4 information (address, port, protocol, etc)."},{"line_number":221,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_029b0dc9","line":218,"range":{"start_line":218,"start_character":34,"end_line":218,"end_character":50},"updated":"2017-11-01 22:09:23.000000000","message":"instance","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":215,"context_line":"* An indication of the originator of the flow, e.g which project or log resource"},{"line_number":216,"context_line":"  generated the event."},{"line_number":217,"context_line":"* The timestamp of the flow."},{"line_number":218,"context_line":"* An identifier of the associated virtual machine interface (neutron port id)."},{"line_number":219,"context_line":"* An identifier of the matching security group rule."},{"line_number":220,"context_line":"* The layer 3 and 4 information (address, port, protocol, etc)."},{"line_number":221,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_0e8c567d","line":218,"range":{"start_line":218,"start_character":34,"end_line":218,"end_character":50},"in_reply_to":"3f4b6375_029b0dc9","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":241,"context_line":"      TCPOptionNoOperation(kind\u003d1,length\u003d1), TCPOptionWindowScale(kind\u003d3,length\u003d3,shift_cnt\u003d3)],"},{"line_number":242,"context_line":"      seq\u003d3284890090,src_port\u003d47825,urgent\u003d0,window_size\u003d14600)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  * Logged data of an ``DROP`` event:"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"  .. code-block:: console"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_82aedde4","line":244,"range":{"start_line":244,"start_character":19,"end_line":244,"end_character":21},"updated":"2017-11-01 22:09:23.000000000","message":"a","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":241,"context_line":"      TCPOptionNoOperation(kind\u003d1,length\u003d1), TCPOptionWindowScale(kind\u003d3,length\u003d3,shift_cnt\u003d3)],"},{"line_number":242,"context_line":"      seq\u003d3284890090,src_port\u003d47825,urgent\u003d0,window_size\u003d14600)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  * Logged data of an ``DROP`` event:"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"  .. code-block:: console"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_2e54b2c9","line":244,"range":{"start_line":244,"start_character":19,"end_line":244,"end_character":21},"in_reply_to":"3f4b6375_82aedde4","updated":"2017-11-02 02:39:13.000000000","message":"Done","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"* Consuming logs: At the moment, consuming logs is out of scope in Neutron perspective."},{"line_number":259,"context_line":"  But there are several ways to consume the collected log."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"  * A Request/Reply HTTP API directed at Neutron. In this case it"},{"line_number":262,"context_line":"    must be possible to easily request non-overlapping log segments"},{"line_number":263,"context_line":"    where no events are missed."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  * Third party services like Monasca."},{"line_number":266,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_8297fd90","line":263,"range":{"start_line":260,"start_character":0,"end_line":263,"end_character":31},"updated":"2017-11-01 22:09:23.000000000","message":"is it implemented, or it\u0027s vaporware? because if it\u0027s implemented, we need to document it somewhere above, where we describe other API commands. But if it\u0027s not existing, then I think this section should be removed. Which is it?","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"* Consuming logs: At the moment, consuming logs is out of scope in Neutron perspective."},{"line_number":259,"context_line":"  But there are several ways to consume the collected log."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"  * A Request/Reply HTTP API directed at Neutron. In this case it"},{"line_number":262,"context_line":"    must be possible to easily request non-overlapping log segments"},{"line_number":263,"context_line":"    where no events are missed."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  * Third party services like Monasca."},{"line_number":266,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_ce62bead","line":263,"range":{"start_line":260,"start_character":0,"end_line":263,"end_character":31},"in_reply_to":"3f4b6375_8297fd90","updated":"2017-11-02 02:39:13.000000000","message":"It is vaporware.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"32c8f590ccdeb4cb2eda572508a9684ae6d079fa","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    must be possible to easily request non-overlapping log segments"},{"line_number":263,"context_line":"    where no events are missed."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  * Third party services like Monasca."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  * A pub/sub subscription mechanism, e.g. Kafka."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  * A file based mechanism to transfer security events in bulk."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_02d2ed5c","line":269,"range":{"start_line":265,"start_character":2,"end_line":269,"end_character":63},"updated":"2017-11-01 22:09:23.000000000","message":"Seems like you give random ideas to administrators on how to get their hands on the log messages. I am not sure it\u0027s very helpful. It should be enough to describe where to get the files (I think it\u0027s already captured above), then admin will decide for themselves which tools they will use to fetch / parse / process the resulting logs. It\u0027s out of scope for the Neutron guide.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"bf226186a7f51e72d6456fcbd403c1367c39095f","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    must be possible to easily request non-overlapping log segments"},{"line_number":263,"context_line":"    where no events are missed."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  * Third party services like Monasca."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  * A pub/sub subscription mechanism, e.g. Kafka."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  * A file based mechanism to transfer security events in bulk."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_6ef86ac3","line":269,"range":{"start_line":265,"start_character":2,"end_line":269,"end_character":63},"in_reply_to":"3f4b6375_02d2ed5c","updated":"2017-11-02 02:39:13.000000000","message":"Indeed!\nInitial, I though the same thing but i wasn\u0027t sure about if it is needed. After your review, I will drop this section and let\u0027s admin decide which tools they prefer by themselves.","commit_id":"0b4b7bdbf9f7f9e90ea6ed1551e1764c8994140b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"22d049cce965109b4f93560012c4dcda46a9600c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"         [agent]"},{"line_number":37,"context_line":"         extensions \u003d log"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#.  On compute nodes:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    #. In ``/etc/neutron/plugins/ml2/openvswitch_agent.ini``, add ``log``"},{"line_number":42,"context_line":"       to the ``extensions`` setting in the ``[agent]`` section. For example:"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_b4eb4576","line":39,"updated":"2017-11-02 11:08:29.000000000","message":"nit: to be strict it should be done also on network nodes (those with L3 services), right?","commit_id":"7b5262f2c487f7c4d077a847738e363da03b12f6"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"71820d3f0b90af7eeb7c2d9e7ac3e6957db2b115","unresolved":false,"context_lines":[{"line_number":36,"context_line":"         [agent]"},{"line_number":37,"context_line":"         extensions \u003d log"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#.  On compute nodes:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    #. In ``/etc/neutron/plugins/ml2/openvswitch_agent.ini``, add ``log``"},{"line_number":42,"context_line":"       to the ``extensions`` setting in the ``[agent]`` section. For example:"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_4d234da8","line":39,"in_reply_to":"3f4b6375_128690ba","updated":"2017-11-03 05:16:13.000000000","message":"I think current version is OK. Let\u0027s wait feedback from Ihar.","commit_id":"7b5262f2c487f7c4d077a847738e363da03b12f6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"08067669efb6024a1d9d78b4c85552e115048feb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"         [agent]"},{"line_number":37,"context_line":"         extensions \u003d log"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#.  On compute nodes:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    #. In ``/etc/neutron/plugins/ml2/openvswitch_agent.ini``, add ``log``"},{"line_number":42,"context_line":"       to the ``extensions`` setting in the ``[agent]`` section. For example:"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_62d85352","line":39,"in_reply_to":"3f4b6375_4d234da8","updated":"2017-11-03 08:05:52.000000000","message":"@Cao: server side is not what I was thinking of. On controller node You have neutron-server (API) and that is mentioned in L22.\nOn network node You have typically L3 agent, so You need also L2 agent to be there. It should be probably the same config like on compute nodes so IMHO if You would change L39 to something like \"On compute/network nodes\" it would be better.","commit_id":"7b5262f2c487f7c4d077a847738e363da03b12f6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6a2fe8e2d48585d3aababec48afbe8c7a46e1ee1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"         [agent]"},{"line_number":37,"context_line":"         extensions \u003d log"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#.  On compute nodes:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    #. In ``/etc/neutron/plugins/ml2/openvswitch_agent.ini``, add ``log``"},{"line_number":42,"context_line":"       to the ``extensions`` setting in the ``[agent]`` section. For example:"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1f485f77_0ef46a5a","line":39,"in_reply_to":"3f4b6375_62d85352","updated":"2017-11-14 21:01:18.000000000","message":"Yeah, using compute/network nodes terminology is better.","commit_id":"7b5262f2c487f7c4d077a847738e363da03b12f6"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"b30bdf522debafbeba66392b940af40c851640af","unresolved":false,"context_lines":[{"line_number":36,"context_line":"         [agent]"},{"line_number":37,"context_line":"         extensions \u003d log"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#.  On compute nodes:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    #. In ``/etc/neutron/plugins/ml2/openvswitch_agent.ini``, add ``log``"},{"line_number":42,"context_line":"       to the ``extensions`` setting in the ``[agent]`` section. For example:"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_c1df0c64","line":39,"in_reply_to":"3f4b6375_b4eb4576","updated":"2017-11-03 01:19:12.000000000","message":"L22 mentioned what need to be done with server side.","commit_id":"7b5262f2c487f7c4d077a847738e363da03b12f6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"354b0d7b3148e2550cb5de7da2d141a4d2ccbb9c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"         [agent]"},{"line_number":37,"context_line":"         extensions \u003d log"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#.  On compute nodes:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    #. In ``/etc/neutron/plugins/ml2/openvswitch_agent.ini``, add ``log``"},{"line_number":42,"context_line":"       to the ``extensions`` setting in the ``[agent]`` section. For example:"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_128690ba","line":39,"in_reply_to":"3f4b6375_c1df0c64","updated":"2017-11-03 05:04:59.000000000","message":"How about aligning with representation?\n\n* Contoller node (which is running neutron-server)\n* Compute node\n* Network node","commit_id":"7b5262f2c487f7c4d077a847738e363da03b12f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fdd243877528f70af88fad1052a131a2ef45e022","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Logging is designed as a service plug-in that captures events for"},{"line_number":8,"context_line":"relevant resources (for example, security groups or firewalls) when they occur."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Supported logging resource types"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_6741c40b","line":8,"range":{"start_line":8,"start_character":48,"end_line":8,"end_character":61},"updated":"2017-12-24 16:27:48.000000000","message":"at now, firewall is not supported. It is mentioned in the next section though.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"648f2382ae37f0567871b75e3591ad10f39e5df3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Logging is designed as a service plug-in that captures events for"},{"line_number":8,"context_line":"relevant resources (for example, security groups or firewalls) when they occur."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Supported logging resource types"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_9ffd1d3c","line":8,"range":{"start_line":8,"start_character":48,"end_line":8,"end_character":61},"in_reply_to":"bf8cb3f7_444b532a","updated":"2017-12-26 18:18:35.000000000","message":"I would suggest to drop it. The title of this document says \"Logging for security groups\". I am okay with either. This is not a reason of my -1.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8959a50ed764b68695aea7a4bbdc80e2d7aefa8e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Logging is designed as a service plug-in that captures events for"},{"line_number":8,"context_line":"relevant resources (for example, security groups or firewalls) when they occur."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Supported logging resource types"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_444b532a","line":8,"range":{"start_line":8,"start_character":48,"end_line":8,"end_character":61},"in_reply_to":"bf8cb3f7_6741c40b","updated":"2017-12-26 01:30:53.000000000","message":"I don\u0027t understand what you mean here. It is just example and do we really need to drop it?","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7779840b8b302b70f280cd9ef7831f98c8b1e8bb","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      .. code-block:: none"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"         service_plugins \u003d router,metering,log"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   #. Add the Logging extension to the ``extensions`` setting in"},{"line_number":32,"context_line":"      ``/etc/neutron/plugins/ml2/ml2_conf.ini``. For example:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"df87a7cf_d7aca9ee","line":29,"range":{"start_line":29,"start_character":43,"end_line":29,"end_character":46},"updated":"2017-12-19 07:31:16.000000000","message":"This is actually \"logapi\" now[1].\n\n[1]: https://github.com/openstack/neutron/blob/master/setup.cfg#L85","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"49d074975157f32134013ba071f7d4dbe6a8c8a0","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      .. code-block:: none"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"         service_plugins \u003d router,metering,log"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   #. Add the Logging extension to the ``extensions`` setting in"},{"line_number":32,"context_line":"      ``/etc/neutron/plugins/ml2/ml2_conf.ini``. For example:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"df87a7cf_849b3615","line":29,"range":{"start_line":29,"start_character":43,"end_line":29,"end_character":46},"in_reply_to":"df87a7cf_d7aca9ee","updated":"2017-12-20 01:11:39.000000000","message":"This point has been fixed/updated.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"2a4375c6e1a43aa6c69d02e018fc9d7f92f675a2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      .. code-block:: none"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"         service_plugins \u003d router,metering,log"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   #. Add the Logging extension to the ``extensions`` setting in"},{"line_number":32,"context_line":"      ``/etc/neutron/plugins/ml2/ml2_conf.ini``. For example:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"df87a7cf_97c38157","line":29,"range":{"start_line":29,"start_character":43,"end_line":29,"end_character":46},"in_reply_to":"df87a7cf_d7aca9ee","updated":"2017-12-19 07:44:17.000000000","message":"This will be covered by https://review.openstack.org/#/c/528977/\n\n``log`` is our intention.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fdd243877528f70af88fad1052a131a2ef45e022","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"         service_plugins \u003d router,metering,log"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   #. Add the Logging extension to the ``extensions`` setting in"},{"line_number":32,"context_line":"      ``/etc/neutron/plugins/ml2/ml2_conf.ini``. For example:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"      .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_e754f4cc","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":61},"updated":"2017-12-24 16:27:48.000000000","message":"Could you add the section information [agent]?","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"648f2382ae37f0567871b75e3591ad10f39e5df3","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"         service_plugins \u003d router,metering,log"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   #. Add the Logging extension to the ``extensions`` setting in"},{"line_number":32,"context_line":"      ``/etc/neutron/plugins/ml2/ml2_conf.ini``. For example:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"      .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_5f9555e3","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":61},"in_reply_to":"bf8cb3f7_64469724","updated":"2017-12-26 18:18:35.000000000","message":"I mean you need to mention a section name too.\nIn my understanding, this \"extensions\" belongs to \"agent\" section. Different sections can have settings with a same name, so I believe a section name is important information.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8959a50ed764b68695aea7a4bbdc80e2d7aefa8e","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"         service_plugins \u003d router,metering,log"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   #. Add the Logging extension to the ``extensions`` setting in"},{"line_number":32,"context_line":"      ``/etc/neutron/plugins/ml2/ml2_conf.ini``. For example:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"      .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_64469724","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":61},"in_reply_to":"bf8cb3f7_e754f4cc","updated":"2017-12-26 01:30:53.000000000","message":"Please explain more about this. I don\u0027t get your point here.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c816d8420a144c4178dc6c60b06d9746749a4643","unresolved":false,"context_lines":[{"line_number":54,"context_line":"         [network_log]"},{"line_number":55,"context_line":"         rate_limit \u003d 100"},{"line_number":56,"context_line":"         burst_limit \u003d 25"},{"line_number":57,"context_line":"         #local_output_log_base \u003d \u003cNone\u003e"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"       In which, ``rate_limit`` is used to configure the maximum number of packets"},{"line_number":60,"context_line":"       to be logged per second (packets per second). When a high rate triggers"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_d8f0b5cc","line":57,"updated":"2017-12-23 15:12:55.000000000","message":"why this line is commented out?","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4139043aa1248e78fc60ed9c8e21d5641c7bdbe5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"         [network_log]"},{"line_number":55,"context_line":"         rate_limit \u003d 100"},{"line_number":56,"context_line":"         burst_limit \u003d 25"},{"line_number":57,"context_line":"         #local_output_log_base \u003d \u003cNone\u003e"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"       In which, ``rate_limit`` is used to configure the maximum number of packets"},{"line_number":60,"context_line":"       to be logged per second (packets per second). When a high rate triggers"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_d1763907","line":57,"in_reply_to":"bf8cb3f7_a45d7fea","updated":"2017-12-26 20:21:39.000000000","message":"I understand that but still I don\u0027t see a point to make it commented out. It\u0027s nit but IMHO it can be written without \"#\" and explained below that it is optional and what will happen if it\u0027s not specified","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8959a50ed764b68695aea7a4bbdc80e2d7aefa8e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"         [network_log]"},{"line_number":55,"context_line":"         rate_limit \u003d 100"},{"line_number":56,"context_line":"         burst_limit \u003d 25"},{"line_number":57,"context_line":"         #local_output_log_base \u003d \u003cNone\u003e"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"       In which, ``rate_limit`` is used to configure the maximum number of packets"},{"line_number":60,"context_line":"       to be logged per second (packets per second). When a high rate triggers"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_a45d7fea","line":57,"in_reply_to":"bf8cb3f7_d8f0b5cc","updated":"2017-12-26 01:30:53.000000000","message":"As you can see its description in following paragraph that logged data can be stored anywhere by using the option. If we don\u0027t specify, logged data will be stored in system journal like /var/log/syslog. And in this case, we don\u0027t specify it.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fdd243877528f70af88fad1052a131a2ef45e022","unresolved":false,"context_lines":[{"line_number":60,"context_line":"       to be logged per second (packets per second). When a high rate triggers"},{"line_number":61,"context_line":"       ``rate_limit``, logging queues packets to be logged. ``burst_limit`` is used"},{"line_number":62,"context_line":"       to configure the maximum of queued packets. And logged data can be stored"},{"line_number":63,"context_line":"       anywhere by using ``local_output_log_base``."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. note::"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_27741c68","line":63,"updated":"2017-12-24 16:27:48.000000000","message":"From the readability perspective, it is better to explain per item. It is easy to understand.\n\nIn addition, items except openvswitch firewall driver in the note below looks better to be merged into here.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8959a50ed764b68695aea7a4bbdc80e2d7aefa8e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"       to be logged per second (packets per second). When a high rate triggers"},{"line_number":61,"context_line":"       ``rate_limit``, logging queues packets to be logged. ``burst_limit`` is used"},{"line_number":62,"context_line":"       to configure the maximum of queued packets. And logged data can be stored"},{"line_number":63,"context_line":"       anywhere by using ``local_output_log_base``."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. note::"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_e40867da","line":63,"in_reply_to":"bf8cb3f7_27741c68","updated":"2017-12-26 01:30:53.000000000","message":"AFAIK, there is no rule to force committer style to core style. In this case, the content of them look fine to me (and at least with other cores too). I will update if the content make confuse to reader.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"648f2382ae37f0567871b75e3591ad10f39e5df3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"       to be logged per second (packets per second). When a high rate triggers"},{"line_number":61,"context_line":"       ``rate_limit``, logging queues packets to be logged. ``burst_limit`` is used"},{"line_number":62,"context_line":"       to configure the maximum of queued packets. And logged data can be stored"},{"line_number":63,"context_line":"       anywhere by using ``local_output_log_base``."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. note::"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_5f1a357d","line":63,"in_reply_to":"bf8cb3f7_e40867da","updated":"2017-12-26 18:18:35.000000000","message":"Regarding the first point, I am okay with either style.\n\nRegarding the second point, I would like to see the above and the below in one place. For example, L.69 describes useful information on values. I believe it is nice to note it above.\n\n(I don\u0027t want to block you on this point. I can send a follow-up patch if you would like to go as-is.)","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fdd243877528f70af88fad1052a131a2ef45e022","unresolved":false,"context_lines":[{"line_number":76,"context_line":"With the default ``/etc/neutron/policy.json``, administrators must"},{"line_number":77,"context_line":"set up resource logging on behalf of the cloud projects."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"If projects are trusted to administer their own resource logging in your cloud,"},{"line_number":80,"context_line":"neutron\u0027s file ``policy.json`` can be modified to allow this."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Modify ``/etc/neutron/policy.json`` policy entries as follows:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_476fe091","line":79,"range":{"start_line":79,"start_character":24,"end_line":79,"end_character":27},"updated":"2017-12-24 16:27:48.000000000","message":"to -\u003e by?","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8959a50ed764b68695aea7a4bbdc80e2d7aefa8e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"With the default ``/etc/neutron/policy.json``, administrators must"},{"line_number":77,"context_line":"set up resource logging on behalf of the cloud projects."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"If projects are trusted to administer their own resource logging in your cloud,"},{"line_number":80,"context_line":"neutron\u0027s file ``policy.json`` can be modified to allow this."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Modify ``/etc/neutron/policy.json`` policy entries as follows:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_641d370e","line":79,"range":{"start_line":79,"start_character":24,"end_line":79,"end_character":27},"in_reply_to":"bf8cb3f7_476fe091","updated":"2017-12-26 01:30:53.000000000","message":"I think ``to`` is correct in this case.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"15e9277cafda1258dc361fa5688644c4a0158f7e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"With the default ``/etc/neutron/policy.json``, administrators must"},{"line_number":77,"context_line":"set up resource logging on behalf of the cloud projects."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"If projects are trusted to administer their own resource logging in your cloud,"},{"line_number":80,"context_line":"neutron\u0027s file ``policy.json`` can be modified to allow this."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Modify ``/etc/neutron/policy.json`` policy entries as follows:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_e492a74b","line":79,"range":{"start_line":79,"start_character":24,"end_line":79,"end_character":27},"in_reply_to":"bf8cb3f7_641d370e","updated":"2017-12-26 01:47:44.000000000","message":"You know, We are not a native speaker. It is better to get feedback from native speaker here :-)","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"648f2382ae37f0567871b75e3591ad10f39e5df3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"With the default ``/etc/neutron/policy.json``, administrators must"},{"line_number":77,"context_line":"set up resource logging on behalf of the cloud projects."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"If projects are trusted to administer their own resource logging in your cloud,"},{"line_number":80,"context_line":"neutron\u0027s file ``policy.json`` can be modified to allow this."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Modify ``/etc/neutron/policy.json`` policy entries as follows:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"bf8cb3f7_bf7b41bc","line":79,"range":{"start_line":79,"start_character":24,"end_line":79,"end_character":27},"in_reply_to":"bf8cb3f7_e492a74b","updated":"2017-12-26 18:18:35.000000000","message":"Ah.... this is my bad. I misread \"administer\" as \"administrator\". You\u0027re correct.","commit_id":"440e403aa9d1be6a364d4634a3580f10151245cf"}]}
