)]}'
{"neutron/tests/tempest/scenario/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"37316402a341e20593686a435e552eb18ccdf574","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            if nic:"},{"line_number":244,"context_line":"                cmd \u003d \u0027sudo {cmd} -I {nic}\u0027.format(cmd\u003dcmd, nic\u003dnic)"},{"line_number":245,"context_line":"            if mtu:"},{"line_number":246,"context_line":"                cmd +\u003d \u0027 -M do -c {count} -w {count} -s {size} {host}\u0027.format("},{"line_number":247,"context_line":"                    count\u003dcount, size\u003dmtu, host\u003dhost)"},{"line_number":248,"context_line":"            else:"},{"line_number":249,"context_line":"                cmd +\u003d \u0027 -c{0} -w{0} -s{1} {2}\u0027.format(count, size, host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_f6df3c63","line":246,"updated":"2017-07-06 17:41:17.000000000","message":"I compare that to https://github.com/openstack/tempest/blob/master/tempest/scenario/manager.py#L516 where we subtract ip header size from the payload size passed to ping tool. Don\u0027t we need to do the same here?","commit_id":"936061027afac46e8e9a73d847384ed142e30e77"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"85a0f1113d225295e19a041b4851f5153698ec95","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            if nic:"},{"line_number":244,"context_line":"                cmd \u003d \u0027sudo {cmd} -I {nic}\u0027.format(cmd\u003dcmd, nic\u003dnic)"},{"line_number":245,"context_line":"            if mtu:"},{"line_number":246,"context_line":"                cmd +\u003d \u0027 -M do -c {count} -w {count} -s {size} {host}\u0027.format("},{"line_number":247,"context_line":"                    count\u003dcount, size\u003dmtu, host\u003dhost)"},{"line_number":248,"context_line":"            else:"},{"line_number":249,"context_line":"                cmd +\u003d \u0027 -c{0} -w{0} -s{1} {2}\u0027.format(count, size, host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_1cbe20ff","line":246,"in_reply_to":"3f1d235d_f6df3c63","updated":"2017-07-09 09:28:00.000000000","message":"Done","commit_id":"936061027afac46e8e9a73d847384ed142e30e77"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"aecfbdc4ca80003bfcd3ac2c0f839de28cd53723","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            except lib_exc.SSHExecCommandFailed:"},{"line_number":252,"context_line":"                LOG.warning(\u0027Failed to ping IP: %s via a ssh connection \u0027"},{"line_number":253,"context_line":"                            \u0027from: %s.\u0027, dest, source.host)"},{"line_number":254,"context_line":"                return not should_succeed"},{"line_number":255,"context_line":"            LOG.debug(\u0027ping result: %s\u0027, result)"},{"line_number":256,"context_line":"            # Assert that the return traffic was from the correct"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_558551ce","side":"PARENT","line":253,"range":{"start_line":253,"start_character":53,"end_line":253,"end_character":58},"updated":"2017-07-11 12:28:42.000000000","message":"How does this relate to this patch?","commit_id":"df762b0d464e5461d1d5785fd91c7424b27034ca"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"aecfbdc4ca80003bfcd3ac2c0f839de28cd53723","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            if mtu:"},{"line_number":246,"context_line":"                cmd +\u003d \u0027 -M do -c {count} -w {count} -s {size} {host}\u0027.format("},{"line_number":247,"context_line":"                    count\u003dcount,"},{"line_number":248,"context_line":"                    size\u003dstr(net_utils.get_ping_payload_size(mtu, 4)),"},{"line_number":249,"context_line":"                    host\u003dhost)"},{"line_number":250,"context_line":"            else:"},{"line_number":251,"context_line":"                cmd +\u003d \u0027 -c{0} -w{0} -s{1} {2}\u0027.format(count, size, host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_5510b1a8","line":248,"range":{"start_line":248,"start_character":66,"end_line":248,"end_character":67},"updated":"2017-07-11 12:28:42.000000000","message":"Nit: ip_version\u003d4 is a lot more readable without need to check the get_ping_payload_size implementation.","commit_id":"f541c3f8d77f805b37e78cae7f638cf047b85b5a"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"b24af55c3666b80388494c1588456643697f2a08","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            if mtu:"},{"line_number":246,"context_line":"                cmd +\u003d \u0027 -M do -c {count} -w {count} -s {size} {host}\u0027.format("},{"line_number":247,"context_line":"                    count\u003dcount,"},{"line_number":248,"context_line":"                    size\u003dstr(net_utils.get_ping_payload_size(mtu, 4)),"},{"line_number":249,"context_line":"                    host\u003dhost)"},{"line_number":250,"context_line":"            else:"},{"line_number":251,"context_line":"                cmd +\u003d \u0027 -c{0} -w{0} -s{1} {2}\u0027.format(count, size, host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_8eebda10","line":248,"range":{"start_line":248,"start_character":66,"end_line":248,"end_character":67},"in_reply_to":"3f1d235d_5510b1a8","updated":"2017-07-11 13:37:07.000000000","message":"Done","commit_id":"f541c3f8d77f805b37e78cae7f638cf047b85b5a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e39ef3df53fd317c0f1237f4ed9598a495e7027b","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            except lib_exc.SSHExecCommandFailed:"},{"line_number":252,"context_line":"                LOG.warning(\u0027Failed to ping IP: %s via a ssh connection \u0027"},{"line_number":253,"context_line":"                            \u0027from: %s.\u0027, dest, source.host)"},{"line_number":254,"context_line":"                return not should_succeed"},{"line_number":255,"context_line":"            LOG.debug(\u0027ping result: %s\u0027, result)"},{"line_number":256,"context_line":"            # Assert that the return traffic was from the correct"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_7a1cb476","side":"PARENT","line":253,"range":{"start_line":253,"start_character":53,"end_line":253,"end_character":58},"updated":"2017-07-11 15:27:53.000000000","message":"I still think we shouldn\u0027t change this. If there is a bug in the code, where RemoteClient doesn\u0027t have the host attribute, it should be fixed in separate patch with explanation. There could be an issue in the depending patch that passes wrong object.","commit_id":"df762b0d464e5461d1d5785fd91c7424b27034ca"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f5abd757b7c8e607c918076b7e1e291d3f10f514","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            except lib_exc.SSHExecCommandFailed:"},{"line_number":252,"context_line":"                LOG.warning(\u0027Failed to ping IP: %s via a ssh connection \u0027"},{"line_number":253,"context_line":"                            \u0027from: %s.\u0027, dest, source.host)"},{"line_number":254,"context_line":"                return not should_succeed"},{"line_number":255,"context_line":"            LOG.debug(\u0027ping result: %s\u0027, result)"},{"line_number":256,"context_line":"            # Assert that the return traffic was from the correct"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_d9085e29","side":"PARENT","line":253,"range":{"start_line":253,"start_character":53,"end_line":253,"end_character":58},"in_reply_to":"3f1d235d_7a1cb476","updated":"2017-07-12 07:46:27.000000000","message":"Done","commit_id":"df762b0d464e5461d1d5785fd91c7424b27034ca"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ae9861ea23b6ae1acd881a80106a22e9c0774224","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                cmd +\u003d \u0027 -M do -c {count} -w {count} -s {size} {host}\u0027.format("},{"line_number":247,"context_line":"                    count\u003dcount,"},{"line_number":248,"context_line":"                    size\u003dstr(net_utils.get_ping_payload_size("},{"line_number":249,"context_line":"                        mtu\u003dmtu, ip_version\u003d4)),"},{"line_number":250,"context_line":"                    host\u003dhost)"},{"line_number":251,"context_line":"            else:"},{"line_number":252,"context_line":"                cmd +\u003d \u0027 -c{0} -w{0} -s{1} {2}\u0027.format(count, size, host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_7af27471","line":249,"range":{"start_line":249,"start_character":33,"end_line":249,"end_character":45},"updated":"2017-07-11 15:21:34.000000000","message":"should it depend on addr.version?","commit_id":"781bffd3b8ab37d775e80245796bed058c6789a0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f5abd757b7c8e607c918076b7e1e291d3f10f514","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                cmd +\u003d \u0027 -M do -c {count} -w {count} -s {size} {host}\u0027.format("},{"line_number":247,"context_line":"                    count\u003dcount,"},{"line_number":248,"context_line":"                    size\u003dstr(net_utils.get_ping_payload_size("},{"line_number":249,"context_line":"                        mtu\u003dmtu, ip_version\u003d4)),"},{"line_number":250,"context_line":"                    host\u003dhost)"},{"line_number":251,"context_line":"            else:"},{"line_number":252,"context_line":"                cmd +\u003d \u0027 -c{0} -w{0} -s{1} {2}\u0027.format(count, size, host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_19fff601","line":249,"range":{"start_line":249,"start_character":33,"end_line":249,"end_character":45},"in_reply_to":"3f1d235d_7af27471","updated":"2017-07-12 07:46:27.000000000","message":"Done","commit_id":"781bffd3b8ab37d775e80245796bed058c6789a0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"321e5cbccc7127e1b9edf7e9d80ee9bd1403bcbc","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        def ping_remote():"},{"line_number":260,"context_line":"            try:"},{"line_number":261,"context_line":"                result \u003d ping_host(source, dest, nic\u003dnic, mtu\u003dmtu)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"            except lib_exc.SSHExecCommandFailed:"},{"line_number":264,"context_line":"                LOG.warning(\u0027Failed to ping IP: %s via a ssh connection \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_929a2dc3","line":261,"updated":"2017-07-12 12:28:21.000000000","message":"Missing passing df","commit_id":"be459a87fc847d6fc4bd8bed04a3366a4d5ae425"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"90f839e6244d07222776514d1ccd1ac65a259c77","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        def ping_remote():"},{"line_number":260,"context_line":"            try:"},{"line_number":261,"context_line":"                result \u003d ping_host(source, dest, nic\u003dnic, mtu\u003dmtu)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"            except lib_exc.SSHExecCommandFailed:"},{"line_number":264,"context_line":"                LOG.warning(\u0027Failed to ping IP: %s via a ssh connection \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_55459f6f","line":261,"in_reply_to":"1f1a1f67_929a2dc3","updated":"2017-07-12 13:12:03.000000000","message":"Done","commit_id":"be459a87fc847d6fc4bd8bed04a3366a4d5ae425"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"321e5cbccc7127e1b9edf7e9d80ee9bd1403bcbc","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    def check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":279,"context_line":"                                  nic\u003dNone, mtu\u003dNone, df\u003dFalse):"},{"line_number":280,"context_line":"        self.assertTrue(self._check_remote_connectivity("},{"line_number":281,"context_line":"            source, dest, should_succeed, nic, mtu))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_b246494f","line":281,"range":{"start_line":281,"start_character":46,"end_line":281,"end_character":50},"updated":"2017-07-12 12:28:21.000000000","message":"Missing df ? What does \u0027df\u0027 stand for?","commit_id":"be459a87fc847d6fc4bd8bed04a3366a4d5ae425"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"90f839e6244d07222776514d1ccd1ac65a259c77","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    def check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":279,"context_line":"                                  nic\u003dNone, mtu\u003dNone, df\u003dFalse):"},{"line_number":280,"context_line":"        self.assertTrue(self._check_remote_connectivity("},{"line_number":281,"context_line":"            source, dest, should_succeed, nic, mtu))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_75353bf7","line":281,"range":{"start_line":281,"start_character":46,"end_line":281,"end_character":50},"in_reply_to":"1f1a1f67_b246494f","updated":"2017-07-12 13:12:03.000000000","message":"Change the name to fragmentation as it\u0027s more clear","commit_id":"be459a87fc847d6fc4bd8bed04a3366a4d5ae425"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"3f0e9a236a6d38459b78467f1ccaedbbd7a1f359","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    def check_remote_connectivity(self, source, dest, should_succeed\u003dTrue,"},{"line_number":279,"context_line":"                                  nic\u003dNone, mtu\u003dNone, df\u003dFalse):"},{"line_number":280,"context_line":"        self.assertTrue(self._check_remote_connectivity("},{"line_number":281,"context_line":"            source, dest, should_succeed, nic, mtu))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_95d1f75a","line":281,"range":{"start_line":281,"start_character":46,"end_line":281,"end_character":50},"in_reply_to":"1f1a1f67_b246494f","updated":"2017-07-12 12:55:10.000000000","message":"don\u0027t fragment","commit_id":"be459a87fc847d6fc4bd8bed04a3366a4d5ae425"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1473d1b21e05ff7f9b6d8743ddc9f57f90b4fa43","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if mtu:"},{"line_number":248,"context_line":"                if not fragmentation:"},{"line_number":249,"context_line":"                    cmd +\u003d \u0027 -M do\u0027"},{"line_number":250,"context_line":"                cmd +\u003d \u0027 -c {count} -w {count} -s {size} {host}\u0027.format("},{"line_number":251,"context_line":"                    count\u003dcount,"},{"line_number":252,"context_line":"                    size\u003dstr(net_utils.get_ping_payload_size("},{"line_number":253,"context_line":"                        mtu\u003dmtu, ip_version\u003daddr.version)),"},{"line_number":254,"context_line":"                    host\u003dhost)"},{"line_number":255,"context_line":"            else:"},{"line_number":256,"context_line":"                cmd +\u003d \u0027 -c{0} -w{0} -s{1} {2}\u0027.format(count, size, host)"},{"line_number":257,"context_line":"            return source.exec_command(cmd)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_906465bb","line":255,"range":{"start_line":250,"start_character":0,"end_line":255,"end_character":17},"updated":"2017-07-12 13:19:59.000000000","message":"As the only change is in size param, you can replace this whole block by:\n\n size \u003d str(net_utils.get_ping_payload_size(\n     mtu\u003dmtu, ip_version\u003daddr.version))\n\nand let L256 consume it","commit_id":"3d5cd7a923dd6d2bfd2fdb3d17541267c214e3d6"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"a3d6830ef9b762b8095430156420287a2127b882","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            if mtu:"},{"line_number":248,"context_line":"                if not fragmentation:"},{"line_number":249,"context_line":"                    cmd +\u003d \u0027 -M do\u0027"},{"line_number":250,"context_line":"                cmd +\u003d \u0027 -c {count} -w {count} -s {size} {host}\u0027.format("},{"line_number":251,"context_line":"                    count\u003dcount,"},{"line_number":252,"context_line":"                    size\u003dstr(net_utils.get_ping_payload_size("},{"line_number":253,"context_line":"                        mtu\u003dmtu, ip_version\u003daddr.version)),"},{"line_number":254,"context_line":"                    host\u003dhost)"},{"line_number":255,"context_line":"            else:"},{"line_number":256,"context_line":"                cmd +\u003d \u0027 -c{0} -w{0} -s{1} {2}\u0027.format(count, size, host)"},{"line_number":257,"context_line":"            return source.exec_command(cmd)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_9066a551","line":255,"range":{"start_line":250,"start_character":0,"end_line":255,"end_character":17},"in_reply_to":"1f1a1f67_906465bb","updated":"2017-07-12 13:31:22.000000000","message":"Indeed, thanks","commit_id":"3d5cd7a923dd6d2bfd2fdb3d17541267c214e3d6"}]}
