)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1d765f78a08aa88accf857e3642cbdd04a6df371","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-07-25 22:07:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dhcp agent start md-proxy with vrouter only when has metadata subnet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3288327bf9d0cdf759a6fdf365d1289e8b7442db"},{"line_number":10,"context_line":"Closes-Bug: #1703059"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f436f4f_ff6146d4","line":8,"updated":"2017-08-16 16:27:04.000000000","message":"This commit message needs more details explaining why this change is being done.","commit_id":"1a35bef61515c58fe20cb0d25960b2893fa48e41"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"b1643373204af86c92cc387484752d4412b1d886","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-07-25 22:07:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dhcp agent start md-proxy with vrouter only when has metadata subnet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3288327bf9d0cdf759a6fdf365d1289e8b7442db"},{"line_number":10,"context_line":"Closes-Bug: #1703059"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f436f4f_c70334be","line":8,"in_reply_to":"9f436f4f_ff6146d4","updated":"2017-08-18 01:27:25.000000000","message":"Done","commit_id":"1a35bef61515c58fe20cb0d25960b2893fa48e41"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fb783b7eb3c6952270fd0f3a6e3df105dbbaf895","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_f546e0c0","side":"PARENT","line":508,"updated":"2017-07-08 03:30:08.000000000","message":"removing this line seems to go against the initial assumption as commented on line 488.","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6ebc31bef7a9894816c999389f3d042cb1bbd1c5","unresolved":false,"context_lines":[{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    def enable_isolated_metadata_proxy(self, network):"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"        # The proxy might work for either a single network"},{"line_number":489,"context_line":"        # or all the networks connected via a router"},{"line_number":490,"context_line":"        # to the one passed as a parameter"},{"line_number":491,"context_line":"        kwargs \u003d {\u0027network_id\u0027: network.id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_d54ac4aa","line":488,"updated":"2017-07-08 03:38:57.000000000","message":"you may want to revise this comment too.","commit_id":"dd0f2cf49b0c7508d33a44b2eb2cf4bfb0fb566c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"631678bcd3016bb3aec37e9f2d9d7cbe22f83f25","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_df540157","side":"PARENT","line":508,"updated":"2017-07-10 15:38:32.000000000","message":"this may break the nsx plugin (and may also break others) would it be possible that you have a configuration value which indicates if the router_id is set. could that be a fix that suits all parties?","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"f566b42a333c63b51d956ab87d1cbadc64420bb9","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_5fff8833","side":"PARENT","line":508,"in_reply_to":"1f1a1f67_1f9a306d","updated":"2017-07-16 06:45:47.000000000","message":"Thanks Shih-Hao Li for your detail scenario explain.\n\nLet me get understand your scenario:\nR1 --- Metadata Network(DHCP Enable)\n   |-- VM Newtork(DHCP Disable)\n\nYou create a VM in \"VM Network\", when the vm request metadata, the request should reached to R1 first.\nMy currently understanding is neutron-l3-agent should create md-proxy for R1 namespace, that md-proxy will handle the request. So in this case, with vRouter which created by neutron-l3-agent, looks like no need create a md-proxy in Metadata Network in this case.\n\nMaybe NSX driver will not proess that request in Vrouter, but it will re-direct the request to Metadata Network. and let the ns-proxy in Metadata Network to process this request. Am I right?","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"3d284c6011e09a7192d7424549a50029e265a990","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_f7bf985e","side":"PARENT","line":508,"in_reply_to":"1f1a1f67_573f6cb3","updated":"2017-07-17 01:54:15.000000000","message":"@Shih-Hao Li, Thanks for your help to let me NSX case, I will update in next patch-set.","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"af743cfe9dc6e9eb54b6551317fd32eb2de8fe42","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_ff63f418","side":"PARENT","line":508,"in_reply_to":"1f1a1f67_5fff8833","updated":"2017-07-16 06:55:44.000000000","message":"Yes, forgot to say. We don\u0027t run L3 agent in NSX setup.","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"4e4472c6bb77db19ec14f75ca75e70f6a73b9638","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_573f6cb3","side":"PARENT","line":508,"in_reply_to":"1f1a1f67_8cadfb9c","updated":"2017-07-17 00:29:25.000000000","message":"OK, then please implement your new solution here so NSX can still work.\nIf the core reviewers are OK then I have no problem with it. Thank you.","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"3c0f0d009f889428f7090a09579504c0da4d21af","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_e6325010","side":"PARENT","line":508,"in_reply_to":"1f1a1f67_bf469c7b","updated":"2017-07-16 14:58:38.000000000","message":"What I described is NSX\u0027s approach for handling DHCP-disabled subnets.\nSo I consider that as a vendor implementation. I am not sure if other\nvendors handle the same problem the same way. Or they need to handle\nother problems by using the router_id here.\n\nTherefore I will not add extra logic here (i.e. in the upstream code) for\ndealing with vendor-specific issues. Also the new logic may work for\none vendor, but break other vendor\u0027s implementations. I would do what\nGary suggests - add a configuration option. So each user/vendor can\ndecide based on their needs.","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"e27a1872e591def8de94248af60e0247e994cccc","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_8cadfb9c","side":"PARENT","line":508,"in_reply_to":"1f1a1f67_e6325010","updated":"2017-07-16 21:01:23.000000000","message":"Hi Shih-Hao Li,\n\nThanks for your reply.\n\nThe problem is if we do not update this, this will be a bug in the following case.\nvRouter1 --- Network with two subnet( subnet1 connect to vrouter, subnet2 is isolated subnet)\n\nIn case, user deploy neutron-dhcp-agent and neutron-l3-agent(this is very typical deploy arch).\nSince subnet2 is isolated subnet, so the logic here will goes into here,\nneutron-dhcp-agent will start ns-proxy with 80 port and router_id.\nBut in this case, the neutron-l3-agent will also start a ns-proxy with 9697 port and router_id.\nBoth process manager in neutron-dhcp-agent and neutron-l3-agent will check that ns-proxy,\nwhen that ns-proxy is down, it sometimes start by neutron-dhcp-agent, sometime start by neutron-l3-agent(In case they are on same network node)\nThis is obviously buggy action with current code. Only the ns-proxy start by neutron-l3-agent can work in this case.\n\n\u003e What I described is NSX\u0027s approach for handling DHCP-disabled subnets. So I consider that as a vendor implementation. \nWe already have similar logic like the following in master code:\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/linux/dhcp.py#L1098-L1103\n\nAnd this logic is introduced by the following patch for support NVP:\nhttps://review.openstack.org/#/c/21934/\n\nLooks like that router_id is used by NVP and network has metadata network.\n\nAnd for add a new configuration Item, I get you and Gary. I\u0027m also a openstack operator ;-) . From operation of view, neutron already have a lot of configuration item, if not nessary, I really do not want to add one more ;-)\n\n\nRegards,\nLiping Mao","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"6c8dd1a469e647070cf8e9fb7024b0cb06bf007e","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_bf469c7b","side":"PARENT","line":508,"in_reply_to":"1f1a1f67_ff63f418","updated":"2017-07-16 07:00:15.000000000","message":"Hi Shih-Hao Li,\n\nThere are two case the should_enable_metadata is true:\n1. when the network or subnetwork is isolated network with dhcp enabled.\n2. the scenario you mentioned, there are \"metadata\" network existed, and the metadata network is used by solutions which do not leverage l3 agent for process metadata service.\n\nRight now, both of these two case will use router_id now.\nin #1, we should not set \"router_id\" here.\nin #2, I can understand that we need to set \"router_id\" here.\n\nSo how about add logic here, check if the network has a metadata subnet, if yes, set \"router_id\" here otherwise do not set \"router_id\".","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"84002cf7a5d0780a1014d368fe74aacc4ac443a3","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_3fe72c43","side":"PARENT","line":508,"in_reply_to":"3f1d235d_511345b9","updated":"2017-07-16 02:54:03.000000000","message":"Hi Shih-Hao Li,\n\nThanks for your review.\n\nBut I did not get your point. Remove this router_id only when the network has isolated network or subnet.\nIn this case it still can get network_id , because we already set in L491. It should can also port.\n\nThanks.\nLiping Mao","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"50fce00daace6173c4904e0982707a783c4f8500","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_1f9a306d","side":"PARENT","line":508,"in_reply_to":"3f1d235d_511345b9","updated":"2017-07-16 04:32:20.000000000","message":"The enable_isolated_metadata_proxy function could be called\nin the following scenario:\n\nA neutron network has only one subnet which is DHCP-disabled.\nWhen this subnet is attached to a router, the system may create an\ninternal DHCP-enabled metadata network (for example 169.254.169.252/30)\nand attach it to the same router.\n\nIf I remember correctly, this is where the function\nenable_isolated_metadata_proxy gets called.\nIt will start a md-prxoy with the router_id option.\n\nWhen a metadata request sent from a VM in the DHCP-disabled subnet,\nthe router will forward it to the internal metadata network, where the\nthe md-proxy will process it and fill in the router_id in the\nX-Neutron-Router-ID header. It then passes the request to the\nmetadata agent. The metadata agent will find the metadata info for\nthe VM based on the VM IP and router_id in the header.\n\nIf you remove the router_id here, the new md-proxy will start\nwith the network_id option, which is the ID of the internal\nmetadata network. When the metadata request from VM\nreceived by the md-proxy, it fills in the network_id in the\nX-Neutron-Network-ID header. Later when metadata agent\nreceives the request, it can not locate the metadata info for \nthe VM  because there is no such VM in the metadata network.\n\nHope this help!","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"84002cf7a5d0780a1014d368fe74aacc4ac443a3","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_dfd5d844","side":"PARENT","line":508,"in_reply_to":"3f1d235d_df540157","updated":"2017-07-16 02:54:03.000000000","message":"@Garyk, thanks for your comments. \n\nI would like to understand why nsx need router_id when the network/subnet is isolated. \n\nBecause with this param here, the metadata ns proxy will listen to port 80(not 9697), this should not work in any case in my mind.\n\nAnd I think we should avoid add configuration item unless this this have to. ;-)\n\nThanks again for your time to review!","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"bb50f01ab11bd4ea4532728c3d7c95cc1a23043d","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                {\u0027port_num\u0027: len(router_ports),"},{"line_number":506,"context_line":"                                 \u0027port_id\u0027: router_ports[0].id,"},{"line_number":507,"context_line":"                                 \u0027router_id\u0027: router_ports[0].device_id})"},{"line_number":508,"context_line":"                kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":509,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_511345b9","side":"PARENT","line":508,"in_reply_to":"3f1d235d_df540157","updated":"2017-07-10 16:06:28.000000000","message":"If router_id is removed, then the ns_mdproxy will be running without this argument.\n\nThus in _proxy_request() in neutron/agent/metadata/namespace_proxy.py, the header will be set differently, i.e.\n\n    if self.router_id:\n        headers[\u0027X-Neutron-Router-ID\u0027] \u003d self.router_id\n    else:\n        headers[\u0027X-Neutron-Network-ID\u0027] \u003d self.network_id\n\nThis will cause issue in _get_instance_and_tenant_id() in neutron/agent/metadata/agent.py:\n\n    router_id \u003d req.headers.get(\u0027X-Neutron-Router-ID\u0027)\n    ports \u003d self._get_ports(remote_address, network_id, router_id)\n\nThe port may not be found.","commit_id":"f04c6181e5110b59c8b782d136f0927af8229a59"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1d765f78a08aa88accf857e3642cbdd04a6df371","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                all_subnets \u003d self.dhcp_driver_cls._get_all_subnets(network)"},{"line_number":509,"context_line":"                if self.dhcp_driver_cls.has_metadata_subnet(all_subnets):"},{"line_number":510,"context_line":"                    kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":511,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("},{"line_number":514,"context_line":"            self._process_monitor, network.namespace, dhcp.METADATA_PORT,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f436f4f_df5c421a","line":511,"updated":"2017-08-16 16:27:04.000000000","message":"Does it make sense to store the device_id in self._metadata_routers when the \u0027router_id\u0027 kwarg is not set?","commit_id":"1a35bef61515c58fe20cb0d25960b2893fa48e41"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"b1643373204af86c92cc387484752d4412b1d886","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                all_subnets \u003d self.dhcp_driver_cls._get_all_subnets(network)"},{"line_number":509,"context_line":"                if self.dhcp_driver_cls.has_metadata_subnet(all_subnets):"},{"line_number":510,"context_line":"                    kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":511,"context_line":"                self._metadata_routers[network.id] \u003d router_ports[0].device_id"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("},{"line_number":514,"context_line":"            self._process_monitor, network.namespace, dhcp.METADATA_PORT,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f436f4f_e7687888","line":511,"in_reply_to":"9f436f4f_df5c421a","updated":"2017-08-18 01:27:25.000000000","message":"Done","commit_id":"1a35bef61515c58fe20cb0d25960b2893fa48e41"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"f83ec2eddea36f9999d174cb15226664bd74a987","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                all_subnets \u003d self.dhcp_driver_cls._get_all_subnets(network)"},{"line_number":509,"context_line":"                if self.dhcp_driver_cls.has_metadata_subnet(all_subnets):"},{"line_number":510,"context_line":"                    kwargs \u003d {\u0027router_id\u0027: router_ports[0].device_id}"},{"line_number":511,"context_line":"                    self._metadata_routers[network.id] \u003d \\"},{"line_number":512,"context_line":"                        router_ports[0].device_id"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        metadata_driver.MetadataDriver.spawn_monitored_metadata_proxy("}],"source_content_type":"text/x-python","patch_set":11,"id":"7f287b81_bed457be","line":511,"updated":"2017-08-25 14:13:30.000000000","message":"nit: avoid using \"\\\", you can do\n\n  self._metadata_routers[network.id] \u003d (\n      router_ports[0].device_id)","commit_id":"818f3a6b1c011fb5a2d2c14fe5654d3d6b081149"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"8d005e0f0e3af337f52c7595a4cc689d7612ba82","unresolved":false,"context_lines":[{"line_number":1068,"context_line":"        return isolated_subnets"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"    @staticmethod"},{"line_number":1071,"context_line":"    def have_metadata_subnet(subnets):"},{"line_number":1072,"context_line":"        \"\"\"Check if the subnets has a metadata subnet.\"\"\""},{"line_number":1073,"context_line":"        meta_cidr \u003d netaddr.IPNetwork(METADATA_DEFAULT_CIDR)"},{"line_number":1074,"context_line":"        if any(netaddr.IPNetwork(s.cidr) in meta_cidr"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff346bd7_e5884ec7","line":1071,"updated":"2017-07-24 16:55:35.000000000","message":"I believe has_ is more appropriate than have_ in method name.","commit_id":"054e3ff409926ac72e6c8396fa0abae7e1d09083"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"bd0ad1dfba192f8cdbaf5be15d2d3382df366a02","unresolved":false,"context_lines":[{"line_number":1068,"context_line":"        return isolated_subnets"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"    @staticmethod"},{"line_number":1071,"context_line":"    def have_metadata_subnet(subnets):"},{"line_number":1072,"context_line":"        \"\"\"Check if the subnets has a metadata subnet.\"\"\""},{"line_number":1073,"context_line":"        meta_cidr \u003d netaddr.IPNetwork(METADATA_DEFAULT_CIDR)"},{"line_number":1074,"context_line":"        if any(netaddr.IPNetwork(s.cidr) in meta_cidr"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff346bd7_adc56b3e","line":1071,"in_reply_to":"ff346bd7_e5884ec7","updated":"2017-07-25 14:08:24.000000000","message":"Done","commit_id":"054e3ff409926ac72e6c8396fa0abae7e1d09083"}]}
