)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":26159,"name":"xiexianbin","email":"xiexianbin@yovole.com","username":"xianbin"},"change_message_id":"30e621e8a9d4a1bcce1b5f669e4974707fda72f4","unresolved":false,"context_lines":[{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        if (s.get(\u0027id\u0027)):"},{"line_number":514,"context_line":"            ips \u003d []"},{"line_number":515,"context_line":"            ipnotinrange \u003d None"},{"line_number":516,"context_line":"            filters \u003d {\u0027fixed_ips\u0027: {\u0027subnet_id\u0027: [s[\u0027id\u0027]]}}"},{"line_number":517,"context_line":"            ports \u003d self.get_ports(context, filters\u003dfilters)"},{"line_number":518,"context_line":"            for port in ports:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_bbd4cfbe","line":515,"range":{"start_line":515,"start_character":12,"end_line":515,"end_character":24},"updated":"2017-07-10 00:36:09.000000000","message":"why not ip_not_inrage ?","commit_id":"4efaaa027143040d8e1c8e1015515c657951e8b8"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"0b104e087143ad8d80c841083e5e9843edacc6ef","unresolved":false,"context_lines":[{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        if (s.get(\u0027id\u0027)):"},{"line_number":514,"context_line":"            ips \u003d []"},{"line_number":515,"context_line":"            ipnotinrange \u003d None"},{"line_number":516,"context_line":"            filters \u003d {\u0027fixed_ips\u0027: {\u0027subnet_id\u0027: [s[\u0027id\u0027]]}}"},{"line_number":517,"context_line":"            ports \u003d self.get_ports(context, filters\u003dfilters)"},{"line_number":518,"context_line":"            for port in ports:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_01c234ea","line":515,"range":{"start_line":515,"start_character":12,"end_line":515,"end_character":24},"in_reply_to":"3f1d235d_bbd4cfbe","updated":"2017-07-10 03:14:15.000000000","message":"Done. Variable renamed.","commit_id":"4efaaa027143040d8e1c8e1015515c657951e8b8"},{"author":{"_account_id":26159,"name":"xiexianbin","email":"xiexianbin@yovole.com","username":"xianbin"},"change_message_id":"30e621e8a9d4a1bcce1b5f669e4974707fda72f4","unresolved":false,"context_lines":[{"line_number":520,"context_line":"                    ips.append(fixedip[\u0027ip_address\u0027])"},{"line_number":521,"context_line":"            # if any of ip in ips is not found in any s[\u0027alocation_pools\u0027]"},{"line_number":522,"context_line":"            # raise error and do not allow subnet update"},{"line_number":523,"context_line":"            ipfound \u003d False"},{"line_number":524,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":525,"context_line":"            if allocation_pools and ips:"},{"line_number":526,"context_line":"                range_pools \u003d self.ipam.pools_to_ip_range(allocation_pools)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_9bd913f6","line":523,"range":{"start_line":523,"start_character":12,"end_line":523,"end_character":19},"updated":"2017-07-10 00:36:09.000000000","message":"why not ip_found?","commit_id":"4efaaa027143040d8e1c8e1015515c657951e8b8"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"0b104e087143ad8d80c841083e5e9843edacc6ef","unresolved":false,"context_lines":[{"line_number":520,"context_line":"                    ips.append(fixedip[\u0027ip_address\u0027])"},{"line_number":521,"context_line":"            # if any of ip in ips is not found in any s[\u0027alocation_pools\u0027]"},{"line_number":522,"context_line":"            # raise error and do not allow subnet update"},{"line_number":523,"context_line":"            ipfound \u003d False"},{"line_number":524,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":525,"context_line":"            if allocation_pools and ips:"},{"line_number":526,"context_line":"                range_pools \u003d self.ipam.pools_to_ip_range(allocation_pools)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_c1bb1c70","line":523,"range":{"start_line":523,"start_character":12,"end_line":523,"end_character":19},"in_reply_to":"3f1d235d_9bd913f6","updated":"2017-07-10 03:14:15.000000000","message":"Done. Variable renamed.","commit_id":"4efaaa027143040d8e1c8e1015515c657951e8b8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2110c951ef92c53bb443ef948b9b68dcf8b6848f","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        # (e.g., update_subnet()), you need to set \u0027ip_version\u0027 field"},{"line_number":511,"context_line":"        # before calling this method."},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        if (s.get(\u0027id\u0027)):"},{"line_number":514,"context_line":"            ips \u003d []"},{"line_number":515,"context_line":"            ip_not_inrange \u003d None"},{"line_number":516,"context_line":"            filters \u003d {\u0027fixed_ips\u0027: {\u0027subnet_id\u0027: [s[\u0027id\u0027]]}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_39c0b550","line":513,"updated":"2017-07-10 15:18:20.000000000","message":"Instead of putting this here to catch the create_subnet() cases it should just live in its own function, something like _validate_allocation_pools(), then just call it from a single location.","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"e5fe0d83ca12d2da616cd92b9444a251f3b4822a","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        # (e.g., update_subnet()), you need to set \u0027ip_version\u0027 field"},{"line_number":511,"context_line":"        # before calling this method."},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        if (s.get(\u0027id\u0027)):"},{"line_number":514,"context_line":"            ips \u003d []"},{"line_number":515,"context_line":"            ip_not_inrange \u003d None"},{"line_number":516,"context_line":"            filters \u003d {\u0027fixed_ips\u0027: {\u0027subnet_id\u0027: [s[\u0027id\u0027]]}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_6331b00b","line":513,"in_reply_to":"3f1d235d_39c0b550","updated":"2017-07-11 16:19:59.000000000","message":"Done","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2110c951ef92c53bb443ef948b9b68dcf8b6848f","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            ports \u003d self.get_ports(context, filters\u003dfilters)"},{"line_number":518,"context_line":"            for port in ports:"},{"line_number":519,"context_line":"                for fixedip in port[\u0027fixed_ips\u0027]:"},{"line_number":520,"context_line":"                    ips.append(fixedip[\u0027ip_address\u0027])"},{"line_number":521,"context_line":"            # if any of ip in ips is not found in any s[\u0027alocation_pools\u0027]"},{"line_number":522,"context_line":"            # raise error and do not allow subnet update"},{"line_number":523,"context_line":"            ip_found \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_24e64cea","line":520,"updated":"2017-07-10 15:18:20.000000000","message":"You could just use a nested list comprehension to build this:\n\nips \u003d [ip for port in ports for ip in port[\u0027fixed_ips\u0027]]","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"e5fe0d83ca12d2da616cd92b9444a251f3b4822a","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            ports \u003d self.get_ports(context, filters\u003dfilters)"},{"line_number":518,"context_line":"            for port in ports:"},{"line_number":519,"context_line":"                for fixedip in port[\u0027fixed_ips\u0027]:"},{"line_number":520,"context_line":"                    ips.append(fixedip[\u0027ip_address\u0027])"},{"line_number":521,"context_line":"            # if any of ip in ips is not found in any s[\u0027alocation_pools\u0027]"},{"line_number":522,"context_line":"            # raise error and do not allow subnet update"},{"line_number":523,"context_line":"            ip_found \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_03179c53","line":520,"in_reply_to":"3f1d235d_24e64cea","updated":"2017-07-11 16:19:59.000000000","message":"This is done, but did it this way : \n                ips \u003d [ip[\u0027ip_address\u0027] for port in ports\n                       for ip in port[\u0027fixed_ips\u0027]]","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2110c951ef92c53bb443ef948b9b68dcf8b6848f","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            # raise error and do not allow subnet update"},{"line_number":523,"context_line":"            ip_found \u003d False"},{"line_number":524,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":525,"context_line":"            if allocation_pools and ips:"},{"line_number":526,"context_line":"                range_pools \u003d self.ipam.pools_to_ip_range(allocation_pools)"},{"line_number":527,"context_line":"                for pool in range_pools:"},{"line_number":528,"context_line":"                    for ip in ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_b9904550","line":525,"updated":"2017-07-10 15:18:20.000000000","message":"This should be the first check - is \u0027allocation_pools\u0027 set, since that would save the get_ports() call if there is no work to do.","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"e5fe0d83ca12d2da616cd92b9444a251f3b4822a","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            # raise error and do not allow subnet update"},{"line_number":523,"context_line":"            ip_found \u003d False"},{"line_number":524,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":525,"context_line":"            if allocation_pools and ips:"},{"line_number":526,"context_line":"                range_pools \u003d self.ipam.pools_to_ip_range(allocation_pools)"},{"line_number":527,"context_line":"                for pool in range_pools:"},{"line_number":528,"context_line":"                    for ip in ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_c308842e","line":525,"in_reply_to":"3f1d235d_b9904550","updated":"2017-07-11 16:19:59.000000000","message":"Done","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2110c951ef92c53bb443ef948b9b68dcf8b6848f","unresolved":false,"context_lines":[{"line_number":526,"context_line":"                range_pools \u003d self.ipam.pools_to_ip_range(allocation_pools)"},{"line_number":527,"context_line":"                for pool in range_pools:"},{"line_number":528,"context_line":"                    for ip in ips:"},{"line_number":529,"context_line":"                        # is ip in pool?"},{"line_number":530,"context_line":"                        if (ip in pool):"},{"line_number":531,"context_line":"                            ip_found \u003d True"},{"line_number":532,"context_line":"                            break"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_799aad6e","line":529,"updated":"2017-07-10 15:18:20.000000000","message":"Don\u0027t need the comment, code is pretty obvious.","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"e5fe0d83ca12d2da616cd92b9444a251f3b4822a","unresolved":false,"context_lines":[{"line_number":526,"context_line":"                range_pools \u003d self.ipam.pools_to_ip_range(allocation_pools)"},{"line_number":527,"context_line":"                for pool in range_pools:"},{"line_number":528,"context_line":"                    for ip in ips:"},{"line_number":529,"context_line":"                        # is ip in pool?"},{"line_number":530,"context_line":"                        if (ip in pool):"},{"line_number":531,"context_line":"                            ip_found \u003d True"},{"line_number":532,"context_line":"                            break"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_a307c81c","line":529,"in_reply_to":"3f1d235d_799aad6e","updated":"2017-07-11 16:19:59.000000000","message":"Done","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2110c951ef92c53bb443ef948b9b68dcf8b6848f","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                for pool in range_pools:"},{"line_number":528,"context_line":"                    for ip in ips:"},{"line_number":529,"context_line":"                        # is ip in pool?"},{"line_number":530,"context_line":"                        if (ip in pool):"},{"line_number":531,"context_line":"                            ip_found \u003d True"},{"line_number":532,"context_line":"                            break"},{"line_number":533,"context_line":"                        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_59893124","line":530,"updated":"2017-07-10 15:18:20.000000000","message":"Don\u0027t need parens.","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"e5fe0d83ca12d2da616cd92b9444a251f3b4822a","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                for pool in range_pools:"},{"line_number":528,"context_line":"                    for ip in ips:"},{"line_number":529,"context_line":"                        # is ip in pool?"},{"line_number":530,"context_line":"                        if (ip in pool):"},{"line_number":531,"context_line":"                            ip_found \u003d True"},{"line_number":532,"context_line":"                            break"},{"line_number":533,"context_line":"                        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_66ff7e01","line":530,"in_reply_to":"3f1d235d_59893124","updated":"2017-07-11 16:19:59.000000000","message":"Done","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2110c951ef92c53bb443ef948b9b68dcf8b6848f","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                            ip_found \u003d True"},{"line_number":532,"context_line":"                            break"},{"line_number":533,"context_line":"                        else:"},{"line_number":534,"context_line":"                            ip_not_inrange \u003d ip"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"                if not ip_found:"},{"line_number":537,"context_line":"                    data \u003d {\u0027ip\u0027: ip_not_inrange}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_7972ad13","line":534,"updated":"2017-07-10 15:18:20.000000000","message":"This is going to reset ip_not_inrange every time one is not found.  If this is the error you\u0027re catching, then you can just raise right here, something like:\n\n    if ip not in pool:\n        \"raise error\"","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"e5fe0d83ca12d2da616cd92b9444a251f3b4822a","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                            ip_found \u003d True"},{"line_number":532,"context_line":"                            break"},{"line_number":533,"context_line":"                        else:"},{"line_number":534,"context_line":"                            ip_not_inrange \u003d ip"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"                if not ip_found:"},{"line_number":537,"context_line":"                    data \u003d {\u0027ip\u0027: ip_not_inrange}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_c60d3236","line":534,"in_reply_to":"3f1d235d_7972ad13","updated":"2017-07-11 16:19:59.000000000","message":"I had to do this way to check for port\u0027s ip across all pools, not just in one.","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2110c951ef92c53bb443ef948b9b68dcf8b6848f","unresolved":false,"context_lines":[{"line_number":534,"context_line":"                            ip_not_inrange \u003d ip"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"                if not ip_found:"},{"line_number":537,"context_line":"                    data \u003d {\u0027ip\u0027: ip_not_inrange}"},{"line_number":538,"context_line":"                    msg \u003d _(\"An existing port with fixed ip %(ip)s is not in \""},{"line_number":539,"context_line":"                            \"updated allocation pools\") % data"},{"line_number":540,"context_line":"                    raise exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_e46bb41c","line":537,"updated":"2017-07-10 15:18:20.000000000","message":"No reason to use a dict when there is only one element","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"e5fe0d83ca12d2da616cd92b9444a251f3b4822a","unresolved":false,"context_lines":[{"line_number":534,"context_line":"                            ip_not_inrange \u003d ip"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"                if not ip_found:"},{"line_number":537,"context_line":"                    data \u003d {\u0027ip\u0027: ip_not_inrange}"},{"line_number":538,"context_line":"                    msg \u003d _(\"An existing port with fixed ip %(ip)s is not in \""},{"line_number":539,"context_line":"                            \"updated allocation pools\") % data"},{"line_number":540,"context_line":"                    raise exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_a61c766a","line":537,"in_reply_to":"3f1d235d_e46bb41c","updated":"2017-07-11 16:19:59.000000000","message":"Done","commit_id":"07b40a89b187600d578f575df206014430d22ccf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9ade015cb7fd5cc0edea325e7b58942571da8568","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def _validate_allocation_pools(self, context, s):"},{"line_number":504,"context_line":"        if (s.get(\u0027id\u0027)):"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_48ddd812","line":504,"updated":"2017-07-13 14:51:02.000000000","message":"Shouldn\u0027t need this if it\u0027s an update.","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"1260b37e673834768011721593759bca3078bc83","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def _validate_allocation_pools(self, context, s):"},{"line_number":504,"context_line":"        if (s.get(\u0027id\u0027)):"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_06e1cc2a","line":504,"in_reply_to":"1f1a1f67_0450e45c","updated":"2017-07-17 12:44:58.000000000","message":"The new logic in this patchset needs to retrieve a list of ports for the subnet, get fixed_ip, etc. s[\u0027id\u0027] is available only in update path. Under create path, since s[\u0027id\u0027] is missing, cannot retrieve ports and in create path, there will be no ports anyway.","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1df0aad7d66537e6e9968d0534fc14da0ee0aff7","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def _validate_allocation_pools(self, context, s):"},{"line_number":504,"context_line":"        if (s.get(\u0027id\u0027)):"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_0450e45c","line":504,"in_reply_to":"1f1a1f67_462ee943","updated":"2017-07-13 18:28:15.000000000","message":"My question is, why?  The commit message mentions subnet update not create.","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"a718aeffadb2d2d08256abbf9f4515fe6de495e1","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    def _validate_allocation_pools(self, context, s):"},{"line_number":504,"context_line":"        if (s.get(\u0027id\u0027)):"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_462ee943","line":504,"in_reply_to":"1f1a1f67_48ddd812","updated":"2017-07-13 15:09:16.000000000","message":"I need this, as _validate_subnet is getting called in create subnet cases also.. (_create_subnet_precommit calls this method)","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9ade015cb7fd5cc0edea325e7b58942571da8568","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"            if allocation_pools:"},{"line_number":509,"context_line":"                ips \u003d []"},{"line_number":510,"context_line":"                ip_not_inrange \u003d None"},{"line_number":511,"context_line":"                filters \u003d {\u0027fixed_ips\u0027: {\u0027subnet_id\u0027: [s[\u0027id\u0027]]}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_689bf471","line":508,"updated":"2017-07-13 14:51:02.000000000","message":"nit: just to not have to indent everything,\n\nif not allocation_pools:\n    return\n\nNot really an issue here since there aren\u0027t many lines you need to wrap.","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"1260b37e673834768011721593759bca3078bc83","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"            if allocation_pools:"},{"line_number":509,"context_line":"                ips \u003d []"},{"line_number":510,"context_line":"                ip_not_inrange \u003d None"},{"line_number":511,"context_line":"                filters \u003d {\u0027fixed_ips\u0027: {\u0027subnet_id\u0027: [s[\u0027id\u0027]]}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_bbb33d98","line":508,"in_reply_to":"1f1a1f67_689bf471","updated":"2017-07-17 12:44:58.000000000","message":"Done","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9ade015cb7fd5cc0edea325e7b58942571da8568","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"            if allocation_pools:"},{"line_number":509,"context_line":"                ips \u003d []"},{"line_number":510,"context_line":"                ip_not_inrange \u003d None"},{"line_number":511,"context_line":"                filters \u003d {\u0027fixed_ips\u0027: {\u0027subnet_id\u0027: [s[\u0027id\u0027]]}}"},{"line_number":512,"context_line":"                ports \u003d self.get_ports(context, filters\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_e8a3844e","line":509,"updated":"2017-07-13 14:51:02.000000000","message":"Not necessary with assignment on L514","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"1260b37e673834768011721593759bca3078bc83","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            allocation_pools \u003d s.get(\u0027allocation_pools\u0027)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"            if allocation_pools:"},{"line_number":509,"context_line":"                ips \u003d []"},{"line_number":510,"context_line":"                ip_not_inrange \u003d None"},{"line_number":511,"context_line":"                filters \u003d {\u0027fixed_ips\u0027: {\u0027subnet_id\u0027: [s[\u0027id\u0027]]}}"},{"line_number":512,"context_line":"                ports \u003d self.get_ports(context, filters\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_7ba92522","line":509,"in_reply_to":"1f1a1f67_e8a3844e","updated":"2017-07-17 12:44:58.000000000","message":"Done","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9ade015cb7fd5cc0edea325e7b58942571da8568","unresolved":false,"context_lines":[{"line_number":512,"context_line":"                ports \u003d self.get_ports(context, filters\u003dfilters)"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"                ips \u003d [ip[\u0027ip_address\u0027] for port in ports"},{"line_number":515,"context_line":"                       for ip in port[\u0027fixed_ips\u0027]]"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"                # if any of ip in ips is not found in any s[\u0027alocation_pools\u0027]"},{"line_number":518,"context_line":"                # raise error and do not allow subnet update"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_88abf01b","line":515,"updated":"2017-07-13 14:51:02.000000000","message":"if not ips:\n    return","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"1260b37e673834768011721593759bca3078bc83","unresolved":false,"context_lines":[{"line_number":512,"context_line":"                ports \u003d self.get_ports(context, filters\u003dfilters)"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"                ips \u003d [ip[\u0027ip_address\u0027] for port in ports"},{"line_number":515,"context_line":"                       for ip in port[\u0027fixed_ips\u0027]]"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"                # if any of ip in ips is not found in any s[\u0027alocation_pools\u0027]"},{"line_number":518,"context_line":"                # raise error and do not allow subnet update"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_5ba66955","line":515,"in_reply_to":"1f1a1f67_88abf01b","updated":"2017-07-17 12:44:58.000000000","message":"Done","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9ade015cb7fd5cc0edea325e7b58942571da8568","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                    for pool in range_pools:"},{"line_number":523,"context_line":"                        for ip in ips:"},{"line_number":524,"context_line":"                            if ip in pool:"},{"line_number":525,"context_line":"                                ip_found \u003d True"},{"line_number":526,"context_line":"                                break"},{"line_number":527,"context_line":"                            else:"},{"line_number":528,"context_line":"                                ip_not_inrange \u003d ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_ab1ea609","line":525,"updated":"2017-07-13 14:51:02.000000000","message":"Once we set this to True, the raise on L534 won\u0027t be triggered.  But your comment on L517 says \"if any of ip in ips is not found\", so it still seems like L528 is where you want to raise?","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"1260b37e673834768011721593759bca3078bc83","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                    for pool in range_pools:"},{"line_number":523,"context_line":"                        for ip in ips:"},{"line_number":524,"context_line":"                            if ip in pool:"},{"line_number":525,"context_line":"                                ip_found \u003d True"},{"line_number":526,"context_line":"                                break"},{"line_number":527,"context_line":"                            else:"},{"line_number":528,"context_line":"                                ip_not_inrange \u003d ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_064f8c34","line":525,"in_reply_to":"1f1a1f67_ab1ea609","updated":"2017-07-17 12:44:58.000000000","message":"Required IP may not be found in a specific pool, but may be found in another, as there can be multiple pools in a subnet. So cannot break in the else part.","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9ade015cb7fd5cc0edea325e7b58942571da8568","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        # (e.g., update_subnet()), you need to set \u0027ip_version\u0027 field"},{"line_number":544,"context_line":"        # before calling this method."},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        self._validate_allocation_pools(context, s)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        ip_ver \u003d s[\u0027ip_version\u0027]"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_a89fcc4e","line":546,"updated":"2017-07-13 14:51:02.000000000","message":"I don\u0027t think you need to validate in the create case, right?  This call should only be from the update code.","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"a718aeffadb2d2d08256abbf9f4515fe6de495e1","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        # (e.g., update_subnet()), you need to set \u0027ip_version\u0027 field"},{"line_number":544,"context_line":"        # before calling this method."},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        self._validate_allocation_pools(context, s)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"        ip_ver \u003d s[\u0027ip_version\u0027]"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_0628f131","line":546,"in_reply_to":"1f1a1f67_a89fcc4e","updated":"2017-07-13 15:09:16.000000000","message":"_validate_subnet is getting called in create subnet cases also.. (_create_subnet_precommit calls this method)","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d31eba174beab8cf7454057be9b2e6a8d07e8765","unresolved":false,"context_lines":[{"line_number":522,"context_line":"            # raise error and do not allow subnet update"},{"line_number":523,"context_line":"            ip_found \u003d False"},{"line_number":524,"context_line":"            range_pools \u003d self.ipam.pools_to_ip_range(allocation_pools)"},{"line_number":525,"context_line":"            for pool in range_pools:"},{"line_number":526,"context_line":"                for ip in ips:"},{"line_number":527,"context_line":"                    if ip in pool:"},{"line_number":528,"context_line":"                        ip_found \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_de27ccc9","line":525,"updated":"2017-07-18 21:30:43.000000000","message":"With this logic, you are looking up every ip in every pool. Once we found all the ips, there is no reason to continue iterating","commit_id":"5b2e97bf349f7785dd47c40a871142cda81b1f71"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d31eba174beab8cf7454057be9b2e6a8d07e8765","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            ip_found \u003d False"},{"line_number":524,"context_line":"            range_pools \u003d self.ipam.pools_to_ip_range(allocation_pools)"},{"line_number":525,"context_line":"            for pool in range_pools:"},{"line_number":526,"context_line":"                for ip in ips:"},{"line_number":527,"context_line":"                    if ip in pool:"},{"line_number":528,"context_line":"                        ip_found \u003d True"},{"line_number":529,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_7ea55846","line":526,"updated":"2017-07-18 21:30:43.000000000","message":"Also, for performance considerations, once we find an ip in a pool, we shouldn\u0027t look it up again in other poos","commit_id":"5b2e97bf349f7785dd47c40a871142cda81b1f71"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f8a98a8f275a966665595312fb2785dac600fc3e","unresolved":false,"context_lines":[{"line_number":525,"context_line":"            for pool in range_pools:"},{"line_number":526,"context_line":"                for ip in ips:"},{"line_number":527,"context_line":"                    if ip in pool:"},{"line_number":528,"context_line":"                        ip_found \u003d True"},{"line_number":529,"context_line":"                        break"},{"line_number":530,"context_line":"                    else:"},{"line_number":531,"context_line":"                        ip_not_inrange \u003d ip"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_feacc89f","line":528,"updated":"2017-07-18 21:19:26.000000000","message":"I think this logic is faulty. Say you have two ports, A and B, each one with one valid fixed ip in the subnet prior to the subnet update request. The subnet is then updated with new allocation pools. A\u0027s fixed ip is within the new allocation pools. B\u0027s is not. If A\u0027s fixed ip is checked first, you will set ip_found to True. You won\u0027t find B\u0027s ip in the new pools, but it doesn\u0027t matter: you already set ip_found to True, so you won\u0027t execute L534-537 below","commit_id":"5b2e97bf349f7785dd47c40a871142cda81b1f71"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9ade015cb7fd5cc0edea325e7b58942571da8568","unresolved":false,"context_lines":[{"line_number":4775,"context_line":"                                    u\u0027type\u0027: u\u0027InvalidInput\u0027,"},{"line_number":4776,"context_line":"                                    u\u0027detail\u0027: u\u0027\u0027}}"},{"line_number":4777,"context_line":"        res \u003d self.deserialize(self.fmt, res)"},{"line_number":4778,"context_line":"        self.assertEqual(errres, res)"},{"line_number":4779,"context_line":""},{"line_number":4780,"context_line":"    def _verify_updated_subnet_allocation_pools(self, res, with_gateway_ip):"},{"line_number":4781,"context_line":"        res \u003d self.deserialize(self.fmt, res)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_8bc9aa79","line":4778,"updated":"2017-07-13 14:51:02.000000000","message":"Look at L1012 for an example of how to check the error type and message.","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":12947,"name":"Sridhar Venkat","email":"svenkat@us.ibm.com","username":"svenkat"},"change_message_id":"1260b37e673834768011721593759bca3078bc83","unresolved":false,"context_lines":[{"line_number":4775,"context_line":"                                    u\u0027type\u0027: u\u0027InvalidInput\u0027,"},{"line_number":4776,"context_line":"                                    u\u0027detail\u0027: u\u0027\u0027}}"},{"line_number":4777,"context_line":"        res \u003d self.deserialize(self.fmt, res)"},{"line_number":4778,"context_line":"        self.assertEqual(errres, res)"},{"line_number":4779,"context_line":""},{"line_number":4780,"context_line":"    def _verify_updated_subnet_allocation_pools(self, res, with_gateway_ip):"},{"line_number":4781,"context_line":"        res \u003d self.deserialize(self.fmt, res)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_dbba796c","line":4778,"in_reply_to":"1f1a1f67_8bc9aa79","updated":"2017-07-17 12:44:58.000000000","message":"Done","commit_id":"a1f63bf308752c40abced085762ef69147b793de"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f8a98a8f275a966665595312fb2785dac600fc3e","unresolved":false,"context_lines":[{"line_number":4836,"context_line":"                             cidr\u003d\u0027192.168.0.0/24\u0027) as subnet:"},{"line_number":4837,"context_line":"                fixed_ips \u003d [{\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027],"},{"line_number":4838,"context_line":"                              \u0027ip_address\u0027: \u0027192.168.0.25\u0027}]"},{"line_number":4839,"context_line":"                self._create_port(self.fmt, network[\u0027network\u0027][\u0027id\u0027],"},{"line_number":4840,"context_line":"                                  webob.exc.HTTPCreated.code,"},{"line_number":4841,"context_line":"                                  fixed_ips\u003dfixed_ips)"},{"line_number":4842,"context_line":"                data \u003d {\u0027subnet\u0027: {\u0027allocation_pools\u0027: ["}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_be7bf025","line":4839,"updated":"2017-07-18 21:19:26.000000000","message":"Please see my comment to https://review.openstack.org/#/c/481967/4/neutron/db/db_base_plugin_v2.py@528. I recommend testing with more that one port / fixed_ip","commit_id":"5b2e97bf349f7785dd47c40a871142cda81b1f71"}]}
