)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"293aea6ecc1ef28c19f170d8ee4f30c1999d2f24","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dongcan Ye \u003cyedongcan@yeah.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-29 01:51:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix generates thousands of DHCP tap interfaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As reported in the bug, there may be an case where an empty"},{"line_number":10,"context_line":"namespace file in /run/netns, but the namespace not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f287b81_c1c9a925","line":7,"updated":"2017-09-05 05:31:23.000000000","message":"Fix generation of thousands of DHCP tap interfaces","commit_id":"dbedbd4e5574c809a0fd73f177adc201e504026e"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"8209d95768abdd3d682064e3f8dc0b583509943b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dongcan Ye \u003cyedongcan@yeah.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-29 01:51:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix generates thousands of DHCP tap interfaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As reported in the bug, there may be an case where an empty"},{"line_number":10,"context_line":"namespace file in /run/netns, but the namespace not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f287b81_34830a07","line":7,"in_reply_to":"7f287b81_c1c9a925","updated":"2017-09-05 08:50:09.000000000","message":"Done","commit_id":"dbedbd4e5574c809a0fd73f177adc201e504026e"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"293aea6ecc1ef28c19f170d8ee4f30c1999d2f24","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"                                      \u0027network %s. Releasing port.\u0027),"},{"line_number":1424,"context_line":"                                  network.id)"},{"line_number":1425,"context_line":"                    # We should unplug the interface in bridge side."},{"line_number":1426,"context_line":"                    self.unplug(interface_name, network)"},{"line_number":1427,"context_line":"                    self.plugin.release_dhcp_port(network.id, port.device_id)"},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"            self.fill_dhcp_udp_checksums(namespace\u003dnetwork.namespace)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_21e4edab","line":1426,"updated":"2017-09-05 05:31:23.000000000","message":"the plug failed above - are there partial resources here that need to be cleaned up?","commit_id":"dbedbd4e5574c809a0fd73f177adc201e504026e"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"8209d95768abdd3d682064e3f8dc0b583509943b","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"                                      \u0027network %s. Releasing port.\u0027),"},{"line_number":1424,"context_line":"                                  network.id)"},{"line_number":1425,"context_line":"                    # We should unplug the interface in bridge side."},{"line_number":1426,"context_line":"                    self.unplug(interface_name, network)"},{"line_number":1427,"context_line":"                    self.plugin.release_dhcp_port(network.id, port.device_id)"},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"            self.fill_dhcp_udp_checksums(namespace\u003dnetwork.namespace)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_94987e75","line":1426,"in_reply_to":"7f287b81_21e4edab","updated":"2017-09-05 08:50:09.000000000","message":"In the plug operation, will adds tap interface in the bridge and adds the interface into dhcp namespace. So there is a case that adds the interface into namespace failed, we need to cleanup in bridge side.","commit_id":"dbedbd4e5574c809a0fd73f177adc201e504026e"}],"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4eb04836172091884d014af90cdd42cd15ed3eeb","unresolved":false,"context_lines":[{"line_number":916,"context_line":""},{"line_number":917,"context_line":"    def execute_namespace(self, name):"},{"line_number":918,"context_line":"        try:"},{"line_number":919,"context_line":"            cmd \u003d [\u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, name, \u0027ip\u0027, \u0027addr\u0027]"},{"line_number":920,"context_line":"            utils.execute(cmd, run_as_root\u003dTrue,"},{"line_number":921,"context_line":"                          log_fail_as_error\u003dTrue)"},{"line_number":922,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_ced9dd22","line":919,"updated":"2017-07-11 08:40:18.000000000","message":"Is there a more lightweight command that could be executed within the namespace than \u0027ip addr\u0027?","commit_id":"e71b0401a1688e52fd52658b60304d06d2eea6c8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9819bf2b557b38b3fb61b305c4a03434b29e471e","unresolved":false,"context_lines":[{"line_number":916,"context_line":""},{"line_number":917,"context_line":"    def execute_namespace(self, name):"},{"line_number":918,"context_line":"        try:"},{"line_number":919,"context_line":"            cmd \u003d [\u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, name, \u0027ip\u0027, \u0027addr\u0027]"},{"line_number":920,"context_line":"            utils.execute(cmd, run_as_root\u003dTrue,"},{"line_number":921,"context_line":"                          log_fail_as_error\u003dTrue)"},{"line_number":922,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_8e4e3a94","line":919,"in_reply_to":"3f1d235d_4e45cd6f","updated":"2017-07-11 13:51:49.000000000","message":"Right, I don\u0027t think running a command in the namespace is a good idea, as it could go away right after the exists() call.  We should fix the code in the dhcp-agent so it behaves better when a failure happens, which is what we try to do in the l3-agent.","commit_id":"e71b0401a1688e52fd52658b60304d06d2eea6c8"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"0002987f00d73812a8f06e43d2035f97db8fd98b","unresolved":false,"context_lines":[{"line_number":916,"context_line":""},{"line_number":917,"context_line":"    def execute_namespace(self, name):"},{"line_number":918,"context_line":"        try:"},{"line_number":919,"context_line":"            cmd \u003d [\u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, name, \u0027ip\u0027, \u0027addr\u0027]"},{"line_number":920,"context_line":"            utils.execute(cmd, run_as_root\u003dTrue,"},{"line_number":921,"context_line":"                          log_fail_as_error\u003dTrue)"},{"line_number":922,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_4e45cd6f","line":919,"in_reply_to":"3f1d235d_ced9dd22","updated":"2017-07-11 08:55:09.000000000","message":"Maybe we will not use this method, as Brian Haley suggests.","commit_id":"e71b0401a1688e52fd52658b60304d06d2eea6c8"}]}
