)]}'
{"neutron/tests/tempest/api/admin/test_logging.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aa9580846869e3c27328acf138bea45935b24031","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    required_extensions \u003d [\u0027logging\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @decorators.idempotent_id(\u00278d2e1ba5-455b-4519-a88e-e587002faba6\u0027)"},{"line_number":30,"context_line":"    def test_create_log(self):"},{"line_number":31,"context_line":"        log \u003d self.create_log(name\u003d\u0027test-log\u0027, description\u003d\u0027test log desc\u0027,"},{"line_number":32,"context_line":"                              resource_type\u003d\u0027security_group\u0027, enabled\u003dTrue)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_397bcfbe","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":23},"updated":"2017-08-11 21:39:56.000000000","message":"Why not call this test case test_create_show_list_log?","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"fe26590487e3eda8e97cb6bbbc2eeceaf816d985","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    required_extensions \u003d [\u0027logging\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @decorators.idempotent_id(\u00278d2e1ba5-455b-4519-a88e-e587002faba6\u0027)"},{"line_number":30,"context_line":"    def test_create_log(self):"},{"line_number":31,"context_line":"        log \u003d self.create_log(name\u003d\u0027test-log\u0027, description\u003d\u0027test log desc\u0027,"},{"line_number":32,"context_line":"                              resource_type\u003d\u0027security_group\u0027, enabled\u003dTrue)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_694e1298","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":23},"in_reply_to":"9f436f4f_397bcfbe","updated":"2017-08-14 08:47:05.000000000","message":"Thanks. Done","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aa9580846869e3c27328acf138bea45935b24031","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # Test \u0027show log\u0027"},{"line_number":35,"context_line":"        retrieved_log \u003d self.admin_client.show_log(log[\u0027id\u0027])[\u0027log\u0027]"},{"line_number":36,"context_line":"        self.assertEqual(\u0027test-log\u0027, retrieved_log[\u0027name\u0027])"},{"line_number":37,"context_line":"        self.assertEqual(\u0027test log desc\u0027, retrieved_log[\u0027description\u0027])"},{"line_number":38,"context_line":"        self.assertEqual(\u0027security_group\u0027, retrieved_log[\u0027resource_type\u0027])"},{"line_number":39,"context_line":"        self.assertTrue(retrieved_log[\u0027enabled\u0027])"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_594d73c2","line":37,"updated":"2017-08-11 21:39:56.000000000","message":"Since you are checking the description attribute in you test cases, please look at this patchset: https://review.openstack.org/#/c/490638. I think you need to add standard-attr-description to your required_extensions in L27","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"fe26590487e3eda8e97cb6bbbc2eeceaf816d985","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # Test \u0027show log\u0027"},{"line_number":35,"context_line":"        retrieved_log \u003d self.admin_client.show_log(log[\u0027id\u0027])[\u0027log\u0027]"},{"line_number":36,"context_line":"        self.assertEqual(\u0027test-log\u0027, retrieved_log[\u0027name\u0027])"},{"line_number":37,"context_line":"        self.assertEqual(\u0027test log desc\u0027, retrieved_log[\u0027description\u0027])"},{"line_number":38,"context_line":"        self.assertEqual(\u0027security_group\u0027, retrieved_log[\u0027resource_type\u0027])"},{"line_number":39,"context_line":"        self.assertTrue(retrieved_log[\u0027enabled\u0027])"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_29448a73","line":37,"in_reply_to":"9f436f4f_594d73c2","updated":"2017-08-14 08:47:05.000000000","message":"Thanks!","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aa9580846869e3c27328acf138bea45935b24031","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertEqual(\u0027test log desc2\u0027, retrieved_log[\u0027description\u0027])"},{"line_number":57,"context_line":"        self.assertTrue(retrieved_log[\u0027enabled\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027e1dc2b30-1d80-48d3-ac29-b2b2af8f559e\u0027)"},{"line_number":60,"context_line":"    def test_show_log(self):"},{"line_number":61,"context_line":"        log \u003d self.create_log(name\u003d\u0027test-log\u0027,"},{"line_number":62,"context_line":"                              resource_type\u003d\u0027security_group\u0027)"},{"line_number":63,"context_line":"        body \u003d self.admin_client.show_log(log[\u0027id\u0027])"},{"line_number":64,"context_line":"        show_log \u003d body[\u0027log\u0027]"},{"line_number":65,"context_line":"        self.assertEqual(\u0027test-log\u0027, show_log[\u0027name\u0027])"},{"line_number":66,"context_line":"        self.assertEqual(log[\u0027id\u0027], show_log[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.idempotent_id(\u0027ef1a6de8-7c19-469c-bdf0-7d72eca99670\u0027)"},{"line_number":69,"context_line":"    def test_list_log(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_59a9f321","line":66,"range":{"start_line":59,"start_character":0,"end_line":66,"end_character":51},"updated":"2017-08-11 21:39:56.000000000","message":"Do we even need  a separate test case to test the show operation. You already do this in L35 above. See my comment to L30","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"fe26590487e3eda8e97cb6bbbc2eeceaf816d985","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertEqual(\u0027test log desc2\u0027, retrieved_log[\u0027description\u0027])"},{"line_number":57,"context_line":"        self.assertTrue(retrieved_log[\u0027enabled\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.idempotent_id(\u0027e1dc2b30-1d80-48d3-ac29-b2b2af8f559e\u0027)"},{"line_number":60,"context_line":"    def test_show_log(self):"},{"line_number":61,"context_line":"        log \u003d self.create_log(name\u003d\u0027test-log\u0027,"},{"line_number":62,"context_line":"                              resource_type\u003d\u0027security_group\u0027)"},{"line_number":63,"context_line":"        body \u003d self.admin_client.show_log(log[\u0027id\u0027])"},{"line_number":64,"context_line":"        show_log \u003d body[\u0027log\u0027]"},{"line_number":65,"context_line":"        self.assertEqual(\u0027test-log\u0027, show_log[\u0027name\u0027])"},{"line_number":66,"context_line":"        self.assertEqual(log[\u0027id\u0027], show_log[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.idempotent_id(\u0027ef1a6de8-7c19-469c-bdf0-7d72eca99670\u0027)"},{"line_number":69,"context_line":"    def test_list_log(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_89549622","line":66,"range":{"start_line":59,"start_character":0,"end_line":66,"end_character":51},"in_reply_to":"9f436f4f_59a9f321","updated":"2017-08-14 08:47:05.000000000","message":"Done","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aa9580846869e3c27328acf138bea45935b24031","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertEqual(log[\u0027id\u0027], show_log[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.idempotent_id(\u0027ef1a6de8-7c19-469c-bdf0-7d72eca99670\u0027)"},{"line_number":69,"context_line":"    def test_list_log(self):"},{"line_number":70,"context_line":"        log1 \u003d self.create_log(name\u003d\u0027test\u0027, description\u003d\u0027test log\u0027,"},{"line_number":71,"context_line":"                               resource_type\u003d\u0027security_group\u0027)"},{"line_number":72,"context_line":"        log2 \u003d self.create_log(name\u003d\u0027test2\u0027, description\u003d\u0027test log\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_19336b16","line":69,"updated":"2017-08-11 21:39:56.000000000","message":"I don\u0027t see the need to test the list operation separately","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"fe26590487e3eda8e97cb6bbbc2eeceaf816d985","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertEqual(log[\u0027id\u0027], show_log[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @decorators.idempotent_id(\u0027ef1a6de8-7c19-469c-bdf0-7d72eca99670\u0027)"},{"line_number":69,"context_line":"    def test_list_log(self):"},{"line_number":70,"context_line":"        log1 \u003d self.create_log(name\u003d\u0027test\u0027, description\u003d\u0027test log\u0027,"},{"line_number":71,"context_line":"                               resource_type\u003d\u0027security_group\u0027)"},{"line_number":72,"context_line":"        log2 \u003d self.create_log(name\u003d\u0027test2\u0027, description\u003d\u0027test log\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_6933b215","line":69,"in_reply_to":"9f436f4f_19336b16","updated":"2017-08-14 08:47:05.000000000","message":"Done","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8b6254984a08c7f254c8f984fbbac427bb8d487e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib import decorators"},{"line_number":16,"context_line":"from tempest.lib import exceptions"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import testscenarios"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.tests.tempest.api import base"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7f287b81_4c497b89","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":20},"updated":"2017-08-24 07:49:59.000000000","message":"The testscenarios is third party library as tempest lib so the space of L17 is unnecessary.","commit_id":"1d3d552999a6ba2482da6ca1d94bc5c68ccb151d"}],"neutron/tests/tempest/api/base.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aa9580846869e3c27328acf138bea45935b24031","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            for address_scope in cls.admin_address_scopes:"},{"line_number":194,"context_line":"                cls._try_delete_resource("},{"line_number":195,"context_line":"                    cls.admin_client.delete_address_scope,"},{"line_number":196,"context_line":"                    address_scope[\u0027id\u0027])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        super(BaseNetworkTest, cls).resource_cleanup()"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_0e1683a9","line":196,"updated":"2017-08-11 21:39:56.000000000","message":"You also need to add your logging resources cleanup here. Look above how the cleanup is accomplished","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"fe26590487e3eda8e97cb6bbbc2eeceaf816d985","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            for address_scope in cls.admin_address_scopes:"},{"line_number":194,"context_line":"                cls._try_delete_resource("},{"line_number":195,"context_line":"                    cls.admin_client.delete_address_scope,"},{"line_number":196,"context_line":"                    address_scope[\u0027id\u0027])"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        super(BaseNetworkTest, cls).resource_cleanup()"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_29392af1","line":196,"in_reply_to":"9f436f4f_0e1683a9","updated":"2017-08-14 08:47:05.000000000","message":"Done","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8b6254984a08c7f254c8f984fbbac427bb8d487e","unresolved":false,"context_lines":[{"line_number":427,"context_line":"            cls.subnetpools.append(body[\u0027subnetpool\u0027])"},{"line_number":428,"context_line":"        return body[\u0027subnetpool\u0027]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    @classmethod"},{"line_number":431,"context_line":"    def create_log(cls, name, description\u003dNone,"},{"line_number":432,"context_line":"                   resource_type\u003d\u0027security_group\u0027, resource_id\u003dNone,"},{"line_number":433,"context_line":"                   target_id\u003dNone, event\u003d\u0027ALL\u0027, enabled\u003dTrue):"},{"line_number":434,"context_line":"        \"\"\"Wrapper utility that returns a test log object.\"\"\""},{"line_number":435,"context_line":"        log_args \u003d {\u0027name\u0027: name,"},{"line_number":436,"context_line":"                    \u0027description\u0027: description,"},{"line_number":437,"context_line":"                    \u0027resource_type\u0027: resource_type,"},{"line_number":438,"context_line":"                    \u0027resource_id\u0027: resource_id,"},{"line_number":439,"context_line":"                    \u0027target_id\u0027: target_id,"},{"line_number":440,"context_line":"                    \u0027event\u0027: event,"},{"line_number":441,"context_line":"                    \u0027enabled\u0027: enabled}"},{"line_number":442,"context_line":"        body \u003d cls.admin_client.create_log(**log_args)"},{"line_number":443,"context_line":"        log_object \u003d body[\u0027log\u0027]"},{"line_number":444,"context_line":"        cls.log_objects.append(log_object)"},{"line_number":445,"context_line":"        return log_object"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"class BaseAdminNetworkTest(BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":24,"id":"7f287b81_cf455d45","line":445,"range":{"start_line":430,"start_character":4,"end_line":445,"end_character":25},"updated":"2017-08-24 07:49:59.000000000","message":"This method is better to be moved to BaseAdminNetworkTest class because create_log is used by admin only.","commit_id":"1d3d552999a6ba2482da6ca1d94bc5c68ccb151d"}],"neutron/tests/tempest/api/test_logging.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76bc0f4c0d759e2472d13a1b302c91b51506d3af","unresolved":false,"context_lines":[{"line_number":23,"context_line":"load_tests \u003d testscenarios.load_tests_apply_scenarios"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class LoggingTestJSON(base.BaseAdminNetworkTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    required_extensions \u003d [\u0027logging\u0027]"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_c6e31605","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":49},"updated":"2017-08-09 14:15:41.000000000","message":"Logging API is generally used by admin so I think that this test should be put in admin directory.","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6ff5e9915dae15410d5679d2ebf21eeb362f961c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"load_tests \u003d testscenarios.load_tests_apply_scenarios"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class LoggingTestJSON(base.BaseAdminNetworkTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    required_extensions \u003d [\u0027logging\u0027]"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_e1a712a7","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":49},"in_reply_to":"9f436f4f_c6e31605","updated":"2017-08-10 03:22:25.000000000","message":"Done","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76bc0f4c0d759e2472d13a1b302c91b51506d3af","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                              resource_type\u003d\u0027security_group\u0027, enabled\u003dTrue)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Test \u0027show log\u0027"},{"line_number":36,"context_line":"        retrieved_log \u003d self.admin_client.show_log(log[\u0027id\u0027])"},{"line_number":37,"context_line":"        retrieved_log \u003d retrieved_log[\u0027log\u0027]"},{"line_number":38,"context_line":"        self.assertEqual(\u0027test-log\u0027, retrieved_log[\u0027name\u0027])"},{"line_number":39,"context_line":"        self.assertEqual(\u0027test log desc\u0027, retrieved_log[\u0027description\u0027])"},{"line_number":40,"context_line":"        self.assertEqual(\u0027security_group\u0027, retrieved_log[\u0027resource_type\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_46304657","line":37,"range":{"start_line":36,"start_character":8,"end_line":37,"end_character":44},"updated":"2017-08-09 14:15:41.000000000","message":"nit: It\u0027s not good for me that same variable name is used as different mean. How about the following?\n\n body \u003d self.admin_client.show_log(log[\u0027id\u0027])\n retrieved_log \u003d body[\u0027log\u0027]\n\nor\n\n retrieved_log \u003d self.admin_client.show_log(log[\u0027id\u0027])[\u0027log\u0027]","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6ff5e9915dae15410d5679d2ebf21eeb362f961c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                              resource_type\u003d\u0027security_group\u0027, enabled\u003dTrue)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Test \u0027show log\u0027"},{"line_number":36,"context_line":"        retrieved_log \u003d self.admin_client.show_log(log[\u0027id\u0027])"},{"line_number":37,"context_line":"        retrieved_log \u003d retrieved_log[\u0027log\u0027]"},{"line_number":38,"context_line":"        self.assertEqual(\u0027test-log\u0027, retrieved_log[\u0027name\u0027])"},{"line_number":39,"context_line":"        self.assertEqual(\u0027test log desc\u0027, retrieved_log[\u0027description\u0027])"},{"line_number":40,"context_line":"        self.assertEqual(\u0027security_group\u0027, retrieved_log[\u0027resource_type\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_c1b88ec9","line":37,"range":{"start_line":36,"start_character":8,"end_line":37,"end_character":44},"in_reply_to":"9f436f4f_46304657","updated":"2017-08-10 03:22:25.000000000","message":"Done","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76bc0f4c0d759e2472d13a1b302c91b51506d3af","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                     description\u003d\u0027test log desc2\u0027,"},{"line_number":55,"context_line":"                                     enabled\u003dTrue)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        retrieved_log \u003d self.admin_client.show_log(log[\u0027id\u0027])"},{"line_number":58,"context_line":"        retrieved_log \u003d retrieved_log[\u0027log\u0027]"},{"line_number":59,"context_line":"        self.assertEqual(\u0027test log desc2\u0027, retrieved_log[\u0027description\u0027])"},{"line_number":60,"context_line":"        self.assertTrue(retrieved_log[\u0027enabled\u0027])"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_e63e1a28","line":58,"range":{"start_line":57,"start_character":8,"end_line":58,"end_character":44},"updated":"2017-08-09 14:15:41.000000000","message":"ditto","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6ff5e9915dae15410d5679d2ebf21eeb362f961c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                     description\u003d\u0027test log desc2\u0027,"},{"line_number":55,"context_line":"                                     enabled\u003dTrue)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        retrieved_log \u003d self.admin_client.show_log(log[\u0027id\u0027])"},{"line_number":58,"context_line":"        retrieved_log \u003d retrieved_log[\u0027log\u0027]"},{"line_number":59,"context_line":"        self.assertEqual(\u0027test log desc2\u0027, retrieved_log[\u0027description\u0027])"},{"line_number":60,"context_line":"        self.assertTrue(retrieved_log[\u0027enabled\u0027])"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_a1bb4ac2","line":58,"range":{"start_line":57,"start_character":8,"end_line":58,"end_character":44},"in_reply_to":"9f436f4f_e63e1a28","updated":"2017-08-10 03:22:25.000000000","message":"Done","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76bc0f4c0d759e2472d13a1b302c91b51506d3af","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @decorators.idempotent_id(\u0027e1dc2b30-1d80-48d3-ac29-b2b2af8f559e\u0027)"},{"line_number":63,"context_line":"    @test.requires_ext(extension\u003d\"project-id\", service\u003d\"network\")"},{"line_number":64,"context_line":"    def test_show_log_has_project_id(self):"},{"line_number":65,"context_line":"        log \u003d self.create_log(name\u003d\u0027test-log\u0027,"},{"line_number":66,"context_line":"                              resource_type\u003d\u0027security_group\u0027)"},{"line_number":67,"context_line":"        body \u003d self.admin_client.show_log(log[\u0027id\u0027])"},{"line_number":68,"context_line":"        show_log \u003d body[\u0027log\u0027]"},{"line_number":69,"context_line":"        self.assertIn(\u0027project_id\u0027, show_log)"},{"line_number":70,"context_line":"        self.assertIn(\u0027tenant_id\u0027, show_log)"},{"line_number":71,"context_line":"        self.assertEqual(self.admin_client.tenant_id,"},{"line_number":72,"context_line":"                         show_log[\u0027project_id\u0027])"},{"line_number":73,"context_line":"        self.assertEqual(self.admin_client.tenant_id,"},{"line_number":74,"context_line":"                         show_log[\u0027tenant_id\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @decorators.idempotent_id(\u0027ef1a6de8-7c19-469c-bdf0-7d72eca99670\u0027)"},{"line_number":77,"context_line":"    def test_list_log_filter_by_name(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_66310a0c","line":74,"range":{"start_line":64,"start_character":4,"end_line":74,"end_character":47},"updated":"2017-08-09 14:15:41.000000000","message":"Why does logging need this test? Does the logging feature have specific mechanism for project_id?","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6ff5e9915dae15410d5679d2ebf21eeb362f961c","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @decorators.idempotent_id(\u0027e1dc2b30-1d80-48d3-ac29-b2b2af8f559e\u0027)"},{"line_number":63,"context_line":"    @test.requires_ext(extension\u003d\"project-id\", service\u003d\"network\")"},{"line_number":64,"context_line":"    def test_show_log_has_project_id(self):"},{"line_number":65,"context_line":"        log \u003d self.create_log(name\u003d\u0027test-log\u0027,"},{"line_number":66,"context_line":"                              resource_type\u003d\u0027security_group\u0027)"},{"line_number":67,"context_line":"        body \u003d self.admin_client.show_log(log[\u0027id\u0027])"},{"line_number":68,"context_line":"        show_log \u003d body[\u0027log\u0027]"},{"line_number":69,"context_line":"        self.assertIn(\u0027project_id\u0027, show_log)"},{"line_number":70,"context_line":"        self.assertIn(\u0027tenant_id\u0027, show_log)"},{"line_number":71,"context_line":"        self.assertEqual(self.admin_client.tenant_id,"},{"line_number":72,"context_line":"                         show_log[\u0027project_id\u0027])"},{"line_number":73,"context_line":"        self.assertEqual(self.admin_client.tenant_id,"},{"line_number":74,"context_line":"                         show_log[\u0027tenant_id\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @decorators.idempotent_id(\u0027ef1a6de8-7c19-469c-bdf0-7d72eca99670\u0027)"},{"line_number":77,"context_line":"    def test_list_log_filter_by_name(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_41d13efb","line":74,"range":{"start_line":64,"start_character":4,"end_line":74,"end_character":47},"in_reply_to":"9f436f4f_66310a0c","updated":"2017-08-10 03:22:25.000000000","message":"Basically, we don\u0027t need this test. So we need only test show log, right?","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76bc0f4c0d759e2472d13a1b302c91b51506d3af","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                         show_log[\u0027tenant_id\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @decorators.idempotent_id(\u0027ef1a6de8-7c19-469c-bdf0-7d72eca99670\u0027)"},{"line_number":77,"context_line":"    def test_list_log_filter_by_name(self):"},{"line_number":78,"context_line":"        self.create_log(name\u003d\u0027test\u0027, description\u003d\u0027test log\u0027,"},{"line_number":79,"context_line":"                        resource_type\u003d\u0027security_group\u0027)"},{"line_number":80,"context_line":"        self.create_log(name\u003d\u0027test2\u0027, description\u003d\u0027test log\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_317e9ae4","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":43},"updated":"2017-08-09 14:15:41.000000000","message":"Does logging feature have specific implementation of filter?","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6ff5e9915dae15410d5679d2ebf21eeb362f961c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                         show_log[\u0027tenant_id\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @decorators.idempotent_id(\u0027ef1a6de8-7c19-469c-bdf0-7d72eca99670\u0027)"},{"line_number":77,"context_line":"    def test_list_log_filter_by_name(self):"},{"line_number":78,"context_line":"        self.create_log(name\u003d\u0027test\u0027, description\u003d\u0027test log\u0027,"},{"line_number":79,"context_line":"                        resource_type\u003d\u0027security_group\u0027)"},{"line_number":80,"context_line":"        self.create_log(name\u003d\u0027test2\u0027, description\u003d\u0027test log\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_01f45685","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":43},"in_reply_to":"9f436f4f_317e9ae4","updated":"2017-08-10 03:22:25.000000000","message":"IIUC, we\u0027ve implemented filter feature for logging [1]. However, I think this test also not need. What do you think?\n\nhttps://github.com/openstack/neutron/blob/master/neutron/services/logapi/logging_plugin.py#L48","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76bc0f4c0d759e2472d13a1b302c91b51506d3af","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            name\u003d\u0027test\u0027, description\u003d\u0027test log desc\u0027,"},{"line_number":93,"context_line":"            resource_type\u003d\u0027security_group\u0027)[\u0027log\u0027]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        retrieved_log \u003d self.admin_client.show_log(log[\u0027id\u0027])"},{"line_number":96,"context_line":"        retrieved_log \u003d retrieved_log[\u0027log\u0027]"},{"line_number":97,"context_line":"        self.assertEqual(\u0027test\u0027, retrieved_log[\u0027name\u0027])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.admin_client.delete_log(log[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_461966d5","line":96,"range":{"start_line":95,"start_character":8,"end_line":96,"end_character":44},"updated":"2017-08-09 14:15:41.000000000","message":"ditto","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6ff5e9915dae15410d5679d2ebf21eeb362f961c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            name\u003d\u0027test\u0027, description\u003d\u0027test log desc\u0027,"},{"line_number":93,"context_line":"            resource_type\u003d\u0027security_group\u0027)[\u0027log\u0027]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        retrieved_log \u003d self.admin_client.show_log(log[\u0027id\u0027])"},{"line_number":96,"context_line":"        retrieved_log \u003d retrieved_log[\u0027log\u0027]"},{"line_number":97,"context_line":"        self.assertEqual(\u0027test\u0027, retrieved_log[\u0027name\u0027])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.admin_client.delete_log(log[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_c12beee8","line":96,"range":{"start_line":95,"start_character":8,"end_line":96,"end_character":44},"in_reply_to":"9f436f4f_461966d5","updated":"2017-08-10 03:22:25.000000000","message":"Done","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76bc0f4c0d759e2472d13a1b302c91b51506d3af","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                          self.admin_client.show_log, log[\u0027id\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.idempotent_id(\u00271af6cdab-0eb0-4e13-8027-d89cf1c7a87a\u0027)"},{"line_number":104,"context_line":"    def test_list_supported_logging_types(self):"},{"line_number":105,"context_line":"        expected_log_keys \u003d [\u0027type\u0027]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        log_types \u003d self.admin_client.list_loggable_resources()"},{"line_number":108,"context_line":"        actual_list_log_types \u003d log_types[\u0027loggable_resources\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_86a86e1f","line":105,"range":{"start_line":104,"start_character":4,"end_line":105,"end_character":36},"updated":"2017-08-09 14:15:41.000000000","message":"What is this for? Why do you check key of loggable_resources not value?","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6ff5e9915dae15410d5679d2ebf21eeb362f961c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                          self.admin_client.show_log, log[\u0027id\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @decorators.idempotent_id(\u00271af6cdab-0eb0-4e13-8027-d89cf1c7a87a\u0027)"},{"line_number":104,"context_line":"    def test_list_supported_logging_types(self):"},{"line_number":105,"context_line":"        expected_log_keys \u003d [\u0027type\u0027]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        log_types \u003d self.admin_client.list_loggable_resources()"},{"line_number":108,"context_line":"        actual_list_log_types \u003d log_types[\u0027loggable_resources\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_6138c23c","line":105,"range":{"start_line":104,"start_character":4,"end_line":105,"end_character":36},"in_reply_to":"9f436f4f_86a86e1f","updated":"2017-08-10 03:22:25.000000000","message":"It should be check value. Done.","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"}],"neutron/tests/tempest/api/test_logging_negative.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76bc0f4c0d759e2472d13a1b302c91b51506d3af","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":29,"context_line":"    @decorators.idempotent_id(\u00275fc61e24-cad5-4d86-a2d4-f40c0fa0a54c\u0027)"},{"line_number":30,"context_line":"    def test_add_log_with_too_long_name(self):"},{"line_number":31,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":32,"context_line":"                          self.client.create_log,"},{"line_number":33,"context_line":"                          LONG_NAME_NG, \u0027test log desc1\u0027, False)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u00277ed63170-0748-44b7-b0a0-64bfd9390dac\u0027)"},{"line_number":37,"context_line":"    def test_add_log_with_too_long_description(self):"},{"line_number":38,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":39,"context_line":"                          self.client.create_log,"},{"line_number":40,"context_line":"                          \u0027test-log\u0027, LONG_DESCRIPTION_NG, False)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":43,"context_line":"    @decorators.idempotent_id(\u002789194c6b-8f47-400b-979b-072b1c1f767b\u0027)"},{"line_number":44,"context_line":"    def test_add_log_with_too_long_tenant_id(self):"},{"line_number":45,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":46,"context_line":"                          self.client.create_log,"},{"line_number":47,"context_line":"                          \u0027test-log\u0027, \u0027test log desc1\u0027,"},{"line_number":48,"context_line":"                          False, LONG_TENANT_ID_NG)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_317b3a8d","line":48,"range":{"start_line":30,"start_character":4,"end_line":48,"end_character":51},"updated":"2017-08-09 14:15:41.000000000","message":"These tests are unnecessary because they are checked by API validator and not related to logging implementation. We should add specific tests for logging, for example, POST with invalid resource type.","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6ff5e9915dae15410d5679d2ebf21eeb362f961c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":29,"context_line":"    @decorators.idempotent_id(\u00275fc61e24-cad5-4d86-a2d4-f40c0fa0a54c\u0027)"},{"line_number":30,"context_line":"    def test_add_log_with_too_long_name(self):"},{"line_number":31,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":32,"context_line":"                          self.client.create_log,"},{"line_number":33,"context_line":"                          LONG_NAME_NG, \u0027test log desc1\u0027, False)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u00277ed63170-0748-44b7-b0a0-64bfd9390dac\u0027)"},{"line_number":37,"context_line":"    def test_add_log_with_too_long_description(self):"},{"line_number":38,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":39,"context_line":"                          self.client.create_log,"},{"line_number":40,"context_line":"                          \u0027test-log\u0027, LONG_DESCRIPTION_NG, False)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":43,"context_line":"    @decorators.idempotent_id(\u002789194c6b-8f47-400b-979b-072b1c1f767b\u0027)"},{"line_number":44,"context_line":"    def test_add_log_with_too_long_tenant_id(self):"},{"line_number":45,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":46,"context_line":"                          self.client.create_log,"},{"line_number":47,"context_line":"                          \u0027test-log\u0027, \u0027test log desc1\u0027,"},{"line_number":48,"context_line":"                          False, LONG_TENANT_ID_NG)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_0149f6ce","line":48,"range":{"start_line":30,"start_character":4,"end_line":48,"end_character":51},"in_reply_to":"9f436f4f_317b3a8d","updated":"2017-08-10 03:22:25.000000000","message":"Thanks for your great suggestion. Done.","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"}],"neutron/tests/tempest/scenario/test_logging.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"76bc0f4c0d759e2472d13a1b302c91b51506d3af","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return self._log_data_is_set(log_data, log_id)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @decorators.idempotent_id(\u002735d4b467-8dd9-4df3-b508-da737bfd96aa\u0027)"},{"line_number":57,"context_line":"    def test_log(self):"},{"line_number":58,"context_line":"        \"\"\"This is a basic test that check log data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_117ef66a","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":23},"updated":"2017-08-09 14:15:41.000000000","message":"This test requires security-group and router extension.","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"6ff5e9915dae15410d5679d2ebf21eeb362f961c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return self._log_data_is_set(log_data, log_id)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @decorators.idempotent_id(\u002735d4b467-8dd9-4df3-b508-da737bfd96aa\u0027)"},{"line_number":57,"context_line":"    def test_log(self):"},{"line_number":58,"context_line":"        \"\"\"This is a basic test that check log data"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f436f4f_416dbe30","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":23},"in_reply_to":"9f436f4f_117ef66a","updated":"2017-08-10 03:22:25.000000000","message":"Thanks. Done","commit_id":"d16b0b76303a9e9e516028b09866d1b46ea078ee"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aa9580846869e3c27328acf138bea45935b24031","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def resource_setup(cls):"},{"line_number":42,"context_line":"        super(LoggingTest, cls).resource_setup()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _log_data_is_set(self, log_lines, log_id):"},{"line_number":45,"context_line":"        pattern \u003d re.compile("},{"line_number":46,"context_line":"            r\"^.*action\u003d(ACCEPT|DROP).* log_resource_ids\u003d\\[.*%s.*\" % log_id"},{"line_number":47,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_142a127e","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":24},"updated":"2017-08-11 21:39:56.000000000","message":"Consider naming this _is_log_data_set.","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"fe26590487e3eda8e97cb6bbbc2eeceaf816d985","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def resource_setup(cls):"},{"line_number":42,"context_line":"        super(LoggingTest, cls).resource_setup()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _log_data_is_set(self, log_lines, log_id):"},{"line_number":45,"context_line":"        pattern \u003d re.compile("},{"line_number":46,"context_line":"            r\"^.*action\u003d(ACCEPT|DROP).* log_resource_ids\u003d\\[.*%s.*\" % log_id"},{"line_number":47,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_c923bebc","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":24},"in_reply_to":"9f436f4f_142a127e","updated":"2017-08-14 08:47:05.000000000","message":"Done","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aa9580846869e3c27328acf138bea45935b24031","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        log \u003d self.os_admin.network_client.create_log("},{"line_number":80,"context_line":"            name\u003d\u0027test-log\u0027,"},{"line_number":81,"context_line":"            description\u003d\u0027test-log-decs\u0027,"},{"line_number":82,"context_line":"            resource_type\u003d\u0027security_group\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_b48586d1","line":79,"range":{"start_line":79,"start_character":19,"end_line":79,"end_character":53},"updated":"2017-08-11 21:39:56.000000000","message":"Why not use the helper function you defined here: https://review.openstack.org/#/c/482886/23/neutron/tests/tempest/api/base.py@426?","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"61f840c0980fd8f2d1608ec23c991ff23d22375c","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        fip2 \u003d self.create_and_associate_floatingip(port[\u0027id\u0027])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        log \u003d self.os_admin.network_client.create_log("},{"line_number":80,"context_line":"            name\u003d\u0027test-log\u0027,"},{"line_number":81,"context_line":"            description\u003d\u0027test-log-decs\u0027,"},{"line_number":82,"context_line":"            resource_type\u003d\u0027security_group\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_ff119005","line":79,"range":{"start_line":79,"start_character":19,"end_line":79,"end_character":53},"in_reply_to":"9f436f4f_b48586d1","updated":"2017-08-14 09:44:15.000000000","message":"Actually, only \u0027admin\u0027 is allowed to create_log, But from my understanding, BaseTempestTestCase is inherited from BaseNetworkTest not BaseAdminNetworkTest. Therefore, I can\u0027t use create_log function as you commented. Is my understanding correct?","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"}],"neutron/tests/tempest/services/network/json/network_client.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aa9580846869e3c27328acf138bea45935b24031","unresolved":false,"context_lines":[{"line_number":972,"context_line":"        resp, body \u003d self.delete(uri)"},{"line_number":973,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    def list_logs(self, **filters):"},{"line_number":976,"context_line":"        if filters:"},{"line_number":977,"context_line":"            uri \u003d \u0027%s/log/logs?%s\u0027 % (self.uri_prefix,"},{"line_number":978,"context_line":"                                      urlparse.urlencode(filters))"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_54a9ba21","line":975,"updated":"2017-08-11 21:39:56.000000000","message":"Instead of adding these methods, can\u0027t you reuse L101-179?","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"fe26590487e3eda8e97cb6bbbc2eeceaf816d985","unresolved":false,"context_lines":[{"line_number":972,"context_line":"        resp, body \u003d self.delete(uri)"},{"line_number":973,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    def list_logs(self, **filters):"},{"line_number":976,"context_line":"        if filters:"},{"line_number":977,"context_line":"            uri \u003d \u0027%s/log/logs?%s\u0027 % (self.uri_prefix,"},{"line_number":978,"context_line":"                                      urlparse.urlencode(filters))"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f436f4f_8902560a","line":975,"in_reply_to":"9f436f4f_54a9ba21","updated":"2017-08-14 08:47:05.000000000","message":"Done","commit_id":"c762686be2182a27316f9a148e8a566aa0bd36d0"}]}
