)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Or Idgar \u003coidgar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-12 18:00:46 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Raising an exception when ovs-ofctl fails"},{"line_number":8,"context_line":"run_ofctl will raise an exception when the error message is"},{"line_number":9,"context_line":"unknown or when number of retries exceeded"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_c5621c17","line":7,"updated":"2017-07-12 15:37:19.000000000","message":"the change will need tests to cover the bug","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-07-12 18:00:46 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Raising an exception when ovs-ofctl fails"},{"line_number":8,"context_line":"run_ofctl will raise an exception when the error message is"},{"line_number":9,"context_line":"unknown or when number of retries exceeded"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1828142a6d2d4f90c54f6db87d73e4c52bad7f73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_05c5b43c","line":8,"updated":"2017-07-12 15:37:19.000000000","message":"nit: add a new line between title and the body of the commit message","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Raising an exception when ovs-ofctl fails"},{"line_number":8,"context_line":"run_ofctl will raise an exception when the error message is"},{"line_number":9,"context_line":"unknown or when number of retries exceeded"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1828142a6d2d4f90c54f6db87d73e4c52bad7f73"},{"line_number":12,"context_line":"Closes-Bug: 1672607"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_85e664e8","line":9,"updated":"2017-07-12 15:37:19.000000000","message":"nit: trailing dot needed","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"}],"neutron/agent/common/exceptions.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_c5057c7c","line":1,"updated":"2017-07-12 15:37:19.000000000","message":"afaik you don\u0027t work for the foundation, so either remove the line, or replace with the current year, and info on real copyright holder.","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Exceptions used by neutron agent.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import exceptions as e"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_45884cc5","line":16,"range":{"start_line":16,"start_character":19,"end_line":16,"end_character":35},"updated":"2017-07-12 15:37:19.000000000","message":"which of them? based on the module name, seems like \u0027all of them\u0027, though the exception you added is openvswitch specific.","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron._i18n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class OVSOpenFlowCLIError(e.NeutronException):"},{"line_number":24,"context_line":"    \"\"\"Call to ovs-ofctl failed.\"\"\""},{"line_number":25,"context_line":"    message \u003d _(\"Calling to ovs-ofctl failed. Error: %(errormsg)s\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_2524300d","line":23,"updated":"2017-07-12 15:37:19.000000000","message":"the name of the module (common.exceptions) suggest that it will contain exceptions that are common across all agents we have (linuxbridge, sriov and whatnot), but this is openvswitch specific. Consider finding a better place for the exception.","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class OVSOpenFlowCLIError(e.NeutronException):"},{"line_number":24,"context_line":"    \"\"\"Call to ovs-ofctl failed.\"\"\""},{"line_number":25,"context_line":"    message \u003d _(\"Calling to ovs-ofctl failed. Error: %(errormsg)s\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_c5c69c17","line":24,"updated":"2017-07-12 15:37:19.000000000","message":"nit: seems rather duplicating, considering the message is almost the same. Consider removing the line.","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class OVSOpenFlowCLIError(e.NeutronException):"},{"line_number":24,"context_line":"    \"\"\"Call to ovs-ofctl failed.\"\"\""},{"line_number":25,"context_line":"    message \u003d _(\"Calling to ovs-ofctl failed. Error: %(errormsg)s\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_2500b034","line":25,"range":{"start_line":25,"start_character":14,"end_line":25,"end_character":15},"updated":"2017-07-12 15:37:19.000000000","message":"for what I understand, this message will never pop up to users, but will be logged in log files. We don\u0027t translate log messages since Pike, so consider removing the translation mark.","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class OVSOpenFlowCLIError(e.NeutronException):"},{"line_number":24,"context_line":"    \"\"\"Call to ovs-ofctl failed.\"\"\""},{"line_number":25,"context_line":"    message \u003d _(\"Calling to ovs-ofctl failed. Error: %(errormsg)s\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_2569d024","line":25,"range":{"start_line":25,"start_character":55,"end_line":25,"end_character":63},"updated":"2017-07-12 15:37:19.000000000","message":"nit: I would go with just \u0027msg\u0027 for density","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7341b30ef26ec596d288a070534af1cc8fc3227b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class OVSOpenFlowCLIError(Exception):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    message \u003d \"Calling to ovs-ofctl failed. Error: %(msg)s\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def __init__(self, **kwargs):"},{"line_number":22,"context_line":"        super(OVSOpenFlowCLIError, self).__init__(self.message % kwargs)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_bb37d7e3","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":22},"updated":"2017-07-25 21:14:02.000000000","message":"Nit: Call","commit_id":"47af1e6d8abe55221628bf5d83c4eda6b6b1adca"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"df6d5fb7df1ae4f9e6ed12dc9203326bd646e35a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class OVSOpenFlowCLIError(Exception):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    message \u003d \"Call to ovs-ofctl failed. Error: %(msg)s\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def __init__(self, **kwargs):"},{"line_number":22,"context_line":"        super(OVSOpenFlowCLIError, self).__init__(self.message % kwargs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_58531e40","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":56},"updated":"2017-08-03 09:58:22.000000000","message":"let move this to __init__","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4d35f808e5024ba427046646a6804c84bb7b6b32","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class OVSOpenFlowCLIError(Exception):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    message \u003d \"Call to ovs-ofctl failed. Error: %(msg)s\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def __init__(self, **kwargs):"},{"line_number":22,"context_line":"        super(OVSOpenFlowCLIError, self).__init__(self.message % kwargs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_db3dc82b","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":56},"in_reply_to":"df3967d1_58531e40","updated":"2017-08-03 10:23:52.000000000","message":"No need to create constant string per call, having a class attribute is more convenient.","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98d630124e074f854ebc223f418dbf4ef0fff0cf","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class OVSOpenFlowCLIError(Exception):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    message \u003d \"Call to ovs-ofctl failed. Error: %(msg)s\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def __init__(self, **kwargs):"},{"line_number":22,"context_line":"        super(OVSOpenFlowCLIError, self).__init__(self.message % kwargs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_8ca704a8","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":56},"in_reply_to":"df3967d1_db3dc82b","updated":"2017-08-03 11:59:02.000000000","message":"Why is this not being translated _()","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7c908764d47287885e92aea70d3514a727fad56e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron._i18n import _"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OVSOpenFlowCLIError(Exception):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    message \u003d _(\"Call to ovs-ofctl failed. Error: %(msg)s\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f436f4f_3dda764a","line":17,"updated":"2017-08-14 17:29:02.000000000","message":"You need another blank line here","commit_id":"b7ea2abd1b9c268d955a401eb1681b5dd6759746"},{"author":{"_account_id":25899,"name":"Or Idgar","email":"oidgar@redhat.com","username":"oidgar"},"change_message_id":"e81fb0bb297f7c5b38ccd31000cc2085f631048b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron._i18n import _"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OVSOpenFlowCLIError(Exception):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    message \u003d _(\"Call to ovs-ofctl failed. Error: %(msg)s\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f436f4f_0abd1801","line":17,"in_reply_to":"9f436f4f_3dda764a","updated":"2017-08-15 08:21:41.000000000","message":"my mistake. will be fixed right up in another patch.","commit_id":"b7ea2abd1b9c268d955a401eb1681b5dd6759746"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cedc3fd25f362c21a8fa6651284d67a1eac48730","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron._i18n import _"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class OVSOpenFlowCLIError(Exception):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    message \u003d _(\"Call to ovs-ofctl failed. Error: %(msg)s\")"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_ca7b7e25","line":19,"updated":"2017-08-15 19:15:41.000000000","message":"I guess I repeat myself, but what is \u0027agent common\u0027 in this exception? it seems rather ovs specific to me.","commit_id":"c21595e1541dac23a0ac075469720a93edb74408"},{"author":{"_account_id":25899,"name":"Or Idgar","email":"oidgar@redhat.com","username":"oidgar"},"change_message_id":"30251eea61d2db89e942bc54231fa86bacde02c9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron._i18n import _"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class OVSOpenFlowCLIError(Exception):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    message \u003d _(\"Call to ovs-ofctl failed. Error: %(msg)s\")"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_080ce4a2","line":19,"in_reply_to":"9f436f4f_ca7b7e25","updated":"2017-08-16 07:36:08.000000000","message":"ovs_lib is also under \"agent common\" so I thought that the execptions should also be in the same dir/package...\nDo you still think it should be in another path?","commit_id":"c21595e1541dac23a0ac075469720a93edb74408"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cedc3fd25f362c21a8fa6651284d67a1eac48730","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    message \u003d _(\"Call to ovs-ofctl failed. Error: %(msg)s\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, **kwargs):"},{"line_number":24,"context_line":"        super(OVSOpenFlowCLIError, self).__init__(self.message % kwargs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_2a832a06","line":23,"updated":"2017-08-15 19:15:41.000000000","message":"we allow a single keyword in the message - msg. Should we accept it here instead of vague kwargs?","commit_id":"c21595e1541dac23a0ac075469720a93edb74408"},{"author":{"_account_id":25899,"name":"Or Idgar","email":"oidgar@redhat.com","username":"oidgar"},"change_message_id":"30251eea61d2db89e942bc54231fa86bacde02c9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    message \u003d _(\"Call to ovs-ofctl failed. Error: %(msg)s\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __init__(self, **kwargs):"},{"line_number":24,"context_line":"        super(OVSOpenFlowCLIError, self).__init__(self.message % kwargs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_0831845a","line":23,"in_reply_to":"9f436f4f_2a832a06","updated":"2017-08-16 07:36:08.000000000","message":"no problem, will change it accordingly. good point.","commit_id":"c21595e1541dac23a0ac075469720a93edb74408"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def run_ofctl(self, cmd, args, process_input\u003dNone):"},{"line_number":287,"context_line":"        full_args \u003d [\"ovs-ofctl\", cmd, self.br_name] + args"},{"line_number":288,"context_line":"        # TODO(kevinbenton): This error handling is really brittle and only"},{"line_number":289,"context_line":"        # detects one specific type of failure. The callers of this need to"},{"line_number":290,"context_line":"        # be refactored to expect errors so we can re-raise and they can"},{"line_number":291,"context_line":"        # take appropriate action based on the type of error."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_853ae4e4","line":288,"updated":"2017-07-12 15:37:19.000000000","message":"(No action required) this todo seems relevant. It suggests that there is more work to do with consumers of the method before we can safely raise exceptions from here.","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"83dbae6dd636dffdcf0cac2002f1852d2ec3dddc","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                LOG.error(_LE(\"Unable to execute %(cmd)s. Exception: \""},{"line_number":303,"context_line":"                              \"%(exception)s\"),"},{"line_number":304,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":305,"context_line":"                raise exceptions.OVSOpenFlowCLIError(errormsg\u003dstr(e))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def count_flows(self):"},{"line_number":308,"context_line":"        flow_list \u003d self.run_ofctl(\"dump-flows\", []).split(\"\\n\")[1:]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_a80a5587","line":305,"updated":"2017-07-12 15:37:19.000000000","message":"there are lots of reasons it could happen (from segfault in vswitchd to e.g. missing bridge). I feel that a better way would be to at least start with tackling specific errors we see happening in gate, like we do in line 297+, and see if special handling will tackle all instances of the errors.\n\nAnother idea is to make the caller of the method to be prepared for None returned, and not call .splitlines() on the result without first checking it with \u0027is not None\u0027.\n\nWhen producing the patch, which specific error do you try to tackle? Do you have a link to logs?","commit_id":"10f99722f62a913ae4b98092116e78e513336f49"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4df96080f99bbd243e8f9db7f295d40a5fb8a36d","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                LOG.error(_LE(\"Unable to execute %(cmd)s. Exception: \""},{"line_number":303,"context_line":"                              \"%(exception)s\"),"},{"line_number":304,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":305,"context_line":"                raise exceptions.OVSOpenFlowCLIError(msg\u003dstr(e))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def count_flows(self):"},{"line_number":308,"context_line":"        flow_list \u003d self.run_ofctl(\"dump-flows\", []).split(\"\\n\")[1:]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_00964740","line":305,"updated":"2017-07-17 09:05:16.000000000","message":"The idea of Ihar in PS1 makes sense: every time we find a new error, hadle it properly and document this error with links and logs.","commit_id":"adf6f55ac958b1cb77b57a3f2b69eb6a346a50f9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2db9f794ed7e549b4213a4b10780028e5569b9f1","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                LOG.error(_LE(\"Unable to execute %(cmd)s. Exception: \""},{"line_number":303,"context_line":"                              \"%(exception)s\"),"},{"line_number":304,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":305,"context_line":"                if \"is not a bridge or a socket\" in str(e):"},{"line_number":306,"context_line":"                    raise exceptions.OVSOpenFlowCLIError(msg\u003dstr(e))"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def count_flows(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_217c9b70","line":305,"range":{"start_line":305,"start_character":19,"end_line":305,"end_character":48},"updated":"2017-07-17 15:27:02.000000000","message":"Why is this needed? We had issues with machines using different than English locale. Line 297 is bad too :)\n\nWhat happens if we get 10 times \"failed to connect to socket\"?","commit_id":"baa5bb7a642c0ba83327a844cbdc3dbd1111844f"},{"author":{"_account_id":25899,"name":"Or Idgar","email":"oidgar@redhat.com","username":"oidgar"},"change_message_id":"400831f06ba7ed2f6e8b75ddfdafed4fcb0a2d3f","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                LOG.error(_LE(\"Unable to execute %(cmd)s. Exception: \""},{"line_number":303,"context_line":"                              \"%(exception)s\"),"},{"line_number":304,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":305,"context_line":"                if \"is not a bridge or a socket\" in str(e):"},{"line_number":306,"context_line":"                    raise exceptions.OVSOpenFlowCLIError(msg\u003dstr(e))"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def count_flows(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_c102873d","line":305,"range":{"start_line":305,"start_character":19,"end_line":305,"end_character":48},"in_reply_to":"1f1a1f67_217c9b70","updated":"2017-07-17 15:46:27.000000000","message":"1. because other reviewers asked to keep the same behaviour except for the bug we encountered.\n2. ok, I\u0027ll talk with you about it.\n3. as for #1, they suggested to keep the same behaviour.","commit_id":"baa5bb7a642c0ba83327a844cbdc3dbd1111844f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"96fc2ec8fcb712ea7c7098fb83a391ddc32ba85f","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                return utils.execute(full_args, run_as_root\u003dTrue,"},{"line_number":296,"context_line":"                                     process_input\u003dprocess_input)"},{"line_number":297,"context_line":"            except Exception as e:"},{"line_number":298,"context_line":"                last_except\u003de"},{"line_number":299,"context_line":"                if \"failed to connect to socket\" in str(e):"},{"line_number":300,"context_line":"                    LOG.debug(\"Failed to connect to OVS. Retrying \""},{"line_number":301,"context_line":"                              \"in 1 second. Attempt: %s/10\", i)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_8a6df805","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":29},"updated":"2017-07-25 08:41:58.000000000","message":"You don\u0027t need last_except as e will reference the latest exception.","commit_id":"4e803f4d9e7a34c2f1d0045ba06ab4f8715a097b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"96fc2ec8fcb712ea7c7098fb83a391ddc32ba85f","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                LOG.error(_LE(\"Unable to execute %(cmd)s. Exception: \""},{"line_number":305,"context_line":"                              \"%(exception)s\"),"},{"line_number":306,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":307,"context_line":"                if \"is not a bridge or a socket\" in str(e):"},{"line_number":308,"context_line":"                    break"},{"line_number":309,"context_line":"        raise agent_exceptions.OVSOpenFlowCLIError(msg\u003dstr(last_except))"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_8a46187c","line":307,"updated":"2017-07-25 08:41:58.000000000","message":"I still don\u0027t understand why should we fail right away if there is such string. I\u0027d just remove those two lines and raise an exception if neither call was successful.","commit_id":"4e803f4d9e7a34c2f1d0045ba06ab4f8715a097b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7341b30ef26ec596d288a070534af1cc8fc3227b","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                              \"%(exception)s\"),"},{"line_number":304,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":305,"context_line":"                break"},{"line_number":306,"context_line":"        raise agent_exceptions.OVSOpenFlowCLIError(msg\u003de)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def count_flows(self):"},{"line_number":309,"context_line":"        flow_list \u003d self.run_ofctl(\"dump-flows\", []).split(\"\\n\")[1:]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_40e116d0","line":306,"updated":"2017-07-25 21:14:02.000000000","message":"The behaviors of Python 3 and Python 2.7 are different in regards to the variable e where the exception is stored in L296: http://logs.openstack.org/96/482996/11/check/gate-neutron-python35/9655749/console.html#_2017-07-25_16_11_40_407960. \n\nIn Python 3 e is local to the except block. It is not defined outside it. Run this simple script https://gist.github.com/miguellavalle/bdaeb2a32608d37de0fa816043ebb021 with Python 2.7 and 3 and you will see the difference.\n\nWhy not just replace the break statement with the raise?","commit_id":"47af1e6d8abe55221628bf5d83c4eda6b6b1adca"},{"author":{"_account_id":25899,"name":"Or Idgar","email":"oidgar@redhat.com","username":"oidgar"},"change_message_id":"ffc5bb9579b215b18789377286eeedc4305a5aac","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                              \"%(exception)s\"),"},{"line_number":304,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":305,"context_line":"                break"},{"line_number":306,"context_line":"        raise agent_exceptions.OVSOpenFlowCLIError(msg\u003de)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def count_flows(self):"},{"line_number":309,"context_line":"        flow_list \u003d self.run_ofctl(\"dump-flows\", []).split(\"\\n\")[1:]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_fd98a91b","line":306,"in_reply_to":"ff346bd7_40e116d0","updated":"2017-07-26 06:55:32.000000000","message":"1. I\u0027ll save the value in outer block variable to maintain compatibility for both Python 2.7 and 3.\n2. About the break statement, it is because if the number of retries exceeded we still want to raise an exception (calling to utils.execute will not occur).","commit_id":"47af1e6d8abe55221628bf5d83c4eda6b6b1adca"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2eec6f01d8bd30985bc2896aaf9addd60ca73d45","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                              \"%(exception)s\"),"},{"line_number":304,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":305,"context_line":"                break"},{"line_number":306,"context_line":"        raise agent_exceptions.OVSOpenFlowCLIError(msg\u003de)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def count_flows(self):"},{"line_number":309,"context_line":"        flow_list \u003d self.run_ofctl(\"dump-flows\", []).split(\"\\n\")[1:]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_c90f63df","line":306,"in_reply_to":"ff346bd7_fd98a91b","updated":"2017-07-26 08:43:45.000000000","message":"Oh, sorry Or, I didn\u0027t know that Python 3 has it this way. I told Or to remove a var to store exception.","commit_id":"47af1e6d8abe55221628bf5d83c4eda6b6b1adca"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98d630124e074f854ebc223f418dbf4ef0fff0cf","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def run_ofctl(self, cmd, args, process_input\u003dNone):"},{"line_number":287,"context_line":"        full_args \u003d [\"ovs-ofctl\", cmd, self.br_name] + args"},{"line_number":288,"context_line":"        last_except \u003d None"},{"line_number":289,"context_line":"        # TODO(kevinbenton): This error handling is really brittle and only"},{"line_number":290,"context_line":"        # detects one specific type of failure. The callers of this need to"},{"line_number":291,"context_line":"        # be refactored to expect errors so we can re-raise and they can"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_acc3e837","line":288,"range":{"start_line":288,"start_character":8,"end_line":288,"end_character":19},"updated":"2017-08-03 11:59:02.000000000","message":"why not last_exception?","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"790bad0b22f4c562523f3396982e33d5ef35b23c","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def run_ofctl(self, cmd, args, process_input\u003dNone):"},{"line_number":287,"context_line":"        full_args \u003d [\"ovs-ofctl\", cmd, self.br_name] + args"},{"line_number":288,"context_line":"        last_except \u003d None"},{"line_number":289,"context_line":"        # TODO(kevinbenton): This error handling is really brittle and only"},{"line_number":290,"context_line":"        # detects one specific type of failure. The callers of this need to"},{"line_number":291,"context_line":"        # be refactored to expect errors so we can re-raise and they can"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_63062a1f","line":288,"range":{"start_line":288,"start_character":8,"end_line":288,"end_character":19},"in_reply_to":"df3967d1_acc3e837","updated":"2017-08-03 14:42:28.000000000","message":"I\u0027ll bet L308 wraps :)","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ee7b640c4b7ef75062821ea6f2934a875b2a5bb4","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        # TODO(kevinbenton): This error handling is really brittle and only"},{"line_number":290,"context_line":"        # detects one specific type of failure. The callers of this need to"},{"line_number":291,"context_line":"        # be refactored to expect errors so we can re-raise and they can"},{"line_number":292,"context_line":"        # take appropriate action based on the type of error."},{"line_number":293,"context_line":"        for i in range(1, 11):"},{"line_number":294,"context_line":"            try:"},{"line_number":295,"context_line":"                return utils.execute(full_args, run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_7016f7aa","line":292,"updated":"2017-08-14 06:32:00.000000000","message":"This comment says we need to update callers too if we decide to raise exceptions from run_ofctl.","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ee7b640c4b7ef75062821ea6f2934a875b2a5bb4","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                return utils.execute(full_args, run_as_root\u003dTrue,"},{"line_number":296,"context_line":"                                     process_input\u003dprocess_input)"},{"line_number":297,"context_line":"            except Exception as e:"},{"line_number":298,"context_line":"                last_except \u003d e"},{"line_number":299,"context_line":"                if \"failed to connect to socket\" in str(e):"},{"line_number":300,"context_line":"                    LOG.debug(\"Failed to connect to OVS. Retrying \""},{"line_number":301,"context_line":"                              \"in 1 second. Attempt: %s/10\", i)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_f0d1c724","line":298,"updated":"2017-08-14 06:32:00.000000000","message":"Is this substitution needed?\nJust using e seems fine.","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2a418e736ae98dfb187042c51f8b03a93988985a","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                return utils.execute(full_args, run_as_root\u003dTrue,"},{"line_number":296,"context_line":"                                     process_input\u003dprocess_input)"},{"line_number":297,"context_line":"            except Exception as e:"},{"line_number":298,"context_line":"                last_except \u003d e"},{"line_number":299,"context_line":"                if \"failed to connect to socket\" in str(e):"},{"line_number":300,"context_line":"                    LOG.debug(\"Failed to connect to OVS. Retrying \""},{"line_number":301,"context_line":"                              \"in 1 second. Attempt: %s/10\", i)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_c4fcc0b6","line":298,"in_reply_to":"9f436f4f_410b2223","updated":"2017-08-14 12:50:55.000000000","message":"Python 3.5 - it was pointed out in one of previous PS.","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":25899,"name":"Or Idgar","email":"oidgar@redhat.com","username":"oidgar"},"change_message_id":"fbcd33035780c7f2ce8ab71585000884e6e7bb94","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                return utils.execute(full_args, run_as_root\u003dTrue,"},{"line_number":296,"context_line":"                                     process_input\u003dprocess_input)"},{"line_number":297,"context_line":"            except Exception as e:"},{"line_number":298,"context_line":"                last_except \u003d e"},{"line_number":299,"context_line":"                if \"failed to connect to socket\" in str(e):"},{"line_number":300,"context_line":"                    LOG.debug(\"Failed to connect to OVS. Retrying \""},{"line_number":301,"context_line":"                              \"in 1 second. Attempt: %s/10\", i)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_410b2223","line":298,"in_reply_to":"9f436f4f_f0d1c724","updated":"2017-08-14 12:35:20.000000000","message":"As I know in python 2.7 you cannot use e outside the except block so I must save it to a different variable","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ee7b640c4b7ef75062821ea6f2934a875b2a5bb4","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                              \"%(exception)s\"),"},{"line_number":306,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":307,"context_line":"                break"},{"line_number":308,"context_line":"        raise agent_exceptions.OVSOpenFlowCLIError(msg\u003dlast_except)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def count_flows(self):"},{"line_number":311,"context_line":"        flow_list \u003d self.run_ofctl(\"dump-flows\", []).split(\"\\n\")[1:]"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_708cb735","line":308,"updated":"2017-08-14 06:32:00.000000000","message":"... if you move this line to the above break statement location.","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":25899,"name":"Or Idgar","email":"oidgar@redhat.com","username":"oidgar"},"change_message_id":"fbcd33035780c7f2ce8ab71585000884e6e7bb94","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                              \"%(exception)s\"),"},{"line_number":306,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":307,"context_line":"                break"},{"line_number":308,"context_line":"        raise agent_exceptions.OVSOpenFlowCLIError(msg\u003dlast_except)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def count_flows(self):"},{"line_number":311,"context_line":"        flow_list \u003d self.run_ofctl(\"dump-flows\", []).split(\"\\n\")[1:]"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_81534a17","line":308,"in_reply_to":"9f436f4f_708cb735","updated":"2017-08-14 12:35:20.000000000","message":"but then if the number of retries exceeded it won\u0027t raise an exception, only in certain case that different than \"failed to connect to socket\"...","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"85623364c9b06984c32ac2bea5c2f5341f5edc9d","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                              \"%(exception)s\"),"},{"line_number":306,"context_line":"                          {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":307,"context_line":"                break"},{"line_number":308,"context_line":"        raise agent_exceptions.OVSOpenFlowCLIError(msg\u003dlast_except)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def count_flows(self):"},{"line_number":311,"context_line":"        flow_list \u003d self.run_ofctl(\"dump-flows\", []).split(\"\\n\")[1:]"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_e72fb43c","line":308,"in_reply_to":"9f436f4f_81534a17","updated":"2017-08-15 02:20:56.000000000","message":"Oh I see.","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":25899,"name":"Or Idgar","email":"oidgar@redhat.com","username":"oidgar"},"change_message_id":"30251eea61d2db89e942bc54231fa86bacde02c9","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        # TODO(kevinbenton): This error handling is really brittle and only"},{"line_number":290,"context_line":"        # detects one specific type of failure. The callers of this need to"},{"line_number":291,"context_line":"        # be refactored to expect errors so we can re-raise and they can"},{"line_number":292,"context_line":"        # take appropriate action based on the type of error."},{"line_number":293,"context_line":"        for i in range(1, 11):"},{"line_number":294,"context_line":"            try:"},{"line_number":295,"context_line":"                return utils.execute(full_args, run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_081aa4ca","line":292,"range":{"start_line":292,"start_character":12,"end_line":292,"end_character":26},"updated":"2017-08-16 07:36:08.000000000","message":"I think you right,it won\u0027t be applicable after this patch.\nWill remove it.","commit_id":"c21595e1541dac23a0ac075469720a93edb74408"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cedc3fd25f362c21a8fa6651284d67a1eac48730","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        # TODO(kevinbenton): This error handling is really brittle and only"},{"line_number":290,"context_line":"        # detects one specific type of failure. The callers of this need to"},{"line_number":291,"context_line":"        # be refactored to expect errors so we can re-raise and they can"},{"line_number":292,"context_line":"        # take appropriate action based on the type of error."},{"line_number":293,"context_line":"        for i in range(1, 11):"},{"line_number":294,"context_line":"            try:"},{"line_number":295,"context_line":"                return utils.execute(full_args, run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_eace4261","line":292,"updated":"2017-08-15 19:15:41.000000000","message":"so isn\u0027t this TODO still applicable? are all callers ready for exceptions being raised? if it\u0027s not applicable, then let\u0027s remove it; though I doubt it\u0027s not.","commit_id":"c21595e1541dac23a0ac075469720a93edb74408"}],"neutron/tests/unit/agent/common/test_ovs_lib.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2db9f794ed7e549b4213a4b10780028e5569b9f1","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    def test_run_ofctl_daemon_unavailable(self):"},{"line_number":464,"context_line":"        self.execute.side_effect \u003d Exception(\"ovs-ofctl: br-int is not a bridge or a socket\")"},{"line_number":465,"context_line":"        self.assertRaises(agent_except.OVSOpenFlowCLIError, self.br.run_ofctl, \u0027dump-flows\u0027, [\u0027br-int\u0027])"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    def test_add_tunnel_port(self):"},{"line_number":468,"context_line":"        pname \u003d \"tap99\""},{"line_number":469,"context_line":"        local_ip \u003d \"1.1.1.1\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_e1c7c395","line":466,"updated":"2017-07-17 15:27:02.000000000","message":"Can you please also add test where we fail 10 times with \"failed to connect to socket\" - that\u0027s what happened in the bug when ovs-vswitchd crashed, isn\u0027t it?","commit_id":"baa5bb7a642c0ba83327a844cbdc3dbd1111844f"},{"author":{"_account_id":25899,"name":"Or Idgar","email":"oidgar@redhat.com","username":"oidgar"},"change_message_id":"400831f06ba7ed2f6e8b75ddfdafed4fcb0a2d3f","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    def test_run_ofctl_daemon_unavailable(self):"},{"line_number":464,"context_line":"        self.execute.side_effect \u003d Exception(\"ovs-ofctl: br-int is not a bridge or a socket\")"},{"line_number":465,"context_line":"        self.assertRaises(agent_except.OVSOpenFlowCLIError, self.br.run_ofctl, \u0027dump-flows\u0027, [\u0027br-int\u0027])"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    def test_add_tunnel_port(self):"},{"line_number":468,"context_line":"        pname \u003d \"tap99\""},{"line_number":469,"context_line":"        local_ip \u003d \"1.1.1.1\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f1a1f67_c154c755","line":466,"in_reply_to":"1f1a1f67_e1c7c395","updated":"2017-07-17 15:46:27.000000000","message":"I don\u0027t think so, I tried running ovs-ofctl when ovs-vswitchd is down and I got \"is not a bridge or a socket\".\nI can add it anyway.","commit_id":"baa5bb7a642c0ba83327a844cbdc3dbd1111844f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b82c642a4d8d67af82226c9241581186dc794480","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        err \u003d RuntimeError(\u0027failed to connect to socket\u0027)"},{"line_number":465,"context_line":"        self.execute.side_effect \u003d [err] * 10"},{"line_number":466,"context_line":"        with mock.patch(\u0027time.sleep\u0027) as sleep:"},{"line_number":467,"context_line":"            self.assertRaises(agent_except.OVSOpenFlowCLIError, self.br.run_ofctl,"},{"line_number":468,"context_line":"                           \u0027dump-flows\u0027, [\u0027br-int\u0027])"},{"line_number":469,"context_line":"        self.assertEqual(10, self.execute.call_count)"},{"line_number":470,"context_line":"        self.assertEqual(10, sleep.call_count)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff346bd7_4037efe4","line":467,"updated":"2017-07-25 09:11:57.000000000","message":"It\u0027s gonna (hopefully :)) fail pep8 job, too long line","commit_id":"adeff74d9b9acca977de3bbed7542be3cff44fa4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b82c642a4d8d67af82226c9241581186dc794480","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        self.execute.side_effect \u003d [err] * 10"},{"line_number":466,"context_line":"        with mock.patch(\u0027time.sleep\u0027) as sleep:"},{"line_number":467,"context_line":"            self.assertRaises(agent_except.OVSOpenFlowCLIError, self.br.run_ofctl,"},{"line_number":468,"context_line":"                           \u0027dump-flows\u0027, [\u0027br-int\u0027])"},{"line_number":469,"context_line":"        self.assertEqual(10, self.execute.call_count)"},{"line_number":470,"context_line":"        self.assertEqual(10, sleep.call_count)"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff346bd7_20362be8","line":468,"updated":"2017-07-25 09:11:57.000000000","message":"Indentation is wrong","commit_id":"adeff74d9b9acca977de3bbed7542be3cff44fa4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b82c642a4d8d67af82226c9241581186dc794480","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        self.execute.side_effect \u003d [err] * 10"},{"line_number":466,"context_line":"        with mock.patch(\u0027time.sleep\u0027) as sleep:"},{"line_number":467,"context_line":"            self.assertRaises(agent_except.OVSOpenFlowCLIError, self.br.run_ofctl,"},{"line_number":468,"context_line":"                           \u0027dump-flows\u0027, [\u0027br-int\u0027])"},{"line_number":469,"context_line":"        self.assertEqual(10, self.execute.call_count)"},{"line_number":470,"context_line":"        self.assertEqual(10, sleep.call_count)"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff346bd7_a0f33b0a","line":468,"range":{"start_line":468,"start_character":42,"end_line":468,"end_character":50},"updated":"2017-07-25 09:11:57.000000000","message":"This is done by run_ofctl itself as it\u0027s tied to self.br [1]. Should be empty list\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/agent/common/ovs_lib.py#L286","commit_id":"adeff74d9b9acca977de3bbed7542be3cff44fa4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b82c642a4d8d67af82226c9241581186dc794480","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        self.execute.side_effect \u003d Exception("},{"line_number":474,"context_line":"            \"ovs-ofctl: br-int is not a bridge or a socket\")"},{"line_number":475,"context_line":"        self.assertRaises(agent_except.OVSOpenFlowCLIError, self.br.run_ofctl,"},{"line_number":476,"context_line":"                           \u0027dump-flows\u0027, [\u0027br-int\u0027])"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test_add_tunnel_port(self):"},{"line_number":479,"context_line":"        pname \u003d \"tap99\""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff346bd7_a057bb02","line":476,"updated":"2017-07-25 09:11:57.000000000","message":"indentation","commit_id":"adeff74d9b9acca977de3bbed7542be3cff44fa4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"27657771a736e7dc1616dc6d5150641f34b4cf79","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        self.execute.side_effect \u003d [err] * 10"},{"line_number":466,"context_line":"        with mock.patch(\u0027time.sleep\u0027) as sleep:"},{"line_number":467,"context_line":"            self.assertRaises(agent_except.OVSOpenFlowCLIError,"},{"line_number":468,"context_line":"                              self.br.run_ofctl, \u0027dump-flows\u0027, [\u0027br-int\u0027])"},{"line_number":469,"context_line":"        self.assertEqual(10, self.execute.call_count)"},{"line_number":470,"context_line":"        self.assertEqual(10, sleep.call_count)"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_fe40c337","line":468,"range":{"start_line":468,"start_character":64,"end_line":468,"end_character":72},"updated":"2017-07-25 11:37:24.000000000","message":"Unaddressed comment from previous PS. Should be empty list.","commit_id":"439689d5a5c334e3fc95adfc6726442627ef45f1"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ee7b640c4b7ef75062821ea6f2934a875b2a5bb4","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        self.execute.side_effect \u003d None"},{"line_number":457,"context_line":"        self.execute.reset_mock()"},{"line_number":458,"context_line":"        with mock.patch(\u0027time.sleep\u0027) as sleep:"},{"line_number":459,"context_line":"            self.br.run_ofctl(\u0027add-flows\u0027, [])"},{"line_number":460,"context_line":"        self.assertEqual(0, sleep.call_count)"},{"line_number":461,"context_line":"        self.assertEqual(1, self.execute.call_count)"},{"line_number":462,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_70ba77c1","line":459,"updated":"2017-08-14 06:32:00.000000000","message":"I think wrapping this with assertRaises is better than disabling an exception in L.456.","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cc28b5f24b02c3d158c776017acd1373b3e68e6b","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        self.execute.side_effect \u003d RuntimeError("},{"line_number":474,"context_line":"            \"ovs-ofctl: br-int is not a bridge or a socket\")"},{"line_number":475,"context_line":"        self.assertRaises(agent_except.OVSOpenFlowCLIError, self.br.run_ofctl,"},{"line_number":476,"context_line":"                          \u0027dump-flows\u0027, [\u0027br-int\u0027])"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test_add_tunnel_port(self):"},{"line_number":479,"context_line":"        pname \u003d \"tap99\""}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_23fa62bc","line":476,"range":{"start_line":476,"start_character":41,"end_line":476,"end_character":49},"updated":"2017-08-03 14:44:23.000000000","message":"delete","commit_id":"df65c6a72a9be6d8d214e66898334be04c630cce"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7c908764d47287885e92aea70d3514a727fad56e","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        self.execute.side_effect \u003d RuntimeError("},{"line_number":467,"context_line":"            \"ovs-ofctl: br-int is not a bridge or a socket\")"},{"line_number":468,"context_line":"        with mock.patch(\u0027time.sleep\u0027) as sleep:"},{"line_number":469,"context_line":"            self.assertRaises(agent_except.OVSOpenFlowCLIError, self.br.run_ofctl,"},{"line_number":470,"context_line":"                              \u0027dump-flows\u0027, [])"},{"line_number":471,"context_line":"        self.assertEqual(0, sleep.call_count)"},{"line_number":472,"context_line":"        self.assertEqual(1, self.execute.call_count)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f436f4f_fde74e11","line":469,"range":{"start_line":469,"start_character":81,"end_line":469,"end_character":82},"updated":"2017-08-14 17:29:02.000000000","message":"One character too long","commit_id":"b7ea2abd1b9c268d955a401eb1681b5dd6759746"},{"author":{"_account_id":25899,"name":"Or Idgar","email":"oidgar@redhat.com","username":"oidgar"},"change_message_id":"e81fb0bb297f7c5b38ccd31000cc2085f631048b","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        self.execute.side_effect \u003d RuntimeError("},{"line_number":467,"context_line":"            \"ovs-ofctl: br-int is not a bridge or a socket\")"},{"line_number":468,"context_line":"        with mock.patch(\u0027time.sleep\u0027) as sleep:"},{"line_number":469,"context_line":"            self.assertRaises(agent_except.OVSOpenFlowCLIError, self.br.run_ofctl,"},{"line_number":470,"context_line":"                              \u0027dump-flows\u0027, [])"},{"line_number":471,"context_line":"        self.assertEqual(0, sleep.call_count)"},{"line_number":472,"context_line":"        self.assertEqual(1, self.execute.call_count)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f436f4f_eab9b414","line":469,"range":{"start_line":469,"start_character":81,"end_line":469,"end_character":82},"in_reply_to":"9f436f4f_fde74e11","updated":"2017-08-15 08:21:41.000000000","message":"my mistake. will be fixed right up in another patch.","commit_id":"b7ea2abd1b9c268d955a401eb1681b5dd6759746"}]}
