)]}'
{"neutron/tests/unit/plugins/ml2/drivers/l2pop/test_mech_driver.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2664d77f09b66fc55ab747b51eebd70d156100e5","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"                    }"},{"line_number":1154,"context_line":"                }"},{"line_number":1155,"context_line":"                mock.patch.object("},{"line_number":1156,"context_line":"                    l2pop_mech, \u0027_get_agent_fdb\u0027, return_value\u003dfdbs).start()"},{"line_number":1157,"context_line":"                # The point is to provide coverage and to assert that"},{"line_number":1158,"context_line":"                # no exceptions are raised."},{"line_number":1159,"context_line":"                l2pop_mech.delete_port_postcommit(port_context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_4773a7e8","line":1156,"updated":"2017-07-12 20:54:45.000000000","message":"Is there any reason we need to mock.patch here? If no reason, I think it is better to patch it at the beginning. This is my vote, but I think it is clearer.","commit_id":"5c331ecbd25be464184e345cea8f38bb9fc712fc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"24fee0fe2a9176eb404124c6b0d5378a008b7f5b","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"                    }"},{"line_number":1154,"context_line":"                }"},{"line_number":1155,"context_line":"                mock.patch.object("},{"line_number":1156,"context_line":"                    l2pop_mech, \u0027_get_agent_fdb\u0027, return_value\u003dfdbs).start()"},{"line_number":1157,"context_line":"                # The point is to provide coverage and to assert that"},{"line_number":1158,"context_line":"                # no exceptions are raised."},{"line_number":1159,"context_line":"                l2pop_mech.delete_port_postcommit(port_context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_78f75ef7","line":1156,"in_reply_to":"1f1a1f67_3d0f982f","updated":"2017-07-12 22:41:25.000000000","message":"What I thought is to add mock.patch just after \"with self.port()\".\n\nYour point totally makes sense. I missed that point. Thanks!","commit_id":"5c331ecbd25be464184e345cea8f38bb9fc712fc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"82e52795ed4fcb983ff0c4a5d128cb707b9f38f3","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"                    }"},{"line_number":1154,"context_line":"                }"},{"line_number":1155,"context_line":"                mock.patch.object("},{"line_number":1156,"context_line":"                    l2pop_mech, \u0027_get_agent_fdb\u0027, return_value\u003dfdbs).start()"},{"line_number":1157,"context_line":"                # The point is to provide coverage and to assert that"},{"line_number":1158,"context_line":"                # no exceptions are raised."},{"line_number":1159,"context_line":"                l2pop_mech.delete_port_postcommit(port_context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_3d0f982f","line":1156,"in_reply_to":"1f1a1f67_4773a7e8","updated":"2017-07-12 21:33:59.000000000","message":"beginning of what, the test case? I can do it, but I actually thought that\u0027s better to reduce the scope of any mocks where not needed...","commit_id":"5c331ecbd25be464184e345cea8f38bb9fc712fc"}]}