)]}'
{"neutron/plugins/midonet/plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"97f71af1a2816481255b5e758d88fe60f64f1799","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                                  fanout\u003dFalse)"},{"line_number":364,"context_line":"        # Consume from all consumers in a thread"},{"line_number":365,"context_line":"        self.conn.consume_in_thread()"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":368,"context_line":"        \"\"\"Create Neutron subnet."},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FdQk%3D","line":366,"updated":"2013-09-26 12:21:50.000000000","message":"Is there a UT case demonstrating the case when DHCP is not enabled?","commit_id":"698a643b6c74b0e823c393e6ebdfd86ac9ff95b0"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"97f71af1a2816481255b5e758d88fe60f64f1799","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            gateway_ip \u003d s[\u0027gateway_ip\u0027]"},{"line_number":385,"context_line":"            cidr \u003d s[\u0027cidr\u0027]"},{"line_number":386,"context_line":"            if s[\u0027enable_dhcp\u0027]:"},{"line_number":387,"context_line":"                dns_nameservers \u003d None"},{"line_number":388,"context_line":"                host_routes \u003d None"},{"line_number":389,"context_line":"                if s[\u0027dns_nameservers\u0027] is not attributes.ATTR_NOT_SPECIFIED:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FdQo%3D","line":386,"updated":"2013-09-26 12:21:50.000000000","message":"Just a thought, but if you change subnet to subnet_info, then s could be renamed to subnet and would make this more readable.","commit_id":"698a643b6c74b0e823c393e6ebdfd86ac9ff95b0"}],"neutron/tests/unit/midonet/test_midonet_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"120b7accf30721cbdea1a2dca31719143edce97d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def test_create_subnet_dhcp_disabled(self):"},{"line_number":133,"context_line":"        super(TestMidonetSubnetsV2, self)._test_create_subnet("},{"line_number":134,"context_line":"            enable_dhcp\u003dFalse)"},{"line_number":135,"context_line":"        assert self.instance.return_value.create_dhcp.called \u003d\u003d 0"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"class TestMidonetPortsV2(test_plugin.TestPortsV2,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2F4Jg%3D","line":135,"updated":"2013-10-25 19:48:12.000000000","message":"self.assertFalse(self.instance.return_value.create_dhcp_called)","commit_id":"83bff3251e1bca3a0461b033013e816f7186caa7"},{"author":{"_account_id":8837,"name":"Joe Mills","email":"joe.h.mills@gmail.com","username":"joemido"},"change_message_id":"fe328479f11a9e3534972fdd9efe579b8aa8392f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def test_create_subnet_dhcp_disabled(self):"},{"line_number":133,"context_line":"        super(TestMidonetSubnetsV2, self)._test_create_subnet("},{"line_number":134,"context_line":"            enable_dhcp\u003dFalse)"},{"line_number":135,"context_line":"        assert self.instance.return_value.create_dhcp.called \u003d\u003d 0"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"class TestMidonetPortsV2(test_plugin.TestPortsV2,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FtRY%3D","line":135,"in_reply_to":"AAAATn%2F%2F4Jg%3D","updated":"2013-10-30 06:40:44.000000000","message":"Done","commit_id":"83bff3251e1bca3a0461b033013e816f7186caa7"}]}