)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"26ecc6d8d4de57f6047d77f0e1f78c4dd23c8a5a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Only ensure default security group exists if necessary"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A default security group will be assigned to a port if there"},{"line_number":10,"context_line":"is no security group attribute set. In many use cases a port may"},{"line_number":11,"context_line":"be created with a security group or with no security groups. The"},{"line_number":12,"context_line":"latter may be in a NFV use case with direct port support."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change save a few cycles, more specifically we do not need to"},{"line_number":15,"context_line":"read from the DB or create a default security group if the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_30edbfb6","line":12,"range":{"start_line":10,"start_character":36,"end_line":12,"end_character":57},"updated":"2017-07-19 08:45:36.000000000","message":"I am not sure this is the majority or not, and this sentence looks unnecessary. How about the following instead?\n\n  A default security group will be assigned .... attribute set.\n  Otherwise there is no need for the default security group\n  and the related logic can be skipped.","commit_id":"6979673d313d4a628355d72f222599a8223b3f6d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"18501e18f6a560021e436791de41879de25b8f21","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Only ensure default security group exists if necessary"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A default security group will be assigned to a port if there"},{"line_number":10,"context_line":"is no security group attribute set. In many use cases a port may"},{"line_number":11,"context_line":"be created with a security group or with no security groups. The"},{"line_number":12,"context_line":"latter may be in a NFV use case with direct port support."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change save a few cycles, more specifically we do not need to"},{"line_number":15,"context_line":"read from the DB or create a default security group if the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_7d6bfeef","line":12,"range":{"start_line":10,"start_character":36,"end_line":12,"end_character":57},"in_reply_to":"1f1a1f67_30edbfb6","updated":"2017-07-19 16:36:24.000000000","message":"I think the part that confused me is that I hadn\u0027t initially noticed that this code path is only executed when handling port security [1]. So I would agree that the commit message is a bit misleading.\n\n[1] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/ml2/plugin.py#n1076","commit_id":"6979673d313d4a628355d72f222599a8223b3f6d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"64dba168fa2e42fcda98b915ce03f58e802d6017","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Only ensure default security group exists if necessary"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A default security group will be assigned to a port if there"},{"line_number":10,"context_line":"is no security group attribute set. In many use cases a port may"},{"line_number":11,"context_line":"be created with a security group or with no security groups. The"},{"line_number":12,"context_line":"latter may be in a NFV use case with direct port support."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change save a few cycles, more specifically we do not need to"},{"line_number":15,"context_line":"read from the DB or create a default security group if the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_2b7524cd","line":12,"range":{"start_line":10,"start_character":36,"end_line":12,"end_character":57},"in_reply_to":"1f1a1f67_7d6bfeef","updated":"2017-07-20 11:57:21.000000000","message":"Done","commit_id":"6979673d313d4a628355d72f222599a8223b3f6d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b026942ed77c61559cd7cefe047dad0f12edd2d8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"read from the DB or create a default security group if the"},{"line_number":16,"context_line":"default will not be used."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"TrivialFix"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib072c2753862ce0709a67942527e9c6241130042"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_8ed7ca4b","line":18,"updated":"2017-07-19 14:07:54.000000000","message":"This is not a backward compatible change. The way this has always worked is that a default security group is provisioned for a tenant no matter what. I would not claim this to be a trivial fix and we need to understand the full implications as to what it means now for potentially having systems with no default group at all.","commit_id":"6979673d313d4a628355d72f222599a8223b3f6d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"64dba168fa2e42fcda98b915ce03f58e802d6017","unresolved":false,"context_lines":[{"line_number":15,"context_line":"read from the DB or create a default security group if the"},{"line_number":16,"context_line":"default will not be used."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"TrivialFix"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib072c2753862ce0709a67942527e9c6241130042"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_cb7b50bc","line":18,"in_reply_to":"1f1a1f67_5d5de276","updated":"2017-07-20 11:57:21.000000000","message":"I can drop this if you guys feel its necessary","commit_id":"6979673d313d4a628355d72f222599a8223b3f6d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6ba7646e6e4af1778ec59b7f98f8001b1cac054e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"read from the DB or create a default security group if the"},{"line_number":16,"context_line":"default will not be used."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"TrivialFix"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib072c2753862ce0709a67942527e9c6241130042"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_5d5de276","line":18,"in_reply_to":"1f1a1f67_8ed7ca4b","updated":"2017-07-19 16:30:56.000000000","message":"it was my understanding that now the method \n_ensure_default_security_group would only be called if the request to create a port specifies a security group. Based on Akihiro\u0027s feedback and after looking closely at logs too, this is fine. Sorry for the noise.","commit_id":"6979673d313d4a628355d72f222599a8223b3f6d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1f14cea1b0038d5457c88ce01dccac34413720e8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"read from the DB or create a default security group if the"},{"line_number":16,"context_line":"default will not be used."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"TrivialFix"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib072c2753862ce0709a67942527e9c6241130042"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_ba8df32b","line":18,"in_reply_to":"1f1a1f67_cb7b50bc","updated":"2017-07-20 15:42:43.000000000","message":"Honestly I don\u0027t think it is TrivialFix :)","commit_id":"6979673d313d4a628355d72f222599a8223b3f6d"}]}
