)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"77b26e279e0aa97d245696b10cd69cce853904c0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"require specific values."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6da72c3ac43f01b5ffa21f128fb3eeaf9fd0a503"},{"line_number":17,"context_line":"Closes-Bug: #1705187"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_61335c63","line":17,"updated":"2017-07-19 16:58:04.000000000","message":"Probably also Closes-Bug: #1704000?","commit_id":"b9d84c92c91c5fd3263279a6ac697e7a19b1001a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fe54f9c94c22cfc44b90419c8e89fc04423f7d2c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch adds a dictionary to hold all updatable fields which"},{"line_number":14,"context_line":"require specific values. It also helps get_random_object_fields()"},{"line_number":15,"context_line":"ccoperate with self.update_obj_fields() not to generate values"},{"line_number":16,"context_line":"that might violated Unique Key constaint."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6da72c3ac43f01b5ffa21f128fb3eeaf9fd0a503"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_4b3dfb2a","line":15,"range":{"start_line":15,"start_character":1,"end_line":15,"end_character":9},"updated":"2017-07-20 19:32:29.000000000","message":"cooperate","commit_id":"3195c5ffd45867bdfe12c757c059c7a6f1fb5366"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fe54f9c94c22cfc44b90419c8e89fc04423f7d2c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch adds a dictionary to hold all updatable fields which"},{"line_number":14,"context_line":"require specific values. It also helps get_random_object_fields()"},{"line_number":15,"context_line":"ccoperate with self.update_obj_fields() not to generate values"},{"line_number":16,"context_line":"that might violated Unique Key constaint."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6da72c3ac43f01b5ffa21f128fb3eeaf9fd0a503"},{"line_number":19,"context_line":"Closes-Bug: #1705187"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f1a1f67_eb43a7ae","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":20},"updated":"2017-07-20 19:32:29.000000000","message":"might violate","commit_id":"3195c5ffd45867bdfe12c757c059c7a6f1fb5366"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"d9efc501356e2afde40b3d0000ca65107c811340","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        objects.register_objects()"},{"line_number":520,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":521,"context_line":"        self._unique_tracker \u003d collections.defaultdict(set)"},{"line_number":522,"context_line":"        self.values_dict \u003d collections.defaultdict(set)"},{"line_number":523,"context_line":"        self.db_objs \u003d ["},{"line_number":524,"context_line":"            self._test_class.db_model(**self.get_random_db_fields())"},{"line_number":525,"context_line":"            for _ in range(3)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_d143233e","line":522,"range":{"start_line":522,"start_character":13,"end_line":522,"end_character":24},"updated":"2017-07-19 14:37:19.000000000","message":"not a very descriptive name.\n\nI\u0027m not really sure what would be better... maybe explicit_updates? Then we can check if the values intersect and if they do.. then you can opt out of the random field generation.","commit_id":"b9d84c92c91c5fd3263279a6ac697e7a19b1001a"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"fa4fe6105da672e75cd31155b035b842144b43b2","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        objects.register_objects()"},{"line_number":520,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":521,"context_line":"        self._unique_tracker \u003d collections.defaultdict(set)"},{"line_number":522,"context_line":"        self.values_dict \u003d collections.defaultdict(set)"},{"line_number":523,"context_line":"        self.db_objs \u003d ["},{"line_number":524,"context_line":"            self._test_class.db_model(**self.get_random_db_fields())"},{"line_number":525,"context_line":"            for _ in range(3)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_94dfc764","line":522,"range":{"start_line":522,"start_character":13,"end_line":522,"end_character":24},"in_reply_to":"1f1a1f67_c16fd025","updated":"2017-07-20 01:48:29.000000000","message":"I make update_obj_fields() to populate the dict now. As for bug 1704000, my only concern is whether we have unique key constraint within \u0027self.locked_obj_fields\u0027, because in current code path, we jump back to get_random_object_fields() to generate all fields but do not touch those generated by update_obj_fields(). Will go through all the test.","commit_id":"b9d84c92c91c5fd3263279a6ac697e7a19b1001a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"77b26e279e0aa97d245696b10cd69cce853904c0","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        objects.register_objects()"},{"line_number":520,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":521,"context_line":"        self._unique_tracker \u003d collections.defaultdict(set)"},{"line_number":522,"context_line":"        self.values_dict \u003d collections.defaultdict(set)"},{"line_number":523,"context_line":"        self.db_objs \u003d ["},{"line_number":524,"context_line":"            self._test_class.db_model(**self.get_random_db_fields())"},{"line_number":525,"context_line":"            for _ in range(3)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_c16fd025","line":522,"range":{"start_line":522,"start_character":13,"end_line":522,"end_character":24},"in_reply_to":"1f1a1f67_d143233e","updated":"2017-07-19 16:58:04.000000000","message":"Should we make update_obj_fields populate the dict? Then no tests will need any change to update self.values_dict, and the patch would fix bug 1704000.\n\nThe name is indeed not very descriptive. Maybe \u0027locked_obj_fields\u0027 to reflect the intent?","commit_id":"b9d84c92c91c5fd3263279a6ac697e7a19b1001a"}]}