)]}'
{"neutron/tests/fullstack/test_securitygroup.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5ece83cd10747610806f83a082b9d5430eb2b26","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            vms[1].namespace, vms[0].namespace, vms[0].ip, 3366,"},{"line_number":274,"context_line":"            net_helpers.NetcatTester.SCTP)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        # 8. Check using multiple security groups"},{"line_number":277,"context_line":"        # Traffic not explicitly allowed (eg. SSH, ICMP) is blocked"},{"line_number":278,"context_line":"        self.assert_no_connection("},{"line_number":279,"context_line":"            vms[1].namespace, vms[0].namespace, vms[0].ip, 22,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_4b81804a","line":276,"updated":"2017-07-20 11:37:13.000000000","message":"Everything looks fine :) Would you mind just wrapping this whole scenario to a single method and just call it from here? (we should do the same with all the tests above in some refactoring patch).","commit_id":"93d757b9f74e9efd48154c75ddf2db31e1b1bd1e"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"050f868997f9294575e1dac95518115fae55dae3","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            vms[1].namespace, vms[0].namespace, vms[0].ip, 3366,"},{"line_number":274,"context_line":"            net_helpers.NetcatTester.SCTP)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        # 8. Check using multiple security groups"},{"line_number":277,"context_line":"        # Traffic not explicitly allowed (eg. SSH, ICMP) is blocked"},{"line_number":278,"context_line":"        self.assert_no_connection("},{"line_number":279,"context_line":"            vms[1].namespace, vms[0].namespace, vms[0].ip, 22,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_6f0423c7","line":276,"in_reply_to":"1f1a1f67_4b81804a","updated":"2017-07-21 07:59:28.000000000","message":"Done. Will update in next patch.","commit_id":"93d757b9f74e9efd48154c75ddf2db31e1b1bd1e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"92caf6fdc75004f8e2f31fe5e4874213ce663e45","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        \"\"\""},{"line_number":121,"context_line":"        if self.firewall_driver \u003d\u003d \u0027iptables_hybrid\u0027:"},{"line_number":122,"context_line":"            # The iptables_hybrid driver lacks isolation between agents"},{"line_number":123,"context_line":"            index_to_host \u003d [0] * 3"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            index_to_host \u003d [0, 1, 1]"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_ac8bda65","line":123,"updated":"2017-10-16 10:53:13.000000000","message":"shouldn\u0027t You use here \"self.index_to_host\"?","commit_id":"402bd2c99be69746ca1c68b6f8391c7cd81ebd2d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"00b975f467a7604b1f07d018536dee08a2b40616","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        \"\"\""},{"line_number":121,"context_line":"        if self.firewall_driver \u003d\u003d \u0027iptables_hybrid\u0027:"},{"line_number":122,"context_line":"            # The iptables_hybrid driver lacks isolation between agents"},{"line_number":123,"context_line":"            index_to_host \u003d [0] * 3"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            index_to_host \u003d [0, 1, 1]"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_4ce466e0","line":123,"in_reply_to":"5f4e5783_ac8bda65","updated":"2017-10-16 11:08:41.000000000","message":"This can be in a refactor patch. So I keep it here.","commit_id":"402bd2c99be69746ca1c68b6f8391c7cd81ebd2d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"92caf6fdc75004f8e2f31fe5e4874213ce663e45","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            # The iptables_hybrid driver lacks isolation between agents"},{"line_number":123,"context_line":"            index_to_host \u003d [0] * 3"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            index_to_host \u003d [0, 1, 1]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        tenant_uuid \u003d uuidutils.generate_uuid()"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_8cea5e0c","line":125,"updated":"2017-10-16 10:53:13.000000000","message":"same here","commit_id":"402bd2c99be69746ca1c68b6f8391c7cd81ebd2d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"92caf6fdc75004f8e2f31fe5e4874213ce663e45","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            protocol\u003dconstants.PROTO_NAME_TCP,"},{"line_number":147,"context_line":"            port_range_min\u003d3333, port_range_max\u003d3333)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        vms \u003d ["},{"line_number":150,"context_line":"            self.useFixture("},{"line_number":151,"context_line":"                machine.FakeFullstackMachine("},{"line_number":152,"context_line":"                    self.environment.hosts[host],"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_6cef221e","line":149,"updated":"2017-10-16 10:53:13.000000000","message":"maybe I\u0027m wrong but it looks for me that it\u0027s (almost) same code like in Your new method \"create_resoures()\" - if so, can\u0027t You maybe change code here to avoid duplication and reuse this method?","commit_id":"402bd2c99be69746ca1c68b6f8391c7cd81ebd2d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"00b975f467a7604b1f07d018536dee08a2b40616","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            protocol\u003dconstants.PROTO_NAME_TCP,"},{"line_number":147,"context_line":"            port_range_min\u003d3333, port_range_max\u003d3333)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        vms \u003d ["},{"line_number":150,"context_line":"            self.useFixture("},{"line_number":151,"context_line":"                machine.FakeFullstackMachine("},{"line_number":152,"context_line":"                    self.environment.hosts[host],"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_aca63aaa","line":149,"in_reply_to":"5f4e5783_6cef221e","updated":"2017-10-16 11:08:41.000000000","message":"Yes, this will in the following refactor patch. So I mentioned in L367.","commit_id":"402bd2c99be69746ca1c68b6f8391c7cd81ebd2d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"92caf6fdc75004f8e2f31fe5e4874213ce663e45","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                    self.safe_client,"},{"line_number":156,"context_line":"                    neutron_port\u003dports[port],"},{"line_number":157,"context_line":"                    use_dhcp\u003dTrue))"},{"line_number":158,"context_line":"            for port, host in enumerate(index_to_host)]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        for vm in vms:"},{"line_number":161,"context_line":"            vm.block_until_boot()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_4cf0e6fd","line":158,"updated":"2017-10-16 10:53:13.000000000","message":"and here","commit_id":"402bd2c99be69746ca1c68b6f8391c7cd81ebd2d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fd783ec25749aac6360281ce214a2c8f6ad82a76","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        # 10. Check using multiple security groups"},{"line_number":305,"context_line":"        self._test_using_multiple_security_groups()"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def _test_using_multiple_security_groups(self):"},{"line_number":308,"context_line":"        tenant_uuid \u003d uuidutils.generate_uuid()"},{"line_number":309,"context_line":"        subnet_cidr \u003d \u002730.0.0.0/24\u0027"},{"line_number":310,"context_line":"        vms, ports, sgs \u003d self.create_resources(tenant_uuid, subnet_cidr)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_674999ce","line":307,"updated":"2017-11-23 11:41:30.000000000","message":"why You need \"whole new\" test for that? Can\u0027t we merge it somehow with this what is already done in steps 1-4? I think it would make this change smaller and test would be littlebit faster, no?","commit_id":"c55b10a318a3f146a81febca972995ccba3ff4dd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23aff30550f4ba881fb1a25e29b9b8c98b06fa46","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    # NOTE: This can be used after refactor other tests to"},{"line_number":388,"context_line":"    # one scenario one test."},{"line_number":389,"context_line":"    def create_resources(self, tenant_uuid, subnet_cidr):"},{"line_number":390,"context_line":"        if self.firewall_driver \u003d\u003d \u0027iptables_hybrid\u0027:"},{"line_number":391,"context_line":"            # The iptables_hybrid driver lacks isolation between agents"},{"line_number":392,"context_line":"            index_to_host \u003d [0] * 4"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_e9323c10","line":389,"range":{"start_line":389,"start_character":8,"end_line":389,"end_character":24},"updated":"2018-04-20 11:57:29.000000000","message":"maybe add \"_\" add the begin of this method\u0027s name to mark it as \"private\".","commit_id":"c55b10a318a3f146a81febca972995ccba3ff4dd"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"33deca41803533a778389c1f821b865715d867ae","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    # NOTE: This can be used after refactor other tests to"},{"line_number":388,"context_line":"    # one scenario one test."},{"line_number":389,"context_line":"    def create_resources(self, tenant_uuid, subnet_cidr):"},{"line_number":390,"context_line":"        if self.firewall_driver \u003d\u003d \u0027iptables_hybrid\u0027:"},{"line_number":391,"context_line":"            # The iptables_hybrid driver lacks isolation between agents"},{"line_number":392,"context_line":"            index_to_host \u003d [0] * 4"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_55ee57b4","line":389,"range":{"start_line":389,"start_character":8,"end_line":389,"end_character":24},"in_reply_to":"9f6a8fd7_e9323c10","updated":"2018-04-20 14:00:53.000000000","message":"Done","commit_id":"c55b10a318a3f146a81febca972995ccba3ff4dd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23aff30550f4ba881fb1a25e29b9b8c98b06fa46","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    # NOTE: This can be used after refactor other tests to"},{"line_number":388,"context_line":"    # one scenario one test."},{"line_number":389,"context_line":"    def create_resources(self, tenant_uuid, subnet_cidr):"},{"line_number":390,"context_line":"        if self.firewall_driver \u003d\u003d \u0027iptables_hybrid\u0027:"},{"line_number":391,"context_line":"            # The iptables_hybrid driver lacks isolation between agents"},{"line_number":392,"context_line":"            index_to_host \u003d [0] * 4"},{"line_number":393,"context_line":"        else:"},{"line_number":394,"context_line":"            index_to_host \u003d [0, 1, 1, 0]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        network \u003d self.safe_client.create_network(tenant_uuid)"},{"line_number":397,"context_line":"        self.safe_client.create_subnet("},{"line_number":398,"context_line":"            tenant_uuid, network[\u0027id\u0027], subnet_cidr)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        sgs \u003d [self.safe_client.create_security_group(tenant_uuid)"},{"line_number":401,"context_line":"               for i in range(3)]"},{"line_number":402,"context_line":"        ports \u003d ["},{"line_number":403,"context_line":"            self.safe_client.create_port(tenant_uuid, network[\u0027id\u0027],"},{"line_number":404,"context_line":"                                         self.environment.hosts[host].hostname,"},{"line_number":405,"context_line":"                                         security_groups\u003d[],"},{"line_number":406,"context_line":"                                         port_security_enabled\u003dFalse)"},{"line_number":407,"context_line":"            for host in index_to_host]"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        self.safe_client.create_security_group_rule("},{"line_number":410,"context_line":"            tenant_uuid, sgs[0][\u0027id\u0027],"},{"line_number":411,"context_line":"            remote_group_id\u003dsgs[0][\u0027id\u0027], direction\u003d\u0027ingress\u0027,"},{"line_number":412,"context_line":"            ethertype\u003dconstants.IPv4,"},{"line_number":413,"context_line":"            protocol\u003dconstants.PROTO_NAME_TCP,"},{"line_number":414,"context_line":"            port_range_min\u003d3333, port_range_max\u003d3333)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        vms \u003d ["},{"line_number":417,"context_line":"            self.useFixture("},{"line_number":418,"context_line":"                machine.FakeFullstackMachine("},{"line_number":419,"context_line":"                    self.environment.hosts[host],"},{"line_number":420,"context_line":"                    network[\u0027id\u0027],"},{"line_number":421,"context_line":"                    tenant_uuid,"},{"line_number":422,"context_line":"                    self.safe_client,"},{"line_number":423,"context_line":"                    neutron_port\u003dports[port],"},{"line_number":424,"context_line":"                    use_dhcp\u003dTrue))"},{"line_number":425,"context_line":"            for port, host in enumerate(index_to_host)]"},{"line_number":426,"context_line":"        map(lambda vm: vm.block_until_boot(), vms)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        return vms, ports, sgs"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def _create_vm_on_host("},{"line_number":431,"context_line":"            self, project_id, network_id, sg_id, host, mac_address\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_c93df8dd","line":428,"range":{"start_line":390,"start_character":0,"end_line":428,"end_character":30},"updated":"2018-04-20 11:57:29.000000000","message":"it looks for me that this code is (almost) the same as in L129-157 - can\u0027t You just reuse it there also?","commit_id":"c55b10a318a3f146a81febca972995ccba3ff4dd"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"01587cc84bb765d25e90ac7d59121a50fbc965b9","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    # NOTE: This can be used after refactor other tests to"},{"line_number":388,"context_line":"    # one scenario one test."},{"line_number":389,"context_line":"    def create_resources(self, tenant_uuid, subnet_cidr):"},{"line_number":390,"context_line":"        if self.firewall_driver \u003d\u003d \u0027iptables_hybrid\u0027:"},{"line_number":391,"context_line":"            # The iptables_hybrid driver lacks isolation between agents"},{"line_number":392,"context_line":"            index_to_host \u003d [0] * 4"},{"line_number":393,"context_line":"        else:"},{"line_number":394,"context_line":"            index_to_host \u003d [0, 1, 1, 0]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        network \u003d self.safe_client.create_network(tenant_uuid)"},{"line_number":397,"context_line":"        self.safe_client.create_subnet("},{"line_number":398,"context_line":"            tenant_uuid, network[\u0027id\u0027], subnet_cidr)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        sgs \u003d [self.safe_client.create_security_group(tenant_uuid)"},{"line_number":401,"context_line":"               for i in range(3)]"},{"line_number":402,"context_line":"        ports \u003d ["},{"line_number":403,"context_line":"            self.safe_client.create_port(tenant_uuid, network[\u0027id\u0027],"},{"line_number":404,"context_line":"                                         self.environment.hosts[host].hostname,"},{"line_number":405,"context_line":"                                         security_groups\u003d[],"},{"line_number":406,"context_line":"                                         port_security_enabled\u003dFalse)"},{"line_number":407,"context_line":"            for host in index_to_host]"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        self.safe_client.create_security_group_rule("},{"line_number":410,"context_line":"            tenant_uuid, sgs[0][\u0027id\u0027],"},{"line_number":411,"context_line":"            remote_group_id\u003dsgs[0][\u0027id\u0027], direction\u003d\u0027ingress\u0027,"},{"line_number":412,"context_line":"            ethertype\u003dconstants.IPv4,"},{"line_number":413,"context_line":"            protocol\u003dconstants.PROTO_NAME_TCP,"},{"line_number":414,"context_line":"            port_range_min\u003d3333, port_range_max\u003d3333)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        vms \u003d ["},{"line_number":417,"context_line":"            self.useFixture("},{"line_number":418,"context_line":"                machine.FakeFullstackMachine("},{"line_number":419,"context_line":"                    self.environment.hosts[host],"},{"line_number":420,"context_line":"                    network[\u0027id\u0027],"},{"line_number":421,"context_line":"                    tenant_uuid,"},{"line_number":422,"context_line":"                    self.safe_client,"},{"line_number":423,"context_line":"                    neutron_port\u003dports[port],"},{"line_number":424,"context_line":"                    use_dhcp\u003dTrue))"},{"line_number":425,"context_line":"            for port, host in enumerate(index_to_host)]"},{"line_number":426,"context_line":"        map(lambda vm: vm.block_until_boot(), vms)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        return vms, ports, sgs"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def _create_vm_on_host("},{"line_number":431,"context_line":"            self, project_id, network_id, sg_id, host, mac_address\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_2d65bb45","line":428,"range":{"start_line":390,"start_character":0,"end_line":428,"end_character":30},"in_reply_to":"9f6a8fd7_22d4c1bc","updated":"2018-05-02 16:27:04.000000000","message":"Thanks, Let\u0027s me see if they can reuse.","commit_id":"c55b10a318a3f146a81febca972995ccba3ff4dd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5ee5ccf6a248dcec4113050362e8eee40663fd22","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    # NOTE: This can be used after refactor other tests to"},{"line_number":388,"context_line":"    # one scenario one test."},{"line_number":389,"context_line":"    def create_resources(self, tenant_uuid, subnet_cidr):"},{"line_number":390,"context_line":"        if self.firewall_driver \u003d\u003d \u0027iptables_hybrid\u0027:"},{"line_number":391,"context_line":"            # The iptables_hybrid driver lacks isolation between agents"},{"line_number":392,"context_line":"            index_to_host \u003d [0] * 4"},{"line_number":393,"context_line":"        else:"},{"line_number":394,"context_line":"            index_to_host \u003d [0, 1, 1, 0]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        network \u003d self.safe_client.create_network(tenant_uuid)"},{"line_number":397,"context_line":"        self.safe_client.create_subnet("},{"line_number":398,"context_line":"            tenant_uuid, network[\u0027id\u0027], subnet_cidr)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        sgs \u003d [self.safe_client.create_security_group(tenant_uuid)"},{"line_number":401,"context_line":"               for i in range(3)]"},{"line_number":402,"context_line":"        ports \u003d ["},{"line_number":403,"context_line":"            self.safe_client.create_port(tenant_uuid, network[\u0027id\u0027],"},{"line_number":404,"context_line":"                                         self.environment.hosts[host].hostname,"},{"line_number":405,"context_line":"                                         security_groups\u003d[],"},{"line_number":406,"context_line":"                                         port_security_enabled\u003dFalse)"},{"line_number":407,"context_line":"            for host in index_to_host]"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        self.safe_client.create_security_group_rule("},{"line_number":410,"context_line":"            tenant_uuid, sgs[0][\u0027id\u0027],"},{"line_number":411,"context_line":"            remote_group_id\u003dsgs[0][\u0027id\u0027], direction\u003d\u0027ingress\u0027,"},{"line_number":412,"context_line":"            ethertype\u003dconstants.IPv4,"},{"line_number":413,"context_line":"            protocol\u003dconstants.PROTO_NAME_TCP,"},{"line_number":414,"context_line":"            port_range_min\u003d3333, port_range_max\u003d3333)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        vms \u003d ["},{"line_number":417,"context_line":"            self.useFixture("},{"line_number":418,"context_line":"                machine.FakeFullstackMachine("},{"line_number":419,"context_line":"                    self.environment.hosts[host],"},{"line_number":420,"context_line":"                    network[\u0027id\u0027],"},{"line_number":421,"context_line":"                    tenant_uuid,"},{"line_number":422,"context_line":"                    self.safe_client,"},{"line_number":423,"context_line":"                    neutron_port\u003dports[port],"},{"line_number":424,"context_line":"                    use_dhcp\u003dTrue))"},{"line_number":425,"context_line":"            for port, host in enumerate(index_to_host)]"},{"line_number":426,"context_line":"        map(lambda vm: vm.block_until_boot(), vms)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        return vms, ports, sgs"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def _create_vm_on_host("},{"line_number":431,"context_line":"            self, project_id, network_id, sg_id, host, mac_address\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_22d4c1bc","line":428,"range":{"start_line":390,"start_character":0,"end_line":428,"end_character":30},"in_reply_to":"9f6a8fd7_551c17c0","updated":"2018-04-20 19:53:02.000000000","message":"But I don\u0027t exactly understand why it can\u0027t be used now in this previous test also? Why You can\u0027t refactor it little bit in this patch?","commit_id":"c55b10a318a3f146a81febca972995ccba3ff4dd"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"33deca41803533a778389c1f821b865715d867ae","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    # NOTE: This can be used after refactor other tests to"},{"line_number":388,"context_line":"    # one scenario one test."},{"line_number":389,"context_line":"    def create_resources(self, tenant_uuid, subnet_cidr):"},{"line_number":390,"context_line":"        if self.firewall_driver \u003d\u003d \u0027iptables_hybrid\u0027:"},{"line_number":391,"context_line":"            # The iptables_hybrid driver lacks isolation between agents"},{"line_number":392,"context_line":"            index_to_host \u003d [0] * 4"},{"line_number":393,"context_line":"        else:"},{"line_number":394,"context_line":"            index_to_host \u003d [0, 1, 1, 0]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        network \u003d self.safe_client.create_network(tenant_uuid)"},{"line_number":397,"context_line":"        self.safe_client.create_subnet("},{"line_number":398,"context_line":"            tenant_uuid, network[\u0027id\u0027], subnet_cidr)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        sgs \u003d [self.safe_client.create_security_group(tenant_uuid)"},{"line_number":401,"context_line":"               for i in range(3)]"},{"line_number":402,"context_line":"        ports \u003d ["},{"line_number":403,"context_line":"            self.safe_client.create_port(tenant_uuid, network[\u0027id\u0027],"},{"line_number":404,"context_line":"                                         self.environment.hosts[host].hostname,"},{"line_number":405,"context_line":"                                         security_groups\u003d[],"},{"line_number":406,"context_line":"                                         port_security_enabled\u003dFalse)"},{"line_number":407,"context_line":"            for host in index_to_host]"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        self.safe_client.create_security_group_rule("},{"line_number":410,"context_line":"            tenant_uuid, sgs[0][\u0027id\u0027],"},{"line_number":411,"context_line":"            remote_group_id\u003dsgs[0][\u0027id\u0027], direction\u003d\u0027ingress\u0027,"},{"line_number":412,"context_line":"            ethertype\u003dconstants.IPv4,"},{"line_number":413,"context_line":"            protocol\u003dconstants.PROTO_NAME_TCP,"},{"line_number":414,"context_line":"            port_range_min\u003d3333, port_range_max\u003d3333)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        vms \u003d ["},{"line_number":417,"context_line":"            self.useFixture("},{"line_number":418,"context_line":"                machine.FakeFullstackMachine("},{"line_number":419,"context_line":"                    self.environment.hosts[host],"},{"line_number":420,"context_line":"                    network[\u0027id\u0027],"},{"line_number":421,"context_line":"                    tenant_uuid,"},{"line_number":422,"context_line":"                    self.safe_client,"},{"line_number":423,"context_line":"                    neutron_port\u003dports[port],"},{"line_number":424,"context_line":"                    use_dhcp\u003dTrue))"},{"line_number":425,"context_line":"            for port, host in enumerate(index_to_host)]"},{"line_number":426,"context_line":"        map(lambda vm: vm.block_until_boot(), vms)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        return vms, ports, sgs"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def _create_vm_on_host("},{"line_number":431,"context_line":"            self, project_id, network_id, sg_id, host, mac_address\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_551c17c0","line":428,"range":{"start_line":390,"start_character":0,"end_line":428,"end_character":30},"in_reply_to":"9f6a8fd7_c93df8dd","updated":"2018-04-20 14:00:53.000000000","message":"I had added a comment in this function, please see L387-388:\n# NOTE: This can be used after refactor other tests to\n# one scenario one test.","commit_id":"c55b10a318a3f146a81febca972995ccba3ff4dd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"718f6049f0c39ec038d5f9e45e8c4609f5c670ca","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        # 10. Check using multiple security groups"},{"line_number":275,"context_line":"        self._test_using_multiple_security_groups()"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def _test_using_multiple_security_groups(self):"},{"line_number":278,"context_line":"        tenant_uuid \u003d uuidutils.generate_uuid()"},{"line_number":279,"context_line":"        subnet_cidr \u003d \u002730.0.0.0/24\u0027"},{"line_number":280,"context_line":"        vms, ports, sgs, _, _ \u003d self._create_resources(tenant_uuid,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_3dc49c3f","line":277,"updated":"2018-05-15 09:49:25.000000000","message":"As this scenario is a more complex one, can you add some docstring describing what the test does?","commit_id":"ff57b91e600ae7b985b33f009fdcded8bf15c091"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"8013607189b87e4f1e94a87c3f88ce4d751e58f2","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        # 10. Check using multiple security groups"},{"line_number":275,"context_line":"        self._test_using_multiple_security_groups()"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def _test_using_multiple_security_groups(self):"},{"line_number":278,"context_line":"        tenant_uuid \u003d uuidutils.generate_uuid()"},{"line_number":279,"context_line":"        subnet_cidr \u003d \u002730.0.0.0/24\u0027"},{"line_number":280,"context_line":"        vms, ports, sgs, _, _ \u003d self._create_resources(tenant_uuid,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_57acd0eb","line":277,"in_reply_to":"5f7c97a3_3dc49c3f","updated":"2018-05-15 14:40:15.000000000","message":"Done. I will try to make some words here.","commit_id":"ff57b91e600ae7b985b33f009fdcded8bf15c091"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"33cba36c5751bf767686aba4a27f73931df3b7f2","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                    neutron_port\u003dports[port],"},{"line_number":395,"context_line":"                    use_dhcp\u003dTrue))"},{"line_number":396,"context_line":"            for port, host in enumerate(index_to_host)]"},{"line_number":397,"context_line":"        map(lambda vm: vm.block_until_boot(), vms)"},{"line_number":398,"context_line":"        map(lambda vm: vm.block_until_dhcp_config_done(), vms)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return vms, ports, sgs, network, index_to_host"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_5d8b9866","line":397,"range":{"start_line":397,"start_character":8,"end_line":397,"end_character":50},"updated":"2018-05-15 09:36:15.000000000","message":"better use list comprehension","commit_id":"ff57b91e600ae7b985b33f009fdcded8bf15c091"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"718f6049f0c39ec038d5f9e45e8c4609f5c670ca","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                    neutron_port\u003dports[port],"},{"line_number":395,"context_line":"                    use_dhcp\u003dTrue))"},{"line_number":396,"context_line":"            for port, host in enumerate(index_to_host)]"},{"line_number":397,"context_line":"        map(lambda vm: vm.block_until_boot(), vms)"},{"line_number":398,"context_line":"        map(lambda vm: vm.block_until_dhcp_config_done(), vms)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return vms, ports, sgs, network, index_to_host"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_dd9a4860","line":397,"range":{"start_line":397,"start_character":8,"end_line":397,"end_character":50},"in_reply_to":"5f7c97a3_5d8b9866","updated":"2018-05-15 09:49:25.000000000","message":"I\u0027d prefer to keep map() here. With list comprehension you\u0027d have an expression without assignment.","commit_id":"ff57b91e600ae7b985b33f009fdcded8bf15c091"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ca9636649c75f93981c4095c9a306a9bdc18f5bc","unresolved":false,"context_lines":[{"line_number":286,"context_line":"           have rules allowed sg0 access(ICMP), so vm0 and vm1 can"},{"line_number":287,"context_line":"           ping vm2."},{"line_number":288,"context_line":"        4. Then remove sg0 from vm0, we removed ICMP and SSH rules."},{"line_number":289,"context_line":"           vm0 and vm1 can not ping and ssh for each other."},{"line_number":290,"context_line":"        \"\"\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        tenant_uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_25222cba","line":289,"updated":"2018-05-16 08:07:48.000000000","message":"but can still ping VM2 because of sg1, right?","commit_id":"1658e353c336d666ec43f725bd2c87633b43571d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"de993ec849f78cc56f2e094fba5df261b3d4660e","unresolved":false,"context_lines":[{"line_number":286,"context_line":"           have rules allowed sg0 access(ICMP), so vm0 and vm1 can"},{"line_number":287,"context_line":"           ping vm2."},{"line_number":288,"context_line":"        4. Then remove sg0 from vm0, we removed ICMP and SSH rules."},{"line_number":289,"context_line":"           vm0 and vm1 can not ping and ssh for each other."},{"line_number":290,"context_line":"        \"\"\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        tenant_uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_0b013a38","line":289,"in_reply_to":"5f7c97a3_25222cba","updated":"2018-05-16 13:56:12.000000000","message":"Yes.","commit_id":"1658e353c336d666ec43f725bd2c87633b43571d"}]}
