)]}'
{"neutron/plugins/midonet/plugin.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bb35236c43741465fc2d5a75a28816c8fa3ca519","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        chain_names \u003d _nat_chain_names(router.get_id())"},{"line_number":359,"context_line":"        for _type, name in chain_names.iteritems():"},{"line_number":360,"context_line":"            self.client.remove_rules_by_property(router.get_tenant_id(),"},{"line_number":361,"context_line":"                name, OS_FLOATING_IP_RULE_KEY, fip[\"id\"])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def setup_rpc(self):"},{"line_number":364,"context_line":"        # RPC support"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FXT4%3D","line":361,"updated":"2013-09-28 06:24:30.000000000","message":"pep8 will fail, check indent or you can move the first param in a new line then indent","commit_id":"288c261695953632281e6b268cc5c4b24648c72b"},{"author":{"_account_id":8718,"name":"Dave Cahill","email":"dpcahill@gmail.com","username":"davecahill"},"change_message_id":"b6283ef3bc5023c222af06a475cd1b3c5f776d79","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        chain_names \u003d _nat_chain_names(router.get_id())"},{"line_number":359,"context_line":"        for _type, name in chain_names.iteritems():"},{"line_number":360,"context_line":"            self.client.remove_rules_by_property(router.get_tenant_id(),"},{"line_number":361,"context_line":"                name, OS_FLOATING_IP_RULE_KEY, fip[\"id\"])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def setup_rpc(self):"},{"line_number":364,"context_line":"        # RPC support"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FVVU%3D","line":361,"in_reply_to":"AAAAS3%2F%2FXT4%3D","updated":"2013-09-30 01:49:13.000000000","message":"You\u0027re right - I was using the wrong version of the pep8 tool locally, tox -e pep8 catches this. Will resubmit with fix.","commit_id":"288c261695953632281e6b268cc5c4b24648c72b"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bb35236c43741465fc2d5a75a28816c8fa3ca519","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"    def disassociate_floatingips(self, context, port_id):"},{"line_number":1015,"context_line":"        try:"},{"line_number":1016,"context_line":"            fip_qry \u003d context.session.query(l3_db.FloatingIP)"},{"line_number":1017,"context_line":"            fip_db \u003d fip_qry.filter_by(fixed_port_id\u003dport_id).one()"},{"line_number":1018,"context_line":"            self._remove_nat_rules(context, fip_db)"},{"line_number":1019,"context_line":"        except sa_exc.NoResultFound:"},{"line_number":1020,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FXTE%3D","line":1017,"updated":"2013-09-28 06:24:30.000000000","message":"can L1016-L1017 be replaced with:\n\n    fip_db \u003d super(MidonetPluginV2, self).get_floatingip(context, port_id)\n\n?","commit_id":"288c261695953632281e6b268cc5c4b24648c72b"},{"author":{"_account_id":8718,"name":"Dave Cahill","email":"dpcahill@gmail.com","username":"davecahill"},"change_message_id":"b6283ef3bc5023c222af06a475cd1b3c5f776d79","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"    def disassociate_floatingips(self, context, port_id):"},{"line_number":1015,"context_line":"        try:"},{"line_number":1016,"context_line":"            fip_qry \u003d context.session.query(l3_db.FloatingIP)"},{"line_number":1017,"context_line":"            fip_db \u003d fip_qry.filter_by(fixed_port_id\u003dport_id).one()"},{"line_number":1018,"context_line":"            self._remove_nat_rules(context, fip_db)"},{"line_number":1019,"context_line":"        except sa_exc.NoResultFound:"},{"line_number":1020,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FVVM%3D","line":1017,"in_reply_to":"AAAAS3%2F%2FXTE%3D","updated":"2013-09-30 01:49:13.000000000","message":"Unfortunately not - get_floatingip takes a floating IP id, not a port id, so we need to query for the floating IPs on the port first.","commit_id":"288c261695953632281e6b268cc5c4b24648c72b"}]}