)]}'
{"neutron/db/dns_db.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"47459246df49574f65477f98d485ccdd63e88305","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron_lib.api.definitions import dns as dns_apidef"},{"line_number":17,"context_line":"from neutron_lib.api import validators"},{"line_number":18,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":19,"context_line":"from neutron_lib.exceptions import dns as dns_err"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_d4da96e7","line":19,"updated":"2017-10-19 19:44:46.000000000","message":"nit: maybe I\u0027m wrong but in all other places which I saw \"convention\" is to name such imported libs with \"exc\" or \"exception\" instead of \"err\"","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron_lib.api.definitions import dns as dns_apidef"},{"line_number":17,"context_line":"from neutron_lib.api import validators"},{"line_number":18,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":19,"context_line":"from neutron_lib.exceptions import dns as dns_err"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_98fd53b3","line":19,"in_reply_to":"3f4b6375_d4da96e7","updated":"2017-10-20 21:13:18.000000000","message":"Done","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"}],"neutron/db/migration/alembic_migrations/versions/liberty/expand/34af2b5c5a59_add_dns_name_to_port.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7cdca665d50fdc5c2a77d0d750b793a7f730f12c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import sqlalchemy as sa"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.db import migration"},{"line_number":28,"context_line":"from neutron_lib.db import constants"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# revision identifiers, used by Alembic."},{"line_number":31,"context_line":"revision \u003d \u002734af2b5c5a59\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_c073f8e6","line":28,"updated":"2017-10-19 17:56:34.000000000","message":"Should we move this after L24? You did in the next file: https://review.openstack.org/#/c/487600/6/neutron/db/migration/alembic_migrations/versions/mitaka/expand/659bf3d90664_add_attributes_to_support_external_dns_integration.py@29","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import sqlalchemy as sa"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.db import migration"},{"line_number":28,"context_line":"from neutron_lib.db import constants"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# revision identifiers, used by Alembic."},{"line_number":31,"context_line":"revision \u003d \u002734af2b5c5a59\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_6d31bb0b","line":28,"in_reply_to":"3f4b6375_549586e3","updated":"2017-10-20 21:13:18.000000000","message":"Done","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"47459246df49574f65477f98d485ccdd63e88305","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import sqlalchemy as sa"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.db import migration"},{"line_number":28,"context_line":"from neutron_lib.db import constants"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# revision identifiers, used by Alembic."},{"line_number":31,"context_line":"revision \u003d \u002734af2b5c5a59\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_549586e3","line":28,"in_reply_to":"3f4b6375_c073f8e6","updated":"2017-10-19 19:44:46.000000000","message":"according to pep8 docs it should be moved after L24 but before L25 IMO","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"}],"neutron/extensions/dns_domain_ports.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7cdca665d50fdc5c2a77d0d750b793a7f730f12c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f4b6375_43895273","updated":"2017-10-19 17:56:34.000000000","message":"Is there going to be a follow up patchset to consume https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/dns_domain_ports.py? Is it because it hasn\u0027t been released?","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f4b6375_cd08af2e","in_reply_to":"3f4b6375_43895273","updated":"2017-10-20 21:13:18.000000000","message":"It should be in neutron-lib 1.10.0 that\u0027s already released.\nTo date I\u0027ve been trying to keep consumption patches separate rather than lumping them together. Otherwise it becomes overwhelming for review + patch maint (merges and such).\n\n\nSo it\u0027ll be coming in a subsequent patch.","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"09f14e1bfa86e8649848f0fc929cde9c601e8638","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f4b6375_13170454","in_reply_to":"3f4b6375_cd08af2e","updated":"2017-10-20 22:56:59.000000000","message":"Cool. Thanks for the explanation :-)","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"47459246df49574f65477f98d485ccdd63e88305","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib.api import converters"},{"line_number":17,"context_line":"from neutron_lib.api.definitions import dns"},{"line_number":18,"context_line":"from neutron_lib.api import extensions"},{"line_number":19,"context_line":"from neutron_lib.db import constants"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_f47112e2","line":17,"updated":"2017-10-19 19:44:46.000000000","message":"nit: everywhere else You imported it as \"dns_apidef\", why here it is different?","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib.api import converters"},{"line_number":17,"context_line":"from neutron_lib.api.definitions import dns"},{"line_number":18,"context_line":"from neutron_lib.api import extensions"},{"line_number":19,"context_line":"from neutron_lib.db import constants"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_d8362be8","line":17,"in_reply_to":"3f4b6375_f47112e2","updated":"2017-10-20 21:13:18.000000000","message":"Done","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"}],"neutron/plugins/ml2/extensions/dns_integration.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7cdca665d50fdc5c2a77d0d750b793a7f730f12c","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"class DNSDomainPortsExtensionDriver(DNSExtensionDriverML2):"},{"line_number":383,"context_line":"    _supported_extension_aliases \u003d [\u0027dns-integration\u0027, \u0027dns-domain-ports\u0027]"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @property"},{"line_number":386,"context_line":"    def extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_43c15254","line":383,"range":{"start_line":383,"start_character":55,"end_line":383,"end_character":73},"updated":"2017-10-19 17:56:34.000000000","message":"If we already can consume https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/dns_domain_ports.py here, then this should be the ALIAS constant defined there","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7cdca665d50fdc5c2a77d0d750b793a7f730f12c","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"class DNSDomainPortsExtensionDriver(DNSExtensionDriverML2):"},{"line_number":383,"context_line":"    _supported_extension_aliases \u003d [\u0027dns-integration\u0027, \u0027dns-domain-ports\u0027]"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @property"},{"line_number":386,"context_line":"    def extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_23dd3642","line":383,"range":{"start_line":383,"start_character":36,"end_line":383,"end_character":53},"updated":"2017-10-19 17:56:34.000000000","message":"Should we use dns_apidef.ALIAS here?","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"class DNSDomainPortsExtensionDriver(DNSExtensionDriverML2):"},{"line_number":383,"context_line":"    _supported_extension_aliases \u003d [\u0027dns-integration\u0027, \u0027dns-domain-ports\u0027]"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @property"},{"line_number":386,"context_line":"    def extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_988c3380","line":383,"range":{"start_line":383,"start_character":36,"end_line":383,"end_character":53},"in_reply_to":"3f4b6375_23dd3642","updated":"2017-10-20 21:13:18.000000000","message":"Done","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"class DNSDomainPortsExtensionDriver(DNSExtensionDriverML2):"},{"line_number":383,"context_line":"    _supported_extension_aliases \u003d [\u0027dns-integration\u0027, \u0027dns-domain-ports\u0027]"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @property"},{"line_number":386,"context_line":"    def extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_783737b2","line":383,"range":{"start_line":383,"start_character":55,"end_line":383,"end_character":73},"in_reply_to":"3f4b6375_43c15254","updated":"2017-10-20 21:13:18.000000000","message":"I would prefer to change the domain ports in the same patch that consumes it. Please see my other comment about my current approach on structuring consumption patches.","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"}],"neutron/services/externaldns/drivers/designate/driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"47459246df49574f65477f98d485ccdd63e88305","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from keystoneauth1 import loading"},{"line_number":22,"context_line":"from keystoneauth1 import token_endpoint"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from neutron_lib.exceptions import dns"},{"line_number":25,"context_line":"from oslo_config import cfg"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.conf.services import extdns_designate_driver"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_742be293","line":24,"updated":"2017-10-19 19:44:46.000000000","message":"nit: in other file You imported it as \"dns_err\", maybe You should use same naming everywhere?","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from keystoneauth1 import loading"},{"line_number":22,"context_line":"from keystoneauth1 import token_endpoint"},{"line_number":23,"context_line":"from neutron_lib import constants"},{"line_number":24,"context_line":"from neutron_lib.exceptions import dns"},{"line_number":25,"context_line":"from oslo_config import cfg"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.conf.services import extdns_designate_driver"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_d81ceb14","line":24,"in_reply_to":"3f4b6375_742be293","updated":"2017-10-20 21:13:18.000000000","message":"Done","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"}],"neutron/tests/unit/extensions/test_dns.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7cdca665d50fdc5c2a77d0d750b793a7f730f12c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        ips_list \u003d ips_list or []"},{"line_number":183,"context_line":"        ipv4_cidrs \u003d ipv4_cidrs or []"},{"line_number":184,"context_line":"        ipv6_cidrs \u003d ipv6_cidrs or []"},{"line_number":185,"context_line":"        self.assertEqual(dns_name, port[\u0027dns_name\u0027])"},{"line_number":186,"context_line":"        dns_assignment \u003d port[\u0027dns_assignment\u0027]"},{"line_number":187,"context_line":"        if ips_list:"},{"line_number":188,"context_line":"            self.assertEqual(len(dns_assignment), len(ips_list))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_8eb8912a","line":185,"range":{"start_line":185,"start_character":40,"end_line":185,"end_character":50},"updated":"2017-10-19 17:56:34.000000000","message":"In this test module we have \u0027dns_name\u0027 hardcoded in several places. Do we want to replace this with the constants defined in the api def in neutron-lib? Or is this out of context for this patch?","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7cdca665d50fdc5c2a77d0d750b793a7f730f12c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        ipv4_cidrs \u003d ipv4_cidrs or []"},{"line_number":184,"context_line":"        ipv6_cidrs \u003d ipv6_cidrs or []"},{"line_number":185,"context_line":"        self.assertEqual(dns_name, port[\u0027dns_name\u0027])"},{"line_number":186,"context_line":"        dns_assignment \u003d port[\u0027dns_assignment\u0027]"},{"line_number":187,"context_line":"        if ips_list:"},{"line_number":188,"context_line":"            self.assertEqual(len(dns_assignment), len(ips_list))"},{"line_number":189,"context_line":"            ips_set \u003d set(ips_list)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_8ee65144","line":186,"range":{"start_line":186,"start_character":31,"end_line":186,"end_character":46},"updated":"2017-10-19 17:56:34.000000000","message":"similar question in regards to \u0027dns_assignment\u0027","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"09f14e1bfa86e8649848f0fc929cde9c601e8638","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        ipv4_cidrs \u003d ipv4_cidrs or []"},{"line_number":184,"context_line":"        ipv6_cidrs \u003d ipv6_cidrs or []"},{"line_number":185,"context_line":"        self.assertEqual(dns_name, port[\u0027dns_name\u0027])"},{"line_number":186,"context_line":"        dns_assignment \u003d port[\u0027dns_assignment\u0027]"},{"line_number":187,"context_line":"        if ips_list:"},{"line_number":188,"context_line":"            self.assertEqual(len(dns_assignment), len(ips_list))"},{"line_number":189,"context_line":"            ips_set \u003d set(ips_list)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_6522efa6","line":186,"range":{"start_line":186,"start_character":31,"end_line":186,"end_character":46},"in_reply_to":"3f4b6375_5808fbd7","updated":"2017-10-20 22:56:59.000000000","message":"Makes sense. Thanks for the reply","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        ipv4_cidrs \u003d ipv4_cidrs or []"},{"line_number":184,"context_line":"        ipv6_cidrs \u003d ipv6_cidrs or []"},{"line_number":185,"context_line":"        self.assertEqual(dns_name, port[\u0027dns_name\u0027])"},{"line_number":186,"context_line":"        dns_assignment \u003d port[\u0027dns_assignment\u0027]"},{"line_number":187,"context_line":"        if ips_list:"},{"line_number":188,"context_line":"            self.assertEqual(len(dns_assignment), len(ips_list))"},{"line_number":189,"context_line":"            ips_set \u003d set(ips_list)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_5808fbd7","line":186,"range":{"start_line":186,"start_character":31,"end_line":186,"end_character":46},"in_reply_to":"3f4b6375_8ee65144","updated":"2017-10-20 21:13:18.000000000","message":"To date I haven\u0027t been going through each and every instance of usage in the tests and replacing them using constants, but rather focusing on those that ref the constant.\n\n\nIf you grep the code you\u0027ll find there\u0027s a lot of places that use the string constant, so IF we do want to change these I\u0027d wonder if it\u0027d muddy up the consumption patch?","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"47459246df49574f65477f98d485ccdd63e88305","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"import netaddr"},{"line_number":22,"context_line":"from neutron_lib.api.definitions import dns"},{"line_number":23,"context_line":"from neutron_lib.api.definitions import portbindings"},{"line_number":24,"context_line":"from neutron_lib.callbacks import events"},{"line_number":25,"context_line":"from neutron_lib.callbacks import exceptions"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_74040218","line":22,"updated":"2017-10-19 19:44:46.000000000","message":"nit: why not \"as dns_apidef\" like in other places?","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"import netaddr"},{"line_number":22,"context_line":"from neutron_lib.api.definitions import dns"},{"line_number":23,"context_line":"from neutron_lib.api.definitions import portbindings"},{"line_number":24,"context_line":"from neutron_lib.callbacks import events"},{"line_number":25,"context_line":"from neutron_lib.callbacks import exceptions"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_58d6bb29","line":22,"in_reply_to":"3f4b6375_74040218","updated":"2017-10-20 21:13:18.000000000","message":"Done","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"47459246df49574f65477f98d485ccdd63e88305","unresolved":false,"context_lines":[{"line_number":3981,"context_line":"        attributes.RESOURCE_ATTRIBUTE_MAP.update("},{"line_number":3982,"context_line":"            l3.RESOURCE_ATTRIBUTE_MAP)"},{"line_number":3983,"context_line":"        attributes.RESOURCE_ATTRIBUTE_MAP[l3.FLOATINGIPS].update("},{"line_number":3984,"context_line":"            dns.RESOURCE_ATTRIBUTE_MAP[l3.FLOATINGIPS])"},{"line_number":3985,"context_line":"        return l3.L3.get_resources()"},{"line_number":3986,"context_line":""},{"line_number":3987,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_2f04f714","line":3984,"updated":"2017-10-19 19:44:46.000000000","message":"is this change related to this patch?","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3ae347bf4c5af5eb05d95ef51848d1ec7be5cce9","unresolved":false,"context_lines":[{"line_number":3981,"context_line":"        attributes.RESOURCE_ATTRIBUTE_MAP.update("},{"line_number":3982,"context_line":"            l3.RESOURCE_ATTRIBUTE_MAP)"},{"line_number":3983,"context_line":"        attributes.RESOURCE_ATTRIBUTE_MAP[l3.FLOATINGIPS].update("},{"line_number":3984,"context_line":"            dns.RESOURCE_ATTRIBUTE_MAP[l3.FLOATINGIPS])"},{"line_number":3985,"context_line":"        return l3.L3.get_resources()"},{"line_number":3986,"context_line":""},{"line_number":3987,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_be71140f","line":3984,"in_reply_to":"3f4b6375_18e043fa","updated":"2017-10-21 07:48:14.000000000","message":"ok, thx","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[{"line_number":3981,"context_line":"        attributes.RESOURCE_ATTRIBUTE_MAP.update("},{"line_number":3982,"context_line":"            l3.RESOURCE_ATTRIBUTE_MAP)"},{"line_number":3983,"context_line":"        attributes.RESOURCE_ATTRIBUTE_MAP[l3.FLOATINGIPS].update("},{"line_number":3984,"context_line":"            dns.RESOURCE_ATTRIBUTE_MAP[l3.FLOATINGIPS])"},{"line_number":3985,"context_line":"        return l3.L3.get_resources()"},{"line_number":3986,"context_line":""},{"line_number":3987,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_18e043fa","line":3984,"in_reply_to":"3f4b6375_2f04f714","updated":"2017-10-20 21:13:18.000000000","message":"Yes; api-defs in lib don\u0027t use EXTENDED_ATTRIBUTES_2_0","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"}],"neutron/tests/unit/plugins/ml2/extensions/test_dns_integration.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"47459246df49574f65477f98d485ccdd63e88305","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from keystoneauth1 import session"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import netaddr"},{"line_number":20,"context_line":"from neutron_lib.api.definitions import dns"},{"line_number":21,"context_line":"from neutron_lib.api.definitions import provider_net as pnet"},{"line_number":22,"context_line":"from neutron_lib import constants"},{"line_number":23,"context_line":"from neutron_lib import context"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_af0fc72c","line":20,"updated":"2017-10-19 19:44:46.000000000","message":"nit: maybe \"as dns_apidef\" as in other places?","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3ae347bf4c5af5eb05d95ef51848d1ec7be5cce9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from keystoneauth1 import session"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import netaddr"},{"line_number":20,"context_line":"from neutron_lib.api.definitions import dns"},{"line_number":21,"context_line":"from neutron_lib.api.definitions import provider_net as pnet"},{"line_number":22,"context_line":"from neutron_lib import constants"},{"line_number":23,"context_line":"from neutron_lib import context"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_7e65dc44","line":20,"in_reply_to":"3f4b6375_78bcd7db","updated":"2017-10-21 07:48:14.000000000","message":"thx :)","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"257ff794929f6a2e33d5ef30d77d8d93d6cf7ea5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from keystoneauth1 import session"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import netaddr"},{"line_number":20,"context_line":"from neutron_lib.api.definitions import dns"},{"line_number":21,"context_line":"from neutron_lib.api.definitions import provider_net as pnet"},{"line_number":22,"context_line":"from neutron_lib import constants"},{"line_number":23,"context_line":"from neutron_lib import context"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_78bcd7db","line":20,"in_reply_to":"3f4b6375_af0fc72c","updated":"2017-10-20 21:13:18.000000000","message":"Because it generates a lot of other hits in this file to change the name, but done.","commit_id":"232386b2e5295aa017f37c55c6308b2579607bda"}]}
