)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a72605434392173ff2ef33ac2e702aec2a4f2338","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add request timeout handling for Mellanox Neutron Agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add request timeout hadling for messages sent to eswitch Daemon."},{"line_number":10,"context_line":"Using configurable number of retries and increasing waiting interval"},{"line_number":11,"context_line":"between retries resend the message."},{"line_number":12,"context_line":"If request timeout persists, eswitch daemon is not reachable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAS3%2F%2FNH0%3D","line":9,"updated":"2013-10-02 12:18:23.000000000","message":"Nit: handling","commit_id":"752337656779fc8506e1142e980a2befac0e76e7"}],"etc/neutron/plugins/mlnx/mlnx_conf.ini":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"96b113022b5297767d58841545ba65e6f8ba8844","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# request_timeout \u003d 3000"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# The number of retries the agent will send request"},{"line_number":44,"context_line":"# to daemon before gives up"},{"line_number":45,"context_line":"# retry \u003d 3"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[agent]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAS3%2F%2FUPg%3D","line":44,"updated":"2013-09-30 11:34:13.000000000","message":"Should you note the growth rate of the retry delays?","commit_id":"6b2fad95c48415350aa771faa57b76c5790014b6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"029a88f9b8696e03b846355dd4446c03f2a00dbc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# request_timeout \u003d 3000"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# The number of retries the agent will send request"},{"line_number":44,"context_line":"# to daemon before gives up"},{"line_number":45,"context_line":"# retry \u003d 3"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[agent]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAS3%2F%2FUNA%3D","line":44,"in_reply_to":"AAAAS3%2F%2FUPg%3D","updated":"2013-10-02 10:39:37.000000000","message":"Done. Added to be configurable","commit_id":"6b2fad95c48415350aa771faa57b76c5790014b6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a72605434392173ff2ef33ac2e702aec2a4f2338","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# request_timeout \u003d 3000"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# The number of retries the agent will send request"},{"line_number":44,"context_line":"# to daemon before gives up"},{"line_number":45,"context_line":"# retry \u003d 3"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[agent]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAS3%2F%2FNHA%3D","line":44,"updated":"2013-10-02 12:18:23.000000000","message":"Missing new retry delay rate config item.","commit_id":"752337656779fc8506e1142e980a2befac0e76e7"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c8e707c14f6dd76169f33f5a956234b1f0fe7247","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# request_timeout \u003d 3000"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# The number of retries the agent will send request"},{"line_number":44,"context_line":"# to daemon before gives up"},{"line_number":45,"context_line":"# retry \u003d 3"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[agent]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAS3%2F%2FNBA%3D","line":44,"in_reply_to":"AAAAS3%2F%2FNHA%3D","updated":"2013-10-03 11:31:14.000000000","message":"Added","commit_id":"752337656779fc8506e1142e980a2befac0e76e7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"94923d0eb432f55d282d19208d773e41a96c99bb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# to daemon before gives up"},{"line_number":45,"context_line":"# retry \u003d 3"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# The delay multiplier for waiting period between retries"},{"line_number":48,"context_line":"# on request to daemon, i.e. value of 2 will double"},{"line_number":49,"context_line":"# the request timeout each retry"},{"line_number":50,"context_line":"# delay_rate \u003d 2"}],"source_content_type":"text/x-properties","patch_set":6,"id":"AAAATn%2F%2FwOo%3D","line":47,"updated":"2013-10-29 14:53:37.000000000","message":"please add that this is in seconds","commit_id":"a194edb7a8485e34a177a1016c645785249bf0d3"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b04b718dc0c1db862ab1e87c8f29e0f31ab93222","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# to daemon before gives up"},{"line_number":45,"context_line":"# retry \u003d 3"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# The delay multiplier for waiting period between retries"},{"line_number":48,"context_line":"# on request to daemon, i.e. value of 2 will double"},{"line_number":49,"context_line":"# the request timeout each retry"},{"line_number":50,"context_line":"# delay_rate \u003d 2"}],"source_content_type":"text/x-properties","patch_set":6,"id":"AAAATn%2F%2Fomg%3D","line":47,"in_reply_to":"AAAATn%2F%2FwOo%3D","updated":"2013-10-31 05:53:31.000000000","message":"Its an integer value to multiply the request_timeout","commit_id":"a194edb7a8485e34a177a1016c645785249bf0d3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"20754871bf4308054006fa1be52c692fadd1943d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# request_timeout \u003d 3000"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# The number of retries the agent will send request"},{"line_number":44,"context_line":"# to daemon before gives up"},{"line_number":45,"context_line":"# retry \u003d 3"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# The delay multiplier for waiting period between retries"}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAATn%2F%2Fn4g%3D","line":44,"updated":"2013-10-31 09:45:49.000000000","message":"nit: before giving up","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4d4bd6a04d7c3a0ff3a79d3ad99717f7fa8b9e95","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# request_timeout \u003d 3000"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# The number of retries the agent will send request"},{"line_number":44,"context_line":"# to daemon before gives up"},{"line_number":45,"context_line":"# retry \u003d 3"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# The delay multiplier for waiting period between retries"}],"source_content_type":"text/x-properties","patch_set":7,"id":"AAAATn%2F%2FnVs%3D","line":44,"in_reply_to":"AAAATn%2F%2Fn4g%3D","updated":"2013-11-03 05:44:24.000000000","message":"Done","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"}],"neutron/plugins/mlnx/agent/eswitch_neutron_agent.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bf0dbc5d6437c43acfefbc4ea936343799e4d54b","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            except exceptions.RequestTimeout:"},{"line_number":396,"context_line":"                LOG.exception(_(\"Request timeout in agent event loop \""},{"line_number":397,"context_line":"                                \"eSwitchD is not responding - exiting...\"))"},{"line_number":398,"context_line":"                sys.exit(1)"},{"line_number":399,"context_line":"            except Exception:"},{"line_number":400,"context_line":"                LOG.exception(_(\"Error in agent event loop\"))"},{"line_number":401,"context_line":"                sync \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FVvs%3D","line":398,"updated":"2013-09-29 15:51:40.000000000","message":"i think this is not safe for ut, use raise SystemExit instead please","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1e44751e5d36afabac022f8c8687df2df52bb167","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            except exceptions.RequestTimeout:"},{"line_number":396,"context_line":"                LOG.exception(_(\"Request timeout in agent event loop \""},{"line_number":397,"context_line":"                                \"eSwitchD is not responding - exiting...\"))"},{"line_number":398,"context_line":"                sys.exit(1)"},{"line_number":399,"context_line":"            except Exception:"},{"line_number":400,"context_line":"                LOG.exception(_(\"Error in agent event loop\"))"},{"line_number":401,"context_line":"                sync \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FVEA%3D","line":398,"in_reply_to":"AAAAS3%2F%2FVvg%3D","updated":"2013-09-30 07:41:59.000000000","message":"According to documentation sys.exit(s) effectively does raise SystemExit(s) and the difference is from design point of view. I do not have any specific preference, but since the decision here is to exit the program, I think its OK to leave the original code.","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"af5185a738989b99bd4287d63d3771987f7d6b77","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            except exceptions.RequestTimeout:"},{"line_number":396,"context_line":"                LOG.exception(_(\"Request timeout in agent event loop \""},{"line_number":397,"context_line":"                                \"eSwitchD is not responding - exiting...\"))"},{"line_number":398,"context_line":"                sys.exit(1)"},{"line_number":399,"context_line":"            except Exception:"},{"line_number":400,"context_line":"                LOG.exception(_(\"Error in agent event loop\"))"},{"line_number":401,"context_line":"                sync \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FVvg%3D","line":398,"in_reply_to":"AAAAS3%2F%2FVvs%3D","updated":"2013-09-29 15:54:49.000000000","message":"in fact, SystemExit is not safe in the same way.\nI\u0027d say any of these two approaches could be used here.","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1a1025c779738a64da16b481395501813da8c7ad","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            except exceptions.RequestTimeout:"},{"line_number":396,"context_line":"                LOG.exception(_(\"Request timeout in agent event loop \""},{"line_number":397,"context_line":"                                \"eSwitchD is not responding - exiting...\"))"},{"line_number":398,"context_line":"                sys.exit(1)"},{"line_number":399,"context_line":"            except Exception:"},{"line_number":400,"context_line":"                LOG.exception(_(\"Error in agent event loop\"))"},{"line_number":401,"context_line":"                sync \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FJY4%3D","line":398,"updated":"2013-10-03 14:53:09.000000000","message":"Is killing the agent the right way to go about it? Wouldn\u0027t this cause an operational issue? If you have this being managed by something like puppet or chef, the agent will be brought up again, defeating the purpose of this sys.exit. Maybe it\u0027s worthwhile sleeping (for a longer period of time) here instead of dying?","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c40e37c1b228c10a633bc86517edc5bcf09694f","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            except exceptions.RequestTimeout:"},{"line_number":396,"context_line":"                LOG.exception(_(\"Request timeout in agent event loop \""},{"line_number":397,"context_line":"                                \"eSwitchD is not responding - exiting...\"))"},{"line_number":398,"context_line":"                sys.exit(1)"},{"line_number":399,"context_line":"            except Exception:"},{"line_number":400,"context_line":"                LOG.exception(_(\"Error in agent event loop\"))"},{"line_number":401,"context_line":"                sync \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F%2FoI%3D","line":398,"in_reply_to":"AAAAS3%2F%2FJY4%3D","updated":"2013-10-07 08:55:15.000000000","message":"The reason to terminate the agent after number of retries to send requests to eswitch daemon is that all configuration and discovery host operations are performed by eswitchd. In case it is not responding, there is no point for agent to exist. if puppet of chef manage the processes of the host, it will try to bring up both the eswitch and agent.","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"20754871bf4308054006fa1be52c692fadd1943d","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            except exceptions.RequestTimeout:"},{"line_number":396,"context_line":"                LOG.exception(_(\"Request timeout in agent event loop \""},{"line_number":397,"context_line":"                                \"eSwitchD is not responding - exiting...\"))"},{"line_number":398,"context_line":"                sys.exit(1)"},{"line_number":399,"context_line":"            except Exception:"},{"line_number":400,"context_line":"                LOG.exception(_(\"Error in agent event loop\"))"},{"line_number":401,"context_line":"                sync \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fn4Q%3D","line":398,"updated":"2013-10-31 09:45:49.000000000","message":"instead of sys.exit consider raising a SystemException which should have the same effect","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4d4bd6a04d7c3a0ff3a79d3ad99717f7fa8b9e95","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            except exceptions.RequestTimeout:"},{"line_number":396,"context_line":"                LOG.exception(_(\"Request timeout in agent event loop \""},{"line_number":397,"context_line":"                                \"eSwitchD is not responding - exiting...\"))"},{"line_number":398,"context_line":"                sys.exit(1)"},{"line_number":399,"context_line":"            except Exception:"},{"line_number":400,"context_line":"                LOG.exception(_(\"Error in agent event loop\"))"},{"line_number":401,"context_line":"                sync \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FnVY%3D","line":398,"in_reply_to":"AAAATn%2F%2Fn4Q%3D","updated":"2013-11-03 05:44:24.000000000","message":"Do you mean SystemExit?","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"}],"neutron/plugins/mlnx/agent/utils.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c7a2eea26b4e8507522723ee819ad68cb791a212","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class RetryDec(object):"},{"line_number":32,"context_line":"    \"\"\"Retry decorator reruns a method \u0027retry\u0027 times if an exception occurs."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Decorator for retrying a method  if RequestTimeout exception occurs"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FV2U%3D","line":31,"updated":"2013-09-29 13:13:24.000000000","message":"I think it\u0027s better not to use abbreviation here","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1e44751e5d36afabac022f8c8687df2df52bb167","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class RetryDec(object):"},{"line_number":32,"context_line":"    \"\"\"Retry decorator reruns a method \u0027retry\u0027 times if an exception occurs."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Decorator for retrying a method  if RequestTimeout exception occurs"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FVGw%3D","line":31,"in_reply_to":"AAAAS3%2F%2FV2U%3D","updated":"2013-09-30 07:41:59.000000000","message":"Done","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c7a2eea26b4e8507522723ee819ad68cb791a212","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            for i in range(dec_self.retry):"},{"line_number":48,"context_line":"                try:"},{"line_number":49,"context_line":"                    return original_func(*args, **kwargs)"},{"line_number":50,"context_line":"                except exceptions.RequestTimeout, e:"},{"line_number":51,"context_line":"                    sleep_interval \u003d dec_self.interval * (i + 1)"},{"line_number":52,"context_line":"                    LOG.debug(_(\"Request timeout - call again after \""},{"line_number":53,"context_line":"                              \"%s seconds\"), sleep_interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FV14%3D","line":50,"updated":"2013-09-29 13:13:24.000000000","message":"that kind of exception instance spec is not compatible with python 3, need to be \n except exceptions.RequestTimeout as e:","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1e44751e5d36afabac022f8c8687df2df52bb167","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            for i in range(dec_self.retry):"},{"line_number":48,"context_line":"                try:"},{"line_number":49,"context_line":"                    return original_func(*args, **kwargs)"},{"line_number":50,"context_line":"                except exceptions.RequestTimeout, e:"},{"line_number":51,"context_line":"                    sleep_interval \u003d dec_self.interval * (i + 1)"},{"line_number":52,"context_line":"                    LOG.debug(_(\"Request timeout - call again after \""},{"line_number":53,"context_line":"                              \"%s seconds\"), sleep_interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FVGY%3D","line":50,"in_reply_to":"AAAAS3%2F%2FV14%3D","updated":"2013-09-30 07:41:59.000000000","message":"Done","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c7a2eea26b4e8507522723ee819ad68cb791a212","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                try:"},{"line_number":49,"context_line":"                    return original_func(*args, **kwargs)"},{"line_number":50,"context_line":"                except exceptions.RequestTimeout, e:"},{"line_number":51,"context_line":"                    sleep_interval \u003d dec_self.interval * (i + 1)"},{"line_number":52,"context_line":"                    LOG.debug(_(\"Request timeout - call again after \""},{"line_number":53,"context_line":"                              \"%s seconds\"), sleep_interval)"},{"line_number":54,"context_line":"                    time.sleep(sleep_interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FV10%3D","line":51,"updated":"2013-09-29 13:13:24.000000000","message":"just curious why interval is growing, is longer waiting period expected to fix anything?","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1e44751e5d36afabac022f8c8687df2df52bb167","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                try:"},{"line_number":49,"context_line":"                    return original_func(*args, **kwargs)"},{"line_number":50,"context_line":"                except exceptions.RequestTimeout, e:"},{"line_number":51,"context_line":"                    sleep_interval \u003d dec_self.interval * (i + 1)"},{"line_number":52,"context_line":"                    LOG.debug(_(\"Request timeout - call again after \""},{"line_number":53,"context_line":"                              \"%s seconds\"), sleep_interval)"},{"line_number":54,"context_line":"                    time.sleep(sleep_interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FVFY%3D","line":51,"in_reply_to":"AAAAS3%2F%2FV10%3D","updated":"2013-09-30 07:41:59.000000000","message":"The growing interval is not expected to fix, it is supposed to retry  and if no success, assume that eswitch daemon is not responsive anymore. The bug happened when there was a load of requests on eswitch daemon, and it took time for it to respond. Once retry timeout increases, it decreases the chance to assume that eswitch daemon is not responsive while its just busy performing other requests.","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"96b113022b5297767d58841545ba65e6f8ba8844","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        dec_self \u003d self"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        def decorated(*args, **kwargs):"},{"line_number":47,"context_line":"            exc \u003d None"},{"line_number":48,"context_line":"            for i in range(dec_self.retry):"},{"line_number":49,"context_line":"                try:"},{"line_number":50,"context_line":"                    return original_func(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FUSY%3D","line":47,"updated":"2013-09-30 11:34:13.000000000","message":"Temp variable not needed. Can just use exc on line 51, and return on L57.","commit_id":"6b2fad95c48415350aa771faa57b76c5790014b6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"029a88f9b8696e03b846355dd4446c03f2a00dbc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        dec_self \u003d self"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        def decorated(*args, **kwargs):"},{"line_number":47,"context_line":"            exc \u003d None"},{"line_number":48,"context_line":"            for i in range(dec_self.retry):"},{"line_number":49,"context_line":"                try:"},{"line_number":50,"context_line":"                    return original_func(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FUM4%3D","line":47,"in_reply_to":"AAAAS3%2F%2FUSY%3D","updated":"2013-10-02 10:39:37.000000000","message":"Done","commit_id":"6b2fad95c48415350aa771faa57b76c5790014b6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"96b113022b5297767d58841545ba65e6f8ba8844","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            self.poller.register(self._conn, zmq.POLLIN)"},{"line_number":77,"context_line":"        return self.__conn"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @RetryDecorator()"},{"line_number":80,"context_line":"    def send_msg(self, msg):"},{"line_number":81,"context_line":"        self._conn.send(msg)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FUQw%3D","line":79,"updated":"2013-09-30 11:34:13.000000000","message":"Add a UT that verifies that decorator is called N times and returns with exception.","commit_id":"6b2fad95c48415350aa771faa57b76c5790014b6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"029a88f9b8696e03b846355dd4446c03f2a00dbc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            self.poller.register(self._conn, zmq.POLLIN)"},{"line_number":77,"context_line":"        return self.__conn"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @RetryDecorator()"},{"line_number":80,"context_line":"    def send_msg(self, msg):"},{"line_number":81,"context_line":"        self._conn.send(msg)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FULI%3D","line":79,"in_reply_to":"AAAAS3%2F%2FUQw%3D","updated":"2013-10-02 10:39:37.000000000","message":"Done. Also moved the RetryDecorator to separate module","commit_id":"6b2fad95c48415350aa771faa57b76c5790014b6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1a1025c779738a64da16b481395501813da8c7ad","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            self.poller.register(self._conn, zmq.POLLIN)"},{"line_number":44,"context_line":"        return self.__conn"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @RetryDecorator(exceptions.RequestTimeout)"},{"line_number":47,"context_line":"    def send_msg(self, msg):"},{"line_number":48,"context_line":"        self._conn.send(msg)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FJZM%3D","line":46,"updated":"2013-10-03 14:53:09.000000000","message":"Adding a retrydecorator for the send_msg might prevent you from dealing with non-idempotent operations. Would there ever be a chance where this might true in the future? Have you considered adding the decorator directly on the \u0027outer\u0027 methods (e.g. get_attached_vnics)?","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c40e37c1b228c10a633bc86517edc5bcf09694f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            self.poller.register(self._conn, zmq.POLLIN)"},{"line_number":44,"context_line":"        return self.__conn"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @RetryDecorator(exceptions.RequestTimeout)"},{"line_number":47,"context_line":"    def send_msg(self, msg):"},{"line_number":48,"context_line":"        self._conn.send(msg)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F%2FoE%3D","line":46,"in_reply_to":"AAAAS3%2F%2FJZM%3D","updated":"2013-10-07 08:55:15.000000000","message":"Once connection to eswitch daemon is lost, it does not matter what operation fails. For now I do not see the reason to add retry only to certain methods. The reason to implement it as decorator and not add this logic to certain method is exactly due to future possibility to apply it on some operations and not all of them.","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"}],"neutron/plugins/mlnx/common/comm_utils.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a72605434392173ff2ef33ac2e702aec2a4f2338","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.exc \u003d exceptionToCheck"},{"line_number":44,"context_line":"        self.interval \u003d interval"},{"line_number":45,"context_line":"        self.retry \u003d retry"},{"line_number":46,"context_line":"        self.delay_rate \u003d cfg.CONF.ESWITCH.delay_rate"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def __call__(self, original_func):"},{"line_number":49,"context_line":"        dec_self \u003d self"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FNGo%3D","line":46,"updated":"2013-10-02 12:18:23.000000000","message":"This new config item isn\u0027t in the .ini file.\n\nShould this too be available as an argument to allow changing (for testing)?","commit_id":"752337656779fc8506e1142e980a2befac0e76e7"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c8e707c14f6dd76169f33f5a956234b1f0fe7247","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.exc \u003d exceptionToCheck"},{"line_number":44,"context_line":"        self.interval \u003d interval"},{"line_number":45,"context_line":"        self.retry \u003d retry"},{"line_number":46,"context_line":"        self.delay_rate \u003d cfg.CONF.ESWITCH.delay_rate"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def __call__(self, original_func):"},{"line_number":49,"context_line":"        dec_self \u003d self"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FNAQ%3D","line":46,"in_reply_to":"AAAAS3%2F%2FNGo%3D","updated":"2013-10-03 11:31:14.000000000","message":"Was not sure if to expose it as an argument, but testing reason is strong enough. Thanks!","commit_id":"752337656779fc8506e1142e980a2befac0e76e7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cf438185f52234e5a7f574ddb9051e08da2897f1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.delay_rate \u003d delay_rate"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def __call__(self, original_func):"},{"line_number":50,"context_line":"        dec_self \u003d self"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        def decorated(*args, **kwargs):"},{"line_number":53,"context_line":"            sleep_interval \u003d dec_self.interval"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FJvY%3D","line":50,"updated":"2013-10-03 13:18:10.000000000","message":"You don\u0027t need to reassign self here.","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c40e37c1b228c10a633bc86517edc5bcf09694f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.delay_rate \u003d delay_rate"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def __call__(self, original_func):"},{"line_number":50,"context_line":"        dec_self \u003d self"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        def decorated(*args, **kwargs):"},{"line_number":53,"context_line":"            sleep_interval \u003d dec_self.interval"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F%2BOU%3D","line":50,"in_reply_to":"AAAAS3%2F%2FJvY%3D","updated":"2013-10-07 08:55:15.000000000","message":"Thanks. Removed","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cf438185f52234e5a7f574ddb9051e08da2897f1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                except self.exc as exc:"},{"line_number":58,"context_line":"                    LOG.debug(_(\"Request timeout - call again after \""},{"line_number":59,"context_line":"                              \"%s seconds\"), sleep_interval)"},{"line_number":60,"context_line":"                    time.sleep(sleep_interval)"},{"line_number":61,"context_line":"                    sleep_interval *\u003d dec_self.delay_rate"},{"line_number":62,"context_line":"            raise exc"},{"line_number":63,"context_line":"        return decorated"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FJss%3D","line":60,"updated":"2013-10-03 13:18:10.000000000","message":"As it stands, on the last try, it will sleep and then generate an exception. So if interval is 3 seconds, retry\u003d3, and delay\u003d2, you wait 8 seconds, only to learn that it failed. You may want to restructure, so that on the last try, it does not do a sleep after, and instead, immediately fails.","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c40e37c1b228c10a633bc86517edc5bcf09694f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                except self.exc as exc:"},{"line_number":58,"context_line":"                    LOG.debug(_(\"Request timeout - call again after \""},{"line_number":59,"context_line":"                              \"%s seconds\"), sleep_interval)"},{"line_number":60,"context_line":"                    time.sleep(sleep_interval)"},{"line_number":61,"context_line":"                    sleep_interval *\u003d dec_self.delay_rate"},{"line_number":62,"context_line":"            raise exc"},{"line_number":63,"context_line":"        return decorated"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F%2FoA%3D","line":60,"in_reply_to":"AAAAS3%2F%2FJss%3D","updated":"2013-10-07 08:55:15.000000000","message":"Done","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"88cd190b60a789a7e16446d1e0c750f6ed65bd23","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                except self.exc:"},{"line_number":59,"context_line":"                    LOG.debug(_(\"Request timeout - call again after \""},{"line_number":60,"context_line":"                              \"%s seconds\"), sleep_interval)"},{"line_number":61,"context_line":"                    RetryDecorator.sleep_fn(sleep_interval)"},{"line_number":62,"context_line":"                    num_of_iter -\u003d 1"},{"line_number":63,"context_line":"                    sleep_interval *\u003d self.delay_rate"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F92U%3D","line":61,"updated":"2013-10-07 12:16:45.000000000","message":"This still suffers from the same issue of sleeping after the last try, no?\n\nIOW, if the retry was set to 3, we\u0027d have three calls and 3 sleeps, instead of 3 calls and 2 sleeps. I think you need to try once, and then enter a loop to try the remaining times sleep and then call. LIke:\n\n            sleep_interval \u003d self.interval\n            try:\n                print \"Try 1\"\n                return original_func(*args, **kwargs)\n            except self.exc as exc:\n                for i in range(self.retry-1):\n                    print(\"Request timeout - call again after \"\n                          \"%s seconds\" % sleep_interval)\n                    time.sleep(sleep_interval)\n                    sleep_interval *\u003d self.delay_rate\n                    try:\n                        print \"Try\", i+2\n                        return original_func(*args, **kwargs)\n                    except self.exc as exc:\n                        pass\n                raise exc","commit_id":"0dce9940184b21a5ca776e7678b7a78c6c99d85f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"5b44bc0e54769a84825f1b54380b60504ba7cf52","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                except self.exc:"},{"line_number":59,"context_line":"                    LOG.debug(_(\"Request timeout - call again after \""},{"line_number":60,"context_line":"                              \"%s seconds\"), sleep_interval)"},{"line_number":61,"context_line":"                    RetryDecorator.sleep_fn(sleep_interval)"},{"line_number":62,"context_line":"                    num_of_iter -\u003d 1"},{"line_number":63,"context_line":"                    sleep_interval *\u003d self.delay_rate"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F9do%3D","line":61,"in_reply_to":"AAAATH%2F%2F92U%3D","updated":"2013-10-07 13:34:34.000000000","message":"There is a number of retries and not number of tries, so retry \u003d 3 means how many times to retry the method that raises checked exception. In case retry \u003d3, the method that consistently raises exception will be called 4 times.","commit_id":"0dce9940184b21a5ca776e7678b7a78c6c99d85f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1627a708b8f5e02265323afd0050bb35077be702","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                except self.exc:"},{"line_number":59,"context_line":"                    LOG.debug(_(\"Request timeout - call again after \""},{"line_number":60,"context_line":"                              \"%s seconds\"), sleep_interval)"},{"line_number":61,"context_line":"                    RetryDecorator.sleep_fn(sleep_interval)"},{"line_number":62,"context_line":"                    num_of_iter -\u003d 1"},{"line_number":63,"context_line":"                    sleep_interval *\u003d self.delay_rate"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F9WE%3D","line":61,"in_reply_to":"AAAATH%2F%2F9do%3D","updated":"2013-10-07 13:55:43.000000000","message":"Oh right, sorry, I missed the change at the end for another call to original_func(). Much better than my suggestion :)","commit_id":"0dce9940184b21a5ca776e7678b7a78c6c99d85f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"20754871bf4308054006fa1be52c692fadd1943d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class RetryDecorator(object):"},{"line_number":29,"context_line":"    \"\"\"Retry decorator reruns a method \u0027retry\u0027 times if an exception occurs."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Decorator for retrying a method  if exceptionToCheck exception occurs"},{"line_number":32,"context_line":"    If method raises exception, retries \u0027retry\u0027 times with increasing"},{"line_number":33,"context_line":"    back off period between calls with \u0027interval\u0027 multiplier"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fn38%3D","line":31,"updated":"2013-10-31 09:45:49.000000000","message":"not sure if it\u0027s a visualization issue or there are two spaces between method and if","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4d4bd6a04d7c3a0ff3a79d3ad99717f7fa8b9e95","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class RetryDecorator(object):"},{"line_number":29,"context_line":"    \"\"\"Retry decorator reruns a method \u0027retry\u0027 times if an exception occurs."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Decorator for retrying a method  if exceptionToCheck exception occurs"},{"line_number":32,"context_line":"    If method raises exception, retries \u0027retry\u0027 times with increasing"},{"line_number":33,"context_line":"    back off period between calls with \u0027interval\u0027 multiplier"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FnUo%3D","line":31,"in_reply_to":"AAAATn%2F%2Fn38%3D","updated":"2013-11-03 05:44:24.000000000","message":"Done","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"20754871bf4308054006fa1be52c692fadd1943d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    sleep_fn \u003d time.sleep"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, exceptionToCheck,"},{"line_number":43,"context_line":"                 interval\u003dcfg.CONF.ESWITCH.request_timeout / 1000,"},{"line_number":44,"context_line":"                 retry\u003dcfg.CONF.ESWITCH.retry,"},{"line_number":45,"context_line":"                 delay_rate\u003dcfg.CONF.ESWITCH.delay_rate):"},{"line_number":46,"context_line":"        self.exc \u003d exceptionToCheck"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fn3M%3D","line":43,"updated":"2013-10-31 09:45:49.000000000","message":"you are performing an integer division here.\nIf one specificies 2500 milliseconds in request timeout this will lead to an interval of 2 seconds, not 2.5\n\nIs that intentional?","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4d4bd6a04d7c3a0ff3a79d3ad99717f7fa8b9e95","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    sleep_fn \u003d time.sleep"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, exceptionToCheck,"},{"line_number":43,"context_line":"                 interval\u003dcfg.CONF.ESWITCH.request_timeout / 1000,"},{"line_number":44,"context_line":"                 retry\u003dcfg.CONF.ESWITCH.retry,"},{"line_number":45,"context_line":"                 delay_rate\u003dcfg.CONF.ESWITCH.delay_rate):"},{"line_number":46,"context_line":"        self.exc \u003d exceptionToCheck"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FnHY%3D","line":43,"in_reply_to":"AAAATn%2F%2Fn3M%3D","updated":"2013-11-03 05:44:24.000000000","message":"Good catch. Actually the accuracy here is not critical, just reusing the single request timeout.","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a205a175dec2969db6398c6c1a19404db5e5f547","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    :param retries: number of times to try before giving up"},{"line_number":38,"context_line":"    :raises: exceptionToCheck"},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    sleep_fn \u003d time.sleep"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, exceptionToCheck,"},{"line_number":43,"context_line":"                 interval\u003dcfg.CONF.ESWITCH.request_timeout / 1000,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BS4w%3D","line":40,"updated":"2013-11-27 18:50:03.000000000","message":"Why is this needed?","commit_id":"220bcf9a70c639b7b9fd1bacac7dc9022adc91ca"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c22da3d266a818cbc2a61b20f0203c2902543fe0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    :param retries: number of times to try before giving up"},{"line_number":38,"context_line":"    :raises: exceptionToCheck"},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    sleep_fn \u003d time.sleep"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, exceptionToCheck,"},{"line_number":43,"context_line":"                 interval\u003dcfg.CONF.ESWITCH.request_timeout / 1000,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BJ38%3D","line":40,"in_reply_to":"AAAATn%2F%2BS4w%3D","updated":"2013-12-01 08:04:55.000000000","message":"This was needed due to unit testing. Somehow just mocking the imported time.sleep method did not work well.","commit_id":"220bcf9a70c639b7b9fd1bacac7dc9022adc91ca"}],"neutron/plugins/mlnx/common/config.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a72605434392173ff2ef33ac2e702aec2a4f2338","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               help\u003d_(\"The number of retries the agent will send request \""},{"line_number":53,"context_line":"                      \"to daemon before gives up\")),"},{"line_number":54,"context_line":"    cfg.IntOpt(\u0027delay_rate\u0027, default\u003d2,"},{"line_number":55,"context_line":"               help\u003d_(\"delay  multiplier for request timeout to daemon\")),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"agent_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FNFI%3D","line":55,"updated":"2013-10-02 12:18:23.000000000","message":"This really doesn\u0027t increase the request timeout, but instead the delay between retries. Suggest improve help.","commit_id":"752337656779fc8506e1142e980a2befac0e76e7"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c8e707c14f6dd76169f33f5a956234b1f0fe7247","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               help\u003d_(\"The number of retries the agent will send request \""},{"line_number":53,"context_line":"                      \"to daemon before gives up\")),"},{"line_number":54,"context_line":"    cfg.IntOpt(\u0027delay_rate\u0027, default\u003d2,"},{"line_number":55,"context_line":"               help\u003d_(\"delay  multiplier for request timeout to daemon\")),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"agent_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FNAI%3D","line":55,"in_reply_to":"AAAAS3%2F%2FNFI%3D","updated":"2013-10-03 11:31:14.000000000","message":"Done","commit_id":"752337656779fc8506e1142e980a2befac0e76e7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0845efd182048f614f6aba2c26b1503929179738","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               help\u003d_(\"Type of VM network interface: mlnx_direct or \""},{"line_number":44,"context_line":"                      \"hostdev\")),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027daemon_endpoint\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027tcp://127.0.0.1:60001\u0027,"},{"line_number":47,"context_line":"               help\u003d_(\u0027eswitch daemon end point\u0027)),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027request_timeout\u0027, default\u003d3000,"},{"line_number":49,"context_line":"               help\u003d_(\"The number of milliseconds the agent will wait for \""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2F0pc%3D","line":46,"updated":"2013-10-28 13:27:31.000000000","message":"this is not related to the patch set. can you please add that in a separate patch","commit_id":"0dce9940184b21a5ca776e7678b7a78c6c99d85f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0845efd182048f614f6aba2c26b1503929179738","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    cfg.IntOpt(\u0027retry\u0027, default\u003d3,"},{"line_number":52,"context_line":"               help\u003d_(\"The number of retries the agent will send request \""},{"line_number":53,"context_line":"                      \"to daemon before gives up\")),"},{"line_number":54,"context_line":"    cfg.IntOpt(\u0027delay_rate\u0027, default\u003d2,"},{"line_number":55,"context_line":"               help\u003d_(\"delay multiplier for waiting period between retries \""},{"line_number":56,"context_line":"                      \"for request to daemon\")),"},{"line_number":57,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2F0pU%3D","line":54,"updated":"2013-10-28 13:27:31.000000000","message":"can you please let the user know if this is in seconds, minutes hours :)","commit_id":"0dce9940184b21a5ca776e7678b7a78c6c99d85f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"94923d0eb432f55d282d19208d773e41a96c99bb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               help\u003d_(\"The number of retries the agent will send request \""},{"line_number":53,"context_line":"                      \"to daemon before gives up\")),"},{"line_number":54,"context_line":"    cfg.IntOpt(\u0027delay_rate\u0027, default\u003d2,"},{"line_number":55,"context_line":"               help\u003d_(\"delay multiplier for waiting period between retries \""},{"line_number":56,"context_line":"                      \"for request to daemon, i.e. value of 2 will double \""},{"line_number":57,"context_line":"                      \"the request timeout each retry\")),"},{"line_number":58,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FwN4%3D","line":55,"updated":"2013-10-29 14:53:37.000000000","message":"delay \u003d\u003e Delay\n\nplease add that the waiting period is in seconds","commit_id":"a194edb7a8485e34a177a1016c645785249bf0d3"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b04b718dc0c1db862ab1e87c8f29e0f31ab93222","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               help\u003d_(\"The number of retries the agent will send request \""},{"line_number":53,"context_line":"                      \"to daemon before gives up\")),"},{"line_number":54,"context_line":"    cfg.IntOpt(\u0027delay_rate\u0027, default\u003d2,"},{"line_number":55,"context_line":"               help\u003d_(\"delay multiplier for waiting period between retries \""},{"line_number":56,"context_line":"                      \"for request to daemon, i.e. value of 2 will double \""},{"line_number":57,"context_line":"                      \"the request timeout each retry\")),"},{"line_number":58,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Fomk%3D","line":55,"in_reply_to":"AAAATn%2F%2FwN4%3D","updated":"2013-10-31 05:53:31.000000000","message":"The rate is an integer. It multiplies the request_timeout.","commit_id":"a194edb7a8485e34a177a1016c645785249bf0d3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"20754871bf4308054006fa1be52c692fadd1943d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.IntOpt(\u0027request_timeout\u0027, default\u003d3000,"},{"line_number":49,"context_line":"               help\u003d_(\"The number of milliseconds the agent will wait for \""},{"line_number":50,"context_line":"                      \"response on request to daemon.\")),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027retry\u0027, default\u003d3,"},{"line_number":52,"context_line":"               help\u003d_(\"The number of retries the agent will send request \""},{"line_number":53,"context_line":"                      \"to daemon before gives up\")),"},{"line_number":54,"context_line":"    cfg.IntOpt(\u0027delay_rate\u0027, default\u003d2,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fn3A%3D","line":51,"updated":"2013-10-31 09:45:49.000000000","message":"I think \u0027retries\u0027 or \u0027retry_attempts\u0027 might be better option names.\n\nBut this is just an opinion.","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4d4bd6a04d7c3a0ff3a79d3ad99717f7fa8b9e95","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.IntOpt(\u0027request_timeout\u0027, default\u003d3000,"},{"line_number":49,"context_line":"               help\u003d_(\"The number of milliseconds the agent will wait for \""},{"line_number":50,"context_line":"                      \"response on request to daemon.\")),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027retry\u0027, default\u003d3,"},{"line_number":52,"context_line":"               help\u003d_(\"The number of retries the agent will send request \""},{"line_number":53,"context_line":"                      \"to daemon before gives up\")),"},{"line_number":54,"context_line":"    cfg.IntOpt(\u0027delay_rate\u0027, default\u003d2,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FnT8%3D","line":51,"in_reply_to":"AAAATn%2F%2Fn3A%3D","updated":"2013-11-03 05:44:24.000000000","message":"Agree. Changed.","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"20754871bf4308054006fa1be52c692fadd1943d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    cfg.IntOpt(\u0027retry\u0027, default\u003d3,"},{"line_number":52,"context_line":"               help\u003d_(\"The number of retries the agent will send request \""},{"line_number":53,"context_line":"                      \"to daemon before gives up\")),"},{"line_number":54,"context_line":"    cfg.IntOpt(\u0027delay_rate\u0027, default\u003d2,"},{"line_number":55,"context_line":"               help\u003d_(\"delay multiplier for waiting period between retries \""},{"line_number":56,"context_line":"                      \"for request to daemon, i.e. value of 2 will double \""},{"line_number":57,"context_line":"                      \"the request timeout each retry\")),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Fn28%3D","line":54,"updated":"2013-10-31 09:45:49.000000000","message":"isn\u0027t this usually called backoff_rate?","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4d4bd6a04d7c3a0ff3a79d3ad99717f7fa8b9e95","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    cfg.IntOpt(\u0027retry\u0027, default\u003d3,"},{"line_number":52,"context_line":"               help\u003d_(\"The number of retries the agent will send request \""},{"line_number":53,"context_line":"                      \"to daemon before gives up\")),"},{"line_number":54,"context_line":"    cfg.IntOpt(\u0027delay_rate\u0027, default\u003d2,"},{"line_number":55,"context_line":"               help\u003d_(\"delay multiplier for waiting period between retries \""},{"line_number":56,"context_line":"                      \"for request to daemon, i.e. value of 2 will double \""},{"line_number":57,"context_line":"                      \"the request timeout each retry\")),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2FnS4%3D","line":54,"in_reply_to":"AAAATn%2F%2Fn28%3D","updated":"2013-11-03 05:44:24.000000000","message":"Thanks, will rename","commit_id":"9d02936b6ebe09d5dfc48d34851ab417a3810d08"}],"neutron/plugins/mlnx/common/exceptions.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"bf0dbc5d6437c43acfefbc4ea936343799e4d54b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class RequestTimeout(qexc.NeutronException):"},{"line_number":26,"context_line":"    message \u003d _(\u0027Request Timeout\u0027)"},{"line_number":27,"context_line":"    "},{"line_number":28,"context_line":"class OperationFailedResponse(qexc.NeutronException):"},{"line_number":29,"context_line":"    message \u003d _(\"Operation Failed Response: %(err_msg)s\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FVv4%3D","line":27,"updated":"2013-09-29 15:51:40.000000000","message":"no space needed","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"1e44751e5d36afabac022f8c8687df2df52bb167","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class RequestTimeout(qexc.NeutronException):"},{"line_number":26,"context_line":"    message \u003d _(\u0027Request Timeout\u0027)"},{"line_number":27,"context_line":"    "},{"line_number":28,"context_line":"class OperationFailedResponse(qexc.NeutronException):"},{"line_number":29,"context_line":"    message \u003d _(\"Operation Failed Response: %(err_msg)s\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FVG4%3D","line":27,"in_reply_to":"AAAAS3%2F%2FVv4%3D","updated":"2013-09-30 07:41:59.000000000","message":"Done","commit_id":"d5c4a368d19f60c6a6e320e96d651ad71f43f09f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"96b113022b5297767d58841545ba65e6f8ba8844","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class RequestTimeout(qexc.NeutronException):"},{"line_number":26,"context_line":"    message \u003d _(\u0027Request Timeout\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class OperationFailedResponse(qexc.NeutronException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FUQ4%3D","line":26,"updated":"2013-09-30 11:34:13.000000000","message":"More descriptive message?","commit_id":"6b2fad95c48415350aa771faa57b76c5790014b6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"029a88f9b8696e03b846355dd4446c03f2a00dbc","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class RequestTimeout(qexc.NeutronException):"},{"line_number":26,"context_line":"    message \u003d _(\u0027Request Timeout\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class OperationFailedResponse(qexc.NeutronException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FUMg%3D","line":26,"in_reply_to":"AAAAS3%2F%2FUQ4%3D","updated":"2013-10-02 10:39:37.000000000","message":"Added","commit_id":"6b2fad95c48415350aa771faa57b76c5790014b6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0845efd182048f614f6aba2c26b1503929179738","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class OperationFailedResponse(qexc.NeutronException):"},{"line_number":30,"context_line":"    message \u003d _(\"Operation Failed Response: %(err_msg)s\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2F0pM%3D","line":30,"updated":"2013-10-28 13:27:31.000000000","message":"Does not really make sense. Is the Response needed here?","commit_id":"0dce9940184b21a5ca776e7678b7a78c6c99d85f"}],"neutron/tests/unit/mlnx/test_mlnx_comm_utils.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a72605434392173ff2ef33ac2e702aec2a4f2338","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def test_no_retry_required(self):"},{"line_number":27,"context_line":"        self.counter \u003d 0"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        @RetryDecorator(exceptions.RequestTimeout, interval\u003d2, retry\u003d3)"},{"line_number":30,"context_line":"        def succeeds():"},{"line_number":31,"context_line":"            self.counter +\u003d 1"},{"line_number":32,"context_line":"            return \u0027success\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FNC4%3D","line":29,"updated":"2013-10-02 12:18:23.000000000","message":"Use a mock so that you can make the sleep call in the decorator a NOP, otherwise the test will take a long time to run.\n\nYou should be able to tell if sleep is called the expected number of times, and with the expected sleep_interval, based on the the delay rate.","commit_id":"752337656779fc8506e1142e980a2befac0e76e7"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c8e707c14f6dd76169f33f5a956234b1f0fe7247","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def test_no_retry_required(self):"},{"line_number":27,"context_line":"        self.counter \u003d 0"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        @RetryDecorator(exceptions.RequestTimeout, interval\u003d2, retry\u003d3)"},{"line_number":30,"context_line":"        def succeeds():"},{"line_number":31,"context_line":"            self.counter +\u003d 1"},{"line_number":32,"context_line":"            return \u0027success\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FM%2FI%3D","line":29,"in_reply_to":"AAAAS3%2F%2FNC4%3D","updated":"2013-10-03 11:31:14.000000000","message":"Thanks for the comment,saves the testing time.","commit_id":"752337656779fc8506e1142e980a2befac0e76e7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cf438185f52234e5a7f574ddb9051e08da2897f1","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestRetryDecorator(base.BaseTestCase):"},{"line_number":32,"context_line":"    def test_no_retry_required(self):"},{"line_number":33,"context_line":"        self.counter \u003d 0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        @RetryDecorator(exceptions.RequestTimeout, interval\u003d2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FJp8%3D","line":32,"updated":"2013-10-03 13:18:10.000000000","message":"Could add a test with retry\u003d0 as another case, where there is no retry (and no sleep either)","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c40e37c1b228c10a633bc86517edc5bcf09694f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestRetryDecorator(base.BaseTestCase):"},{"line_number":32,"context_line":"    def test_no_retry_required(self):"},{"line_number":33,"context_line":"        self.counter \u003d 0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        @RetryDecorator(exceptions.RequestTimeout, interval\u003d2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F%2FmM%3D","line":32,"in_reply_to":"AAAAS3%2F%2FJp8%3D","updated":"2013-10-07 08:55:15.000000000","message":"Done","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cf438185f52234e5a7f574ddb9051e08da2897f1","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        with mock.patch.object(time, \u0027sleep\u0027) as sleep_fn:"},{"line_number":42,"context_line":"            ret \u003d succeeds()"},{"line_number":43,"context_line":"            sleep_fn.assertCalled()"},{"line_number":44,"context_line":"            self.assertEqual(ret, \u0027success\u0027)"},{"line_number":45,"context_line":"            self.assertEqual(self.counter, 1)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FJsU%3D","line":43,"updated":"2013-10-03 13:18:10.000000000","message":"Shouldn\u0027t call sleep() in this case, right?","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c40e37c1b228c10a633bc86517edc5bcf09694f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        with mock.patch.object(time, \u0027sleep\u0027) as sleep_fn:"},{"line_number":42,"context_line":"            ret \u003d succeeds()"},{"line_number":43,"context_line":"            sleep_fn.assertCalled()"},{"line_number":44,"context_line":"            self.assertEqual(ret, \u0027success\u0027)"},{"line_number":45,"context_line":"            self.assertEqual(self.counter, 1)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F%2Bho%3D","line":43,"in_reply_to":"AAAAS3%2F%2FJsU%3D","updated":"2013-10-07 08:55:15.000000000","message":"Had some strange behavior of time.sleep mock. Fixed the code and test.","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cf438185f52234e5a7f574ddb9051e08da2897f1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            self.assertEqual(self.counter, retry)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            expected_sleep_fn_arg \u003d []"},{"line_number":83,"context_line":"            for i in range(retry):"},{"line_number":84,"context_line":"                expected_sleep_fn_arg.append(interval)"},{"line_number":85,"context_line":"                interval *\u003d delay_rate"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FJq8%3D","line":83,"updated":"2013-10-03 13:18:10.000000000","message":"If you reorg the decorator, then you\u0027d have 3 tries with 2 sleeps in-between, so you\u0027d need to adjust this too.","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c40e37c1b228c10a633bc86517edc5bcf09694f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            self.assertEqual(self.counter, retry)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            expected_sleep_fn_arg \u003d []"},{"line_number":83,"context_line":"            for i in range(retry):"},{"line_number":84,"context_line":"                expected_sleep_fn_arg.append(interval)"},{"line_number":85,"context_line":"                interval *\u003d delay_rate"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F%2Bhk%3D","line":83,"in_reply_to":"AAAAS3%2F%2FJq8%3D","updated":"2013-10-07 08:55:15.000000000","message":"Done","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cf438185f52234e5a7f574ddb9051e08da2897f1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        delay_rate \u003d cfg.CONF.ESWITCH.delay_rate"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        expected_sleep_fn_arg \u003d []"},{"line_number":102,"context_line":"        for i in range(retry):"},{"line_number":103,"context_line":"            expected_sleep_fn_arg.append(interval)"},{"line_number":104,"context_line":"            interval *\u003d delay_rate"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FJqk%3D","line":102,"updated":"2013-10-03 13:18:10.000000000","message":"Ditto","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c40e37c1b228c10a633bc86517edc5bcf09694f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        delay_rate \u003d cfg.CONF.ESWITCH.delay_rate"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        expected_sleep_fn_arg \u003d []"},{"line_number":102,"context_line":"        for i in range(retry):"},{"line_number":103,"context_line":"            expected_sleep_fn_arg.append(interval)"},{"line_number":104,"context_line":"            interval *\u003d delay_rate"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F%2Bhg%3D","line":102,"in_reply_to":"AAAAS3%2F%2FJqk%3D","updated":"2013-10-07 08:55:15.000000000","message":"Done","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cf438185f52234e5a7f574ddb9051e08da2897f1","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        with mock.patch.object(time, \u0027sleep\u0027) as sleep_fn:"},{"line_number":118,"context_line":"            self.assertRaises(WrongException, raise_unexpected_error)"},{"line_number":119,"context_line":"            sleep_fn.assertCalled()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FJqY%3D","line":119,"updated":"2013-10-03 13:18:10.000000000","message":"Ditto. Sleep wouldn\u0027t be called.","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c40e37c1b228c10a633bc86517edc5bcf09694f","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        with mock.patch.object(time, \u0027sleep\u0027) as sleep_fn:"},{"line_number":118,"context_line":"            self.assertRaises(WrongException, raise_unexpected_error)"},{"line_number":119,"context_line":"            sleep_fn.assertCalled()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F%2BhY%3D","line":119,"in_reply_to":"AAAAS3%2F%2FJqY%3D","updated":"2013-10-07 08:55:15.000000000","message":"Done","commit_id":"d0b6fa1e967fcddcdd4793b62d863b7af7bffa79"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"88cd190b60a789a7e16446d1e0c750f6ed65bd23","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        with mock.patch.object(RetryDecorator, \u0027sleep_fn\u0027) as sleep_fn:"},{"line_number":98,"context_line":"            self.assertRaises(exceptions.RequestTimeout, always_fails)"},{"line_number":99,"context_line":"            self.assertEqual(self.counter, retry + 1)"},{"line_number":100,"context_line":"            self.assertEqual(sleep_fn.call_count, retry)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            expected_sleep_fn_arg \u003d []"},{"line_number":103,"context_line":"            for i in range(retry):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F9uU%3D","line":100,"updated":"2013-10-07 12:16:45.000000000","message":"The goal here should be that it tries the function 3 times, but only sleeps 2 times (rather than sleeping a third time and then fail. For example, in this case we get try #1, sleep 2, try #2, sleep 8, try #3, sleep 32, then assert. Versus, try #1, sleep 2, try #2, sleep 8, try #3, assert.","commit_id":"0dce9940184b21a5ca776e7678b7a78c6c99d85f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"5b44bc0e54769a84825f1b54380b60504ba7cf52","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        with mock.patch.object(RetryDecorator, \u0027sleep_fn\u0027) as sleep_fn:"},{"line_number":98,"context_line":"            self.assertRaises(exceptions.RequestTimeout, always_fails)"},{"line_number":99,"context_line":"            self.assertEqual(self.counter, retry + 1)"},{"line_number":100,"context_line":"            self.assertEqual(sleep_fn.call_count, retry)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            expected_sleep_fn_arg \u003d []"},{"line_number":103,"context_line":"            for i in range(retry):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F9c8%3D","line":100,"in_reply_to":"AAAATH%2F%2F9uU%3D","updated":"2013-10-07 13:34:34.000000000","message":"the retry defines how many times to retry the failed method, so actually the method that raises exception will be called retry + 1 times.","commit_id":"0dce9940184b21a5ca776e7678b7a78c6c99d85f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f24bc4aeb991e36d6b801ed233fa72f084820117","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            self.counter +\u003d 1"},{"line_number":37,"context_line":"            return \u0027success\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        with mock.patch.object(RetryDecorator, \u0027sleep_fn\u0027) as sleep_fn:"},{"line_number":40,"context_line":"            ret \u003d succeeds()"},{"line_number":41,"context_line":"            self.assertEqual(sleep_fn.called, False)"},{"line_number":42,"context_line":"            self.assertEqual(sleep_fn.call_count, 0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FwFw%3D","line":39,"updated":"2013-10-29 15:10:45.000000000","message":"is it worth reducing duplication and patch sleep_fn once and for all in the testcase setup?","commit_id":"a194edb7a8485e34a177a1016c645785249bf0d3"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b04b718dc0c1db862ab1e87c8f29e0f31ab93222","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            self.counter +\u003d 1"},{"line_number":37,"context_line":"            return \u0027success\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        with mock.patch.object(RetryDecorator, \u0027sleep_fn\u0027) as sleep_fn:"},{"line_number":40,"context_line":"            ret \u003d succeeds()"},{"line_number":41,"context_line":"            self.assertEqual(sleep_fn.called, False)"},{"line_number":42,"context_line":"            self.assertEqual(sleep_fn.call_count, 0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Foms%3D","line":39,"in_reply_to":"AAAATn%2F%2FwFw%3D","updated":"2013-10-31 05:53:31.000000000","message":"Done","commit_id":"a194edb7a8485e34a177a1016c645785249bf0d3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a205a175dec2969db6398c6c1a19404db5e5f547","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            return \u0027success\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        ret \u003d succeeds()"},{"line_number":46,"context_line":"        self.assertEqual(self.sleep_fn.called, False)"},{"line_number":47,"context_line":"        self.assertEqual(self.sleep_fn.call_count, 0)"},{"line_number":48,"context_line":"        self.assertEqual(ret, \u0027success\u0027)"},{"line_number":49,"context_line":"        self.assertEqual(self.counter, 1)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BS4Y%3D","line":46,"updated":"2013-11-27 18:50:03.000000000","message":"self.assertFalse()","commit_id":"220bcf9a70c639b7b9fd1bacac7dc9022adc91ca"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c22da3d266a818cbc2a61b20f0203c2902543fe0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            return \u0027success\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        ret \u003d succeeds()"},{"line_number":46,"context_line":"        self.assertEqual(self.sleep_fn.called, False)"},{"line_number":47,"context_line":"        self.assertEqual(self.sleep_fn.call_count, 0)"},{"line_number":48,"context_line":"        self.assertEqual(ret, \u0027success\u0027)"},{"line_number":49,"context_line":"        self.assertEqual(self.counter, 1)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BJ30%3D","line":46,"in_reply_to":"AAAATn%2F%2BS4Y%3D","updated":"2013-12-01 08:04:55.000000000","message":"Done","commit_id":"220bcf9a70c639b7b9fd1bacac7dc9022adc91ca"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a205a175dec2969db6398c6c1a19404db5e5f547","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        ret \u003d succeeds()"},{"line_number":46,"context_line":"        self.assertEqual(self.sleep_fn.called, False)"},{"line_number":47,"context_line":"        self.assertEqual(self.sleep_fn.call_count, 0)"},{"line_number":48,"context_line":"        self.assertEqual(ret, \u0027success\u0027)"},{"line_number":49,"context_line":"        self.assertEqual(self.counter, 1)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BS4U%3D","line":47,"updated":"2013-11-27 18:50:03.000000000","message":"This is redundant since line 46 checks for false.","commit_id":"220bcf9a70c639b7b9fd1bacac7dc9022adc91ca"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c22da3d266a818cbc2a61b20f0203c2902543fe0","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        ret \u003d succeeds()"},{"line_number":46,"context_line":"        self.assertEqual(self.sleep_fn.called, False)"},{"line_number":47,"context_line":"        self.assertEqual(self.sleep_fn.call_count, 0)"},{"line_number":48,"context_line":"        self.assertEqual(ret, \u0027success\u0027)"},{"line_number":49,"context_line":"        self.assertEqual(self.counter, 1)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BJ34%3D","line":47,"in_reply_to":"AAAATn%2F%2BS4U%3D","updated":"2013-12-01 08:04:55.000000000","message":"Just was double checking, since caught here strange behavior with mocked sleep method. I guess I can remove it.","commit_id":"220bcf9a70c639b7b9fd1bacac7dc9022adc91ca"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a205a175dec2969db6398c6c1a19404db5e5f547","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.assertRaises(exceptions.RequestTimeout, always_fails)"},{"line_number":64,"context_line":"        self.assertEqual(self.counter, 1)"},{"line_number":65,"context_line":"        self.assertEqual(self.sleep_fn.call_count, 0)"},{"line_number":66,"context_line":"        self.assertEquals(self.sleep_fn.called, False)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_retries_once(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BS4M%3D","line":65,"updated":"2013-11-27 18:50:03.000000000","message":"Same comment about using self.assertFalse()","commit_id":"220bcf9a70c639b7b9fd1bacac7dc9022adc91ca"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c22da3d266a818cbc2a61b20f0203c2902543fe0","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.assertRaises(exceptions.RequestTimeout, always_fails)"},{"line_number":64,"context_line":"        self.assertEqual(self.counter, 1)"},{"line_number":65,"context_line":"        self.assertEqual(self.sleep_fn.call_count, 0)"},{"line_number":66,"context_line":"        self.assertEquals(self.sleep_fn.called, False)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_retries_once(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BJ3w%3D","line":65,"in_reply_to":"AAAATn%2F%2BS4M%3D","updated":"2013-12-01 08:04:55.000000000","message":"Done","commit_id":"220bcf9a70c639b7b9fd1bacac7dc9022adc91ca"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"a205a175dec2969db6398c6c1a19404db5e5f547","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self.assertRaises(WrongException, raise_unexpected_error)"},{"line_number":141,"context_line":"        self.assertFalse(self.sleep_fn.called)"},{"line_number":142,"context_line":"        self.assertEqual(self.sleep_fn.call_count, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BS4E%3D","line":142,"updated":"2013-11-27 18:50:03.000000000","message":"This is redundant with line 141","commit_id":"220bcf9a70c639b7b9fd1bacac7dc9022adc91ca"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c22da3d266a818cbc2a61b20f0203c2902543fe0","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self.assertRaises(WrongException, raise_unexpected_error)"},{"line_number":141,"context_line":"        self.assertFalse(self.sleep_fn.called)"},{"line_number":142,"context_line":"        self.assertEqual(self.sleep_fn.call_count, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BJ3s%3D","line":142,"in_reply_to":"AAAATn%2F%2BS4E%3D","updated":"2013-12-01 08:04:55.000000000","message":"Done","commit_id":"220bcf9a70c639b7b9fd1bacac7dc9022adc91ca"}]}
