)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0b7f5a1b5838b506f87fe90aa310fcb5eb2dae32","unresolved":false,"context_lines":[{"line_number":21,"context_line":"complete the loop, and thus allowing a port to be made"},{"line_number":22,"context_line":"available for use elsewhere."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-bug: #1707339"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I15cdb28072835fcb8c37ae4b56fc8754375a807c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df3967d1_183cc9bd","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":6},"updated":"2017-08-01 08:01:26.000000000","message":"This should be related bug. From what I saw in the logs from the gate, the subport was treated as trusted port, which is wrong. I had the test with some debug messages added running in the loop over night but no success. We might need to sync between deletion of subport in ovsdb handler and security group rpc calls.","commit_id":"9813b190de0fab643b5d65bebfe2eba96aad8485"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0b7f5a1b5838b506f87fe90aa310fcb5eb2dae32","unresolved":false,"context_lines":[{"line_number":635,"context_line":"            ovs_port \u003d self.get_ovs_port(port_id)"},{"line_number":636,"context_line":"            # Test if it\u0027s a patch port"},{"line_number":637,"context_line":"            self._get_port_vlan_tag(ovs_port.port_name)"},{"line_number":638,"context_line":"        except (exceptions.OVSFWTagNotFound, exceptions.OVSFWPortNotFound):"},{"line_number":639,"context_line":"            # It\u0027s a patch port, or it no longer exists: don\u0027t do anything"},{"line_number":640,"context_line":"            return"},{"line_number":641,"context_line":"        self._delete_flows("}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_989e79b6","line":638,"range":{"start_line":638,"start_character":45,"end_line":638,"end_character":74},"updated":"2017-08-01 08:01:26.000000000","message":"We should issue an ERROR message here. If the port was unplugged without calling remove to firewall driver, the rules will remain and can cause issues once next port gets the same ofport id.","commit_id":"9813b190de0fab643b5d65bebfe2eba96aad8485"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"79ec1c389a88eff1712cb407fc7d7958389b99d8","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    def prepare_port_filter(self, port):"},{"line_number":457,"context_line":"        if not firewall.port_sec_enabled(port):"},{"line_number":458,"context_line":"            self._initialize_egress_no_port_security(port[\u0027device\u0027])"},{"line_number":459,"context_line":"            self.sg_port_map.not_filtered_port_ids.add(port[\u0027device\u0027])"},{"line_number":460,"context_line":"            return"},{"line_number":461,"context_line":"        old_of_port \u003d self.get_ofport(port)"},{"line_number":462,"context_line":"        # Make sure delete old allow_address_pair MACs because"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_166a47b2","line":459,"updated":"2017-08-01 18:51:05.000000000","message":"aren\u0027t we adding this already in _initialize_egress_no_port_security?","commit_id":"b2616bd70b3cd0f427dab60f7fade342b19e21db"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"94b4d034668f5897934e8387323b37ec28a4ac2c","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    def prepare_port_filter(self, port):"},{"line_number":457,"context_line":"        if not firewall.port_sec_enabled(port):"},{"line_number":458,"context_line":"            self._initialize_egress_no_port_security(port[\u0027device\u0027])"},{"line_number":459,"context_line":"            self.sg_port_map.not_filtered_port_ids.add(port[\u0027device\u0027])"},{"line_number":460,"context_line":"            return"},{"line_number":461,"context_line":"        old_of_port \u003d self.get_ofport(port)"},{"line_number":462,"context_line":"        # Make sure delete old allow_address_pair MACs because"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_6478ab29","line":459,"in_reply_to":"df3967d1_166a47b2","updated":"2017-08-02 07:34:15.000000000","message":"Yep","commit_id":"b2616bd70b3cd0f427dab60f7fade342b19e21db"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1236f0249a90d6ff819239c52d51a3eba4b703cd","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            )"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def _initialize_egress_no_port_security(self, port_id):"},{"line_number":620,"context_line":"        try:"},{"line_number":621,"context_line":"            ovs_port \u003d self.get_ovs_port(port_id)"},{"line_number":622,"context_line":"            try:"},{"line_number":623,"context_line":"                vlan_tag \u003d self._get_port_vlan_tag(ovs_port.port_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_d977503a","line":620,"updated":"2017-08-01 19:31:35.000000000","message":"more of a style nit: I\u0027d avoid the nested try/except and do:\n\n  ovs_port \u003d None\n  try:\n      ovs_port \u003d ...\n\n   except exceptions.OVSFWTagNotFound as e:\n      if not ovs_port:\n          LOG.error()\n\nIt\u0027s more succinct and easier to read, IMO","commit_id":"b2616bd70b3cd0f427dab60f7fade342b19e21db"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"94b4d034668f5897934e8387323b37ec28a4ac2c","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            )"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def _initialize_egress_no_port_security(self, port_id):"},{"line_number":620,"context_line":"        try:"},{"line_number":621,"context_line":"            ovs_port \u003d self.get_ovs_port(port_id)"},{"line_number":622,"context_line":"            try:"},{"line_number":623,"context_line":"                vlan_tag \u003d self._get_port_vlan_tag(ovs_port.port_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_04931f51","line":620,"in_reply_to":"df3967d1_d977503a","updated":"2017-08-02 07:34:15.000000000","message":"Done","commit_id":"b2616bd70b3cd0f427dab60f7fade342b19e21db"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1236f0249a90d6ff819239c52d51a3eba4b703cd","unresolved":false,"context_lines":[{"line_number":664,"context_line":"                # It\u0027s a patch port, don\u0027t do anything"},{"line_number":665,"context_line":"                return"},{"line_number":666,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":667,"context_line":"            LOG.error(\"Removing rules for not filtered port %(port_id)s but \""},{"line_number":668,"context_line":"                      \"it\u0027s not existing in the ovsdb: %(err)s.\","},{"line_number":669,"context_line":"                      port_id\u003dport_id,"},{"line_number":670,"context_line":"                      err\u003dnot_found_e)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_5999206c","line":667,"updated":"2017-08-01 19:31:35.000000000","message":"same here","commit_id":"b2616bd70b3cd0f427dab60f7fade342b19e21db"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"94b4d034668f5897934e8387323b37ec28a4ac2c","unresolved":false,"context_lines":[{"line_number":664,"context_line":"                # It\u0027s a patch port, don\u0027t do anything"},{"line_number":665,"context_line":"                return"},{"line_number":666,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":667,"context_line":"            LOG.error(\"Removing rules for not filtered port %(port_id)s but \""},{"line_number":668,"context_line":"                      \"it\u0027s not existing in the ovsdb: %(err)s.\","},{"line_number":669,"context_line":"                      port_id\u003dport_id,"},{"line_number":670,"context_line":"                      err\u003dnot_found_e)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_c49cf75e","line":667,"in_reply_to":"df3967d1_5999206c","updated":"2017-08-02 07:34:15.000000000","message":"Done","commit_id":"b2616bd70b3cd0f427dab60f7fade342b19e21db"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"022a3449b9e7e8f480488fff714dd5b7995bdac0","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.ports \u003d {}"},{"line_number":147,"context_line":"        self.sec_groups \u003d {}"},{"line_number":148,"context_line":"        # Maps port_id to ofport number"},{"line_number":149,"context_line":"        self.not_filtered \u003d {}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_sg(self, sg_id):"},{"line_number":152,"context_line":"        return self.sec_groups.get(sg_id, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_0adf8f0d","line":149,"range":{"start_line":149,"start_character":13,"end_line":149,"end_character":26},"updated":"2017-08-02 19:41:43.000000000","message":"aka unfiltered, or unfiltered_ports","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5e8f2ac350a80a1b50332eca74e538573cb37e0","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.ports \u003d {}"},{"line_number":147,"context_line":"        self.sec_groups \u003d {}"},{"line_number":148,"context_line":"        # Maps port_id to ofport number"},{"line_number":149,"context_line":"        self.not_filtered \u003d {}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_sg(self, sg_id):"},{"line_number":152,"context_line":"        return self.sec_groups.get(sg_id, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_638d18d2","line":149,"range":{"start_line":149,"start_character":13,"end_line":149,"end_character":26},"in_reply_to":"df3967d1_0adf8f0d","updated":"2017-08-03 07:55:43.000000000","message":"Done","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"022a3449b9e7e8f480488fff714dd5b7995bdac0","unresolved":false,"context_lines":[{"line_number":624,"context_line":"            # It\u0027s a patch port, don\u0027t set anything"},{"line_number":625,"context_line":"            return"},{"line_number":626,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":627,"context_line":"            LOG.error(\"Initializing not filtered port %(port_id)s but it\u0027s \""},{"line_number":628,"context_line":"                      \"not existing in the ovsdb: %(err)s.\","},{"line_number":629,"context_line":"                      {\u0027port_id\u0027: port_id,"},{"line_number":630,"context_line":"                       \u0027err\u0027: not_found_e})"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_aa8523d1","line":627,"range":{"start_line":627,"start_character":12,"end_line":627,"end_character":21},"updated":"2017-08-02 19:41:43.000000000","message":"is it an impossible situation that indicates that operator should immediately start looking at why it happened (and then the message indeed justifies a ERROR level)? or can it occur from time to time with no need for operator attention (in which case we should downgrade it to DEBUG)?","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"022a3449b9e7e8f480488fff714dd5b7995bdac0","unresolved":false,"context_lines":[{"line_number":624,"context_line":"            # It\u0027s a patch port, don\u0027t set anything"},{"line_number":625,"context_line":"            return"},{"line_number":626,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":627,"context_line":"            LOG.error(\"Initializing not filtered port %(port_id)s but it\u0027s \""},{"line_number":628,"context_line":"                      \"not existing in the ovsdb: %(err)s.\","},{"line_number":629,"context_line":"                      {\u0027port_id\u0027: port_id,"},{"line_number":630,"context_line":"                       \u0027err\u0027: not_found_e})"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_cae4e7e2","line":627,"range":{"start_line":627,"start_character":36,"end_line":627,"end_character":49},"updated":"2017-08-02 19:41:43.000000000","message":"unfiltered?","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5e8f2ac350a80a1b50332eca74e538573cb37e0","unresolved":false,"context_lines":[{"line_number":624,"context_line":"            # It\u0027s a patch port, don\u0027t set anything"},{"line_number":625,"context_line":"            return"},{"line_number":626,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":627,"context_line":"            LOG.error(\"Initializing not filtered port %(port_id)s but it\u0027s \""},{"line_number":628,"context_line":"                      \"not existing in the ovsdb: %(err)s.\","},{"line_number":629,"context_line":"                      {\u0027port_id\u0027: port_id,"},{"line_number":630,"context_line":"                       \u0027err\u0027: not_found_e})"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_c3a4c4a8","line":627,"range":{"start_line":627,"start_character":12,"end_line":627,"end_character":21},"in_reply_to":"df3967d1_aa8523d1","updated":"2017-08-03 07:55:43.000000000","message":"This is a very bad situation that should never occur, can happen if somebody removes a port from ovs very quickly right after it\u0027s been plugged and bound.","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5e8f2ac350a80a1b50332eca74e538573cb37e0","unresolved":false,"context_lines":[{"line_number":624,"context_line":"            # It\u0027s a patch port, don\u0027t set anything"},{"line_number":625,"context_line":"            return"},{"line_number":626,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":627,"context_line":"            LOG.error(\"Initializing not filtered port %(port_id)s but it\u0027s \""},{"line_number":628,"context_line":"                      \"not existing in the ovsdb: %(err)s.\","},{"line_number":629,"context_line":"                      {\u0027port_id\u0027: port_id,"},{"line_number":630,"context_line":"                       \u0027err\u0027: not_found_e})"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_03b64c8b","line":627,"range":{"start_line":627,"start_character":36,"end_line":627,"end_character":49},"in_reply_to":"df3967d1_cae4e7e2","updated":"2017-08-03 07:55:43.000000000","message":"Done","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"022a3449b9e7e8f480488fff714dd5b7995bdac0","unresolved":false,"context_lines":[{"line_number":625,"context_line":"            return"},{"line_number":626,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":627,"context_line":"            LOG.error(\"Initializing not filtered port %(port_id)s but it\u0027s \""},{"line_number":628,"context_line":"                      \"not existing in the ovsdb: %(err)s.\","},{"line_number":629,"context_line":"                      {\u0027port_id\u0027: port_id,"},{"line_number":630,"context_line":"                       \u0027err\u0027: not_found_e})"},{"line_number":631,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_0a2d4ffd","line":628,"range":{"start_line":628,"start_character":39,"end_line":628,"end_character":42},"updated":"2017-08-02 19:41:43.000000000","message":"(not sure but) I think the article should be removed","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"022a3449b9e7e8f480488fff714dd5b7995bdac0","unresolved":false,"context_lines":[{"line_number":624,"context_line":"            # It\u0027s a patch port, don\u0027t set anything"},{"line_number":625,"context_line":"            return"},{"line_number":626,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":627,"context_line":"            LOG.error(\"Initializing not filtered port %(port_id)s but it\u0027s \""},{"line_number":628,"context_line":"                      \"not existing in the ovsdb: %(err)s.\","},{"line_number":629,"context_line":"                      {\u0027port_id\u0027: port_id,"},{"line_number":630,"context_line":"                       \u0027err\u0027: not_found_e})"},{"line_number":631,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_6acf3b56","line":628,"range":{"start_line":627,"start_character":70,"end_line":628,"end_character":35},"updated":"2017-08-02 19:41:43.000000000","message":"it doesn\u0027t exist","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5e8f2ac350a80a1b50332eca74e538573cb37e0","unresolved":false,"context_lines":[{"line_number":625,"context_line":"            return"},{"line_number":626,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":627,"context_line":"            LOG.error(\"Initializing not filtered port %(port_id)s but it\u0027s \""},{"line_number":628,"context_line":"                      \"not existing in the ovsdb: %(err)s.\","},{"line_number":629,"context_line":"                      {\u0027port_id\u0027: port_id,"},{"line_number":630,"context_line":"                       \u0027err\u0027: not_found_e})"},{"line_number":631,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_a3b0a08b","line":628,"range":{"start_line":628,"start_character":39,"end_line":628,"end_character":42},"in_reply_to":"df3967d1_0a2d4ffd","updated":"2017-08-03 07:55:43.000000000","message":"Done","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5e8f2ac350a80a1b50332eca74e538573cb37e0","unresolved":false,"context_lines":[{"line_number":624,"context_line":"            # It\u0027s a patch port, don\u0027t set anything"},{"line_number":625,"context_line":"            return"},{"line_number":626,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":627,"context_line":"            LOG.error(\"Initializing not filtered port %(port_id)s but it\u0027s \""},{"line_number":628,"context_line":"                      \"not existing in the ovsdb: %(err)s.\","},{"line_number":629,"context_line":"                      {\u0027port_id\u0027: port_id,"},{"line_number":630,"context_line":"                       \u0027err\u0027: not_found_e})"},{"line_number":631,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_83a91c25","line":628,"range":{"start_line":627,"start_character":70,"end_line":628,"end_character":35},"in_reply_to":"df3967d1_6acf3b56","updated":"2017-08-03 07:55:43.000000000","message":"Done","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"022a3449b9e7e8f480488fff714dd5b7995bdac0","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def _remove_egress_no_port_security(self, port_id):"},{"line_number":654,"context_line":"        try:"},{"line_number":655,"context_line":"            ofport \u003d self.sg_port_map.not_filtered[port_id]"},{"line_number":656,"context_line":"        except KeyError:"},{"line_number":657,"context_line":"            LOG.debug(\"Port id %s is not handled by the firewall.\", port_id)"},{"line_number":658,"context_line":"            # Port is not handled by the firewall"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_aabac36a","line":655,"updated":"2017-08-02 19:41:43.000000000","message":"nit: could be a regular:\n\nif key not in map:\n    ...","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5e8f2ac350a80a1b50332eca74e538573cb37e0","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def _remove_egress_no_port_security(self, port_id):"},{"line_number":654,"context_line":"        try:"},{"line_number":655,"context_line":"            ofport \u003d self.sg_port_map.not_filtered[port_id]"},{"line_number":656,"context_line":"        except KeyError:"},{"line_number":657,"context_line":"            LOG.debug(\"Port id %s is not handled by the firewall.\", port_id)"},{"line_number":658,"context_line":"            # Port is not handled by the firewall"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_431694aa","line":655,"in_reply_to":"df3967d1_aabac36a","updated":"2017-08-03 07:55:43.000000000","message":"Could be but majority of cases is that port is managed by the firewall, not managed ports are corner case. That means you would be asking for permission when it\u0027s not needed. That\u0027s the reason why common python practices recommend EAFP.","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"022a3449b9e7e8f480488fff714dd5b7995bdac0","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        try:"},{"line_number":655,"context_line":"            ofport \u003d self.sg_port_map.not_filtered[port_id]"},{"line_number":656,"context_line":"        except KeyError:"},{"line_number":657,"context_line":"            LOG.debug(\"Port id %s is not handled by the firewall.\", port_id)"},{"line_number":658,"context_line":"            # Port is not handled by the firewall"},{"line_number":659,"context_line":"            return"},{"line_number":660,"context_line":"        self._delete_flows("}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_aaec038f","line":657,"range":{"start_line":657,"start_character":27,"end_line":657,"end_character":30},"updated":"2017-08-02 19:41:43.000000000","message":"remove","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5e8f2ac350a80a1b50332eca74e538573cb37e0","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        try:"},{"line_number":655,"context_line":"            ofport \u003d self.sg_port_map.not_filtered[port_id]"},{"line_number":656,"context_line":"        except KeyError:"},{"line_number":657,"context_line":"            LOG.debug(\"Port id %s is not handled by the firewall.\", port_id)"},{"line_number":658,"context_line":"            # Port is not handled by the firewall"},{"line_number":659,"context_line":"            return"},{"line_number":660,"context_line":"        self._delete_flows("}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_236a70ed","line":657,"range":{"start_line":657,"start_character":27,"end_line":657,"end_character":30},"in_reply_to":"df3967d1_aaec038f","updated":"2017-08-03 07:55:43.000000000","message":"Done","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"022a3449b9e7e8f480488fff714dd5b7995bdac0","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            ofport \u003d self.sg_port_map.not_filtered[port_id]"},{"line_number":656,"context_line":"        except KeyError:"},{"line_number":657,"context_line":"            LOG.debug(\"Port id %s is not handled by the firewall.\", port_id)"},{"line_number":658,"context_line":"            # Port is not handled by the firewall"},{"line_number":659,"context_line":"            return"},{"line_number":660,"context_line":"        self._delete_flows("},{"line_number":661,"context_line":"            table\u003dovs_consts.TRANSIENT_TABLE,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_0ac9cf24","line":658,"updated":"2017-08-02 19:41:43.000000000","message":"the comment is redundant","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5e8f2ac350a80a1b50332eca74e538573cb37e0","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            ofport \u003d self.sg_port_map.not_filtered[port_id]"},{"line_number":656,"context_line":"        except KeyError:"},{"line_number":657,"context_line":"            LOG.debug(\"Port id %s is not handled by the firewall.\", port_id)"},{"line_number":658,"context_line":"            # Port is not handled by the firewall"},{"line_number":659,"context_line":"            return"},{"line_number":660,"context_line":"        self._delete_flows("},{"line_number":661,"context_line":"            table\u003dovs_consts.TRANSIENT_TABLE,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_637bd8bd","line":658,"in_reply_to":"df3967d1_0ac9cf24","updated":"2017-08-03 07:55:43.000000000","message":"Done","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"022a3449b9e7e8f480488fff714dd5b7995bdac0","unresolved":false,"context_lines":[{"line_number":657,"context_line":"            LOG.debug(\"Port id %s is not handled by the firewall.\", port_id)"},{"line_number":658,"context_line":"            # Port is not handled by the firewall"},{"line_number":659,"context_line":"            return"},{"line_number":660,"context_line":"        self._delete_flows("},{"line_number":661,"context_line":"            table\u003dovs_consts.TRANSIENT_TABLE,"},{"line_number":662,"context_line":"            in_port\u003dofport"},{"line_number":663,"context_line":"        )"},{"line_number":664,"context_line":"        self._delete_flows("},{"line_number":665,"context_line":"            table\u003dovs_consts.ACCEPT_OR_INGRESS_TABLE,"},{"line_number":666,"context_line":"            reg_port\u003dofport"},{"line_number":667,"context_line":"        )"},{"line_number":668,"context_line":"        del self.sg_port_map.not_filtered[port_id]"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"    def _initialize_egress(self, port):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_ca43c76b","line":667,"range":{"start_line":660,"start_character":8,"end_line":667,"end_character":9},"updated":"2017-08-02 19:41:43.000000000","message":"if any of those raise an error, does it mean we will leave the port id in the not_filtered map? is it the actual plan here?","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5e8f2ac350a80a1b50332eca74e538573cb37e0","unresolved":false,"context_lines":[{"line_number":657,"context_line":"            LOG.debug(\"Port id %s is not handled by the firewall.\", port_id)"},{"line_number":658,"context_line":"            # Port is not handled by the firewall"},{"line_number":659,"context_line":"            return"},{"line_number":660,"context_line":"        self._delete_flows("},{"line_number":661,"context_line":"            table\u003dovs_consts.TRANSIENT_TABLE,"},{"line_number":662,"context_line":"            in_port\u003dofport"},{"line_number":663,"context_line":"        )"},{"line_number":664,"context_line":"        self._delete_flows("},{"line_number":665,"context_line":"            table\u003dovs_consts.ACCEPT_OR_INGRESS_TABLE,"},{"line_number":666,"context_line":"            reg_port\u003dofport"},{"line_number":667,"context_line":"        )"},{"line_number":668,"context_line":"        del self.sg_port_map.not_filtered[port_id]"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"    def _initialize_egress(self, port):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_437b34f4","line":667,"range":{"start_line":660,"start_character":8,"end_line":667,"end_character":9},"in_reply_to":"df3967d1_ca43c76b","updated":"2017-08-03 07:55:43.000000000","message":"Yes, technically if flows for managed port where not removed, then firewall still needs to know about it. The flows will be removed on next call of refresh_firewall() from sg_agent.","commit_id":"2fa50b6a18bfdb51e328a446db1e9786b2b4dfe0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"707ea226f954b4f99004183a2b2a027343539c0f","unresolved":false,"context_lines":[{"line_number":624,"context_line":"            # It\u0027s a patch port, don\u0027t set anything"},{"line_number":625,"context_line":"            return"},{"line_number":626,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":627,"context_line":"            LOG.error(\"Initializing unfiltered port %(port_id)s that does not\""},{"line_number":628,"context_line":"                      \"exist in ovsdb: %(err)s.\","},{"line_number":629,"context_line":"                      {\u0027port_id\u0027: port_id,"},{"line_number":630,"context_line":"                       \u0027err\u0027: not_found_e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_7c2fe43e","line":627,"updated":"2017-08-03 18:28:58.000000000","message":"missing space between not and exist","commit_id":"ae91a0c6857f5583f0ef5141851df9de969e9773"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2489bd21d059bd8193ab760c9d22e4ccf3d66928","unresolved":false,"context_lines":[{"line_number":624,"context_line":"            # It\u0027s a patch port, don\u0027t set anything"},{"line_number":625,"context_line":"            return"},{"line_number":626,"context_line":"        except exceptions.OVSFWPortNotFound as not_found_e:"},{"line_number":627,"context_line":"            LOG.error(\"Initializing unfiltered port %(port_id)s that does not\""},{"line_number":628,"context_line":"                      \"exist in ovsdb: %(err)s.\","},{"line_number":629,"context_line":"                      {\u0027port_id\u0027: port_id,"},{"line_number":630,"context_line":"                       \u0027err\u0027: not_found_e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_9ca608ab","line":627,"in_reply_to":"df3967d1_7c2fe43e","updated":"2017-08-03 18:33:37.000000000","message":"ouch, thanks :)","commit_id":"ae91a0c6857f5583f0ef5141851df9de969e9773"}]}
