)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7affec7a9939703079d43b0452e69d98c094a1f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhengwei Gao \u003cmulti_task@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-02 20:05:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed: User doesn\u0027t get quota usage for themself project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage for themself project, it will return"},{"line_number":10,"context_line":"null."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_10734b4f","line":7,"updated":"2017-08-02 16:31:04.000000000","message":"User cannot get quota usage for their own project","commit_id":"4a0f61978ca98b230fa3f9b60f1fa09202e38e8e"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"c523b9476173de8b53a11e7c1e008b1c129296b5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhengwei Gao \u003cmulti_task@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-02 20:05:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed: User doesn\u0027t get quota usage for themself project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage for themself project, it will return"},{"line_number":10,"context_line":"null."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_d9ba7e6c","line":7,"in_reply_to":"df3967d1_10734b4f","updated":"2017-08-03 02:13:52.000000000","message":"Done","commit_id":"4a0f61978ca98b230fa3f9b60f1fa09202e38e8e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7affec7a9939703079d43b0452e69d98c094a1f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixed: User doesn\u0027t get quota usage for themself project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage for themself project, it will return"},{"line_number":10,"context_line":"null."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"},{"line_number":13,"context_line":"Related-Bug: #1708133"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_b0e7dfe4","line":10,"updated":"2017-08-02 16:31:04.000000000","message":"Maybe just mention the fix instead of repeating the first line:\n\nFix code indentation to correctly return quota information.","commit_id":"4a0f61978ca98b230fa3f9b60f1fa09202e38e8e"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"c523b9476173de8b53a11e7c1e008b1c129296b5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixed: User doesn\u0027t get quota usage for themself project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage for themself project, it will return"},{"line_number":10,"context_line":"null."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"},{"line_number":13,"context_line":"Related-Bug: #1708133"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_b9b33a98","line":10,"in_reply_to":"df3967d1_b0e7dfe4","updated":"2017-08-03 02:13:52.000000000","message":"Done","commit_id":"4a0f61978ca98b230fa3f9b60f1fa09202e38e8e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7affec7a9939703079d43b0452e69d98c094a1f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"null."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"},{"line_number":13,"context_line":"Related-Bug: #1708133"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_30cacf6c","line":13,"updated":"2017-08-02 16:31:04.000000000","message":"Closes-bug right?","commit_id":"4a0f61978ca98b230fa3f9b60f1fa09202e38e8e"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"c523b9476173de8b53a11e7c1e008b1c129296b5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"null."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"},{"line_number":13,"context_line":"Related-Bug: #1708133"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_79a95222","line":13,"in_reply_to":"df3967d1_30cacf6c","updated":"2017-08-03 02:13:52.000000000","message":"Done","commit_id":"4a0f61978ca98b230fa3f9b60f1fa09202e38e8e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3dcedce5247bb9141bc46826324952aee7807197","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhengwei Gao \u003cmulti_task@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-03 10:14:33 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"User cann\u0027t get quota usage detail for their own project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df3967d1_2fc93825","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":11},"updated":"2017-08-03 07:18:26.000000000","message":"cann\u0027t -\u003e cannot\n\nwe usually use \"cannot\".","commit_id":"8c033f30ff08e59fa0a7cd082a3aab8d7f1c3394"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3dcedce5247bb9141bc46826324952aee7807197","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"},{"line_number":11,"context_line":"get other\u0027s project quota usage detail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"},{"line_number":14,"context_line":"Closes-Bug: #1708133"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df3967d1_4ff8fc47","line":11,"updated":"2017-08-03 07:18:26.000000000","message":"Previously the only admin can get project quota usage. It doesn\u0027t matter whether which project quota usage is requested.\n\n it only allows only admin to get project quota usage detail.","commit_id":"8c033f30ff08e59fa0a7cd082a3aab8d7f1c3394"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"511ff1d69bb168138933e8a1e858d5955e597500","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"},{"line_number":11,"context_line":"get other\u0027s project quota usage detail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"},{"line_number":14,"context_line":"Closes-Bug: #1708133"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df3967d1_096e6bc8","line":11,"in_reply_to":"df3967d1_4ff8fc47","updated":"2017-08-03 08:40:32.000000000","message":"previously the only admin can get other\u0027s project quota usage, Please review neutron/extensions/quotasv2_detail.py #L55","commit_id":"8c033f30ff08e59fa0a7cd082a3aab8d7f1c3394"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"230ff85e8e64108201388d1a7d3beedc8be307e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhengwei Gao \u003cmulti_task@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-03 16:51:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"User cannot get quota usage detail for their own project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_50aff893","line":7,"range":{"start_line":7,"start_character":50,"end_line":7,"end_character":56},"updated":"2017-08-08 16:03:41.000000000","message":"These characters exceed the recommended maximum length (50 characters) of a commit message first line. Please see: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e9371436ffa7ceefc4500030b965d08ebe724f41","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhengwei Gao \u003cmulti_task@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-03 16:51:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"User cannot get quota usage detail for their own project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_ee9f23b2","line":7,"range":{"start_line":7,"start_character":50,"end_line":7,"end_character":56},"in_reply_to":"9f436f4f_50aff893","updated":"2017-08-09 00:25:30.000000000","message":"Done","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"230ff85e8e64108201388d1a7d3beedc8be307e8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"User cannot get quota usage detail for their own project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"},{"line_number":11,"context_line":"get other\u0027s project quota usage detail."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_908e802c","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":77},"updated":"2017-08-08 16:03:41.000000000","message":"This line exceed the recommended maximum length (72 characters) of a commit body line. Please see: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e9371436ffa7ceefc4500030b965d08ebe724f41","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"User cannot get quota usage detail for their own project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"},{"line_number":11,"context_line":"get other\u0027s project quota usage detail."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_cea45f0b","line":9,"range":{"start_line":9,"start_character":72,"end_line":9,"end_character":77},"in_reply_to":"9f436f4f_908e802c","updated":"2017-08-09 00:25:30.000000000","message":"Done","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"230ff85e8e64108201388d1a7d3beedc8be307e8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"User cannot get quota usage detail for their own project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"},{"line_number":11,"context_line":"get other\u0027s project quota usage detail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_70831c06","line":10,"range":{"start_line":10,"start_character":73,"end_line":10,"end_character":77},"updated":"2017-08-08 16:03:41.000000000","message":"Ditto","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5a4fcc0556fc5d899346b9559c1ac9c1dbaa1aa9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"User cannot get quota usage detail for their own project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"},{"line_number":11,"context_line":"get other\u0027s project quota usage detail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df3967d1_ec96904c","line":10,"range":{"start_line":10,"start_character":44,"end_line":10,"end_character":53},"updated":"2017-08-03 11:57:00.000000000","message":"incorrect","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e9371436ffa7ceefc4500030b965d08ebe724f41","unresolved":false,"context_lines":[{"line_number":7,"context_line":"User cannot get quota usage detail for their own project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"},{"line_number":11,"context_line":"get other\u0027s project quota usage detail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_aea91be0","line":10,"range":{"start_line":10,"start_character":44,"end_line":10,"end_character":53},"in_reply_to":"df3967d1_ec96904c","updated":"2017-08-09 00:25:30.000000000","message":"Done","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5a4fcc0556fc5d899346b9559c1ac9c1dbaa1aa9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"},{"line_number":11,"context_line":"get other\u0027s project quota usage detail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"},{"line_number":14,"context_line":"Closes-Bug: #1708133"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df3967d1_6c8ce035","line":12,"updated":"2017-08-03 11:57:00.000000000","message":"this is a change in the behavior. until now it was an admin only operation. i think that this requires discussion. can you please send a mail to the list and see what people feel about it.","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e577b9a1acdab6b8334850fc31eeec57657f191","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When user try to get quota usage detail for their own project, it will return"},{"line_number":10,"context_line":"null. As process logic of details method is uncorrect, it only allow admin to"},{"line_number":11,"context_line":"get other\u0027s project quota usage detail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2e21dac497a6c5bffba6b55cb4456820900449df"},{"line_number":14,"context_line":"Closes-Bug: #1708133"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf3e73b7_c13f8cd4","line":12,"in_reply_to":"df3967d1_6c8ce035","updated":"2017-08-07 16:30:27.000000000","message":"This extension is added in Pike. If we are quick to fix this before final Pike release, I think we are good.","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"}],"neutron/tests/unit/extensions/test_quotasv2_detail.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7affec7a9939703079d43b0452e69d98c094a1f","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class DetailQuotaExtensionDbTestCase(DetailQuotaExtensionTestCase):"},{"line_number":68,"context_line":"    fmt \u003d \u0027json\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_show_detail_quotas(self):"},{"line_number":71,"context_line":"        tenant_id \u003d \u0027tenant_id1\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_50e2f302","side":"PARENT","line":68,"updated":"2017-08-02 16:31:04.000000000","message":"This change seems unrelated to the bug.","commit_id":"90feab379a98c0d47bff2fafcd474fb2e9f912e9"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"c523b9476173de8b53a11e7c1e008b1c129296b5","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class DetailQuotaExtensionDbTestCase(DetailQuotaExtensionTestCase):"},{"line_number":68,"context_line":"    fmt \u003d \u0027json\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_show_detail_quotas(self):"},{"line_number":71,"context_line":"        tenant_id \u003d \u0027tenant_id1\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_799032ee","side":"PARENT","line":68,"in_reply_to":"df3967d1_50e2f302","updated":"2017-08-03 02:13:52.000000000","message":"please reference below reply.","commit_id":"90feab379a98c0d47bff2fafcd474fb2e9f912e9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"a3ccdb65d01312202e2fd322f019ec1d2ad2f17b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        env \u003d {\u0027neutron.context\u0027: context.Context(\u0027\u0027, tenant_id,"},{"line_number":73,"context_line":"                                                  is_admin\u003dTrue)}"},{"line_number":74,"context_line":"        res \u003d self.api.get(_get_path(\u0027quotas\u0027, id\u003dtenant_id,"},{"line_number":75,"context_line":"                                     fmt\u003dself.fmt,"},{"line_number":76,"context_line":"                                     endpoint\u003dDEFAULT_QUOTAS_ACTION),"},{"line_number":77,"context_line":"                           extra_environ\u003denv)"},{"line_number":78,"context_line":"        self.assertEqual(200, res.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_b00b5622","side":"PARENT","line":75,"updated":"2017-08-02 20:10:56.000000000","message":"This is also unrelated to the bug. please restore. Same applies to lines 104, 127, 150 below","commit_id":"90feab379a98c0d47bff2fafcd474fb2e9f912e9"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"c523b9476173de8b53a11e7c1e008b1c129296b5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        env \u003d {\u0027neutron.context\u0027: context.Context(\u0027\u0027, tenant_id,"},{"line_number":73,"context_line":"                                                  is_admin\u003dTrue)}"},{"line_number":74,"context_line":"        res \u003d self.api.get(_get_path(\u0027quotas\u0027, id\u003dtenant_id,"},{"line_number":75,"context_line":"                                     fmt\u003dself.fmt,"},{"line_number":76,"context_line":"                                     endpoint\u003dDEFAULT_QUOTAS_ACTION),"},{"line_number":77,"context_line":"                           extra_environ\u003denv)"},{"line_number":78,"context_line":"        self.assertEqual(200, res.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_f99c220f","side":"PARENT","line":75,"in_reply_to":"df3967d1_b00b5622","updated":"2017-08-03 02:13:52.000000000","message":"when _get_path method with parameter fmt\u003d\u0027json\u0027, parameter is end with \u0027.json\u0027, namely  v2.0/quotas/tenant_id1.json/details. However, test unit want v2.0/quotas/tenant_id1/details","commit_id":"90feab379a98c0d47bff2fafcd474fb2e9f912e9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"61e0021b2a0525dc0246c07faa3892b8ce75806b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        env \u003d {\u0027neutron.context\u0027: context.Context(\u0027\u0027, tenant_id,"},{"line_number":73,"context_line":"                                                  is_admin\u003dTrue)}"},{"line_number":74,"context_line":"        res \u003d self.api.get(_get_path(\u0027quotas\u0027, id\u003dtenant_id,"},{"line_number":75,"context_line":"                                     fmt\u003dself.fmt,"},{"line_number":76,"context_line":"                                     endpoint\u003dDEFAULT_QUOTAS_ACTION),"},{"line_number":77,"context_line":"                           extra_environ\u003denv)"},{"line_number":78,"context_line":"        self.assertEqual(200, res.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_78d5c7e4","side":"PARENT","line":75,"in_reply_to":"df3967d1_f99c220f","updated":"2017-08-03 07:17:44.000000000","message":"Rather than dropping fmt argument, it is better to fix _get_path().\nLooking at _get_path() [1], I think the order of fmt and endpoint should be swapped.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/unit/api/v2/test_base.py#L54-L70","commit_id":"90feab379a98c0d47bff2fafcd474fb2e9f912e9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3dcedce5247bb9141bc46826324952aee7807197","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        env \u003d {\u0027neutron.context\u0027: context.Context(\u0027\u0027, tenant_id,"},{"line_number":73,"context_line":"                                                  is_admin\u003dTrue)}"},{"line_number":74,"context_line":"        res \u003d self.api.get(_get_path(\u0027quotas\u0027, id\u003dtenant_id,"},{"line_number":75,"context_line":"                                     fmt\u003dself.fmt,"},{"line_number":76,"context_line":"                                     endpoint\u003dDEFAULT_QUOTAS_ACTION),"},{"line_number":77,"context_line":"                           extra_environ\u003denv)"},{"line_number":78,"context_line":"        self.assertEqual(200, res.status_int)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_78eee7b4","side":"PARENT","line":75,"updated":"2017-08-03 07:18:26.000000000","message":"See my comment in patch set 1","commit_id":"90feab379a98c0d47bff2fafcd474fb2e9f912e9"},{"author":{"_account_id":19178,"name":"Zhengwei Gao","email":"gaozhengwei1@letv.com","username":"gaozhengwei"},"change_message_id":"511ff1d69bb168138933e8a1e858d5955e597500","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        env \u003d {\u0027neutron.context\u0027: context.Context(\u0027\u0027, tenant_id,"},{"line_number":73,"context_line":"                                                  is_admin\u003dTrue)}"},{"line_number":74,"context_line":"        res \u003d self.api.get(_get_path(\u0027quotas\u0027, id\u003dtenant_id,"},{"line_number":75,"context_line":"                                     fmt\u003dself.fmt,"},{"line_number":76,"context_line":"                                     endpoint\u003dDEFAULT_QUOTAS_ACTION),"},{"line_number":77,"context_line":"                           extra_environ\u003denv)"},{"line_number":78,"context_line":"        self.assertEqual(200, res.status_int)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_c9750366","side":"PARENT","line":75,"in_reply_to":"df3967d1_78eee7b4","updated":"2017-08-03 08:40:32.000000000","message":"Done","commit_id":"90feab379a98c0d47bff2fafcd474fb2e9f912e9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e577b9a1acdab6b8334850fc31eeec57657f191","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                         quota[\u0027quota\u0027][\u0027subnet\u0027][\u0027limit\u0027])"},{"line_number":142,"context_line":"        self.assertEqual(qconf.DEFAULT_QUOTA_PORT,"},{"line_number":143,"context_line":"                         quota[\u0027quota\u0027][\u0027port\u0027][\u0027limit\u0027])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_detail_quotas_without_admin_forbidden_returns_403(self):"},{"line_number":146,"context_line":"        tenant_id \u003d \u0027tenant_id1\u0027"},{"line_number":147,"context_line":"        env \u003d {\u0027neutron.context\u0027: context.Context(\u0027\u0027, tenant_id + \u00272\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_214c189d","line":144,"updated":"2017-08-07 16:30:27.000000000","message":"please add a new api test that will target the scenario you fix","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"62d445044a1dd4d06d84dbd294016b2c0d9ed672","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                         quota[\u0027quota\u0027][\u0027subnet\u0027][\u0027limit\u0027])"},{"line_number":142,"context_line":"        self.assertEqual(qconf.DEFAULT_QUOTA_PORT,"},{"line_number":143,"context_line":"                         quota[\u0027quota\u0027][\u0027port\u0027][\u0027limit\u0027])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_detail_quotas_without_admin_forbidden_returns_403(self):"},{"line_number":146,"context_line":"        tenant_id \u003d \u0027tenant_id1\u0027"},{"line_number":147,"context_line":"        env \u003d {\u0027neutron.context\u0027: context.Context(\u0027\u0027, tenant_id + \u00272\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_4d3d0cba","line":144,"in_reply_to":"9f436f4f_4e63cfdd","updated":"2017-08-09 08:13:52.000000000","message":"Sounds reasonable to modify the existing tests.","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e9371436ffa7ceefc4500030b965d08ebe724f41","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                         quota[\u0027quota\u0027][\u0027subnet\u0027][\u0027limit\u0027])"},{"line_number":142,"context_line":"        self.assertEqual(qconf.DEFAULT_QUOTA_PORT,"},{"line_number":143,"context_line":"                         quota[\u0027quota\u0027][\u0027port\u0027][\u0027limit\u0027])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_detail_quotas_without_admin_forbidden_returns_403(self):"},{"line_number":146,"context_line":"        tenant_id \u003d \u0027tenant_id1\u0027"},{"line_number":147,"context_line":"        env \u003d {\u0027neutron.context\u0027: context.Context(\u0027\u0027, tenant_id + \u00272\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_4e63cfdd","line":144,"in_reply_to":"bf3e73b7_214c189d","updated":"2017-08-09 00:25:30.000000000","message":"looks like test_show_detail_quotas can test this with a small modification to make the context non-admin since there is already an admin test","commit_id":"a6bcac575ce667a9080620f58204d3e732e497dc"}]}