)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"77b4e21931172e904ac0e219d77d9fbd156a0f46","unresolved":false,"context_lines":[{"line_number":16,"context_line":"scenario test. It might help to debug this test in future."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I29bb8a173af8d6d6e7db4bf61e28a00de9b4b509"},{"line_number":19,"context_line":"Closes-Bug: #1662109"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_ea04b8c8","line":19,"updated":"2017-08-08 17:48:20.000000000","message":"but when the timeout actually happens, won\u0027t the test still fail? if so, I don\u0027t think it solves the failure, does it?","commit_id":"4c26b3a32e553f690c8687590b353f3a09cd1400"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8ad9a0f938bc5f9f531996a144c76dff757eadc7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"scenario test. It might help to debug this test in future."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I29bb8a173af8d6d6e7db4bf61e28a00de9b4b509"},{"line_number":19,"context_line":"Closes-Bug: #1662109"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_2a0d6a8f","line":19,"in_reply_to":"9f436f4f_6ab1e88f","updated":"2017-08-15 19:17:20.000000000","message":"That seems like hiding the issue at stake (reading data hanging). I would rather leave it as-is and try to dig further on why it happens in the first place.","commit_id":"4c26b3a32e553f690c8687590b353f3a09cd1400"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e31aa06b2c7ff1b25f3b33ef3c623dacf5e3f4da","unresolved":false,"context_lines":[{"line_number":16,"context_line":"scenario test. It might help to debug this test in future."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I29bb8a173af8d6d6e7db4bf61e28a00de9b4b509"},{"line_number":19,"context_line":"Closes-Bug: #1662109"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_6ab1e88f","line":19,"in_reply_to":"9f436f4f_ea04b8c8","updated":"2017-08-08 18:13:20.000000000","message":"In fact I\u0027m not sure. My intention here is to add this timeout and catch it to be able to call socket.recv() once again. Maybe it will help somehow and transfer will finish.\nI know that it\u0027s not perfect explanation but I have no other idea how to deal with it.","commit_id":"4c26b3a32e553f690c8687590b353f3a09cd1400"}],"neutron/tests/tempest/scenario/test_qos.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4c11c40dc9dc3d670f78119dd72c8b51ade25e1d","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        start_time \u003d time.time()"},{"line_number":110,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":111,"context_line":"        # NOTE(slaweq): just in case if connection would \"hangs\" it will raise"},{"line_number":112,"context_line":"        # timeout exception if any data will be returned after this small time"},{"line_number":113,"context_line":"        client_socket.settimeout(5)"},{"line_number":114,"context_line":"        total_bytes_read \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_fc76c73e","line":111,"range":{"start_line":111,"start_character":58,"end_line":111,"end_character":63},"updated":"2017-08-07 04:57:03.000000000","message":"hang","commit_id":"c95f31e5515ee2326d83addd07217058c847a030"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"8a6dc50626a42f6f2b125af0873e5635404eea7d","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        start_time \u003d time.time()"},{"line_number":110,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":111,"context_line":"        # NOTE(slaweq): just in case if connection would \"hangs\" it will raise"},{"line_number":112,"context_line":"        # timeout exception if any data will be returned after this small time"},{"line_number":113,"context_line":"        client_socket.settimeout(5)"},{"line_number":114,"context_line":"        total_bytes_read \u003d 0"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_77f09291","line":112,"range":{"start_line":111,"start_character":24,"end_line":112,"end_character":78},"updated":"2017-08-09 15:11:00.000000000","message":"\"In case of connection hangs a timeout exception will be raised if no data is returned during the allocated time.\"\n\nJust make sure I\u0027m not misinterpreting this note.","commit_id":"0b2eb1d3b6f61d3f866f29191edfb4875e3826e5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d016d2f5f024c6dd5cf15f5924bdefc6e1a31ede","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        start_time \u003d time.time()"},{"line_number":110,"context_line":"        client_socket \u003d _connect_socket(host, port)"},{"line_number":111,"context_line":"        # NOTE(slaweq): just in case if connection would \"hangs\" it will raise"},{"line_number":112,"context_line":"        # timeout exception if any data will be returned after this small time"},{"line_number":113,"context_line":"        client_socket.settimeout(5)"},{"line_number":114,"context_line":"        total_bytes_read \u003d 0"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_692544ab","line":112,"range":{"start_line":111,"start_character":24,"end_line":112,"end_character":78},"in_reply_to":"9f436f4f_77f09291","updated":"2017-08-10 07:22:55.000000000","message":"it\u0027s great. Thx :)","commit_id":"0b2eb1d3b6f61d3f866f29191edfb4875e3826e5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8d517ec55a204ca14d3088a4576aa4048a5a2668","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        while total_bytes_read \u003c QoSTest.FILE_SIZE:"},{"line_number":121,"context_line":"            try:"},{"line_number":122,"context_line":"                data \u003d client_socket.recv(QoSTest.BUFFER_SIZE)"},{"line_number":123,"context_line":"                LOG.debug(\"Read %s bytes in current iteration\", len(data))"},{"line_number":124,"context_line":"                total_bytes_read +\u003d len(data)"},{"line_number":125,"context_line":"                LOG.debug(\"Already read %s bytes\" % total_bytes_read)"},{"line_number":126,"context_line":"            except socket.timeout:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_51635e1b","line":123,"updated":"2017-08-09 14:22:40.000000000","message":"nit: maybe you can join L123 and L125.","commit_id":"0b2eb1d3b6f61d3f866f29191edfb4875e3826e5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d016d2f5f024c6dd5cf15f5924bdefc6e1a31ede","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        while total_bytes_read \u003c QoSTest.FILE_SIZE:"},{"line_number":121,"context_line":"            try:"},{"line_number":122,"context_line":"                data \u003d client_socket.recv(QoSTest.BUFFER_SIZE)"},{"line_number":123,"context_line":"                LOG.debug(\"Read %s bytes in current iteration\", len(data))"},{"line_number":124,"context_line":"                total_bytes_read +\u003d len(data)"},{"line_number":125,"context_line":"                LOG.debug(\"Already read %s bytes\" % total_bytes_read)"},{"line_number":126,"context_line":"            except socket.timeout:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_a979ec93","line":123,"in_reply_to":"9f436f4f_51635e1b","updated":"2017-08-10 07:22:55.000000000","message":"Done","commit_id":"0b2eb1d3b6f61d3f866f29191edfb4875e3826e5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8d517ec55a204ca14d3088a4576aa4048a5a2668","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                            \"%(total_bytes_read)s bytes of data.\","},{"line_number":130,"context_line":"                            {\u0027host\u0027: host,"},{"line_number":131,"context_line":"                             \u0027port\u0027: port,"},{"line_number":132,"context_line":"                             \u0027total_bytes_read\u0027: total_bytes_read})"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        time_elapsed \u003d time.time() - start_time"},{"line_number":135,"context_line":"        bytes_per_second \u003d total_bytes_read / time_elapsed"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_91ab061c","line":132,"updated":"2017-08-09 14:22:40.000000000","message":"The only problem I see in this loop is if the socket doesn\u0027t start working again, you\u0027ll be trapped in the loop forever.\n\nIMO, if there is a timeout, you should:\n- Exit the loop\n- Send the warning (L127)\n- Return 0 (no valid BW measurement)\n\n\n\ntry:\n  while total_bytes_read \u003c QoSTest.FILE_SIZE:\n    read data.....\n\nexcept timeout:\n  warning\n  return 0","commit_id":"0b2eb1d3b6f61d3f866f29191edfb4875e3826e5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7dc6d53937675158573a9c15d17587dbf3bb66d2","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                            \"%(total_bytes_read)s bytes of data.\","},{"line_number":130,"context_line":"                            {\u0027host\u0027: host,"},{"line_number":131,"context_line":"                             \u0027port\u0027: port,"},{"line_number":132,"context_line":"                             \u0027total_bytes_read\u0027: total_bytes_read})"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        time_elapsed \u003d time.time() - start_time"},{"line_number":135,"context_line":"        bytes_per_second \u003d total_bytes_read / time_elapsed"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_a859dd5a","line":132,"in_reply_to":"9f436f4f_66d7c5ef","updated":"2017-08-10 14:10:46.000000000","message":"\"...it\u0027s broken with timeout exception\"\n\nhmmm, what you brake is the try/except branch, but not the while loop. Anyway, the condition in L191 is enough to exit the function.","commit_id":"0b2eb1d3b6f61d3f866f29191edfb4875e3826e5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d016d2f5f024c6dd5cf15f5924bdefc6e1a31ede","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                            \"%(total_bytes_read)s bytes of data.\","},{"line_number":130,"context_line":"                            {\u0027host\u0027: host,"},{"line_number":131,"context_line":"                             \u0027port\u0027: port,"},{"line_number":132,"context_line":"                             \u0027total_bytes_read\u0027: total_bytes_read})"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        time_elapsed \u003d time.time() - start_time"},{"line_number":135,"context_line":"        bytes_per_second \u003d total_bytes_read / time_elapsed"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_66d7c5ef","line":132,"in_reply_to":"9f436f4f_91ab061c","updated":"2017-08-10 07:22:55.000000000","message":"It will then be watched by timeout which is set in \"wait_until_true\" helper function. See in line 191 how it\u0027s called.\nIn fact same case is now. If socket hangs for any reason it\u0027s then hangs for 120 seconds and it\u0027s broken with timeout exception.","commit_id":"0b2eb1d3b6f61d3f866f29191edfb4875e3826e5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4873aca68a5999e40daf91965c8e73f4d6519cd4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            try:"},{"line_number":122,"context_line":"                data \u003d client_socket.recv(QoSTest.BUFFER_SIZE)"},{"line_number":123,"context_line":"                total_bytes_read +\u003d len(data)"},{"line_number":124,"context_line":"                LOG.debug(\"Amount of data read in iteration: %(iteration)s \""},{"line_number":125,"context_line":"                          \"bytes. \""},{"line_number":126,"context_line":"                          \"Total amount of already read data: %(total)s \""},{"line_number":127,"context_line":"                          \"bytes\","}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_82befa62","line":124,"range":{"start_line":124,"start_character":63,"end_line":124,"end_character":72},"updated":"2017-08-10 13:08:48.000000000","message":"nit: shouldn\u0027t this be bytes_read ?","commit_id":"2ec80582c75091bc9dd97608e2d158d7a9b90297"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"22b25515cc64ab56052b15674e914f56308da10c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                          {\u0027iteration\u0027: len(data),"},{"line_number":129,"context_line":"                           \u0027total\u0027: total_bytes_read})"},{"line_number":130,"context_line":"            except socket.timeout:"},{"line_number":131,"context_line":"                LOG.warning(\"Socket timeout occurs during trying to read \""},{"line_number":132,"context_line":"                            \"data from %(host)s:%(port)s. Already read \""},{"line_number":133,"context_line":"                            \"%(total_bytes_read)s bytes of data.\","},{"line_number":134,"context_line":"                            {\u0027host\u0027: host,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_f808ce2d","line":131,"range":{"start_line":131,"start_character":44,"end_line":131,"end_character":57},"updated":"2017-08-10 16:55:16.000000000","message":"nit s/occurs during/occurred when","commit_id":"2ec80582c75091bc9dd97608e2d158d7a9b90297"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e70343d9c1453bd3edd326c733d7c2bdfb3abc84","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                          \"%(total_bytes_read)s bytes\","},{"line_number":128,"context_line":"                          {\u0027bytes_read\u0027: len(data),"},{"line_number":129,"context_line":"                           \u0027total_bytes_read\u0027: total_bytes_read})"},{"line_number":130,"context_line":"            except socket.timeout:"},{"line_number":131,"context_line":"                LOG.warning(\"Socket timeout occurred when trying to read \""},{"line_number":132,"context_line":"                            \"data from %(host)s:%(port)s. Already read \""},{"line_number":133,"context_line":"                            \"%(total_bytes_read)s bytes of data.\","}],"source_content_type":"text/x-python","patch_set":8,"id":"ff5d4b2f_07aede2d","line":130,"updated":"2017-09-19 17:27:21.000000000","message":"can we also include the exception str() representation in the log message?","commit_id":"4b667be3d6c73f5fda64d501596b7668f464c43d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"160ca4a011de8362414751ad23c3f973e563dc53","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                            \"%(total_bytes_read)s bytes of data.\","},{"line_number":134,"context_line":"                            {\u0027host\u0027: host,"},{"line_number":135,"context_line":"                             \u0027port\u0027: port,"},{"line_number":136,"context_line":"                             \u0027total_bytes_read\u0027: total_bytes_read})"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        time_elapsed \u003d time.time() - start_time"},{"line_number":139,"context_line":"        bytes_per_second \u003d total_bytes_read / time_elapsed"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff5d4b2f_ac4b7985","line":136,"updated":"2017-09-19 16:48:13.000000000","message":"can we raise here so that we actually fail the test if it happens, and so that we don\u0027t unintentionally loop indefinitely when it times out over and over?","commit_id":"4b667be3d6c73f5fda64d501596b7668f464c43d"}]}
