)]}'
{"neutron/agent/l3/agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1a816153543d8cdba0b8325f95555e11650ac29c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        return cctxt.call(context, \u0027delete_agent_gateway_port\u0027,"},{"line_number":169,"context_line":"                          host\u003dself.host, network_id\u003dfip_net)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class L3NATAgent(ha.AgentMixin,"},{"line_number":173,"context_line":"                 dvr.AgentMixin,"},{"line_number":174,"context_line":"                 manager.Manager):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_a48353cc","line":171,"updated":"2017-08-10 08:30:55.000000000","message":"Classes with rpc consumers usually have decorator\n  @profiler.trace_cls(\"rpc or other name\")\nto help debugging","commit_id":"9cc85bb67fef66b0a243d34c794eacaba968a940"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1c4afdc31847913cb4dc4f0ea508ba6111b21ce9","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            self.internal_network_removed(p)"},{"line_number":552,"context_line":"            LOG.debug(\"removing port %s from internal_ports cache\", p)"},{"line_number":553,"context_line":"            self.internal_ports.remove(p)"},{"line_number":554,"context_line":"            enable_ra \u003d enable_ra or self._port_has_ipv6_subnet(p)"},{"line_number":555,"context_line":"            for subnet in p[\u0027subnets\u0027]:"},{"line_number":556,"context_line":"                if ipv6_utils.is_ipv6_pd_enabled(subnet):"},{"line_number":557,"context_line":"                    self.agent.pd.disable_subnet(self.router_id, subnet[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_ac211ca2","line":554,"updated":"2017-08-07 18:36:34.000000000","message":"You have now raised my interest in finding why we are enabling radvd for ports that are going away and not disabling it.","commit_id":"e9d8073da245eeaca7ba05ca1415d0b91ba96e23"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1c4afdc31847913cb4dc4f0ea508ba6111b21ce9","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        # Enable RA"},{"line_number":592,"context_line":"        if enable_ra:"},{"line_number":593,"context_line":"            self.enable_radvd(self.internal_ports)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        existing_devices \u003d self._get_existing_devices()"},{"line_number":596,"context_line":"        current_internal_devs \u003d set(n for n in existing_devices"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_6c12145b","line":593,"updated":"2017-08-07 18:36:34.000000000","message":"Doesn\u0027t seem exactly related to MTU.  Also, if you pass no ports it will use self.internal_ports.","commit_id":"e9d8073da245eeaca7ba05ca1415d0b91ba96e23"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"68e433cb6b5410e9ab003181c3c68e0c78ed8504","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        # Enable RA"},{"line_number":592,"context_line":"        if enable_ra:"},{"line_number":593,"context_line":"            self.enable_radvd(self.internal_ports)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        existing_devices \u003d self._get_existing_devices()"},{"line_number":596,"context_line":"        current_internal_devs \u003d set(n for n in existing_devices"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_a7f7f5f5","line":593,"in_reply_to":"bf3e73b7_6c12145b","updated":"2017-08-07 18:47:00.000000000","message":"It is related, because internal_ports (without self) contains old mtu values. But true that we could pass nothing.","commit_id":"e9d8073da245eeaca7ba05ca1415d0b91ba96e23"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1a816153543d8cdba0b8325f95555e11650ac29c","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        # Enable RA"},{"line_number":592,"context_line":"        if enable_ra:"},{"line_number":593,"context_line":"            self.enable_radvd(self.internal_ports)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        existing_devices \u003d self._get_existing_devices()"},{"line_number":596,"context_line":"        current_internal_devs \u003d set(n for n in existing_devices"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_64744b69","line":593,"range":{"start_line":593,"start_character":30,"end_line":593,"end_character":49},"updated":"2017-08-10 08:30:55.000000000","message":"Is this change related?","commit_id":"9cc85bb67fef66b0a243d34c794eacaba968a940"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ab149fb2382fdc3313b5eb43e7e111574b6da731","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        # Enable RA"},{"line_number":592,"context_line":"        if enable_ra:"},{"line_number":593,"context_line":"            self.enable_radvd(self.internal_ports)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        existing_devices \u003d self._get_existing_devices()"},{"line_number":596,"context_line":"        current_internal_devs \u003d set(n for n in existing_devices"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_769f3d5f","line":593,"range":{"start_line":593,"start_character":30,"end_line":593,"end_character":49},"in_reply_to":"9f436f4f_168923c9","updated":"2017-08-11 07:47:34.000000000","message":"Sorry, I didn\u0027t read the previous comments...","commit_id":"9cc85bb67fef66b0a243d34c794eacaba968a940"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5642342ba38072032befb9498e9755126d8d85ae","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        # Enable RA"},{"line_number":592,"context_line":"        if enable_ra:"},{"line_number":593,"context_line":"            self.enable_radvd(self.internal_ports)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        existing_devices \u003d self._get_existing_devices()"},{"line_number":596,"context_line":"        current_internal_devs \u003d set(n for n in existing_devices"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_db77443a","line":593,"range":{"start_line":593,"start_character":30,"end_line":593,"end_character":49},"in_reply_to":"9f436f4f_64744b69","updated":"2017-08-10 17:22:04.000000000","message":"Yes, answered twice in previous patchsets. :) Sadly, explaining it in a comment wouldn\u0027t make sense in context outside the patch itself, so I am hesitant to explain it here. Thoughts?","commit_id":"9cc85bb67fef66b0a243d34c794eacaba968a940"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5601d867f1074ed8f319bea9bd4d7c8587a21471","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        # Enable RA"},{"line_number":592,"context_line":"        if enable_ra:"},{"line_number":593,"context_line":"            self.enable_radvd(self.internal_ports)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        existing_devices \u003d self._get_existing_devices()"},{"line_number":596,"context_line":"        current_internal_devs \u003d set(n for n in existing_devices"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_9e174e52","line":593,"range":{"start_line":593,"start_character":30,"end_line":593,"end_character":49},"in_reply_to":"9f436f4f_769f3d5f","updated":"2017-08-11 13:10:33.000000000","message":"That\u0027s good you asked; it made us have another look, and it seems like this change is not really needed","commit_id":"9cc85bb67fef66b0a243d34c794eacaba968a940"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"565ba8e397cfe4fe8b053e99ff0e7e7cea4083a6","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        # Enable RA"},{"line_number":592,"context_line":"        if enable_ra:"},{"line_number":593,"context_line":"            self.enable_radvd(self.internal_ports)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        existing_devices \u003d self._get_existing_devices()"},{"line_number":596,"context_line":"        current_internal_devs \u003d set(n for n in existing_devices"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_168923c9","line":593,"range":{"start_line":593,"start_character":30,"end_line":593,"end_character":49},"in_reply_to":"9f436f4f_db77443a","updated":"2017-08-10 17:57:53.000000000","message":"yeah, i think outside of this patch the comment won\u0027t add anything","commit_id":"9cc85bb67fef66b0a243d34c794eacaba968a940"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"130af9260ac9d83e51c38a1b8469ff863077382b","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        # Enable RA"},{"line_number":592,"context_line":"        if enable_ra:"},{"line_number":593,"context_line":"            self.enable_radvd(self.internal_ports)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        existing_devices \u003d self._get_existing_devices()"},{"line_number":596,"context_line":"        current_internal_devs \u003d set(n for n in existing_devices"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f436f4f_e5ab7986","line":593,"updated":"2017-08-11 05:16:50.000000000","message":"testing if this change is relevant, here: https://review.openstack.org/492802","commit_id":"5ba10aaea7c0627463519e5bdddd8674c52cfd6c"}],"neutron/tests/fullstack/test_l3_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3d948a49157660015a64d38cb49a4a99c00665f3","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        vm.block_until_ping(external_vm.ipv6)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"class TestHAL3Agent(TestL3Agent):"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def setUp(self):"},{"line_number":215,"context_line":"        host_descriptions \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_017783a2","line":212,"updated":"2017-08-11 13:12:41.000000000","message":"I should probably add a test case here too to cover the change in ha_router.py; but I won\u0027t have time for that till Monday. Can we leave it for a follow up?","commit_id":"f1ce3f49e2c71af82b7505792e72a1b7a530987a"}]}