)]}'
{"neutron/tests/fullstack/test_dhcp_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"02e4b2f5652c5eab7a446626a0f257a6d3fd3ea6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_mtu_update(self):"},{"line_number":105,"context_line":"        self.vm.block_until_dhcp_config_done()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        namespace \u003d cmd._get_namespace_name("},{"line_number":108,"context_line":"            self.network[\u0027id\u0027],"},{"line_number":109,"context_line":"            suffix\u003dself.environment.hosts[0].dhcp_agent.get_namespace_suffix())"},{"line_number":110,"context_line":"        ip \u003d ip_lib.IPWrapper(namespace)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        devices \u003d ip.get_devices()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_77416d39","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":79},"updated":"2017-08-11 14:16:51.000000000","message":"Isn\u0027t it what is at self.environment.hosts[0].dhcp_agent.namespace ?","commit_id":"ccab145403659fe2d9adc1d5ace1f4a368c26d3f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"489ca34585a9ccebcc5c9f83d27390d5e9644a9e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_mtu_update(self):"},{"line_number":105,"context_line":"        self.vm.block_until_dhcp_config_done()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        namespace \u003d cmd._get_namespace_name("},{"line_number":108,"context_line":"            self.network[\u0027id\u0027],"},{"line_number":109,"context_line":"            suffix\u003dself.environment.hosts[0].dhcp_agent.get_namespace_suffix())"},{"line_number":110,"context_line":"        ip \u003d ip_lib.IPWrapper(namespace)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        devices \u003d ip.get_devices()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_ce0cfbed","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":79},"in_reply_to":"9f436f4f_4dcc9a60","updated":"2017-08-11 19:53:03.000000000","message":"I suspect this class just doesn\u0027t execute the agent in a nested namespace but in root only. Otherwise it should have failed (?). Not sure if it\u0027s worth digging it right now since I will get to the patch on Monday the earliest, and we probably want to have those two remaining bits for agent side implementation of network mtu update in pike before final. (We already landed the neutron-server side.)","commit_id":"ccab145403659fe2d9adc1d5ace1f4a368c26d3f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"329d9cb330436a401a6be0c9fb7e70f3b33c10eb","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_mtu_update(self):"},{"line_number":105,"context_line":"        self.vm.block_until_dhcp_config_done()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        namespace \u003d cmd._get_namespace_name("},{"line_number":108,"context_line":"            self.network[\u0027id\u0027],"},{"line_number":109,"context_line":"            suffix\u003dself.environment.hosts[0].dhcp_agent.get_namespace_suffix())"},{"line_number":110,"context_line":"        ip \u003d ip_lib.IPWrapper(namespace)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        devices \u003d ip.get_devices()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_4dcc9a60","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":79},"in_reply_to":"9f436f4f_6d419e39","updated":"2017-08-11 15:24:05.000000000","message":"Oh, right. Makes me thinking - if the agent is running in namespace, the qdhcp- namespaces will be inside of that namespace. Don\u0027t you need a nested namespace command here then? Like\n\nip net e dhcp-agent-ns ip net e qdhcp-\u003cnet\u003e \u003csome ip commands\u003e","commit_id":"ccab145403659fe2d9adc1d5ace1f4a368c26d3f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cb6506dde344f7fbc25778b0e1b0384fac38f2a6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_mtu_update(self):"},{"line_number":105,"context_line":"        self.vm.block_until_dhcp_config_done()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        namespace \u003d cmd._get_namespace_name("},{"line_number":108,"context_line":"            self.network[\u0027id\u0027],"},{"line_number":109,"context_line":"            suffix\u003dself.environment.hosts[0].dhcp_agent.get_namespace_suffix())"},{"line_number":110,"context_line":"        ip \u003d ip_lib.IPWrapper(namespace)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        devices \u003d ip.get_devices()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_6d419e39","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":79},"in_reply_to":"9f436f4f_77416d39","updated":"2017-08-11 15:12:22.000000000","message":"I think no. Isn\u0027t it a namespace where the agent is running, not qdhcp?","commit_id":"ccab145403659fe2d9adc1d5ace1f4a368c26d3f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2661c73ac7d6d72021319cb0317ab77dd7159420","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_mtu_update(self):"},{"line_number":105,"context_line":"        self.vm.block_until_dhcp_config_done()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        namespace \u003d cmd._get_namespace_name("},{"line_number":108,"context_line":"            self.network[\u0027id\u0027],"},{"line_number":109,"context_line":"            suffix\u003dself.environment.hosts[0].dhcp_agent.get_namespace_suffix())"},{"line_number":110,"context_line":"        ip \u003d ip_lib.IPWrapper(namespace)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        devices \u003d ip.get_devices()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_542c1aab","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":79},"in_reply_to":"9f436f4f_ce0cfbed","updated":"2017-08-11 21:46:23.000000000","message":"Ok, we can look at it later. It might introduce another fullstack issue tho.","commit_id":"ccab145403659fe2d9adc1d5ace1f4a368c26d3f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"02e4b2f5652c5eab7a446626a0f257a6d3fd3ea6","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        dhcp_dev \u003d devices[0]"},{"line_number":116,"context_line":"        mtu \u003d dhcp_dev.link.mtu"},{"line_number":117,"context_line":"        self.assertEqual(1450, mtu)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        mtu -\u003d 1"},{"line_number":120,"context_line":"        self.safe_client.update_network(self.network[\u0027id\u0027], mtu\u003dmtu)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_f7843d60","line":117,"range":{"start_line":117,"start_character":25,"end_line":117,"end_character":29},"updated":"2017-08-11 14:16:51.000000000","message":"Should this value be based on the used overlay network? Meaning if we\u0027d add different tenant network type it should fit its value.","commit_id":"ccab145403659fe2d9adc1d5ace1f4a368c26d3f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"329d9cb330436a401a6be0c9fb7e70f3b33c10eb","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        dhcp_dev \u003d devices[0]"},{"line_number":116,"context_line":"        mtu \u003d dhcp_dev.link.mtu"},{"line_number":117,"context_line":"        self.assertEqual(1450, mtu)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        mtu -\u003d 1"},{"line_number":120,"context_line":"        self.safe_client.update_network(self.network[\u0027id\u0027], mtu\u003dmtu)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_2ddb961b","line":117,"range":{"start_line":117,"start_character":25,"end_line":117,"end_character":29},"in_reply_to":"9f436f4f_6d6abeb3","updated":"2017-08-11 15:24:05.000000000","message":"Yeah, let future us handle that when it\u0027s needed.","commit_id":"ccab145403659fe2d9adc1d5ace1f4a368c26d3f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cb6506dde344f7fbc25778b0e1b0384fac38f2a6","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        dhcp_dev \u003d devices[0]"},{"line_number":116,"context_line":"        mtu \u003d dhcp_dev.link.mtu"},{"line_number":117,"context_line":"        self.assertEqual(1450, mtu)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        mtu -\u003d 1"},{"line_number":120,"context_line":"        self.safe_client.update_network(self.network[\u0027id\u0027], mtu\u003dmtu)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_6d6abeb3","line":117,"range":{"start_line":117,"start_character":25,"end_line":117,"end_character":29},"in_reply_to":"9f436f4f_f7843d60","updated":"2017-08-11 15:12:22.000000000","message":"Yeah, but there is no clear way to get a type to mtu mapping without creating the whole ml2 plugin object, with configuration initialized etal. I was hoping that we can leave it to when/if we need to change the underlying network types executed for the test class.","commit_id":"ccab145403659fe2d9adc1d5ace1f4a368c26d3f"}]}