)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"34287fa27b24ea337db4c9de46bdcce1b525ff80","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ovsfw: Use multiple priorities in RULES_*_TABLE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OpenFlow spec says packets shouldn\u0027t match against multiple flows"},{"line_number":10,"context_line":"at the same proiority or the result is undefined. In ovsfw, 4 priority"},{"line_number":11,"context_line":"levels are needed to comply with this rule."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6deaee8dbe81453285b1fc685282952bc9456949"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_71e67ceb","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":21},"updated":"2017-08-22 22:56:37.000000000","message":"priority","commit_id":"a47abc22f6e87995c1f347993c45cf0cf7a4d98c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"c730fc48b001c274236f10292a0d9a0443c1ca75","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ovsfw: Use multiple priorities in RULES_*_TABLE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OpenFlow spec says packets shouldn\u0027t match against multiple flows"},{"line_number":10,"context_line":"at the same proiority or the result is undefined. In ovsfw, 4 priority"},{"line_number":11,"context_line":"levels are needed to comply with this rule."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6deaee8dbe81453285b1fc685282952bc9456949"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_128f3024","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":21},"in_reply_to":"7f287b81_71e67ceb","updated":"2017-08-23 07:58:15.000000000","message":"Done","commit_id":"a47abc22f6e87995c1f347993c45cf0cf7a4d98c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"155bf8386a39b74c523e5742156da612e5a6a1a9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ovsfw: Use multiple priorities in RULES_*_TABLE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OpenFlow spec says packets shouldn\u0027t match against multiple flows"},{"line_number":10,"context_line":"at the same priority or the result is undefined. In ovsfw, 4 priority"},{"line_number":11,"context_line":"levels are needed to comply with this rule."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6deaee8dbe81453285b1fc685282952bc9456949"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f2577a7_648190fb","line":10,"range":{"start_line":10,"start_character":59,"end_line":10,"end_character":69},"updated":"2017-09-15 15:47:55.000000000","message":"I\u0027m feeling we need lower priority for conjunction flows,\nresulting in 8 in total.","commit_id":"f64ffa5302ba5e6be2ca04fc301e931feffb7a32"}],"doc/source/contributor/internals/openvswitch_firewall.rst":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"34287fa27b24ea337db4c9de46bdcce1b525ff80","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Flow priorities for security group rules"},{"line_number":94,"context_line":"----------------------------------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The OpenFlow spec says any packet should not match against multiple"},{"line_number":97,"context_line":"flows at the same priority. The firewall driver uses 4 levels of"},{"line_number":98,"context_line":"priorities to achieve this. The method ``flows_priority_offset``"},{"line_number":99,"context_line":"calculates a priority for a given security group rule."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_03748b34","line":96,"range":{"start_line":96,"start_character":23,"end_line":96,"end_character":26},"updated":"2017-08-22 22:56:37.000000000","message":"This is unnecessary and makes the sentence difficult to understand. I suggest:\n\nThe OpenFlow spec says packets should not match....","commit_id":"a47abc22f6e87995c1f347993c45cf0cf7a4d98c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"c730fc48b001c274236f10292a0d9a0443c1ca75","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Flow priorities for security group rules"},{"line_number":94,"context_line":"----------------------------------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The OpenFlow spec says any packet should not match against multiple"},{"line_number":97,"context_line":"flows at the same priority. The firewall driver uses 4 levels of"},{"line_number":98,"context_line":"priorities to achieve this. The method ``flows_priority_offset``"},{"line_number":99,"context_line":"calculates a priority for a given security group rule."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_329b4c73","line":96,"range":{"start_line":96,"start_character":23,"end_line":96,"end_character":26},"in_reply_to":"7f287b81_03748b34","updated":"2017-08-23 07:58:15.000000000","message":"Done","commit_id":"a47abc22f6e87995c1f347993c45cf0cf7a4d98c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"986379cd51506cc9f142875c5a4b1db7bba402fd","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"::"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":" table\u003d72, priority\u003d71,ct_state\u003d+est-rel-rpl,icmp,reg5\u003d0x1, actions\u003dresubmit(,73)"},{"line_number":246,"context_line":" table\u003d72, priority\u003d70,ct_state\u003d+new-est,icmp,reg5\u003d0x1, actions\u003dresubmit(,73)"},{"line_number":247,"context_line":" table\u003d72, priority\u003d50,ct_state\u003d+inv+trk actions\u003ddrop"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f287b81_8a7fd164","line":245,"range":{"start_line":245,"start_character":11,"end_line":245,"end_character":49},"updated":"2017-09-08 08:42:58.000000000","message":"But in this case, no traffic can match L245 flow and L246 flow, because ct_state conditions are opposite.","commit_id":"f64ffa5302ba5e6be2ca04fc301e931feffb7a32"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":25943,"name":"Zachary Ma","email":"mazengxie@126.com","username":"Zachary"},"change_message_id":"e3bd5063153498d8fbd373f25bb36947b1245325","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        if self.id_free:"},{"line_number":220,"context_line":"            return self.id_free.popleft()"},{"line_number":221,"context_line":"        # Allocate new one.  It must be divisible by 8."},{"line_number":222,"context_line":"        self.max_id +\u003d 8"},{"line_number":223,"context_line":"        return self.max_id"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def get_conj_id(self, sg_id, remote_sg_id, direction, ethertype):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_e455b651","line":222,"updated":"2017-11-01 08:11:26.000000000","message":"How did you get this value to be 8?","commit_id":"c445824ae65324a9579f5f8395ab86f75b46d1b6"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"2c9d20125d6f745d7829d022be6a98d533e2f51f","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        if self.id_free:"},{"line_number":220,"context_line":"            return self.id_free.popleft()"},{"line_number":221,"context_line":"        # Allocate new one.  It must be divisible by 8."},{"line_number":222,"context_line":"        self.max_id +\u003d 8"},{"line_number":223,"context_line":"        return self.max_id"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def get_conj_id(self, sg_id, remote_sg_id, direction, ethertype):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_1f35bb46","line":222,"in_reply_to":"3f4b6375_e455b651","updated":"2017-11-01 08:54:35.000000000","message":"Does the comment on L228 make sense to you?","commit_id":"c445824ae65324a9579f5f8395ab86f75b46d1b6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a7b99edf8c53b8688b21ae212416c3b7ac0c8260","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # If there is any freed ID, use one."},{"line_number":219,"context_line":"        if self.id_free:"},{"line_number":220,"context_line":"            return self.id_free.popleft()"},{"line_number":221,"context_line":"        # Allocate new one.  It must be divisible by 8."},{"line_number":222,"context_line":"        self.max_id +\u003d 8"},{"line_number":223,"context_line":"        return self.max_id"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1f485f77_ec905a51","line":221,"updated":"2017-11-09 14:40:23.000000000","message":"Sorry but can you explain the reason for division by 8 , and not by any other even number like 14, 16,6 etc?","commit_id":"51e7ee201305d5c3b4d5b8baf406e92044ec24ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1d0bfce67ff04c216ba1bf4dfceacbc38745e936","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # If there is any freed ID, use one."},{"line_number":219,"context_line":"        if self.id_free:"},{"line_number":220,"context_line":"            return self.id_free.popleft()"},{"line_number":221,"context_line":"        # Allocate new one.  It must be divisible by 8."},{"line_number":222,"context_line":"        self.max_id +\u003d 8"},{"line_number":223,"context_line":"        return self.max_id"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1f485f77_1b708172","line":221,"in_reply_to":"1f485f77_b87853f8","updated":"2017-11-10 04:05:50.000000000","message":"Got it :)\nMakes much clearer sense now","commit_id":"51e7ee201305d5c3b4d5b8baf406e92044ec24ed"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"12df03423ff5b5dbd09b92ecae7fa7d84f7f2ec3","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # If there is any freed ID, use one."},{"line_number":219,"context_line":"        if self.id_free:"},{"line_number":220,"context_line":"            return self.id_free.popleft()"},{"line_number":221,"context_line":"        # Allocate new one.  It must be divisible by 8."},{"line_number":222,"context_line":"        self.max_id +\u003d 8"},{"line_number":223,"context_line":"        return self.max_id"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1f485f77_b87853f8","line":221,"in_reply_to":"1f485f77_ec905a51","updated":"2017-11-10 03:57:38.000000000","message":"Please see the next function.","commit_id":"51e7ee201305d5c3b4d5b8baf406e92044ec24ed"}],"neutron/agent/linux/openvswitch_firewall/rules.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"986379cd51506cc9f142875c5a4b1db7bba402fd","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        return 0"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    if protocol in [n_consts.PROTO_NUM_ICMP, n_consts.PROTO_NUM_IPV6_ICMP]:"},{"line_number":161,"context_line":"        if \u0027port_range_min\u0027 not in rule:"},{"line_number":162,"context_line":"            return 1"},{"line_number":163,"context_line":"        elif \u0027port_range_max\u0027 not in rule:"},{"line_number":164,"context_line":"            return 2"},{"line_number":165,"context_line":"    return 3"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_6a7705d6","line":164,"range":{"start_line":161,"start_character":8,"end_line":164,"end_character":20},"updated":"2017-09-08 08:42:58.000000000","message":"I\u0027m trying to figure out why we need to have different priorities for icmp depending on if icmp has type/code.\n\nIf you don\u0027t mind, that will be very helpful!","commit_id":"f64ffa5302ba5e6be2ca04fc301e931feffb7a32"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"28b0fd8f6b96d79498e5efbb36d1f6ee6268c1ce","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        return 0"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    if protocol in [n_consts.PROTO_NUM_ICMP, n_consts.PROTO_NUM_IPV6_ICMP]:"},{"line_number":161,"context_line":"        if \u0027port_range_min\u0027 not in rule:"},{"line_number":162,"context_line":"            return 1"},{"line_number":163,"context_line":"        elif \u0027port_range_max\u0027 not in rule:"},{"line_number":164,"context_line":"            return 2"},{"line_number":165,"context_line":"    return 3"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_0102be3d","line":164,"range":{"start_line":161,"start_character":8,"end_line":164,"end_character":20},"in_reply_to":"7f287b81_6a7705d6","updated":"2017-09-15 15:26:17.000000000","message":"We have sorta:\n\nproirity\u003d70,icmp,icmp_type\u003d0,blah.. actions\u003dct(commit,foo-bar)\npriority\u003d70,icmp,icmp_type\u003d0,icmp_code\u003d0,blah.. actions\u003dct(commit,foo-bar)\n\ntoday.\n\nIt seems ovs executes either of those actions for an icmp_type\u003d0,icmp_code\u003d0 packet, but according to the OpenFlow spec, 2 matching flows at the same priority means an undefined behavior.\nUsing different priorities will save such cases.","commit_id":"f64ffa5302ba5e6be2ca04fc301e931feffb7a32"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a7b99edf8c53b8688b21ae212416c3b7ac0c8260","unresolved":false,"context_lines":[{"line_number":350,"context_line":"def create_conj_flows(port, conj_id, direction, ethertype):"},{"line_number":351,"context_line":"    \"\"\"Generate \"accept\" flows for a given conjunction ID.\"\"\""},{"line_number":352,"context_line":"    flow_template \u003d {"},{"line_number":353,"context_line":"        \u0027priority\u0027: 70 + (conj_id % 8 // 2),"},{"line_number":354,"context_line":"        \u0027conj_id\u0027: conj_id,"},{"line_number":355,"context_line":"        \u0027dl_type\u0027: ovsfw_consts.ethertype_to_dl_type_map[ethertype],"},{"line_number":356,"context_line":"        # This reg_port matching is for delete_all_port_flows."}],"source_content_type":"text/x-python","patch_set":14,"id":"1f485f77_2cb672db","line":353,"range":{"start_line":353,"start_character":21,"end_line":353,"end_character":44},"updated":"2017-11-09 14:40:23.000000000","message":"any reason to divide the remainder by 2 ?\nA comment would help here to understand the logic","commit_id":"51e7ee201305d5c3b4d5b8baf406e92044ec24ed"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"12df03423ff5b5dbd09b92ecae7fa7d84f7f2ec3","unresolved":false,"context_lines":[{"line_number":350,"context_line":"def create_conj_flows(port, conj_id, direction, ethertype):"},{"line_number":351,"context_line":"    \"\"\"Generate \"accept\" flows for a given conjunction ID.\"\"\""},{"line_number":352,"context_line":"    flow_template \u003d {"},{"line_number":353,"context_line":"        \u0027priority\u0027: 70 + (conj_id % 8 // 2),"},{"line_number":354,"context_line":"        \u0027conj_id\u0027: conj_id,"},{"line_number":355,"context_line":"        \u0027dl_type\u0027: ovsfw_consts.ethertype_to_dl_type_map[ethertype],"},{"line_number":356,"context_line":"        # This reg_port matching is for delete_all_port_flows."}],"source_content_type":"text/x-python","patch_set":14,"id":"1f485f77_7bcbf5a4","line":353,"range":{"start_line":353,"start_character":21,"end_line":353,"end_character":44},"in_reply_to":"1f485f77_2cb672db","updated":"2017-11-10 03:57:38.000000000","message":"Done","commit_id":"51e7ee201305d5c3b4d5b8baf406e92044ec24ed"}],"neutron/tests/unit/agent/linux/openvswitch_firewall/test_rules.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5af899c6b6fffc45792ed9fcd629bb750ae8e499","unresolved":false,"context_lines":[{"line_number":419,"context_line":"            self.assertEqual(range_max, result1[0][\u0027port_range_max\u0027])"},{"line_number":420,"context_line":"            self.assertEqual(conj_ids, set(result1[1]))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def test__assert_mergeable_rules(self):"},{"line_number":424,"context_line":"        self.assertRaises(RuntimeError,"},{"line_number":425,"context_line":"                          rules._assert_mergeable_rules,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_4af04668","line":422,"updated":"2017-08-23 21:33:55.000000000","message":"Well, you got a pep8 failure because of this line, even though you didn\u0027t touch it. I downloaded your patchset, removed the line and ran pep8 locally: pep8: commands succeeded. So I suggest removing this line","commit_id":"d4b2a93b889d3370c10f3db414090cf096129fc0"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"696f8aa9311fecb92373d7b3643c30cf6ac579f1","unresolved":false,"context_lines":[{"line_number":419,"context_line":"            self.assertEqual(range_max, result1[0][\u0027port_range_max\u0027])"},{"line_number":420,"context_line":"            self.assertEqual(conj_ids, set(result1[1]))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def test__assert_mergeable_rules(self):"},{"line_number":424,"context_line":"        self.assertRaises(RuntimeError,"},{"line_number":425,"context_line":"                          rules._assert_mergeable_rules,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_db0d2a38","line":422,"in_reply_to":"7f287b81_4af04668","updated":"2017-08-24 00:09:00.000000000","message":"It\u0027s due to https://review.openstack.org/#/c/492404\n\nWill fix in there.","commit_id":"d4b2a93b889d3370c10f3db414090cf096129fc0"}]}
