)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5baa7c2e9832a4fac1510433de7e0d50d25b999c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is no way to have dhcp agents not announce DNS servers"},{"line_number":10,"context_line":"for a subnet. The current behaviour when the dns_nameservers option is"},{"line_number":11,"context_line":"set to \u00270.0.0.0\u0027 is that each agent will only announce itself instead of"},{"line_number":12,"context_line":"announcing the list of all dhcp agents for that subnet, which seems not"},{"line_number":13,"context_line":"too useful. So we redefine the meaning of this option to instruct the"},{"line_number":14,"context_line":"dhcp agent to not announce any DNS server in that case."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_8549f460","line":11,"updated":"2017-08-29 19:28:23.000000000","message":"Is that correct?  By default the list of nameservers is [] in the subnet, which (I\u0027m guessing) results in dnsmasq inserting itself in the reply?","commit_id":"90f6bbbbb0b205abb6e626534a3e0892601f2566"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e13c979c9ececbade04700297d9074fadb362aab","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is no way to have dhcp agents not announce DNS servers"},{"line_number":10,"context_line":"for a subnet. The current behaviour when the dns_nameservers option is"},{"line_number":11,"context_line":"set to \u00270.0.0.0\u0027 is that each agent will only announce itself instead of"},{"line_number":12,"context_line":"announcing the list of all dhcp agents for that subnet, which seems not"},{"line_number":13,"context_line":"too useful. So we redefine the meaning of this option to instruct the"},{"line_number":14,"context_line":"dhcp agent to not announce any DNS server in that case."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_876c4ece","line":11,"in_reply_to":"7f287b81_8549f460","updated":"2017-08-30 05:17:58.000000000","message":"If there was indeed no nameserver specified, dnsmasq would insert only itself, but the agent code does something else, see my comment below.\n\nThe behaviour of dnsmasq when 0.0.0.0/:: is specified is implicitly mentioned here https://github.com/imp/dnsmasq/blob/master/dnsmasq.conf.example#L348, I also verified it locally.","commit_id":"90f6bbbbb0b205abb6e626534a3e0892601f2566"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5baa7c2e9832a4fac1510433de7e0d50d25b999c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"seem feasible."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I32d943360162c483ac1364100a21ab56b13517fb"},{"line_number":22,"context_line":"Closes-Bug: 1311040"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_c515bc41","line":22,"updated":"2017-08-29 19:28:23.000000000","message":"And Closes-Bug: 1692121","commit_id":"90f6bbbbb0b205abb6e626534a3e0892601f2566"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"206313f90eabe3828862d16c9815d0f1c9e0c37b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"seem feasible."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I32d943360162c483ac1364100a21ab56b13517fb"},{"line_number":22,"context_line":"Closes-Bug: 1311040"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_7da68711","line":22,"in_reply_to":"7f287b81_4762e6d9","updated":"2017-08-30 16:11:43.000000000","message":"That\u0027s fine, I\u0027ll take care of that and update the commit message.","commit_id":"90f6bbbbb0b205abb6e626534a3e0892601f2566"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e13c979c9ececbade04700297d9074fadb362aab","unresolved":false,"context_lines":[{"line_number":19,"context_line":"seem feasible."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I32d943360162c483ac1364100a21ab56b13517fb"},{"line_number":22,"context_line":"Closes-Bug: 1311040"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_4762e6d9","line":22,"in_reply_to":"7f287b81_c515bc41","updated":"2017-08-30 05:17:58.000000000","message":"I\u0027d rather mark that second bug as duplicate of the first one in LP, but up to you to decide.","commit_id":"90f6bbbbb0b205abb6e626534a3e0892601f2566"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"54e4b11975614f919d2525a714faabedd9b0e283","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is no way to have DHCP agents not announce DNS servers"},{"line_number":10,"context_line":"for a subnet. The current behaviour when the dns_nameservers option is"},{"line_number":11,"context_line":"set to \u00270.0.0.0\u0027 is that each agent will only announce itself instead of"},{"line_number":12,"context_line":"announcing the list of all dhcp agents for that subnet, which seems not"},{"line_number":13,"context_line":"too useful. So we redefine the meaning of this option to instruct the"},{"line_number":14,"context_line":"DHCP agent to not announce any DNS server in that case."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f2577a7_2212f4b2","line":11,"updated":"2017-09-08 20:27:51.000000000","message":"Ack","commit_id":"584b7561c162ec461e5c6a8dff5c012402cac5e0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"154c588bcb5d50df920c2ce42bf332bcb1f5ebbf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is no way to have DHCP agents not announce DNS servers"},{"line_number":10,"context_line":"for a subnet. The current behaviour when the dns_nameservers option is"},{"line_number":11,"context_line":"set to \u00270.0.0.0\u0027 is that each agent will only announce itself instead of"},{"line_number":12,"context_line":"announcing the list of all dhcp agents for that subnet, which seems not"},{"line_number":13,"context_line":"too useful. So we redefine the meaning of this option to instruct the"},{"line_number":14,"context_line":"DHCP agent to not announce any DNS server in that case."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f287b81_4c7fd4de","line":11,"updated":"2017-09-07 19:41:02.000000000","message":"Looking at the current logic, I don\u0027t see where \u00270.0.0.0\u0027 is handled as announcing itself. Is that something dnsmasq does automatically if 0.0.0.0 is passed in?","commit_id":"584b7561c162ec461e5c6a8dff5c012402cac5e0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9e17e3a69a6ff7b3c396c735ddd8b6f41d0b5848","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is no way to have DHCP agents not announce DNS servers"},{"line_number":10,"context_line":"for a subnet. The current behaviour when the dns_nameservers option is"},{"line_number":11,"context_line":"set to \u00270.0.0.0\u0027 is that each agent will only announce itself instead of"},{"line_number":12,"context_line":"announcing the list of all dhcp agents for that subnet, which seems not"},{"line_number":13,"context_line":"too useful. So we redefine the meaning of this option to instruct the"},{"line_number":14,"context_line":"DHCP agent to not announce any DNS server in that case."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f287b81_9fa4c04c","line":11,"in_reply_to":"7f287b81_4c7fd4de","updated":"2017-09-07 20:28:13.000000000","message":"Kevin - yes, if it\u0027s blank or 0.0.0.0 then dnsmasq sends it\u0027s local IP in the \u0027dns-server\u0027 block in the reply.  Since no one typically uses 0.0.0.0 it seemed like an Ok way to get this behavior - no \u0027dns-server\u0027 block at all.","commit_id":"584b7561c162ec461e5c6a8dff5c012402cac5e0"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e13c979c9ececbade04700297d9074fadb362aab","unresolved":false,"context_lines":[{"line_number":891,"context_line":"            else:"},{"line_number":892,"context_line":"                # use the dnsmasq ip as nameservers only if there is no"},{"line_number":893,"context_line":"                # dns-server submitted by the server"},{"line_number":894,"context_line":"                subnet_index_map[subnet.id] \u003d i"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"            if self.conf.dns_domain and subnet.ip_version \u003d\u003d 6:"},{"line_number":897,"context_line":"                options.append(\u0027tag:tag%s,option6:domain-search,%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_044f3c93","side":"PARENT","line":894,"updated":"2017-08-30 05:17:58.000000000","message":"This causes the list of dhcp agents for this subnet to be added as dns-servers options later in _generate_opts_per_port.","commit_id":"f311b42d28cdaaa25fab5f9dc4b76d0c294e31dc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5baa7c2e9832a4fac1510433de7e0d50d25b999c","unresolved":false,"context_lines":[{"line_number":883,"context_line":"                continue"},{"line_number":884,"context_line":"            if subnet.dns_nameservers:"},{"line_number":885,"context_line":"                if (subnet.ip_version \u003d\u003d 4 and"},{"line_number":886,"context_line":"                    subnet.dns_nameservers \u003d\u003d [u\u00270.0.0.0\u0027]):"},{"line_number":887,"context_line":"                    # Special case: Do not announce DNS servers"},{"line_number":888,"context_line":"                    options.append("},{"line_number":889,"context_line":"                        self._format_option("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_ea15274a","line":886,"range":{"start_line":886,"start_character":47,"end_line":886,"end_character":48},"updated":"2017-08-29 19:28:23.000000000","message":"Don\u0027t think you need the \u0027u\u0027 here.\n\nShould also check IPv6/\u0027::\u0027 to be consistent.","commit_id":"90f6bbbbb0b205abb6e626534a3e0892601f2566"}]}
