)]}'
{"neutron/db/agents_db.py":[{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                             agent_model.Agent.host \u003d\u003d host,"},{"line_number":157,"context_line":"                             agent_model.Agent.admin_state_up \u003d\u003d sql.true())"},{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            agent \u003d query.one()"},{"line_number":160,"context_line":"        except exc.NoResultFound:"},{"line_number":161,"context_line":"            LOG.debug(\u0027No enabled %(agent_type)s agent on host \u0027"},{"line_number":162,"context_line":"                      \u0027%(host)s\u0027, {\u0027agent_type\u0027: agent_type, \u0027host\u0027: host})"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_4f4cdb75","side":"PARENT","line":159,"range":{"start_line":159,"start_character":12,"end_line":159,"end_character":31},"updated":"2017-09-04 02:20:54.000000000","message":"In the original codes .one() requires that there is only one result in the result set; it is an error if the database returns 0 or 2 or more results and an exception will be raised.\n\nCan we do the same in OVO? Otherwise, we will be missing the error cases if multiple records match the filters.","commit_id":"3514f3e0d283e7b5b7e5851bfe24d03317971edd"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                             agent_model.Agent.host \u003d\u003d host,"},{"line_number":157,"context_line":"                             agent_model.Agent.admin_state_up \u003d\u003d sql.true())"},{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            agent \u003d query.one()"},{"line_number":160,"context_line":"        except exc.NoResultFound:"},{"line_number":161,"context_line":"            LOG.debug(\u0027No enabled %(agent_type)s agent on host \u0027"},{"line_number":162,"context_line":"                      \u0027%(host)s\u0027, {\u0027agent_type\u0027: agent_type, \u0027host\u0027: host})"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_c1d4094a","side":"PARENT","line":159,"range":{"start_line":159,"start_character":12,"end_line":159,"end_character":31},"in_reply_to":"7f287b81_4f4cdb75","updated":"2017-09-05 06:18:16.000000000","message":"Unfortunately, we haven\u0027t had any solution for doing the same in OVO.\nIf you have any suggestion, please feel free to let us know.","commit_id":"3514f3e0d283e7b5b7e5851bfe24d03317971edd"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        filters \u003d {\u0027agent_type\u0027: agent_type,"},{"line_number":144,"context_line":"                   \u0027host\u0027: host,"},{"line_number":145,"context_line":"                   \u0027admin_state_up\u0027: sql.true()}"},{"line_number":146,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if not agents:"},{"line_number":149,"context_line":"            LOG.debug(\u0027No enabled %(agent_type)s agent on host \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_143a6ae6","line":146,"range":{"start_line":146,"start_character":54,"end_line":146,"end_character":63},"updated":"2017-09-04 02:20:54.000000000","message":"I think we can use\n\nagent_type\u003dagent_type,\nhost\u003dhost,\nadmin_state_up\u003dtrue)\n\ndirectly.","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        filters \u003d {\u0027agent_type\u0027: agent_type,"},{"line_number":144,"context_line":"                   \u0027host\u0027: host,"},{"line_number":145,"context_line":"                   \u0027admin_state_up\u0027: sql.true()}"},{"line_number":146,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if not agents:"},{"line_number":149,"context_line":"            LOG.debug(\u0027No enabled %(agent_type)s agent on host \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_9c7d4a70","line":146,"range":{"start_line":146,"start_character":54,"end_line":146,"end_character":63},"in_reply_to":"7f287b81_143a6ae6","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        json_value \u003d None"},{"line_number":179,"context_line":"        try:"},{"line_number":180,"context_line":"            json_value \u003d getattr(agent_db, dict_name)"},{"line_number":181,"context_line":"            if not isinstance(json_value, dict):"},{"line_number":182,"context_line":"                conf \u003d jsonutils.loads(json_value)"},{"line_number":183,"context_line":"            else:"},{"line_number":184,"context_line":"                conf \u003d json_value"},{"line_number":185,"context_line":"        except Exception:"},{"line_number":186,"context_line":"            if json_value or not ignore_missing:"},{"line_number":187,"context_line":"                msg \u003d (\u0027Dictionary %(dict_name)s for agent %(agent_type)s \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_af3c5fbf","line":184,"range":{"start_line":181,"start_character":0,"end_line":184,"end_character":33},"updated":"2017-09-04 02:20:54.000000000","message":"I think after all agent_db is converted to agent_obj, we no longer need these checks, right? If so, please add a TODO to explain so that we can clean up later.","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        json_value \u003d None"},{"line_number":179,"context_line":"        try:"},{"line_number":180,"context_line":"            json_value \u003d getattr(agent_db, dict_name)"},{"line_number":181,"context_line":"            if not isinstance(json_value, dict):"},{"line_number":182,"context_line":"                conf \u003d jsonutils.loads(json_value)"},{"line_number":183,"context_line":"            else:"},{"line_number":184,"context_line":"                conf \u003d json_value"},{"line_number":185,"context_line":"        except Exception:"},{"line_number":186,"context_line":"            if json_value or not ignore_missing:"},{"line_number":187,"context_line":"                msg \u003d (\u0027Dictionary %(dict_name)s for agent %(agent_type)s \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_7c805e47","line":184,"range":{"start_line":181,"start_character":0,"end_line":184,"end_character":33},"in_reply_to":"7f287b81_af3c5fbf","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        agent \u003d self._get_agent(context, id)"},{"line_number":222,"context_line":"        registry.notify(resources.AGENT, events.BEFORE_DELETE, self,"},{"line_number":223,"context_line":"                        context\u003dcontext, agent\u003dagent)"},{"line_number":224,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":225,"context_line":"            agent.delete()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":228,"context_line":"    def update_agent(self, context, id, agent):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_4f75fb97","line":225,"range":{"start_line":224,"start_character":0,"end_line":225,"end_character":26},"updated":"2017-09-04 02:20:54.000000000","message":"Object manipulations have their own session, so we can safely remove Line 224.","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        agent \u003d self._get_agent(context, id)"},{"line_number":222,"context_line":"        registry.notify(resources.AGENT, events.BEFORE_DELETE, self,"},{"line_number":223,"context_line":"                        context\u003dcontext, agent\u003dagent)"},{"line_number":224,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":225,"context_line":"            agent.delete()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":228,"context_line":"    def update_agent(self, context, id, agent):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_5c97e291","line":225,"range":{"start_line":224,"start_character":0,"end_line":225,"end_character":26},"in_reply_to":"7f287b81_4f75fb97","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":237,"context_line":"    def get_agents_db(self, context, filters\u003dNone):"},{"line_number":238,"context_line":"        filters \u003d filters or dict()"},{"line_number":239,"context_line":"        return agent_obj.Agent.get_objects(context, **filters)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @db_api.retry_if_session_inactive()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_af657fe3","line":238,"range":{"start_line":238,"start_character":29,"end_line":238,"end_character":35},"updated":"2017-09-04 02:20:54.000000000","message":"{} ?","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":237,"context_line":"    def get_agents_db(self, context, filters\u003dNone):"},{"line_number":238,"context_line":"        filters \u003d filters or dict()"},{"line_number":239,"context_line":"        return agent_obj.Agent.get_objects(context, **filters)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @db_api.retry_if_session_inactive()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_3c92d6a0","line":238,"range":{"start_line":238,"start_character":29,"end_line":238,"end_character":35},"in_reply_to":"7f287b81_af657fe3","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":242,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":243,"context_line":"        filters \u003d filters or dict()"},{"line_number":244,"context_line":"        alive \u003d filters and filters.pop(\u0027alive\u0027, None)"},{"line_number":245,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":246,"context_line":"        if alive:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_8f62c3d7","line":243,"range":{"start_line":243,"start_character":29,"end_line":243,"end_character":35},"updated":"2017-09-04 02:20:54.000000000","message":"ditto","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":242,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":243,"context_line":"        filters \u003d filters or dict()"},{"line_number":244,"context_line":"        alive \u003d filters and filters.pop(\u0027alive\u0027, None)"},{"line_number":245,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":246,"context_line":"        if alive:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_1c915a9a","line":243,"range":{"start_line":243,"start_character":29,"end_line":243,"end_character":35},"in_reply_to":"7f287b81_8f62c3d7","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    def _get_agent_by_type_and_host(self, context, agent_type, host):"},{"line_number":274,"context_line":"        filters \u003d {\u0027agent_type\u0027: agent_type,"},{"line_number":275,"context_line":"                   \u0027host\u0027: host}"},{"line_number":276,"context_line":"        agent_dbs \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":277,"context_line":"        if not agent_dbs:"},{"line_number":278,"context_line":"            raise ext_agent.AgentNotFoundByTypeHost(agent_type\u003dagent_type,"},{"line_number":279,"context_line":"                                                    host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_8fb7633b","line":276,"range":{"start_line":276,"start_character":8,"end_line":276,"end_character":17},"updated":"2017-09-04 02:20:54.000000000","message":"Shouldn\u0027t this be agent_objs now?","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    def _get_agent_by_type_and_host(self, context, agent_type, host):"},{"line_number":274,"context_line":"        filters \u003d {\u0027agent_type\u0027: agent_type,"},{"line_number":275,"context_line":"                   \u0027host\u0027: host}"},{"line_number":276,"context_line":"        agent_dbs \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":277,"context_line":"        if not agent_dbs:"},{"line_number":278,"context_line":"            raise ext_agent.AgentNotFoundByTypeHost(agent_type\u003dagent_type,"},{"line_number":279,"context_line":"                                                    host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_afaa1fcf","line":276,"range":{"start_line":276,"start_character":57,"end_line":276,"end_character":66},"updated":"2017-09-04 02:20:54.000000000","message":"ditto Line 146","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    def _get_agent_by_type_and_host(self, context, agent_type, host):"},{"line_number":274,"context_line":"        filters \u003d {\u0027agent_type\u0027: agent_type,"},{"line_number":275,"context_line":"                   \u0027host\u0027: host}"},{"line_number":276,"context_line":"        agent_dbs \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":277,"context_line":"        if not agent_dbs:"},{"line_number":278,"context_line":"            raise ext_agent.AgentNotFoundByTypeHost(agent_type\u003dagent_type,"},{"line_number":279,"context_line":"                                                    host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_fc8b2e65","line":276,"range":{"start_line":276,"start_character":8,"end_line":276,"end_character":17},"in_reply_to":"7f287b81_8fb7633b","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    def _get_agent_by_type_and_host(self, context, agent_type, host):"},{"line_number":274,"context_line":"        filters \u003d {\u0027agent_type\u0027: agent_type,"},{"line_number":275,"context_line":"                   \u0027host\u0027: host}"},{"line_number":276,"context_line":"        agent_dbs \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":277,"context_line":"        if not agent_dbs:"},{"line_number":278,"context_line":"            raise ext_agent.AgentNotFoundByTypeHost(agent_type\u003dagent_type,"},{"line_number":279,"context_line":"                                                    host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_dce87217","line":276,"range":{"start_line":276,"start_character":57,"end_line":276,"end_character":66},"in_reply_to":"7f287b81_afaa1fcf","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        if len(agent_dbs) \u003e 1:"},{"line_number":281,"context_line":"            raise ext_agent.MultipleAgentFoundByTypeHost("},{"line_number":282,"context_line":"                agent_type\u003dagent_type, host\u003dhost)"},{"line_number":283,"context_line":"        return agent_dbs.pop()"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":286,"context_line":"    def get_agent(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_4f83bb57","line":283,"range":{"start_line":283,"start_character":15,"end_line":283,"end_character":30},"updated":"2017-09-04 02:20:54.000000000","message":"This may be personal preference, but I think agent_objs[0] would be better.","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        if len(agent_dbs) \u003e 1:"},{"line_number":281,"context_line":"            raise ext_agent.MultipleAgentFoundByTypeHost("},{"line_number":282,"context_line":"                agent_type\u003dagent_type, host\u003dhost)"},{"line_number":283,"context_line":"        return agent_dbs.pop()"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":286,"context_line":"    def get_agent(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_bceb6610","line":283,"range":{"start_line":283,"start_character":15,"end_line":283,"end_character":30},"in_reply_to":"7f287b81_4f83bb57","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"a53d55532641c427626f7d1fbcaeeb7c88ad8022","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        if utils.is_agent_down(agents[0].heartbeat_timestamp):"},{"line_number":155,"context_line":"            LOG.warning(\u0027%(agent_type)s agent %(agent_id)s is not active\u0027,"},{"line_number":156,"context_line":"                        {\u0027agent_type\u0027: agent_type, \u0027agent_id\u0027: agents[0].id})"},{"line_number":157,"context_line":"        return agents.pop()"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @debtcollector.removals.remove("},{"line_number":160,"context_line":"        message\u003d\"This will be removed in the future. \""}],"source_content_type":"text/x-python","patch_set":10,"id":"7f287b81_1c483aca","line":157,"range":{"start_line":157,"start_character":22,"end_line":157,"end_character":25},"updated":"2017-09-05 06:41:07.000000000","message":"agents[0]?","commit_id":"fd1de3a6479e14ebeedae17b1d6e4849c617d717"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"592f728ca9606e78397c50d9ddcf5d52ed44c01c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        if utils.is_agent_down(agents[0].heartbeat_timestamp):"},{"line_number":155,"context_line":"            LOG.warning(\u0027%(agent_type)s agent %(agent_id)s is not active\u0027,"},{"line_number":156,"context_line":"                        {\u0027agent_type\u0027: agent_type, \u0027agent_id\u0027: agents[0].id})"},{"line_number":157,"context_line":"        return agents.pop()"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @debtcollector.removals.remove("},{"line_number":160,"context_line":"        message\u003d\"This will be removed in the future. \""}],"source_content_type":"text/x-python","patch_set":10,"id":"7f287b81_bcc006e2","line":157,"range":{"start_line":157,"start_character":22,"end_line":157,"end_character":25},"in_reply_to":"7f287b81_1c483aca","updated":"2017-09-05 06:53:26.000000000","message":"Done","commit_id":"fd1de3a6479e14ebeedae17b1d6e4849c617d717"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e27e54b1078e82a6290eec52cd96496856d6eb62","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":228,"context_line":"    def get_agents_db(self, context, filters\u003dNone):"},{"line_number":229,"context_line":"        filters \u003d filters or {}"},{"line_number":230,"context_line":"        return agent_obj.Agent.get_objects(context, **filters)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":233,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_c5b66d8b","line":230,"updated":"2017-10-04 20:56:44.000000000","message":"should this be changed?\nDon\u0027t we need some kind of backward compatibility e.g. for some external plugins which can expect SQLA objects here?","commit_id":"c64f3d3dfff6797b4e35366dbe56d7342baddaf9"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"dddeff0e246897eae8431655d41f6f3e33889c19","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":228,"context_line":"    def get_agents_db(self, context, filters\u003dNone):"},{"line_number":229,"context_line":"        filters \u003d filters or {}"},{"line_number":230,"context_line":"        return agent_obj.Agent.get_objects(context, **filters)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":233,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_0caa6984","line":230,"in_reply_to":"7f515b1d_c5b66d8b","updated":"2017-10-05 02:46:31.000000000","message":"Could you please elaborate more on this?","commit_id":"c64f3d3dfff6797b4e35366dbe56d7342baddaf9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e27e54b1078e82a6290eec52cd96496856d6eb62","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                res[\u0027started_at\u0027] \u003d current_time"},{"line_number":350,"context_line":"                res[\u0027heartbeat_timestamp\u0027] \u003d current_time"},{"line_number":351,"context_line":"                res[\u0027admin_state_up\u0027] \u003d cfg.CONF.enable_new_agents"},{"line_number":352,"context_line":"                agent_db \u003d agent_obj.Agent(context\u003dcontext, **res)"},{"line_number":353,"context_line":"                greenthread.sleep(0)"},{"line_number":354,"context_line":"                agent_db.create()"},{"line_number":355,"context_line":"                event_type \u003d events.AFTER_CREATE"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_e566092a","line":352,"updated":"2017-10-04 20:56:44.000000000","message":"is it still \"agent_db\"? maybe it should be called agent_obj now?","commit_id":"c64f3d3dfff6797b4e35366dbe56d7342baddaf9"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"dddeff0e246897eae8431655d41f6f3e33889c19","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                res[\u0027started_at\u0027] \u003d current_time"},{"line_number":350,"context_line":"                res[\u0027heartbeat_timestamp\u0027] \u003d current_time"},{"line_number":351,"context_line":"                res[\u0027admin_state_up\u0027] \u003d cfg.CONF.enable_new_agents"},{"line_number":352,"context_line":"                agent_db \u003d agent_obj.Agent(context\u003dcontext, **res)"},{"line_number":353,"context_line":"                greenthread.sleep(0)"},{"line_number":354,"context_line":"                agent_db.create()"},{"line_number":355,"context_line":"                event_type \u003d events.AFTER_CREATE"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_2c09a5dc","line":352,"in_reply_to":"7f515b1d_e566092a","updated":"2017-10-05 02:46:31.000000000","message":"Done","commit_id":"c64f3d3dfff6797b4e35366dbe56d7342baddaf9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                             agent_model.Agent.host \u003d\u003d host,"},{"line_number":156,"context_line":"                             agent_model.Agent.admin_state_up \u003d\u003d sql.true())"},{"line_number":157,"context_line":"        try:"},{"line_number":158,"context_line":"            agent \u003d query.one()"},{"line_number":159,"context_line":"        except exc.NoResultFound:"},{"line_number":160,"context_line":"            LOG.debug(\u0027No enabled %(agent_type)s agent on host \u0027"},{"line_number":161,"context_line":"                      \u0027%(host)s\u0027, {\u0027agent_type\u0027: agent_type, \u0027host\u0027: host})"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_d007261d","side":"PARENT","line":158,"updated":"2017-10-05 20:22:49.000000000","message":"(no action required) this seems like a bug because there may be other agents that we just ignore. Why does the code path depend on the order of records returned by db driver?..","commit_id":"fc73306daaebd595c8c488e52c0f2046bd5b9387"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":82,"context_line":"        result \u003d {}"},{"line_number":83,"context_line":"        agents \u003d agent_obj.Agent.get_agents_group_by_zones(context, filters)"},{"line_number":84,"context_line":"        for agent in agents:"},{"line_number":85,"context_line":"            if not agent.availability_zone:"},{"line_number":86,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_d08e0631","line":83,"range":{"start_line":83,"start_character":44,"end_line":83,"end_character":49},"updated":"2017-10-05 20:22:49.000000000","message":"grouped?","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":82,"context_line":"        result \u003d {}"},{"line_number":83,"context_line":"        agents \u003d agent_obj.Agent.get_agents_group_by_zones(context, filters)"},{"line_number":84,"context_line":"        for agent in agents:"},{"line_number":85,"context_line":"            if not agent.availability_zone:"},{"line_number":86,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_2ba06bf4","line":83,"range":{"start_line":83,"start_character":44,"end_line":83,"end_character":49},"in_reply_to":"7f515b1d_d08e0631","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        result \u003d {}"},{"line_number":83,"context_line":"        agents \u003d agent_obj.Agent.get_agents_group_by_zones(context, filters)"},{"line_number":84,"context_line":"        for agent in agents:"},{"line_number":85,"context_line":"            if not agent.availability_zone:"},{"line_number":86,"context_line":"                continue"},{"line_number":87,"context_line":"            if agent.agent_type \u003d\u003d constants.AGENT_TYPE_DHCP:"},{"line_number":88,"context_line":"                resource \u003d \u0027network\u0027"},{"line_number":89,"context_line":"            elif agent.agent_type \u003d\u003d constants.AGENT_TYPE_L3:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_d0e046fb","line":86,"range":{"start_line":85,"start_character":12,"end_line":86,"end_character":24},"updated":"2017-10-05 20:22:49.000000000","message":"(no action required) it\u0027s weird, why haven\u0027t we included it in the query by passing \u0027availability_zone\u0027: [None, \u0027\u0027] as a filter?","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            return"},{"line_number":122,"context_line":"        agents \u003d agent_obj.Agent.get_agents_by_availability_zone("},{"line_number":123,"context_line":"            context, agent_type, availability_zones)"},{"line_number":124,"context_line":"        azs \u003d [item[0] for item in agents]"},{"line_number":125,"context_line":"        diff \u003d set(availability_zones) - set(azs)"},{"line_number":126,"context_line":"        if diff:"},{"line_number":127,"context_line":"            raise az_ext.AvailabilityZoneNotFound(availability_zone\u003ddiff.pop())"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_b0ab8a73","line":124,"range":{"start_line":124,"start_character":15,"end_line":124,"end_character":22},"updated":"2017-10-05 20:22:49.000000000","message":"Agent[0]? What does it even mean? I think your result type for get_agents_by_availability_zone is a bit twisted. Can\u0027t we make it return availability zone strings?..","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def get_enabled_agent_on_host(self, context, agent_type, host):"},{"line_number":141,"context_line":"        \"\"\"Return agent of agent_type for the specified host.\"\"\""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context,"},{"line_number":144,"context_line":"                                             agent_type\u003dagent_type,"},{"line_number":145,"context_line":"                                             host\u003dhost,"},{"line_number":146,"context_line":"                                             admin_state_up\u003dsql.true())"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_704bd286","line":143,"updated":"2017-10-05 20:22:49.000000000","message":"the original code was limiting the result to one record. I think we should do the same with a Pager here.","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def get_enabled_agent_on_host(self, context, agent_type, host):"},{"line_number":141,"context_line":"        \"\"\"Return agent of agent_type for the specified host.\"\"\""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context,"},{"line_number":144,"context_line":"                                             agent_type\u003dagent_type,"},{"line_number":145,"context_line":"                                             host\u003dhost,"},{"line_number":146,"context_line":"                                             admin_state_up\u003dsql.true())"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_4b84c75e","line":143,"in_reply_to":"7f515b1d_704bd286","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context,"},{"line_number":144,"context_line":"                                             agent_type\u003dagent_type,"},{"line_number":145,"context_line":"                                             host\u003dhost,"},{"line_number":146,"context_line":"                                             admin_state_up\u003dsql.true())"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if not agents:"},{"line_number":149,"context_line":"            LOG.debug(\u0027No enabled %(agent_type)s agent on host \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_f07582cd","line":146,"range":{"start_line":146,"start_character":60,"end_line":146,"end_character":70},"updated":"2017-10-05 20:22:49.000000000","message":"\u003d\u003e True","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context,"},{"line_number":144,"context_line":"                                             agent_type\u003dagent_type,"},{"line_number":145,"context_line":"                                             host\u003dhost,"},{"line_number":146,"context_line":"                                             admin_state_up\u003dsql.true())"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if not agents:"},{"line_number":149,"context_line":"            LOG.debug(\u0027No enabled %(agent_type)s agent on host \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_0b7ecf6a","line":146,"range":{"start_line":146,"start_character":60,"end_line":146,"end_character":70},"in_reply_to":"7f515b1d_f07582cd","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                      \u0027%(host)s\u0027, {\u0027agent_type\u0027: agent_type, \u0027host\u0027: host})"},{"line_number":151,"context_line":"            return"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if utils.is_agent_down(agents[0].heartbeat_timestamp):"},{"line_number":154,"context_line":"            LOG.warning(\u0027%(agent_type)s agent %(agent_id)s is not active\u0027,"},{"line_number":155,"context_line":"                        {\u0027agent_type\u0027: agent_type, \u0027agent_id\u0027: agents[0].id})"},{"line_number":156,"context_line":"        return agents[0]"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_103dbedc","line":153,"range":{"start_line":153,"start_character":31,"end_line":153,"end_character":40},"updated":"2017-10-05 20:22:49.000000000","message":"nit: instead of doing agents[0] in three places, just calculate it once:\n\nagent \u003d agents[0]","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                      \u0027%(host)s\u0027, {\u0027agent_type\u0027: agent_type, \u0027host\u0027: host})"},{"line_number":151,"context_line":"            return"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        if utils.is_agent_down(agents[0].heartbeat_timestamp):"},{"line_number":154,"context_line":"            LOG.warning(\u0027%(agent_type)s agent %(agent_id)s is not active\u0027,"},{"line_number":155,"context_line":"                        {\u0027agent_type\u0027: agent_type, \u0027agent_id\u0027: agents[0].id})"},{"line_number":156,"context_line":"        return agents[0]"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_eb82534f","line":153,"range":{"start_line":153,"start_character":31,"end_line":153,"end_character":40},"in_reply_to":"7f515b1d_103dbedc","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        json_value \u003d None"},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            json_value \u003d getattr(agent_db, dict_name)"},{"line_number":171,"context_line":"            # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":172,"context_line":"            #               we no longer need these checks"},{"line_number":173,"context_line":"            if not isinstance(json_value, dict):"},{"line_number":174,"context_line":"                conf \u003d jsonutils.loads(json_value)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_6b752398","line":171,"updated":"2017-10-05 20:22:49.000000000","message":"what breaks? I am not sure I see a place where _get_dict would be called with a db model and not an OVO object. What am I missing?","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        json_value \u003d None"},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            json_value \u003d getattr(agent_db, dict_name)"},{"line_number":171,"context_line":"            # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":172,"context_line":"            #               we no longer need these checks"},{"line_number":173,"context_line":"            if not isinstance(json_value, dict):"},{"line_number":174,"context_line":"                conf \u003d jsonutils.loads(json_value)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_6b8e6379","line":171,"in_reply_to":"7f515b1d_6b752398","updated":"2017-10-11 08:52:58.000000000","message":"The explanation has been added.","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            res[\u0027load\u0027] \u003d self._get_agent_load(agent_state)"},{"line_number":325,"context_line":"            current_time \u003d timeutils.utcnow()"},{"line_number":326,"context_line":"            try:"},{"line_number":327,"context_line":"                agent_db \u003d self._get_agent_by_type_and_host("},{"line_number":328,"context_line":"                    context, agent_state[\u0027agent_type\u0027], agent_state[\u0027host\u0027])"},{"line_number":329,"context_line":"                if not agent_db.is_active:"},{"line_number":330,"context_line":"                    status \u003d n_const.AGENT_REVIVED"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_ab531be2","line":327,"range":{"start_line":327,"start_character":16,"end_line":327,"end_character":25},"updated":"2017-10-05 20:22:49.000000000","message":"rename the variable into \u0027agent_obj\u0027 or \u0027agent\u0027 because it\u0027s no longer a db model","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            res[\u0027load\u0027] \u003d self._get_agent_load(agent_state)"},{"line_number":325,"context_line":"            current_time \u003d timeutils.utcnow()"},{"line_number":326,"context_line":"            try:"},{"line_number":327,"context_line":"                agent_db \u003d self._get_agent_by_type_and_host("},{"line_number":328,"context_line":"                    context, agent_state[\u0027agent_type\u0027], agent_state[\u0027host\u0027])"},{"line_number":329,"context_line":"                if not agent_db.is_active:"},{"line_number":330,"context_line":"                    status \u003d n_const.AGENT_REVIVED"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_2bee2b22","line":327,"range":{"start_line":327,"start_character":16,"end_line":327,"end_character":25},"in_reply_to":"7f515b1d_ab531be2","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                res[\u0027started_at\u0027] \u003d current_time"},{"line_number":350,"context_line":"                res[\u0027heartbeat_timestamp\u0027] \u003d current_time"},{"line_number":351,"context_line":"                res[\u0027admin_state_up\u0027] \u003d cfg.CONF.enable_new_agents"},{"line_number":352,"context_line":"                agent_objs \u003d agent_obj.Agent(context\u003dcontext, **res)"},{"line_number":353,"context_line":"                greenthread.sleep(0)"},{"line_number":354,"context_line":"                agent_objs.create()"},{"line_number":355,"context_line":"                event_type \u003d events.AFTER_CREATE"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_cb6d379a","line":352,"range":{"start_line":352,"start_character":23,"end_line":352,"end_character":26},"updated":"2017-10-05 20:22:49.000000000","message":"why objs? it\u0027s a single object, should be \u0027agent_obj\u0027 or just \u0027agent\u0027","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                res[\u0027started_at\u0027] \u003d current_time"},{"line_number":350,"context_line":"                res[\u0027heartbeat_timestamp\u0027] \u003d current_time"},{"line_number":351,"context_line":"                res[\u0027admin_state_up\u0027] \u003d cfg.CONF.enable_new_agents"},{"line_number":352,"context_line":"                agent_objs \u003d agent_obj.Agent(context\u003dcontext, **res)"},{"line_number":353,"context_line":"                greenthread.sleep(0)"},{"line_number":354,"context_line":"                agent_objs.create()"},{"line_number":355,"context_line":"                event_type \u003d events.AFTER_CREATE"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_0bf36f0c","line":352,"range":{"start_line":352,"start_character":23,"end_line":352,"end_character":26},"in_reply_to":"7f515b1d_cb6d379a","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"2e0970a4f7e54e986d75ea722cc861f1c1c84257","unresolved":false,"context_lines":[{"line_number":75,"context_line":"DOWNTIME_VERSIONS_RATIO \u003d 2"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def get_availability_zones_by_agent_type(context, agent_type,"},{"line_number":79,"context_line":"                                         availability_zones):"},{"line_number":80,"context_line":"    return agent_obj.Agent._get_availability_zones_by_agent_type("},{"line_number":81,"context_line":"        context, agent_type\u003dagent_type, availability_zones\u003davailability_zones)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class AgentAvailabilityZoneMixin(az_ext.AvailabilityZonePluginBase):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_e445c616","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":78},"updated":"2017-10-12 07:15:49.000000000","message":"why do we need to move this method out of class?","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"f98e16ba417076def5568f8cb2d48d263f780c9b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"DOWNTIME_VERSIONS_RATIO \u003d 2"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def get_availability_zones_by_agent_type(context, agent_type,"},{"line_number":79,"context_line":"                                         availability_zones):"},{"line_number":80,"context_line":"    return agent_obj.Agent._get_availability_zones_by_agent_type("},{"line_number":81,"context_line":"        context, agent_type\u003dagent_type, availability_zones\u003davailability_zones)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class AgentAvailabilityZoneMixin(az_ext.AvailabilityZonePluginBase):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_96903145","line":81,"range":{"start_line":78,"start_character":0,"end_line":81,"end_character":78},"in_reply_to":"5f4e5783_e445c616","updated":"2017-10-16 09:48:47.000000000","message":"This is based on suggestion from Ihar:\nhttps://review.openstack.org/#/c/495810/16/neutron/objects/agent.py@132","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e88e80f0680472b0a85c1ad84a96db3d86acd2f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            agent_type \u003d constants.AGENT_TYPE_L3"},{"line_number":126,"context_line":"        else:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":"        agents \u003d agent_obj.Agent.get_availability_zones_by_agent_type("},{"line_number":129,"context_line":"            context, agent_type, availability_zones)"},{"line_number":130,"context_line":"        azs \u003d [item[0] for item in agents]"},{"line_number":131,"context_line":"        diff \u003d set(availability_zones) - set(azs)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_2184feb0","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":14},"updated":"2017-10-11 17:52:28.000000000","message":"the variable suggests it\u0027s agents, but the method name says it\u0027s zones.","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"f98e16ba417076def5568f8cb2d48d263f780c9b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            agent_type \u003d constants.AGENT_TYPE_L3"},{"line_number":126,"context_line":"        else:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":"        agents \u003d agent_obj.Agent.get_availability_zones_by_agent_type("},{"line_number":129,"context_line":"            context, agent_type, availability_zones)"},{"line_number":130,"context_line":"        azs \u003d [item[0] for item in agents]"},{"line_number":131,"context_line":"        diff \u003d set(availability_zones) - set(azs)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_16a441a5","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":14},"in_reply_to":"5f4e5783_2184feb0","updated":"2017-10-16 09:48:47.000000000","message":"Thanks, I\u0027ve changed it to \"zones\"","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"2e0970a4f7e54e986d75ea722cc861f1c1c84257","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":"        agents \u003d agent_obj.Agent.get_availability_zones_by_agent_type("},{"line_number":129,"context_line":"            context, agent_type, availability_zones)"},{"line_number":130,"context_line":"        azs \u003d [item[0] for item in agents]"},{"line_number":131,"context_line":"        diff \u003d set(availability_zones) - set(azs)"},{"line_number":132,"context_line":"        if diff:"},{"line_number":133,"context_line":"            raise az_ext.AvailabilityZoneNotFound(availability_zone\u003ddiff.pop())"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_846052a7","line":130,"range":{"start_line":130,"start_character":15,"end_line":130,"end_character":22},"updated":"2017-10-12 07:15:49.000000000","message":"I do not understand why we have [0] here. Shouldn\u0027t \u0027item\u0027 be an agent OVO object?","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"f98e16ba417076def5568f8cb2d48d263f780c9b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":"        agents \u003d agent_obj.Agent.get_availability_zones_by_agent_type("},{"line_number":129,"context_line":"            context, agent_type, availability_zones)"},{"line_number":130,"context_line":"        azs \u003d [item[0] for item in agents]"},{"line_number":131,"context_line":"        diff \u003d set(availability_zones) - set(azs)"},{"line_number":132,"context_line":"        if diff:"},{"line_number":133,"context_line":"            raise az_ext.AvailabilityZoneNotFound(availability_zone\u003ddiff.pop())"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_36e97db6","line":130,"range":{"start_line":130,"start_character":15,"end_line":130,"end_character":22},"in_reply_to":"5f4e5783_846052a7","updated":"2017-10-16 09:48:47.000000000","message":"Sorry for this confusion, I\u0027ve just updated to \"zones\"","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"2e0970a4f7e54e986d75ea722cc861f1c1c84257","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        pager \u003d base.Pager(limit\u003d1)"},{"line_number":150,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context,"},{"line_number":151,"context_line":"                                             _pager\u003dpager,"},{"line_number":152,"context_line":"                                             agent_type\u003dagent_type,"},{"line_number":153,"context_line":"                                             host\u003dhost,"},{"line_number":154,"context_line":"                                             admin_state_up\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_818a8418","line":151,"range":{"start_line":151,"start_character":52,"end_line":151,"end_character":57},"updated":"2017-10-12 07:15:49.000000000","message":"We can use \n\nbase.Pager(limit\u003d1)\n\nhere to save line 149.","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"f98e16ba417076def5568f8cb2d48d263f780c9b","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        pager \u003d base.Pager(limit\u003d1)"},{"line_number":150,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context,"},{"line_number":151,"context_line":"                                             _pager\u003dpager,"},{"line_number":152,"context_line":"                                             agent_type\u003dagent_type,"},{"line_number":153,"context_line":"                                             host\u003dhost,"},{"line_number":154,"context_line":"                                             admin_state_up\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_d6d7c9ed","line":151,"range":{"start_line":151,"start_character":52,"end_line":151,"end_character":57},"in_reply_to":"5f4e5783_818a8418","updated":"2017-10-16 09:48:47.000000000","message":"Done","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e88e80f0680472b0a85c1ad84a96db3d86acd2f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":181,"context_line":"            #               we no longer need this."},{"line_number":182,"context_line":"            #               Without this check, some unit tests will fail"},{"line_number":183,"context_line":"            #               because some of json_values are dict already"},{"line_number":184,"context_line":"            if not isinstance(json_value, dict):"},{"line_number":185,"context_line":"                conf \u003d jsonutils.loads(json_value)"},{"line_number":186,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_a166ae28","line":183,"updated":"2017-10-11 17:52:28.000000000","message":"do you have a list of tests that fail? I would like to try them out locally to see if we can get rid of the TODO without much effort.","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"c9fe64a5abd7314146e28062f19aec3d3587447c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":181,"context_line":"            #               we no longer need this."},{"line_number":182,"context_line":"            #               Without this check, some unit tests will fail"},{"line_number":183,"context_line":"            #               because some of json_values are dict already"},{"line_number":184,"context_line":"            if not isinstance(json_value, dict):"},{"line_number":185,"context_line":"                conf \u003d jsonutils.loads(json_value)"},{"line_number":186,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_ae42b4a9","line":183,"in_reply_to":"3f4b6375_3532935f","updated":"2017-10-25 04:19:40.000000000","message":"Hi Ihar, just another quick update.\nPatch set 22 has been able to pass all the tests.\nIn this patch, if below check is not included, the amount of failed tests is enormous:\n- Unit tests failed: 45\n- Functional tests failed: 434","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d40da712697fd2f82da8c90986ef37d0e791c23f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":181,"context_line":"            #               we no longer need this."},{"line_number":182,"context_line":"            #               Without this check, some unit tests will fail"},{"line_number":183,"context_line":"            #               because some of json_values are dict already"},{"line_number":184,"context_line":"            if not isinstance(json_value, dict):"},{"line_number":185,"context_line":"                conf \u003d jsonutils.loads(json_value)"},{"line_number":186,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_f8f6d9d8","line":183,"in_reply_to":"3f4b6375_ae42b4a9","updated":"2017-10-27 18:00:09.000000000","message":"OK I see that you need it because get_l3_agents is returning models. let\u0027s merge it as is and revisit later then.","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"eca93df9eedcf7ed7622289d8e7f0345ad83cacd","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":181,"context_line":"            #               we no longer need this."},{"line_number":182,"context_line":"            #               Without this check, some unit tests will fail"},{"line_number":183,"context_line":"            #               because some of json_values are dict already"},{"line_number":184,"context_line":"            if not isinstance(json_value, dict):"},{"line_number":185,"context_line":"                conf \u003d jsonutils.loads(json_value)"},{"line_number":186,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f4b6375_3532935f","line":183,"in_reply_to":"5f4e5783_16fb2179","updated":"2017-10-25 01:40:53.000000000","message":"Hi Ihar, I would like to update the list of tests that fail.\nUnit Tests (failed 43): http://paste.openstack.org/show/624540/\nFunctional Tests (failed 26): http://paste.openstack.org/show/624539/","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"f98e16ba417076def5568f8cb2d48d263f780c9b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":181,"context_line":"            #               we no longer need this."},{"line_number":182,"context_line":"            #               Without this check, some unit tests will fail"},{"line_number":183,"context_line":"            #               because some of json_values are dict already"},{"line_number":184,"context_line":"            if not isinstance(json_value, dict):"},{"line_number":185,"context_line":"                conf \u003d jsonutils.loads(json_value)"},{"line_number":186,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_16fb2179","line":183,"in_reply_to":"5f4e5783_a166ae28","updated":"2017-10-16 09:48:47.000000000","message":"Thanks for your help.\nHere\u0027s the list of tests that fail:\nhttp://paste.openstack.org/show/623689/","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"2e0970a4f7e54e986d75ea722cc861f1c1c84257","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                greenthread.sleep(0)"},{"line_number":365,"context_line":"                agent.create()"},{"line_number":366,"context_line":"                event_type \u003d events.AFTER_CREATE"},{"line_number":367,"context_line":"                self._log_heartbeat(agent_state, agent,"},{"line_number":368,"context_line":"                                    configurations_dict)"},{"line_number":369,"context_line":"                status \u003d n_const.AGENT_NEW"},{"line_number":370,"context_line":"            greenthread.sleep(0)"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_219cf05b","line":368,"range":{"start_line":367,"start_character":35,"end_line":368,"end_character":56},"updated":"2017-10-12 07:15:49.000000000","message":"Can\u0027t we make it one line? You deleted 4 characters from original codes. There shouldn\u0027t be a problem.","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"f98e16ba417076def5568f8cb2d48d263f780c9b","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                greenthread.sleep(0)"},{"line_number":365,"context_line":"                agent.create()"},{"line_number":366,"context_line":"                event_type \u003d events.AFTER_CREATE"},{"line_number":367,"context_line":"                self._log_heartbeat(agent_state, agent,"},{"line_number":368,"context_line":"                                    configurations_dict)"},{"line_number":369,"context_line":"                status \u003d n_const.AGENT_NEW"},{"line_number":370,"context_line":"            greenthread.sleep(0)"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_b6ed6db8","line":368,"range":{"start_line":367,"start_character":35,"end_line":368,"end_character":56},"in_reply_to":"5f4e5783_219cf05b","updated":"2017-10-16 09:48:47.000000000","message":"Done","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8c83523ee03f0834df796a8d6c397647431388b5","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":238,"context_line":"    def get_agents_db(self, context, filters\u003dNone):"},{"line_number":239,"context_line":"        filters \u003d filters or {}"},{"line_number":240,"context_line":"        return agent_obj.Agent.get_objects(context, **filters)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":243,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f4e5783_f622c5b8","line":240,"updated":"2017-10-16 09:58:18.000000000","message":"name of this method suggests that it will return db object. Maybe it should be changed or some new method should be proposed and this one should then be deprecated?","commit_id":"81c541c4326e64dac70f706b28d0e3f979500fb7"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"8faaed2b13f02fecd6b50eae8e9e60f3ea785255","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":238,"context_line":"    def get_agents_db(self, context, filters\u003dNone):"},{"line_number":239,"context_line":"        filters \u003d filters or {}"},{"line_number":240,"context_line":"        return agent_obj.Agent.get_objects(context, **filters)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":243,"context_line":"    def get_agents(self, context, filters\u003dNone, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f4e5783_5263cab2","line":240,"in_reply_to":"5f4e5783_f622c5b8","updated":"2017-10-17 07:01:54.000000000","message":"Thanks for your suggestion.\nWe\u0027ll keep the original code.","commit_id":"81c541c4326e64dac70f706b28d0e3f979500fb7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8c83523ee03f0834df796a8d6c397647431388b5","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        filters \u003d filters or {}"},{"line_number":245,"context_line":"        alive \u003d filters and filters.pop(\u0027alive\u0027, None)"},{"line_number":246,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":247,"context_line":"        if alive:"},{"line_number":248,"context_line":"            alive \u003d converters.convert_to_boolean(alive[0])"},{"line_number":249,"context_line":"            agents \u003d [agent for agent in agents if agent.is_active \u003d\u003d alive]"},{"line_number":250,"context_line":"        return [self._make_agent_dict(agent, fields\u003dfields)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f4e5783_d62b4992","line":247,"updated":"2017-10-16 09:58:18.000000000","message":"can it be set to \"False\" in filters? if yes, then Your condition should be \"if alive is not None\"","commit_id":"81c541c4326e64dac70f706b28d0e3f979500fb7"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"8faaed2b13f02fecd6b50eae8e9e60f3ea785255","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        filters \u003d filters or {}"},{"line_number":245,"context_line":"        alive \u003d filters and filters.pop(\u0027alive\u0027, None)"},{"line_number":246,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":247,"context_line":"        if alive:"},{"line_number":248,"context_line":"            alive \u003d converters.convert_to_boolean(alive[0])"},{"line_number":249,"context_line":"            agents \u003d [agent for agent in agents if agent.is_active \u003d\u003d alive]"},{"line_number":250,"context_line":"        return [self._make_agent_dict(agent, fields\u003dfields)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5f4e5783_1298b267","line":247,"in_reply_to":"5f4e5783_d62b4992","updated":"2017-10-17 07:01:54.000000000","message":"Yes, it can be \"False\".\nHowever, it only takes agent alive filter.","commit_id":"81c541c4326e64dac70f706b28d0e3f979500fb7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0aef38acebe56ae0790106a01fb163e9f5c74beb","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def get_availability_zones_by_agent_type(context, agent_type,"},{"line_number":82,"context_line":"                                         availability_zones):"},{"line_number":83,"context_line":"    agents \u003d agent_obj.Agent._get_availability_zones_by_agent_type("},{"line_number":84,"context_line":"        context, agent_type\u003dagent_type, availability_zones\u003davailability_zones)"},{"line_number":85,"context_line":"    return [agent.availability_zone for agent in agents]"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_36cb041f","line":82,"updated":"2017-10-22 09:37:05.000000000","message":"can You explain what is the difference between \"availability_zones\" passed as argument and with what is returned from this function?","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ec438e529adf9353f326ccb85a4742db3f103271","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def get_availability_zones_by_agent_type(context, agent_type,"},{"line_number":82,"context_line":"                                         availability_zones):"},{"line_number":83,"context_line":"    agents \u003d agent_obj.Agent._get_availability_zones_by_agent_type("},{"line_number":84,"context_line":"        context, agent_type\u003dagent_type, availability_zones\u003davailability_zones)"},{"line_number":85,"context_line":"    return [agent.availability_zone for agent in agents]"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_26c5e8f1","line":82,"in_reply_to":"3f4b6375_36cb041f","updated":"2017-10-24 09:20:03.000000000","message":"Function\u0027s description has been added","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0aef38acebe56ae0790106a01fb163e9f5c74beb","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    def get_enabled_agent_on_host(self, context, agent_type, host):"},{"line_number":150,"context_line":"        \"\"\"Return agent of agent_type for the specified host.\"\"\""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context,"},{"line_number":153,"context_line":"                                             _pager\u003dbase.Pager(limit\u003d1),"},{"line_number":154,"context_line":"                                             agent_type\u003dagent_type,"},{"line_number":155,"context_line":"                                             host\u003dhost,"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_16d248d3","line":152,"updated":"2017-10-22 09:37:05.000000000","message":"if it\u0027s always only one agent expected, maybe You could use \"get_object()\" method instead of \"get_objects()\"?","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ec438e529adf9353f326ccb85a4742db3f103271","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    def get_enabled_agent_on_host(self, context, agent_type, host):"},{"line_number":150,"context_line":"        \"\"\"Return agent of agent_type for the specified host.\"\"\""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context,"},{"line_number":153,"context_line":"                                             _pager\u003dbase.Pager(limit\u003d1),"},{"line_number":154,"context_line":"                                             agent_type\u003dagent_type,"},{"line_number":155,"context_line":"                                             host\u003dhost,"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_4665841d","line":152,"in_reply_to":"3f4b6375_16d248d3","updated":"2017-10-24 09:20:03.000000000","message":"Done","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0aef38acebe56ae0790106a01fb163e9f5c74beb","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                      \u0027%(host)s\u0027, {\u0027agent_type\u0027: agent_type, \u0027host\u0027: host})"},{"line_number":161,"context_line":"            return"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        agent \u003d agents[0]"},{"line_number":164,"context_line":"        if utils.is_agent_down(agent.heartbeat_timestamp):"},{"line_number":165,"context_line":"            LOG.warning(\u0027%(agent_type)s agent %(agent_id)s is not active\u0027,"},{"line_number":166,"context_line":"                        {\u0027agent_type\u0027: agent_type, \u0027agent_id\u0027: agent.id})"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_f6d44cbf","line":163,"updated":"2017-10-22 09:37:05.000000000","message":"shouldn\u0027t You check if there is no more than one agent for some reason? and raise an exception in such case?\nIn previous implementation query.one() would raise MultipleResultsFound in such case and now IMO You silently ignore it","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8fbe0990bb61b4c1246cb2a18acbf13a21fe9c4d","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":252,"context_line":"        if alive:"},{"line_number":253,"context_line":"            alive \u003d converters.convert_to_boolean(alive[0])"},{"line_number":254,"context_line":"            agents \u003d [agent for agent in agents if agent.is_active \u003d\u003d alive]"},{"line_number":255,"context_line":"        return [self._make_agent_dict(agent, fields\u003dfields)"},{"line_number":256,"context_line":"                for agent in agents]"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_fec19e55","line":254,"updated":"2017-11-02 09:40:51.000000000","message":"But variable \"alive\" is used only in L254 currently. It can\u0027t be False so You can just do:\n   [agent for agent in agents if agent.is_active]\nand then conversion wouldn\u0027t be necessary IMHO","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0aef38acebe56ae0790106a01fb163e9f5c74beb","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":252,"context_line":"        if alive:"},{"line_number":253,"context_line":"            alive \u003d converters.convert_to_boolean(alive[0])"},{"line_number":254,"context_line":"            agents \u003d [agent for agent in agents if agent.is_active \u003d\u003d alive]"},{"line_number":255,"context_line":"        return [self._make_agent_dict(agent, fields\u003dfields)"},{"line_number":256,"context_line":"                for agent in agents]"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_d6db90ea","line":254,"updated":"2017-10-22 09:37:05.000000000","message":"nit: \"alive\" here will always be True so can\u0027t You just use True, then I think that conversion to boolean wouldn\u0027t be necessary anymore","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ec438e529adf9353f326ccb85a4742db3f103271","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":252,"context_line":"        if alive:"},{"line_number":253,"context_line":"            alive \u003d converters.convert_to_boolean(alive[0])"},{"line_number":254,"context_line":"            agents \u003d [agent for agent in agents if agent.is_active \u003d\u003d alive]"},{"line_number":255,"context_line":"        return [self._make_agent_dict(agent, fields\u003dfields)"},{"line_number":256,"context_line":"                for agent in agents]"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_492a377f","line":254,"in_reply_to":"3f4b6375_d6db90ea","updated":"2017-10-24 09:20:03.000000000","message":"Conversion to boolean is necessary because it could be string","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1cb48375d824751294c5b8191c0919eccdf15e31","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":241,"context_line":"    def get_agents_db(self, context, filters\u003dNone):"},{"line_number":242,"context_line":"        # Note(annp): keep this method for backward compatibility"},{"line_number":243,"context_line":"        query \u003d model_query.get_collection_query(context,"},{"line_number":244,"context_line":"                                                 agent_model.Agent,"},{"line_number":245,"context_line":"                                                 filters\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f4b6375_cdf4818a","line":242,"updated":"2017-10-27 17:29:55.000000000","message":"Note -\u003e NOTE\n\nAlso, maybe we need a TODO instead to clean it up later?","commit_id":"67a4363590c57c8823254867505417b3b1fd4740"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ce2930da5e2c6c2724536dfc199faa897aebc037","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":241,"context_line":"    def get_agents_db(self, context, filters\u003dNone):"},{"line_number":242,"context_line":"        # Note(annp): keep this method for backward compatibility"},{"line_number":243,"context_line":"        query \u003d model_query.get_collection_query(context,"},{"line_number":244,"context_line":"                                                 agent_model.Agent,"},{"line_number":245,"context_line":"                                                 filters\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f4b6375_ab7351b1","line":242,"in_reply_to":"3f4b6375_cdf4818a","updated":"2017-10-30 08:09:48.000000000","message":"Done","commit_id":"67a4363590c57c8823254867505417b3b1fd4740"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb610b2f12b320ecef6f9f5fceb462a0a726a46d","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    agents \u003d agent_obj.Agent._get_agents_by_availability_zones_and_agent_type("},{"line_number":63,"context_line":"        context, agent_type\u003dagent_type, availability_zones\u003davailability_zones)"},{"line_number":64,"context_line":"    return [agent.availability_zone for agent in agents]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class AgentAvailabilityZoneMixin(az_ext.AvailabilityZonePluginBase):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_de426268","line":64,"updated":"2017-11-02 10:00:49.000000000","message":"nit: shouldn\u0027t it be converted to set() to remove duplicates?","commit_id":"8c86cc02bff39baf14cbe280714fa7fddd7295fc"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"9a4276b1b7f7f74d9ae788bc21c7c42aba6bb955","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    agents \u003d agent_obj.Agent._get_agents_by_availability_zones_and_agent_type("},{"line_number":63,"context_line":"        context, agent_type\u003dagent_type, availability_zones\u003davailability_zones)"},{"line_number":64,"context_line":"    return [agent.availability_zone for agent in agents]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class AgentAvailabilityZoneMixin(az_ext.AvailabilityZonePluginBase):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_7f146ca0","line":64,"in_reply_to":"3f4b6375_de426268","updated":"2017-11-03 07:27:55.000000000","message":"Done","commit_id":"8c86cc02bff39baf14cbe280714fa7fddd7295fc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb610b2f12b320ecef6f9f5fceb462a0a726a46d","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":237,"context_line":"        if alive:"},{"line_number":238,"context_line":"            alive \u003d converters.convert_to_boolean(alive[0])"},{"line_number":239,"context_line":"            agents \u003d [agent for agent in agents if agent.is_active \u003d\u003d alive]"},{"line_number":240,"context_line":"        return [self._make_agent_dict(agent, fields\u003dfields)"},{"line_number":241,"context_line":"                for agent in agents]"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_be47a677","line":239,"updated":"2017-11-02 10:00:49.000000000","message":"I know that I was already talking about it but I would say once again, IMHO You can do here:\n\n    agents \u003d [agent for agent in agents if agent.is_active]\n\nand then convertion to boolean from L238 will not be necessary","commit_id":"8c86cc02bff39baf14cbe280714fa7fddd7295fc"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"9a4276b1b7f7f74d9ae788bc21c7c42aba6bb955","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":237,"context_line":"        if alive:"},{"line_number":238,"context_line":"            alive \u003d converters.convert_to_boolean(alive[0])"},{"line_number":239,"context_line":"            agents \u003d [agent for agent in agents if agent.is_active \u003d\u003d alive]"},{"line_number":240,"context_line":"        return [self._make_agent_dict(agent, fields\u003dfields)"},{"line_number":241,"context_line":"                for agent in agents]"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_df524067","line":239,"in_reply_to":"3f4b6375_be47a677","updated":"2017-11-03 07:27:55.000000000","message":"As I\u0027ve debugged, \"alive\" before convertion could be: [\u0027false\u0027].\nThat\u0027s why we still need convertion to boolean from L238.","commit_id":"8c86cc02bff39baf14cbe280714fa7fddd7295fc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"114124ef2bb4f702f7797dcd6cdbc0762e449608","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":237,"context_line":"        if alive:"},{"line_number":238,"context_line":"            alive \u003d converters.convert_to_boolean(alive[0])"},{"line_number":239,"context_line":"            agents \u003d [agent for agent in agents if agent.is_active \u003d\u003d alive]"},{"line_number":240,"context_line":"        return [self._make_agent_dict(agent, fields\u003dfields)"},{"line_number":241,"context_line":"                for agent in agents]"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_a2e9abe3","line":239,"in_reply_to":"3f4b6375_df524067","updated":"2017-11-03 08:11:14.000000000","message":"Ok.","commit_id":"8c86cc02bff39baf14cbe280714fa7fddd7295fc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"114124ef2bb4f702f7797dcd6cdbc0762e449608","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    agents \u003d agent_obj.Agent._get_agents_by_availability_zones_and_agent_type("},{"line_number":63,"context_line":"        context, agent_type\u003dagent_type, availability_zones\u003davailability_zones)"},{"line_number":64,"context_line":"    return [set(agent.availability_zone for agent in agents)]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class AgentAvailabilityZoneMixin(az_ext.AvailabilityZonePluginBase):"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f4b6375_e2cc438a","line":64,"updated":"2017-11-03 08:11:14.000000000","message":"I think that You misplaced \"[\" here. Now You returns list with set as first element. Was it really intentional? Shouldn\u0027t You just return set created from list which was in PS 27?","commit_id":"e9a59427807d72145951071f70098bfc7f46c85b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"1209a7a3a82ac849ebb06166545595489fb228ee","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    agents \u003d agent_obj.Agent._get_agents_by_availability_zones_and_agent_type("},{"line_number":63,"context_line":"        context, agent_type\u003dagent_type, availability_zones\u003davailability_zones)"},{"line_number":64,"context_line":"    return [set(agent.availability_zone for agent in agents)]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class AgentAvailabilityZoneMixin(az_ext.AvailabilityZonePluginBase):"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f4b6375_a2488bb2","line":64,"in_reply_to":"3f4b6375_e2cc438a","updated":"2017-11-03 08:28:30.000000000","message":"Done","commit_id":"e9a59427807d72145951071f70098bfc7f46c85b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"21782a97ca1d38d667db12ebc601077b45b7c6a8","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    agents \u003d agent_obj.Agent._get_agents_by_availability_zones_and_agent_type("},{"line_number":63,"context_line":"        context, agent_type\u003dagent_type, availability_zones\u003davailability_zones)"},{"line_number":64,"context_line":"    return set(agent.availability_zone for agent in agents)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class AgentAvailabilityZoneMixin(az_ext.AvailabilityZonePluginBase):"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f4b6375_9515c73f","line":64,"updated":"2017-11-03 08:39:13.000000000","message":"thx, now it looks better :)","commit_id":"913d93d9eb3c50ff88600ed591dd34c07a1ba121"}],"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d4d44fd4e4f978fdec12f7c0575741f6b6e13e19","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            dhcp_notifier \u003d self.agent_notifiers.get(constants.AGENT_TYPE_DHCP)"},{"line_number":319,"context_line":"            dead_bindings \u003d [b for b in"},{"line_number":320,"context_line":"                             self._filter_bindings(context, down_bindings)]"},{"line_number":321,"context_line":"            agents \u003d self.get_agents_objects("},{"line_number":322,"context_line":"                context, {\u0027agent_type\u0027: [constants.AGENT_TYPE_DHCP]})"},{"line_number":323,"context_line":"            if not agents:"},{"line_number":324,"context_line":"                # No agents configured so nothing to do."}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_a9ad449c","line":321,"range":{"start_line":321,"start_character":26,"end_line":321,"end_character":45},"updated":"2017-11-01 20:23:52.000000000","message":"prolly get_agent_objects is slightly better","commit_id":"91b115a8d3bb37a76f0f3aaa5d9f010fe7ee15ab"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ccd92f8a9bafeea1b5d4398cbc828a204a8735fd","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            dhcp_notifier \u003d self.agent_notifiers.get(constants.AGENT_TYPE_DHCP)"},{"line_number":319,"context_line":"            dead_bindings \u003d [b for b in"},{"line_number":320,"context_line":"                             self._filter_bindings(context, down_bindings)]"},{"line_number":321,"context_line":"            agents \u003d self.get_agents_objects("},{"line_number":322,"context_line":"                context, {\u0027agent_type\u0027: [constants.AGENT_TYPE_DHCP]})"},{"line_number":323,"context_line":"            if not agents:"},{"line_number":324,"context_line":"                # No agents configured so nothing to do."}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_344c00c7","line":321,"range":{"start_line":321,"start_character":26,"end_line":321,"end_character":45},"in_reply_to":"3f4b6375_a9ad449c","updated":"2017-11-02 03:18:11.000000000","message":"Done","commit_id":"91b115a8d3bb37a76f0f3aaa5d9f010fe7ee15ab"}],"neutron/objects/agent.py":[{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                group_by(agent_model.Agent.id)."},{"line_number":112,"context_line":"                filter(agent_model.Agent.id.in_(agent_ids))."},{"line_number":113,"context_line":"                order_by(\u0027count\u0027))"},{"line_number":114,"context_line":"        agents \u003d [cls._load_object(context, record[0]) for record in query]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_2f886f6f","side":"PARENT","line":116,"range":{"start_line":114,"start_character":75,"end_line":116,"end_character":21},"updated":"2017-09-04 02:20:54.000000000","message":"Unrelated change?","commit_id":"3514f3e0d283e7b5b7e5851bfe24d03317971edd"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                group_by(agent_model.Agent.id)."},{"line_number":112,"context_line":"                filter(agent_model.Agent.id.in_(agent_ids))."},{"line_number":113,"context_line":"                order_by(\u0027count\u0027))"},{"line_number":114,"context_line":"        agents \u003d [cls._load_object(context, record[0]) for record in query]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_7cf5feec","side":"PARENT","line":116,"range":{"start_line":114,"start_character":75,"end_line":116,"end_character":21},"in_reply_to":"7f287b81_2f886f6f","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"3514f3e0d283e7b5b7e5851bfe24d03317971edd"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        query \u003d model_query.get_collection_query(context, agent_model.Agent,"},{"line_number":124,"context_line":"                                                 filters\u003dfilters)"},{"line_number":125,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":126,"context_line":"        return query"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @classmethod"},{"line_number":129,"context_line":"    def get_agents_by_availability_zone(cls, context, agent_type,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_d45e2244","line":126,"range":{"start_line":126,"start_character":15,"end_line":126,"end_character":20},"updated":"2017-09-04 02:20:54.000000000","message":"Can we return ovo objects here? By using _load_object()","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        query \u003d model_query.get_collection_query(context, agent_model.Agent,"},{"line_number":124,"context_line":"                                                 filters\u003dfilters)"},{"line_number":125,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":126,"context_line":"        return query"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @classmethod"},{"line_number":129,"context_line":"    def get_agents_by_availability_zone(cls, context, agent_type,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_3cc0967c","line":126,"range":{"start_line":126,"start_character":15,"end_line":126,"end_character":20},"in_reply_to":"7f287b81_d45e2244","updated":"2017-09-05 06:18:16.000000000","message":"If we do so, many functional tests will fail.\nTherefore, I\u0027ve added TODO: \"after all agent_db is converted to agent_obj, OVO object will be returned here\".","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            agent_model.Agent.availability_zone)"},{"line_number":135,"context_line":"        query \u003d query.filter("},{"line_number":136,"context_line":"            agent_model.Agent.availability_zone.in_(availability_zones)).all()"},{"line_number":137,"context_line":"        return query"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_b45b9652","line":137,"range":{"start_line":137,"start_character":15,"end_line":137,"end_character":20},"updated":"2017-09-04 02:20:54.000000000","message":"ditto","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            agent_model.Agent.availability_zone)"},{"line_number":135,"context_line":"        query \u003d query.filter("},{"line_number":136,"context_line":"            agent_model.Agent.availability_zone.in_(availability_zones)).all()"},{"line_number":137,"context_line":"        return query"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_1cbf1afc","line":137,"range":{"start_line":137,"start_character":15,"end_line":137,"end_character":20},"in_reply_to":"7f287b81_b45b9652","updated":"2017-09-05 06:18:16.000000000","message":"the same with above","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e27e54b1078e82a6290eec52cd96496856d6eb62","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":127,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":128,"context_line":"        #               OVO object will be returned here."},{"line_number":129,"context_line":"        return query"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def get_agents_by_availability_zone(cls, context, agent_type,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_8554f555","line":129,"updated":"2017-10-04 20:56:44.000000000","message":"sorry for maybe stupid question but why You can\u0027t return OVO objects here now?","commit_id":"c64f3d3dfff6797b4e35366dbe56d7342baddaf9"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"dddeff0e246897eae8431655d41f6f3e33889c19","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":127,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":128,"context_line":"        #               OVO object will be returned here."},{"line_number":129,"context_line":"        return query"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def get_agents_by_availability_zone(cls, context, agent_type,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_4c2d0145","line":129,"in_reply_to":"7f515b1d_8554f555","updated":"2017-10-05 02:46:31.000000000","message":"If we do so, many functional tests will fail.\nTherefore, I\u0027ve added TODO: \"after all agent_db is converted to agent_obj, OVO object will be returned here\".","commit_id":"c64f3d3dfff6797b4e35366dbe56d7342baddaf9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e27e54b1078e82a6290eec52cd96496856d6eb62","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            agent_model.Agent.availability_zone.in_(availability_zones)).all()"},{"line_number":140,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":141,"context_line":"        #               OVO object will be returned here."},{"line_number":142,"context_line":"        return query"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_05c6c517","line":142,"updated":"2017-10-04 20:56:44.000000000","message":"same question here also","commit_id":"c64f3d3dfff6797b4e35366dbe56d7342baddaf9"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"dddeff0e246897eae8431655d41f6f3e33889c19","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            agent_model.Agent.availability_zone.in_(availability_zones)).all()"},{"line_number":140,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":141,"context_line":"        #               OVO object will be returned here."},{"line_number":142,"context_line":"        return query"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_cc20d14c","line":142,"in_reply_to":"7f515b1d_05c6c517","updated":"2017-10-05 02:46:31.000000000","message":"The same with above","commit_id":"c64f3d3dfff6797b4e35366dbe56d7342baddaf9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        query \u003d model_query.get_collection_query(context, agent_model.Agent,"},{"line_number":125,"context_line":"                                                 filters\u003dfilters)"},{"line_number":126,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":127,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":128,"context_line":"        #               OVO object will be returned here."},{"line_number":129,"context_line":"        return query"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_8bfcdfb5","line":127,"updated":"2017-10-05 20:22:49.000000000","message":"I think the only place where the method is called is already converted to OVO. We should change the method to return OVO objects now.","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        query \u003d model_query.get_collection_query(context, agent_model.Agent,"},{"line_number":125,"context_line":"                                                 filters\u003dfilters)"},{"line_number":126,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":127,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":128,"context_line":"        #               OVO object will be returned here."},{"line_number":129,"context_line":"        return query"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_cbdc3776","line":127,"in_reply_to":"7f515b1d_8bfcdfb5","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":127,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":128,"context_line":"        #               OVO object will be returned here."},{"line_number":129,"context_line":"        return query"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def get_agents_by_availability_zone(cls, context, agent_type,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_30b1dae2","line":129,"updated":"2017-10-05 20:22:49.000000000","message":"as any other OVO method, it should return OVO objects and not sqlalchemy queries","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":127,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":128,"context_line":"        #               OVO object will be returned here."},{"line_number":129,"context_line":"        return query"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def get_agents_by_availability_zone(cls, context, agent_type,"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_abd9fb83","line":129,"in_reply_to":"7f515b1d_30b1dae2","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        return query"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def get_agents_by_availability_zone(cls, context, agent_type,"},{"line_number":133,"context_line":"                                        availability_zones):"},{"line_number":134,"context_line":"        query \u003d context.session.query("},{"line_number":135,"context_line":"            agent_model.Agent.availability_zone).filter_by("}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_b0f26a99","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":39},"updated":"2017-10-05 20:22:49.000000000","message":"what it really is is a function that returns available zones. Rename into get_availability_zones_by_agent_type. And maybe also create a little helper somewhere that would not require explicit call on Agent OVO since it seems loosely related.\n\n(in some other file)\ndef get_availability_zones_by_agent_type(...):\n    return Agent._get_availability_zones_by_agent_type(...)\n\n(in neutron/objects/agent.py)\nclass Agent(...):\n    @classmethod\n    def _get_availability_zones_by_agent_type(...):\n        ...\n\nThe use the former function from inside the plugin code. Note that I put an underscore to make it explicit that it\u0027s not supposed to be used directly since it\u0027s not part of the object API.","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        return query"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def get_agents_by_availability_zone(cls, context, agent_type,"},{"line_number":133,"context_line":"                                        availability_zones):"},{"line_number":134,"context_line":"        query \u003d context.session.query("},{"line_number":135,"context_line":"            agent_model.Agent.availability_zone).filter_by("}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_8be63f44","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":39},"in_reply_to":"7f515b1d_b0f26a99","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            agent_model.Agent.availability_zone)"},{"line_number":138,"context_line":"        query \u003d query.filter("},{"line_number":139,"context_line":"            agent_model.Agent.availability_zone.in_(availability_zones)).all()"},{"line_number":140,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":141,"context_line":"        #               OVO object will be returned here."},{"line_number":142,"context_line":"        return query"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_eb20f34b","line":140,"updated":"2017-10-05 20:22:49.000000000","message":"ditto, the only place the method is called is already converted to OVO.","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            agent_model.Agent.availability_zone)"},{"line_number":138,"context_line":"        query \u003d query.filter("},{"line_number":139,"context_line":"            agent_model.Agent.availability_zone.in_(availability_zones)).all()"},{"line_number":140,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":141,"context_line":"        #               OVO object will be returned here."},{"line_number":142,"context_line":"        return query"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_4bd2875e","line":140,"in_reply_to":"7f515b1d_eb20f34b","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            agent_model.Agent.availability_zone.in_(availability_zones)).all()"},{"line_number":140,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":141,"context_line":"        #               OVO object will be returned here."},{"line_number":142,"context_line":"        return query"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_50ba16c0","line":142,"updated":"2017-10-05 20:22:49.000000000","message":"as any other OVO method, it should return OVO objects and not sqlalchemy queries","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            agent_model.Agent.availability_zone.in_(availability_zones)).all()"},{"line_number":140,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":141,"context_line":"        #               OVO object will be returned here."},{"line_number":142,"context_line":"        return query"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_2bd74b4e","line":142,"in_reply_to":"7f515b1d_50ba16c0","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e88e80f0680472b0a85c1ad84a96db3d86acd2f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        query \u003d model_query.get_collection_query(context, agent_model.Agent,"},{"line_number":125,"context_line":"                                                 filters\u003dfilters)"},{"line_number":126,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":127,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":128,"context_line":"        #               OVO object will be returned here."},{"line_number":129,"context_line":"        agents \u003d [cls._load_object(context, record[0]) for record in query]"},{"line_number":130,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_2172bee4","line":127,"updated":"2017-10-11 17:52:28.000000000","message":"this comment now doesn\u0027t make sense since you already return OVO objects","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"2e0970a4f7e54e986d75ea722cc861f1c1c84257","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        query \u003d model_query.get_collection_query(context, agent_model.Agent,"},{"line_number":125,"context_line":"                                                 filters\u003dfilters)"},{"line_number":126,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":127,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":128,"context_line":"        #               OVO object will be returned here."},{"line_number":129,"context_line":"        agents \u003d [cls._load_object(context, record[0]) for record in query]"},{"line_number":130,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_61bb08c4","line":127,"in_reply_to":"5f4e5783_2172bee4","updated":"2017-10-12 07:15:49.000000000","message":"+1. \n\nLine 129 loads db queries to OVO objects.","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"f98e16ba417076def5568f8cb2d48d263f780c9b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        query \u003d model_query.get_collection_query(context, agent_model.Agent,"},{"line_number":125,"context_line":"                                                 filters\u003dfilters)"},{"line_number":126,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":127,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":128,"context_line":"        #               OVO object will be returned here."},{"line_number":129,"context_line":"        agents \u003d [cls._load_object(context, record[0]) for record in query]"},{"line_number":130,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_d64589b5","line":127,"in_reply_to":"5f4e5783_2172bee4","updated":"2017-10-16 09:48:47.000000000","message":"Thanks, I\u0027ve just removed it.","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"f98e16ba417076def5568f8cb2d48d263f780c9b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        query \u003d model_query.get_collection_query(context, agent_model.Agent,"},{"line_number":125,"context_line":"                                                 filters\u003dfilters)"},{"line_number":126,"context_line":"        query \u003d query.with_entities(*columns).group_by(*columns).all()"},{"line_number":127,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":128,"context_line":"        #               OVO object will be returned here."},{"line_number":129,"context_line":"        agents \u003d [cls._load_object(context, record[0]) for record in query]"},{"line_number":130,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_b6420daa","line":127,"in_reply_to":"5f4e5783_61bb08c4","updated":"2017-10-16 09:48:47.000000000","message":"Done","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e88e80f0680472b0a85c1ad84a96db3d86acd2f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        return agents"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @classmethod"},{"line_number":133,"context_line":"    def _get_availability_zones_by_agent_type(cls, context, agent_type,"},{"line_number":134,"context_line":"                                              availability_zones):"},{"line_number":135,"context_line":"        query \u003d context.session.query("},{"line_number":136,"context_line":"            agent_model.Agent.availability_zone).filter_by("}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_c14c0aa0","line":133,"updated":"2017-10-11 17:52:28.000000000","message":"the name suggests you return zones but you return agents instead. so what\u0027s the correct one?","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"f98e16ba417076def5568f8cb2d48d263f780c9b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        return agents"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @classmethod"},{"line_number":133,"context_line":"    def _get_availability_zones_by_agent_type(cls, context, agent_type,"},{"line_number":134,"context_line":"                                              availability_zones):"},{"line_number":135,"context_line":"        query \u003d context.session.query("},{"line_number":136,"context_line":"            agent_model.Agent.availability_zone).filter_by("}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_f625250a","line":133,"in_reply_to":"5f4e5783_c14c0aa0","updated":"2017-10-16 09:48:47.000000000","message":"Thanks, I\u0027ve just updated to \"zones\"","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e88e80f0680472b0a85c1ad84a96db3d86acd2f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            agent_model.Agent.availability_zone)"},{"line_number":139,"context_line":"        query \u003d query.filter("},{"line_number":140,"context_line":"            agent_model.Agent.availability_zone.in_(availability_zones)).all()"},{"line_number":141,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":142,"context_line":"        #               OVO object will be returned here."},{"line_number":143,"context_line":"        agents \u003d [cls._load_object(context, record[0]) for record in query]"},{"line_number":144,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_41601a02","line":141,"updated":"2017-10-11 17:52:28.000000000","message":"ditto for wrong comment","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"f98e16ba417076def5568f8cb2d48d263f780c9b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            agent_model.Agent.availability_zone)"},{"line_number":139,"context_line":"        query \u003d query.filter("},{"line_number":140,"context_line":"            agent_model.Agent.availability_zone.in_(availability_zones)).all()"},{"line_number":141,"context_line":"        # TODO(tuanvu): after all agent_db is converted to agent_obj,"},{"line_number":142,"context_line":"        #               OVO object will be returned here."},{"line_number":143,"context_line":"        agents \u003d [cls._load_object(context, record[0]) for record in query]"},{"line_number":144,"context_line":"        return agents"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f4e5783_b61b2dc8","line":141,"in_reply_to":"5f4e5783_41601a02","updated":"2017-10-16 09:48:47.000000000","message":"Done","commit_id":"e7fa1922396900e9b6b4c610aa24d6e5f722c32b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0aef38acebe56ae0790106a01fb163e9f5c74beb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        return agents"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @classmethod"},{"line_number":120,"context_line":"    def get_agents_grouped_by_zones(cls, context, filters):"},{"line_number":121,"context_line":"        columns \u003d (agent_model.Agent.admin_state_up,"},{"line_number":122,"context_line":"                   agent_model.Agent.availability_zone,"},{"line_number":123,"context_line":"                   agent_model.Agent.agent_type)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_b6d6d4c2","line":120,"updated":"2017-10-22 09:37:05.000000000","message":"is there any test case which will cover this new method? I don\u0027t see it in this patch","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ec438e529adf9353f326ccb85a4742db3f103271","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        return agents"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @classmethod"},{"line_number":120,"context_line":"    def get_agents_grouped_by_zones(cls, context, filters):"},{"line_number":121,"context_line":"        columns \u003d (agent_model.Agent.admin_state_up,"},{"line_number":122,"context_line":"                   agent_model.Agent.availability_zone,"},{"line_number":123,"context_line":"                   agent_model.Agent.agent_type)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_09555ffa","line":120,"in_reply_to":"3f4b6375_b6d6d4c2","updated":"2017-10-24 09:20:03.000000000","message":"Actually, this method is not necessary, so it should be removed.","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1cb48375d824751294c5b8191c0919eccdf15e31","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return agents"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @classmethod"},{"line_number":119,"context_line":"    def _get_availability_zones_by_agent_type(cls, context, agent_type,"},{"line_number":120,"context_line":"                                              availability_zones):"},{"line_number":121,"context_line":"        query \u003d context.session.query("},{"line_number":122,"context_line":"            agent_model.Agent).filter_by("}],"source_content_type":"text/x-python","patch_set":23,"id":"3f4b6375_2d331565","line":119,"updated":"2017-10-27 17:29:55.000000000","message":"the name suggests that you return zones but it returns agent objects.","commit_id":"67a4363590c57c8823254867505417b3b1fd4740"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ce2930da5e2c6c2724536dfc199faa897aebc037","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return agents"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @classmethod"},{"line_number":119,"context_line":"    def _get_availability_zones_by_agent_type(cls, context, agent_type,"},{"line_number":120,"context_line":"                                              availability_zones):"},{"line_number":121,"context_line":"        query \u003d context.session.query("},{"line_number":122,"context_line":"            agent_model.Agent).filter_by("}],"source_content_type":"text/x-python","patch_set":23,"id":"3f4b6375_aba8f1da","line":119,"in_reply_to":"3f4b6375_2d331565","updated":"2017-10-30 08:09:48.000000000","message":"Done","commit_id":"67a4363590c57c8823254867505417b3b1fd4740"}],"neutron/objects/db/api.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":39,"context_line":"def _kwargs_to_filters(**kwargs):"},{"line_number":40,"context_line":"    return {k: v if (isinstance(v, list) or"},{"line_number":41,"context_line":"                     isinstance(v, obj_utils.StringMatchingFilterObj) or"},{"line_number":42,"context_line":"                     isinstance(v, set))"},{"line_number":43,"context_line":"            else [v]"},{"line_number":44,"context_line":"            for k, v in kwargs.items()}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_0bdfcf3a","line":42,"range":{"start_line":42,"start_character":35,"end_line":42,"end_character":40},"updated":"2017-10-05 20:22:49.000000000","message":"where is it needed? can\u0027t the caller convert to list before passing?","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d4d44fd4e4f978fdec12f7c0575741f6b6e13e19","unresolved":false,"context_lines":[{"line_number":39,"context_line":"def _kwargs_to_filters(**kwargs):"},{"line_number":40,"context_line":"    return {k: v if (isinstance(v, list) or"},{"line_number":41,"context_line":"                     isinstance(v, obj_utils.StringMatchingFilterObj) or"},{"line_number":42,"context_line":"                     isinstance(v, set))"},{"line_number":43,"context_line":"            else [v]"},{"line_number":44,"context_line":"            for k, v in kwargs.items()}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_2972744a","line":42,"updated":"2017-11-01 20:23:52.000000000","message":"ideally, this change would be separated from the agent patch since it has its own noble goal, and then it would also include some test case for the change in test_base.\n\nAlso, it starts being rediculous that we list each class separately. isinstance allows to pass a tuple of classes to check against, so we could do smth like:\n\nretain_classes \u003d (list, set, StringMatchingFilterObj)\nreturn {\n    k: v if isinstance(v, retain_classes) else [v]\n    for ...\n}","commit_id":"91b115a8d3bb37a76f0f3aaa5d9f010fe7ee15ab"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ccd92f8a9bafeea1b5d4398cbc828a204a8735fd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"def _kwargs_to_filters(**kwargs):"},{"line_number":40,"context_line":"    return {k: v if (isinstance(v, list) or"},{"line_number":41,"context_line":"                     isinstance(v, obj_utils.StringMatchingFilterObj) or"},{"line_number":42,"context_line":"                     isinstance(v, set))"},{"line_number":43,"context_line":"            else [v]"},{"line_number":44,"context_line":"            for k, v in kwargs.items()}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f4b6375_94d294d0","line":42,"in_reply_to":"3f4b6375_2972744a","updated":"2017-11-02 03:18:11.000000000","message":"Done","commit_id":"91b115a8d3bb37a76f0f3aaa5d9f010fe7ee15ab"}],"neutron/plugins/ml2/drivers/mech_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1cb48375d824751294c5b8191c0919eccdf15e31","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            self, context, segments, candidate_hosts, agent_getter):"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        hosts \u003d set()"},{"line_number":208,"context_line":"        # Note(annp): we don\u0027t support \u0027set\u0027 type in filter fields"},{"line_number":209,"context_line":"        filters \u003d {\u0027host\u0027: list(candidate_hosts),"},{"line_number":210,"context_line":"                   \u0027agent_type\u0027: [self.agent_type]}"},{"line_number":211,"context_line":"        for agent in agent_getter(context, filters\u003dfilters):"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f4b6375_8d4329b0","line":208,"updated":"2017-10-27 17:29:55.000000000","message":"is it a limitation in neutron/objects/db/api or neutron/objects/base? Then how about always converting sets there to lists? Then you don\u0027t need this change.","commit_id":"67a4363590c57c8823254867505417b3b1fd4740"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ce2930da5e2c6c2724536dfc199faa897aebc037","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            self, context, segments, candidate_hosts, agent_getter):"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        hosts \u003d set()"},{"line_number":208,"context_line":"        # Note(annp): we don\u0027t support \u0027set\u0027 type in filter fields"},{"line_number":209,"context_line":"        filters \u003d {\u0027host\u0027: list(candidate_hosts),"},{"line_number":210,"context_line":"                   \u0027agent_type\u0027: [self.agent_type]}"},{"line_number":211,"context_line":"        for agent in agent_getter(context, filters\u003dfilters):"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f4b6375_4be5fd37","line":208,"in_reply_to":"3f4b6375_8d4329b0","updated":"2017-10-30 08:09:48.000000000","message":"Thanks for your suggestion, neutron/objects/db/api has just been updated","commit_id":"67a4363590c57c8823254867505417b3b1fd4740"}],"neutron/scheduler/base_resource_filter.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                # problem because \"+ 1\" here does not meant to predict"},{"line_number":40,"context_line":"                # precisely what the load of the agent will be. The value will"},{"line_number":41,"context_line":"                # be corrected by the agent on the next report interval."},{"line_number":42,"context_line":"                res[\u0027load\u0027] \u003d agent.load + 1"},{"line_number":43,"context_line":"                agent.update_fields(res)"},{"line_number":44,"context_line":"                agent.update()"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_ebceb381","line":43,"range":{"start_line":42,"start_character":17,"end_line":43,"end_character":40},"updated":"2017-10-05 20:22:49.000000000","message":"why not just set it as an attribute right away?\n\nagent.load +\u003d 1\nagent.update()","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                # problem because \"+ 1\" here does not meant to predict"},{"line_number":40,"context_line":"                # precisely what the load of the agent will be. The value will"},{"line_number":41,"context_line":"                # be corrected by the agent on the next report interval."},{"line_number":42,"context_line":"                res[\u0027load\u0027] \u003d agent.load + 1"},{"line_number":43,"context_line":"                agent.update_fields(res)"},{"line_number":44,"context_line":"                agent.update()"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_ebd01353","line":43,"range":{"start_line":42,"start_character":17,"end_line":43,"end_character":40},"in_reply_to":"7f515b1d_ebceb381","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e6e3f8ec57eacf0a577d1f831af978fb3491f477","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                # precisely what the load of the agent will be. The value will"},{"line_number":40,"context_line":"                # be corrected by the agent on the next report interval."},{"line_number":41,"context_line":"                agent.load +\u003d 1"},{"line_number":42,"context_line":"                agent.update()"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_9a9fa44f","line":42,"range":{"start_line":42,"start_character":22,"end_line":42,"end_character":30},"updated":"2017-10-19 23:30:04.000000000","message":"update is expecting an argument. That is why the unit tests are failing: http://logs.openstack.org/10/495810/20/check/openstack-tox-py27/33c2476/job-output.txt.gz#_2017-10-18_07_35_32_793485. Playing with your patch and PDB, I can see the following:\n\nTests running...\n\u003e /home/miguel/neutron/neutron/scheduler/base_resource_filter.py(43)bind()\n-\u003e agent.load +\u003d 1\n(Pdb) agent\n\u003cneutron.db.models.agent.Agent[object at 7fbe24525b10] {id\u003du\u00272eb325e1-a494-4552-a702-354d1302c881\u0027, agent_type\u003du\u0027DHCP agent\u0027, binary\u003du\u0027neutron-dhcp-agent\u0027, topic\u003du\u0027dhcp_agent\u0027, host\u003du\u0027host-c\u0027, availability_zone\u003du\u0027nova\u0027, admin_state_up\u003dTrue, created_at\u003ddatetime.datetime(2017, 10, 19, 23, 20, 48, 707918), started_at\u003ddatetime.datetime(2017, 10, 19, 23, 20, 48, 707918), heartbeat_timestamp\u003ddatetime.datetime(2017, 10, 19, 23, 20, 48, 707918), description\u003dNone, configurations\u003du\u0027{\"dhcp_driver\": \"dhcp_driver\", \"networks\": 0}\u0027, resource_versions\u003dNone, load\u003d0}\u003e\n\nSo agent is of type https://github.com/openstack/neutron/blob/master/neutron/db/models/agent.py#L21. I suspect that when Ihar recommended this optimization, he assumed that you had converted agent to type https://github.com/openstack/neutron/blob/master/neutron/objects/agent.py, which inherits this update method: https://github.com/openstack/neutron/blob/master/neutron/objects/base.py.","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ec438e529adf9353f326ccb85a4742db3f103271","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                # precisely what the load of the agent will be. The value will"},{"line_number":40,"context_line":"                # be corrected by the agent on the next report interval."},{"line_number":41,"context_line":"                agent.load +\u003d 1"},{"line_number":42,"context_line":"                agent.update()"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f4b6375_298b7b6e","line":42,"range":{"start_line":42,"start_character":22,"end_line":42,"end_character":30},"in_reply_to":"3f4b6375_9a9fa44f","updated":"2017-10-24 09:20:03.000000000","message":"Done","commit_id":"346e2598ce8f7aa5d4d33b185d7014ce23b0b578"}],"neutron/scheduler/dhcp_agent_scheduler.py":[{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                \u0027host\u0027: host,"},{"line_number":64,"context_line":"                \u0027admin_state_up\u0027: sql.true()"},{"line_number":65,"context_line":"            }"},{"line_number":66,"context_line":"            dhcp_agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            segment_host_mapping \u003d network.SegmentHostMapping.get_objects("},{"line_number":69,"context_line":"                context, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_ef81474c","line":66,"range":{"start_line":66,"start_character":63,"end_line":66,"end_character":72},"updated":"2017-09-04 02:20:54.000000000","message":"ditto in agents_db()","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                \u0027host\u0027: host,"},{"line_number":64,"context_line":"                \u0027admin_state_up\u0027: sql.true()"},{"line_number":65,"context_line":"            }"},{"line_number":66,"context_line":"            dhcp_agents \u003d agent_obj.Agent.get_objects(context, **filters)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            segment_host_mapping \u003d network.SegmentHostMapping.get_objects("},{"line_number":69,"context_line":"                context, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_fcb9ee14","line":66,"range":{"start_line":66,"start_character":63,"end_line":66,"end_character":72},"in_reply_to":"7f287b81_ef81474c","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        az_hints \u003d (network.get(az_ext.AZ_HINTS) or"},{"line_number":274,"context_line":"                    cfg.CONF.default_availability_zones)"},{"line_number":275,"context_line":"        active_dhcp_agents \u003d self._get_active_agents(plugin, context, az_hints)"},{"line_number":276,"context_line":"        hosted_agent_ids \u003d [agent[\u0027id\u0027] for agent in hosted_agents]"},{"line_number":277,"context_line":"        if not active_dhcp_agents:"},{"line_number":278,"context_line":"            return {\u0027n_agents\u0027: 0, \u0027hostable_agents\u0027: [],"},{"line_number":279,"context_line":"                    \u0027hosted_agents\u0027: hosted_agents}"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_cf20cb4c","line":276,"range":{"start_line":276,"start_character":8,"end_line":276,"end_character":67},"updated":"2017-09-04 02:20:54.000000000","message":"You did this because now hosted_agents are in OVO but active_dhcp_agents are still in db, right? Can you add a TODO explaining that this line is not need after we convert active_dhcp_agents into OVO?","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        az_hints \u003d (network.get(az_ext.AZ_HINTS) or"},{"line_number":274,"context_line":"                    cfg.CONF.default_availability_zones)"},{"line_number":275,"context_line":"        active_dhcp_agents \u003d self._get_active_agents(plugin, context, az_hints)"},{"line_number":276,"context_line":"        hosted_agent_ids \u003d [agent[\u0027id\u0027] for agent in hosted_agents]"},{"line_number":277,"context_line":"        if not active_dhcp_agents:"},{"line_number":278,"context_line":"            return {\u0027n_agents\u0027: 0, \u0027hostable_agents\u0027: [],"},{"line_number":279,"context_line":"                    \u0027hosted_agents\u0027: hosted_agents}"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_9c40aa09","line":276,"range":{"start_line":276,"start_character":8,"end_line":276,"end_character":67},"in_reply_to":"7f287b81_cf20cb4c","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                return False"},{"line_number":59,"context_line":"            dhcp_agents \u003d agent_obj.Agent.get_objects("},{"line_number":60,"context_line":"                context, agent_type\u003dconstants.AGENT_TYPE_DHCP,"},{"line_number":61,"context_line":"                host\u003dhost, admin_state_up\u003dsql.true())"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            segment_host_mapping \u003d network.SegmentHostMapping.get_objects("},{"line_number":64,"context_line":"                context, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_0bad8f9a","line":61,"range":{"start_line":61,"start_character":42,"end_line":61,"end_character":52},"updated":"2017-10-05 20:22:49.000000000","message":"\u003d\u003e True","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                return False"},{"line_number":59,"context_line":"            dhcp_agents \u003d agent_obj.Agent.get_objects("},{"line_number":60,"context_line":"                context, agent_type\u003dconstants.AGENT_TYPE_DHCP,"},{"line_number":61,"context_line":"                host\u003dhost, admin_state_up\u003dsql.true())"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            segment_host_mapping \u003d network.SegmentHostMapping.get_objects("},{"line_number":64,"context_line":"                context, host\u003dhost)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_abc21b84","line":61,"range":{"start_line":61,"start_character":42,"end_line":61,"end_character":52},"in_reply_to":"7f515b1d_0bad8f9a","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                    cfg.CONF.default_availability_zones)"},{"line_number":265,"context_line":"        active_dhcp_agents \u003d self._get_active_agents(plugin, context, az_hints)"},{"line_number":266,"context_line":"        # TODO(tuanvu): below line is not needed after we convert"},{"line_number":267,"context_line":"        #               active_dhcp_agents into OVO"},{"line_number":268,"context_line":"        hosted_agent_ids \u003d [agent[\u0027id\u0027] for agent in hosted_agents]"},{"line_number":269,"context_line":"        if not active_dhcp_agents:"},{"line_number":270,"context_line":"            return {\u0027n_agents\u0027: 0, \u0027hostable_agents\u0027: [],"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_2bb16be2","line":267,"updated":"2017-10-05 20:22:49.000000000","message":"could you please explain why is it so? It seems like the type returned by _get_dhcp_agents_hosting_network is the same, and [\u0027id\u0027] is valid either way, whether it\u0027s a db model, a dict, or OVO.","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1cb48375d824751294c5b8191c0919eccdf15e31","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                       \u0027admin_state_up\u0027: [True]}"},{"line_number":241,"context_line":"            if az_hints:"},{"line_number":242,"context_line":"                filters[\u0027availability_zone\u0027] \u003d az_hints"},{"line_number":243,"context_line":"            active_dhcp_agents \u003d plugin.get_agents_object("},{"line_number":244,"context_line":"                context, filters\u003dfilters)"},{"line_number":245,"context_line":"            if not active_dhcp_agents:"},{"line_number":246,"context_line":"                LOG.warning(\u0027No more DHCP agents\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f4b6375_ad1f05b6","line":243,"updated":"2017-10-27 17:29:55.000000000","message":"the name of the method is not clear. does it return a list of agents [then it would be get_agent_objects], or a single object [then it would be get_agent_object or get_agent_obj]?","commit_id":"67a4363590c57c8823254867505417b3b1fd4740"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"ce2930da5e2c6c2724536dfc199faa897aebc037","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                       \u0027admin_state_up\u0027: [True]}"},{"line_number":241,"context_line":"            if az_hints:"},{"line_number":242,"context_line":"                filters[\u0027availability_zone\u0027] \u003d az_hints"},{"line_number":243,"context_line":"            active_dhcp_agents \u003d plugin.get_agents_object("},{"line_number":244,"context_line":"                context, filters\u003dfilters)"},{"line_number":245,"context_line":"            if not active_dhcp_agents:"},{"line_number":246,"context_line":"                LOG.warning(\u0027No more DHCP agents\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f4b6375_0be82514","line":243,"in_reply_to":"3f4b6375_ad1f05b6","updated":"2017-10-30 08:09:48.000000000","message":"Thanks, the name of the method has been updated","commit_id":"67a4363590c57c8823254867505417b3b1fd4740"}],"neutron/tests/unit/db/test_agents_db.py":[{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c7fc3712add7cff860f7d15624d77dc6820a44d1","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _save_agents(self, agents):"},{"line_number":79,"context_line":"        for agent in agents:"},{"line_number":80,"context_line":"            with self.context.session.begin(subtransactions\u003dTrue):"},{"line_number":81,"context_line":"                agent.create()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _create_and_save_agents(self, hosts, agent_type, down_agents_count\u003d0,"},{"line_number":84,"context_line":"                                down_but_version_considered\u003d0):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_8f1ac314","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":30},"updated":"2017-09-04 02:20:54.000000000","message":"We do not need Line 80 now.","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"99f6442741418051a12d245298bc37131558be85","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _save_agents(self, agents):"},{"line_number":79,"context_line":"        for agent in agents:"},{"line_number":80,"context_line":"            with self.context.session.begin(subtransactions\u003dTrue):"},{"line_number":81,"context_line":"                agent.create()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _create_and_save_agents(self, hosts, agent_type, down_agents_count\u003d0,"},{"line_number":84,"context_line":"                                down_but_version_considered\u003d0):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f287b81_5c4a4227","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":30},"in_reply_to":"7f287b81_8f1ac314","updated":"2017-09-05 06:18:16.000000000","message":"Done","commit_id":"bb30affe258fb378ae6a96a4b03c4b87674a0989"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e27e54b1078e82a6290eec52cd96496856d6eb62","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _take_down_agent(self):"},{"line_number":365,"context_line":"        with self.context.session.begin(subtransactions\u003dTrue):"},{"line_number":366,"context_line":"            agts \u003d agent_obj.Agent.get_objects(self.context)"},{"line_number":367,"context_line":"            agts[0].heartbeat_timestamp \u003d ("},{"line_number":368,"context_line":"                agts[0].heartbeat_timestamp - datetime.timedelta(hours\u003d1))"},{"line_number":369,"context_line":"            agts[0].update()"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_e534c9fd","line":366,"updated":"2017-10-04 20:56:44.000000000","message":"do You really need this shortcut?","commit_id":"c64f3d3dfff6797b4e35366dbe56d7342baddaf9"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"dddeff0e246897eae8431655d41f6f3e33889c19","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _take_down_agent(self):"},{"line_number":365,"context_line":"        with self.context.session.begin(subtransactions\u003dTrue):"},{"line_number":366,"context_line":"            agts \u003d agent_obj.Agent.get_objects(self.context)"},{"line_number":367,"context_line":"            agts[0].heartbeat_timestamp \u003d ("},{"line_number":368,"context_line":"                agts[0].heartbeat_timestamp - datetime.timedelta(hours\u003d1))"},{"line_number":369,"context_line":"            agts[0].update()"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_ace23500","line":366,"in_reply_to":"7f515b1d_e534c9fd","updated":"2017-10-05 02:46:31.000000000","message":"Done","commit_id":"c64f3d3dfff6797b4e35366dbe56d7342baddaf9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            for host in hosts"},{"line_number":76,"context_line":"        ]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _save_agents(self, agents):"},{"line_number":79,"context_line":"        for agent in agents:"},{"line_number":80,"context_line":"            agent.create()"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_8bd4dfea","line":78,"updated":"2017-10-05 20:22:49.000000000","message":"at this point the method is so silly and simple that we could move it inline into line 95 which seems like the only place it\u0027s called to.","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            for host in hosts"},{"line_number":76,"context_line":"        ]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _save_agents(self, agents):"},{"line_number":79,"context_line":"        for agent in agents:"},{"line_number":80,"context_line":"            agent.create()"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_0b412f0c","line":78,"in_reply_to":"7f515b1d_8bd4dfea","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _take_down_agent(self):"},{"line_number":365,"context_line":"        with self.context.session.begin(subtransactions\u003dTrue):"},{"line_number":366,"context_line":"            agent_objs \u003d agent_obj.Agent.get_objects(self.context)"},{"line_number":367,"context_line":"            agent_objs[0].heartbeat_timestamp \u003d \\"},{"line_number":368,"context_line":"                (agent_objs[0].heartbeat_timestamp - datetime.timedelta("},{"line_number":369,"context_line":"                    hours\u003d1))"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_cb665756","line":366,"updated":"2017-10-05 20:22:49.000000000","message":"since we don\u0027t care about the rest except the first agent, use pager to limit the result to 1","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _take_down_agent(self):"},{"line_number":365,"context_line":"        with self.context.session.begin(subtransactions\u003dTrue):"},{"line_number":366,"context_line":"            agent_objs \u003d agent_obj.Agent.get_objects(self.context)"},{"line_number":367,"context_line":"            agent_objs[0].heartbeat_timestamp \u003d \\"},{"line_number":368,"context_line":"                (agent_objs[0].heartbeat_timestamp - datetime.timedelta("},{"line_number":369,"context_line":"                    hours\u003d1))"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_8b54ffcb","line":366,"in_reply_to":"7f515b1d_cb665756","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5d67a99792e976826751f909c7fbbd9a26144926","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    def _take_down_agent(self):"},{"line_number":365,"context_line":"        with self.context.session.begin(subtransactions\u003dTrue):"},{"line_number":366,"context_line":"            agent_objs \u003d agent_obj.Agent.get_objects(self.context)"},{"line_number":367,"context_line":"            agent_objs[0].heartbeat_timestamp \u003d \\"},{"line_number":368,"context_line":"                (agent_objs[0].heartbeat_timestamp - datetime.timedelta("},{"line_number":369,"context_line":"                    hours\u003d1))"},{"line_number":370,"context_line":"            agent_objs[0].update()"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_6b61a339","line":367,"range":{"start_line":367,"start_character":47,"end_line":367,"end_character":49},"updated":"2017-10-05 20:22:49.000000000","message":"nit: you could opening brace on the same line and avoid the \\ char:\n\nagent_objs[0].heartbeat_timestamp \u003d (\n    ...)","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"919d0012de8bdd4dd4aeb47c87fa81cf24b9d6f7","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    def _take_down_agent(self):"},{"line_number":365,"context_line":"        with self.context.session.begin(subtransactions\u003dTrue):"},{"line_number":366,"context_line":"            agent_objs \u003d agent_obj.Agent.get_objects(self.context)"},{"line_number":367,"context_line":"            agent_objs[0].heartbeat_timestamp \u003d \\"},{"line_number":368,"context_line":"                (agent_objs[0].heartbeat_timestamp - datetime.timedelta("},{"line_number":369,"context_line":"                    hours\u003d1))"},{"line_number":370,"context_line":"            agent_objs[0].update()"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f4e5783_6b51c3d8","line":367,"range":{"start_line":367,"start_character":47,"end_line":367,"end_character":49},"in_reply_to":"7f515b1d_6b61a339","updated":"2017-10-11 08:52:58.000000000","message":"Done","commit_id":"793185a77a44419f4cf97b5de391cdcb1e83bde6"}],"neutron/tests/unit/plugins/ml2/drivers/l2pop/test_mech_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"96f0eb82692fcab3e6305325ddbd7f2db642d366","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        scheduler \u003d l3_agent_scheduler.ChanceScheduler()"},{"line_number":215,"context_line":"        filters \u003d {\u0027agent_type\u0027: [constants.AGENT_TYPE_L3]}"},{"line_number":216,"context_line":"        agents_db \u003d self.plugin.get_agents_object(self.adminContext,"},{"line_number":217,"context_line":"                                              filters\u003dfilters)"},{"line_number":218,"context_line":"        for agent_db in agents_db:"},{"line_number":219,"context_line":"            scheduler.create_ha_port_and_bind("},{"line_number":220,"context_line":"                self.plugin,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f4b6375_9bce2d80","line":217,"updated":"2017-10-24 13:08:26.000000000","message":"nit: alignment is wrong here","commit_id":"be9b293b78f1c9de3f4abd943e594d60380b4996"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"36bad160d2de27641e6065d89133f61133f02b45","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        scheduler \u003d l3_agent_scheduler.ChanceScheduler()"},{"line_number":215,"context_line":"        filters \u003d {\u0027agent_type\u0027: [constants.AGENT_TYPE_L3]}"},{"line_number":216,"context_line":"        agents_db \u003d self.plugin.get_agents_object(self.adminContext,"},{"line_number":217,"context_line":"                                              filters\u003dfilters)"},{"line_number":218,"context_line":"        for agent_db in agents_db:"},{"line_number":219,"context_line":"            scheduler.create_ha_port_and_bind("},{"line_number":220,"context_line":"                self.plugin,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f4b6375_f33c1330","line":217,"in_reply_to":"3f4b6375_9bce2d80","updated":"2017-10-25 03:16:16.000000000","message":"Done","commit_id":"be9b293b78f1c9de3f4abd943e594d60380b4996"}]}
