)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"05e9affef0a1865b27266f623e6d0d61ebc87297","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate security group rules for SCTP port ranges"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use the same validation logic for SCTP as the logic for TCP and UDP."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ife90be597d1a59a634d5474dad543dc1803e8242"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_577680a6","line":9,"updated":"2017-08-22 04:39:54.000000000","message":"\"Use the same port range validation logic...\" seems to be less obscure, though the title has already implied this. I don\u0027t have quite strong opinion on this, +1 anyway.","commit_id":"064b05bd9e751e0fe107d9c5b2c5cbf7ee1c58e1"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d8df0af67d4294b6c367786084fb67a7ec65d88f","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            raise ext_sg.SecurityGroupProtocolRequiredWithPorts()"},{"line_number":446,"context_line":"        ip_proto \u003d self._get_ip_proto_number(rule[\u0027protocol\u0027])"},{"line_number":447,"context_line":"        if ip_proto in [constants.PROTO_NUM_SCTP, constants.PROTO_NUM_TCP,"},{"line_number":448,"context_line":"                        constants.PROTO_NUM_UDP]:"},{"line_number":449,"context_line":"            if rule[\u0027port_range_min\u0027] \u003d\u003d 0 or rule[\u0027port_range_max\u0027] \u003d\u003d 0:"},{"line_number":450,"context_line":"                raise ext_sg.SecurityGroupInvalidPortValue(port\u003d0)"},{"line_number":451,"context_line":"            elif (rule[\u0027port_range_min\u0027] is not None and"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_5ce6f418","line":448,"updated":"2017-08-23 01:58:27.000000000","message":"I suppose UDPLITE should also be added, or perhaps create a constant for \"upper layer protocols\" that have port numbers?","commit_id":"064b05bd9e751e0fe107d9c5b2c5cbf7ee1c58e1"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"aa1b18c06e6067107864d88addf3edab1ae2438a","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            raise ext_sg.SecurityGroupProtocolRequiredWithPorts()"},{"line_number":446,"context_line":"        ip_proto \u003d self._get_ip_proto_number(rule[\u0027protocol\u0027])"},{"line_number":447,"context_line":"        if ip_proto in [constants.PROTO_NUM_SCTP, constants.PROTO_NUM_TCP,"},{"line_number":448,"context_line":"                        constants.PROTO_NUM_UDP]:"},{"line_number":449,"context_line":"            if rule[\u0027port_range_min\u0027] \u003d\u003d 0 or rule[\u0027port_range_max\u0027] \u003d\u003d 0:"},{"line_number":450,"context_line":"                raise ext_sg.SecurityGroupInvalidPortValue(port\u003d0)"},{"line_number":451,"context_line":"            elif (rule[\u0027port_range_min\u0027] is not None and"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_77ee6989","line":448,"in_reply_to":"7f287b81_5ce6f418","updated":"2017-08-23 04:12:44.000000000","message":"There\u0027s also DCCP.\nActually those 3 are the protocols supported by ovsfw.","commit_id":"064b05bd9e751e0fe107d9c5b2c5cbf7ee1c58e1"}],"releasenotes/notes/security-group-port-range-check-73114bdcde459e53.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c3cb8775ac0bd221cdddc33e321139bc8a2e2fe4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - In security group rules API, API level validation for port_range values"},{"line_number":4,"context_line":"    has been performed only against TCP and UDP. Now it is performed"},{"line_number":5,"context_line":"    against DCCP, SCTP and UDP-Lite, too."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_a75036d6","line":5,"range":{"start_line":5,"start_character":35,"end_line":5,"end_character":36},"updated":"2017-09-08 19:22:50.000000000","message":"nit: don\u0027t need comma","commit_id":"f711ad78c5c0af44318c6234957590c91592b984"}]}
