)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"041064a6a8794f3a4574aeda6741cfdda42ce510","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In _create_network_policy(), policy object is passed into _get_policy_obj()"},{"line_number":10,"context_line":"although it expects to be passed policy id. This patch passes policy id"},{"line_number":11,"context_line":"instead of policy object and adds a unit test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic4c755c54d93d7ca3312b432b7c1e6770f25c359"},{"line_number":14,"context_line":"Closes-bug: #1712278"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_b55e06e4","line":11,"range":{"start_line":11,"start_character":34,"end_line":11,"end_character":45},"updated":"2017-08-23 08:22:19.000000000","message":"and API tests :)","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"}],"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"041064a6a8794f3a4574aeda6741cfdda42ce510","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            if driver[\u0027name\u0027] \u003d\u003d driver_name:"},{"line_number":38,"context_line":"                return driver"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _create_project(self):"},{"line_number":41,"context_line":"        # Add a project to conduct the test"},{"line_number":42,"context_line":"        test_project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":43,"context_line":"        test_description \u003d data_utils.rand_name(\u0027desc_\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_15e95a19","line":40,"updated":"2017-08-23 08:22:19.000000000","message":"This method looks pretty much like https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/admin/test_quotas.py#L36\n\nIt would make sense to avoid copy\u0026paste and move the method to BaseAdminNetworkTest class.","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6af9d291f2e178981180869996758a3735878fac","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            if driver[\u0027name\u0027] \u003d\u003d driver_name:"},{"line_number":38,"context_line":"                return driver"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _create_project(self):"},{"line_number":41,"context_line":"        # Add a project to conduct the test"},{"line_number":42,"context_line":"        test_project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":43,"context_line":"        test_description \u003d data_utils.rand_name(\u0027desc_\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_4704d017","line":40,"in_reply_to":"7f287b81_15e95a19","updated":"2017-08-23 12:11:11.000000000","message":"You\u0027re right. However, it will change base.py out of scope of this patch. I\u0027ll post another patch for the refactor.","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8f467f631fc0eb6252c69f4aea5a0050f588a3ea","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            if driver[\u0027name\u0027] \u003d\u003d driver_name:"},{"line_number":38,"context_line":"                return driver"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _create_project(self):"},{"line_number":41,"context_line":"        # Add a project to conduct the test"},{"line_number":42,"context_line":"        test_project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":43,"context_line":"        test_description \u003d data_utils.rand_name(\u0027desc_\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_f90484c8","line":40,"in_reply_to":"7f287b81_4704d017","updated":"2017-08-23 12:18:01.000000000","message":"Well, I don\u0027t think that if you move a method from another module, so you can use it in your new code, is unrelated. But maybe that\u0027s just my opinion :)","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4a840c64d4965a90b163a003bc38bcf7679c0bf9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            if driver[\u0027name\u0027] \u003d\u003d driver_name:"},{"line_number":38,"context_line":"                return driver"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _create_project(self):"},{"line_number":41,"context_line":"        # Add a project to conduct the test"},{"line_number":42,"context_line":"        test_project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":43,"context_line":"        test_description \u003d data_utils.rand_name(\u0027desc_\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_cf88d672","line":40,"in_reply_to":"7f287b81_f90484c8","updated":"2017-08-23 13:07:54.000000000","message":"I just copied from test_quotas as you thought so you\u0027re completely right. I had to parepare common method.\n\nI posted the patch https://review.openstack.org/#/c/496701/ now.","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"041064a6a8794f3a4574aeda6741cfdda42ce510","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":409,"context_line":"        self.assertEqual("},{"line_number":410,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":411,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":414,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_15371ab3","line":411,"updated":"2017-08-23 08:22:19.000000000","message":"Shouldn\u0027t this be added to cleanup somewhere on L407?","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"356ac20fcd6c9b3aee99af23d6a911d482940fde","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":409,"context_line":"        self.assertEqual("},{"line_number":410,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":411,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":414,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_38456db4","line":411,"in_reply_to":"7f287b81_15371ab3","updated":"2017-08-23 09:20:51.000000000","message":"I think that self.create_network() is doing that in same way as it\u0027s done for create_qos_policy()","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b1db32e747d54d143570ff857cf7e9299e2f3bb","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":409,"context_line":"        self.assertEqual("},{"line_number":410,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":411,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":414,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_798894c5","line":411,"in_reply_to":"7f287b81_1974f034","updated":"2017-08-23 12:26:23.000000000","message":"You\u0027re right. But it shouldn\u0027t be done in this patch IMHO. I will do separate patch with such change","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6af9d291f2e178981180869996758a3735878fac","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":409,"context_line":"        self.assertEqual("},{"line_number":410,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":411,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":414,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_ccbc676b","line":411,"in_reply_to":"7f287b81_1bb86bc6","updated":"2017-08-23 12:11:11.000000000","message":"The resources which this test created are clenuped finally. This _disassociate_network() avoids the \"in use\" error as Slawek said.","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b536ac3f9e14f7eb95c02064cbe3b19997226a6e","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":409,"context_line":"        self.assertEqual("},{"line_number":410,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":411,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":414,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_db21c3a1","line":411,"in_reply_to":"7f287b81_38456db4","updated":"2017-08-23 09:32:46.000000000","message":"What does it mean? So you think it should be added to cleanup or not? If not and L409 fails, will the network and qos policy be cleaned properly?","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0a71c726dc13b3d9641df4153d6bf36c70cf74eb","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":409,"context_line":"        self.assertEqual("},{"line_number":410,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":411,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":414,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_7c408236","line":411,"in_reply_to":"7f287b81_798894c5","updated":"2017-08-23 12:33:49.000000000","message":"I understand. It\u0027s another bug in test_qos because I just copied. I believe that Slawek will clean the bug.","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e704540ea52bdae708b5594a64c1bb52d54f739a","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":409,"context_line":"        self.assertEqual("},{"line_number":410,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":411,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":414,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_dbaae383","line":411,"in_reply_to":"7f287b81_7bf52fcb","updated":"2017-08-23 09:46:12.000000000","message":"The qos policy is cleaned before cleaning networks - on L126, while networks are cleaned later on L166. I understand it that you can\u0027t delete a qos policy that is used by some resource and hence you need to disassociate qos policy from network before you delete the policy.","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8f467f631fc0eb6252c69f4aea5a0050f588a3ea","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":409,"context_line":"        self.assertEqual("},{"line_number":410,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":411,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":414,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_1974f034","line":411,"in_reply_to":"7f287b81_ccbc676b","updated":"2017-08-23 12:18:01.000000000","message":"So my point is whether the _disassociate_network() should be also added to cleanup.\n\n self.addCleanup(self._disassociate_network, self.admin_client, network[\u0027id\u0027])\n\nbecause, if L409 fails and hence _disassociate_network is *not* called, will the network/qos cleanup be successful, as we\u0027ll be deleting network with associated qos policy.","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"543789075c83da7cc2a93d3061a84d94cf724f1e","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":409,"context_line":"        self.assertEqual("},{"line_number":410,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":411,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":414,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_7bf52fcb","line":411,"in_reply_to":"7f287b81_db21c3a1","updated":"2017-08-23 09:41:50.000000000","message":"IMHO it\u0027s not necessary to add cleanup for it here because each created network is added to list of networks inhttps://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/base.py#L227 and then cleaned in https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/base.py#L166\nBut I can be wrong of course.","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cfeb1d28d9c2598d79e6c54d5f98f97fe913c74d","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":409,"context_line":"        self.assertEqual("},{"line_number":410,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":411,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":414,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_1bb86bc6","line":411,"in_reply_to":"7f287b81_dbaae383","updated":"2017-08-23 09:50:20.000000000","message":"Yes, You can\u0027t remove policy which is \"in use\" and that\u0027s why this dissasotiate_network() is required to call here. But then network should be cleaned later.","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"041064a6a8794f3a4574aeda6741cfdda42ce510","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":426,"context_line":"        self.assertEqual("},{"line_number":427,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":428,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"class QosBandwidthLimitRuleTestJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_954aea24","line":428,"updated":"2017-08-23 08:22:19.000000000","message":"Ditto as L411","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"356ac20fcd6c9b3aee99af23d6a911d482940fde","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":426,"context_line":"        self.assertEqual("},{"line_number":427,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":428,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"class QosBandwidthLimitRuleTestJSON(base.BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_f81805d4","line":428,"in_reply_to":"7f287b81_954aea24","updated":"2017-08-23 09:20:51.000000000","message":"see my comment above","commit_id":"ba2c7e6314a4c884380a804ac75c8a7ddfde301c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a2cdcc6145b8b5a1962bdd7cf9ed5dbe017122ac","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":410,"context_line":"        self.assertEqual("},{"line_number":411,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":412,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":415,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_1c8f3ecd","line":412,"updated":"2017-08-23 12:59:36.000000000","message":"Now you can remove this line :)","commit_id":"0c928d1e9d895cf923d8361066bb561961b13597"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"844acc048dbc0d9d2e29a7808fde2085e1909654","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        retrieved_network \u003d self.admin_client.show_network(network[\u0027id\u0027])"},{"line_number":410,"context_line":"        self.assertEqual("},{"line_number":411,"context_line":"            policy[\u0027id\u0027], retrieved_network[\u0027network\u0027][\u0027qos_policy_id\u0027])"},{"line_number":412,"context_line":"        self._disassociate_network(self.admin_client, network[\u0027id\u0027])"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @decorators.idempotent_id(\u0027807cce45-38e5-482d-94db-36e1796aba73\u0027)"},{"line_number":415,"context_line":"    def test_default_policy_creating_network_with_policy(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_1c561e2b","line":412,"in_reply_to":"7f287b81_1c8f3ecd","updated":"2017-08-23 13:03:30.000000000","message":"oops. Thanks.","commit_id":"0c928d1e9d895cf923d8361066bb561961b13597"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cefdf5ff734491562ca6f689d7b58c57254ca9a9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def _create_project(self):"},{"line_number":41,"context_line":"        # Add a project to conduct the test"},{"line_number":42,"context_line":"        test_project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":43,"context_line":"        test_description \u003d data_utils.rand_name(\u0027desc_\u0027)"},{"line_number":44,"context_line":"        project \u003d self.identity_admin_client.create_project("},{"line_number":45,"context_line":"            name\u003dtest_project,"},{"line_number":46,"context_line":"            description\u003dtest_description)[\u0027project\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_a3f34573","line":43,"range":{"start_line":43,"start_character":38,"end_line":43,"end_character":47},"updated":"2017-08-24 12:34:31.000000000","message":"(no action needed; just comment) It is now used for others than \u0027name\u0027. it might be better to rename it to rand_string or something.","commit_id":"95bbb7385bbd538de99a94b20e2f58718cce16d7"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8afbeef3105484358c2da7dd801832ba5e8d284f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def _create_project(self):"},{"line_number":41,"context_line":"        # Add a project to conduct the test"},{"line_number":42,"context_line":"        test_project \u003d data_utils.rand_name(\u0027test_project_\u0027)"},{"line_number":43,"context_line":"        test_description \u003d data_utils.rand_name(\u0027desc_\u0027)"},{"line_number":44,"context_line":"        project \u003d self.identity_admin_client.create_project("},{"line_number":45,"context_line":"            name\u003dtest_project,"},{"line_number":46,"context_line":"            description\u003dtest_description)[\u0027project\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_fa40cb37","line":43,"range":{"start_line":43,"start_character":38,"end_line":43,"end_character":47},"in_reply_to":"7f287b81_a3f34573","updated":"2017-08-24 15:39:28.000000000","message":"It\u0027s better but tempest lib doesn\u0027t have proper string generator except rand_name. We can add new method like rand_string or pareper other solution here but I guess that it\u0027s too much.","commit_id":"95bbb7385bbd538de99a94b20e2f58718cce16d7"}],"neutron/tests/unit/core_extensions/test_qos.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64d51291279fb7fe452be2a81f87b8aae7f9383d","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        network \u003d {\u0027id\u0027: \u0027dummy_id\u0027, \u0027project_id\u0027: \u0027dummy_project\u0027,"},{"line_number":347,"context_line":"                   qos_consts.QOS_POLICY_ID: None}"},{"line_number":348,"context_line":"        with mock.patch.object(policy.QosPolicyDefault, \u0027get_object\u0027,"},{"line_number":349,"context_line":"                return_value\u003dpolicy_mock), mock.patch.object("},{"line_number":350,"context_line":"                policy.QosPolicy, \u0027get_object\u0027):"},{"line_number":351,"context_line":"            self.core_extension._create_network_policy("},{"line_number":352,"context_line":"                self.context, network, network_changes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_842c0f9a","line":349,"range":{"start_line":349,"start_character":41,"end_line":349,"end_character":43},"updated":"2017-08-22 15:29:22.000000000","message":"Could you wrap lines with a backslash in this case?\n\nWe usually avoid backslashes, but in case of with statement there is no other good way to wrap lines. At least, the current style looks tricky.","commit_id":"97e47bf509d6a293c56cba46d65762af5676e931"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0d31c8409195dd6f63073663918025a01cb0ea23","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        network \u003d {\u0027id\u0027: \u0027dummy_id\u0027, \u0027project_id\u0027: \u0027dummy_project\u0027,"},{"line_number":347,"context_line":"                   qos_consts.QOS_POLICY_ID: None}"},{"line_number":348,"context_line":"        with mock.patch.object(policy.QosPolicyDefault, \u0027get_object\u0027,"},{"line_number":349,"context_line":"                return_value\u003dpolicy_mock), mock.patch.object("},{"line_number":350,"context_line":"                policy.QosPolicy, \u0027get_object\u0027):"},{"line_number":351,"context_line":"            self.core_extension._create_network_policy("},{"line_number":352,"context_line":"                self.context, network, network_changes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_63cb4f53","line":349,"range":{"start_line":349,"start_character":41,"end_line":349,"end_character":43},"in_reply_to":"7f287b81_842c0f9a","updated":"2017-08-22 23:53:45.000000000","message":"Done","commit_id":"97e47bf509d6a293c56cba46d65762af5676e931"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64d51291279fb7fe452be2a81f87b8aae7f9383d","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                policy.QosPolicy, \u0027get_object\u0027):"},{"line_number":351,"context_line":"            self.core_extension._create_network_policy("},{"line_number":352,"context_line":"                self.context, network, network_changes)"},{"line_number":353,"context_line":"            self.assertEqual(policy_id, network[qos_consts.QOS_POLICY_ID])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_78642eba","line":353,"range":{"start_line":353,"start_character":12,"end_line":353,"end_character":74},"updated":"2017-08-22 15:29:22.000000000","message":"honestly I prefer to assertNone. I think we are expecting the value is None rather than the value is same as network[QOS_POLICY_ID].","commit_id":"97e47bf509d6a293c56cba46d65762af5676e931"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0d31c8409195dd6f63073663918025a01cb0ea23","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                policy.QosPolicy, \u0027get_object\u0027):"},{"line_number":351,"context_line":"            self.core_extension._create_network_policy("},{"line_number":352,"context_line":"                self.context, network, network_changes)"},{"line_number":353,"context_line":"            self.assertEqual(policy_id, network[qos_consts.QOS_POLICY_ID])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_c3e1e3d2","line":353,"range":{"start_line":353,"start_character":12,"end_line":353,"end_character":74},"in_reply_to":"7f287b81_78642eba","updated":"2017-08-22 23:53:45.000000000","message":"You mean assertIsNotNone? In _create_network_policy() there is a logic we should confirm the id. Please look at next PS.","commit_id":"97e47bf509d6a293c56cba46d65762af5676e931"}]}
