)]}'
{"neutron/tests/functional/agent/ovsdb/test_impl_idl.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8ad0db159d06d2f0e0edbfd1783595d1e0554e09","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def test_post_commit_vswitchd_incomplete_timeout(self, *args):"},{"line_number":74,"context_line":"        # Due to timing issues we may rarely hit the global timeout, which"},{"line_number":75,"context_line":"        # raises RuntimeError to match the vsctl implementation"},{"line_number":76,"context_line":"        self.ovs.ovsdb.ovsdb_connection.timeout \u003d 3"},{"line_number":77,"context_line":"        self.assertRaises((exc.TimeoutException, RuntimeError), self._add_br)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_becb7aa3","line":76,"updated":"2017-08-23 15:16:38.000000000","message":"I wonder if the non-backward compatible change is gonna creep in non-constrained environments and thus break branches as well. I am almost tempted to say that the fix belongs to ovsdbapp rather then here.","commit_id":"594d8b8b3aa9f8b91b0fd111cd8d8c366068a5b0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f264fbfd39ccdbf1c9acc3baf780ac3385937996","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def test_post_commit_vswitchd_incomplete_timeout(self, *args):"},{"line_number":74,"context_line":"        # Due to timing issues we may rarely hit the global timeout, which"},{"line_number":75,"context_line":"        # raises RuntimeError to match the vsctl implementation"},{"line_number":76,"context_line":"        self.ovs.ovsdb.ovsdb_connection.timeout \u003d 3"},{"line_number":77,"context_line":"        self.assertRaises((exc.TimeoutException, RuntimeError), self._add_br)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_de8e462d","line":76,"in_reply_to":"7f287b81_becb7aa3","updated":"2017-08-23 15:21:59.000000000","message":"And that was my thought as well: https://review.openstack.org/#/c/496742/\n\nOn the other hand, we should unblock the gate as it\u0027s failing constantly, regardless of waiting for new ovsdbapp release.","commit_id":"594d8b8b3aa9f8b91b0fd111cd8d8c366068a5b0"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"688af35cff58a7f5faf1102fe415a2c5083e9d62","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def test_post_commit_vswitchd_incomplete_timeout(self, *args):"},{"line_number":74,"context_line":"        # Due to timing issues we may rarely hit the global timeout, which"},{"line_number":75,"context_line":"        # raises RuntimeError to match the vsctl implementation"},{"line_number":76,"context_line":"        self.ovs.ovsdb.ovsdb_connection.timeout \u003d 3"},{"line_number":77,"context_line":"        self.assertRaises((exc.TimeoutException, RuntimeError), self._add_br)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_de1886d4","line":76,"in_reply_to":"7f287b81_becb7aa3","updated":"2017-08-23 15:30:01.000000000","message":"Honestly, this whole file should just go away/be in ovsdbapp. Neutron shouldn\u0027t be testing ovsdbapp implementations specifically. (non-ovsdbapp code should never even look inside the impl and just use the API)","commit_id":"594d8b8b3aa9f8b91b0fd111cd8d8c366068a5b0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"09be064ad563c337e29a3cd6da8f04fd99cd1801","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def test_post_commit_vswitchd_incomplete_timeout(self, *args):"},{"line_number":74,"context_line":"        # Due to timing issues we may rarely hit the global timeout, which"},{"line_number":75,"context_line":"        # raises RuntimeError to match the vsctl implementation"},{"line_number":76,"context_line":"        self.ovs.ovsdb.ovsdb_connection.timeout \u003d 3"},{"line_number":77,"context_line":"        self.assertRaises((exc.TimeoutException, RuntimeError), self._add_br)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_feefc284","line":76,"in_reply_to":"7f287b81_de1886d4","updated":"2017-08-23 15:34:34.000000000","message":"makes sense, but then this is a public attribute of the class, so any test that relies on it is fair game.","commit_id":"594d8b8b3aa9f8b91b0fd111cd8d8c366068a5b0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0f47c6ce3b29933f98c831d6de40fa996b0f11eb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def test_post_commit_vswitchd_incomplete_timeout(self, *args):"},{"line_number":74,"context_line":"        # Due to timing issues we may rarely hit the global timeout, which"},{"line_number":75,"context_line":"        # raises RuntimeError to match the vsctl implementation"},{"line_number":76,"context_line":"        self.ovs.ovsdb.ovsdb_connection.timeout \u003d 3"},{"line_number":77,"context_line":"        self.assertRaises((exc.TimeoutException, RuntimeError), self._add_br)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_5e9ff64f","line":76,"in_reply_to":"7f287b81_de8e462d","updated":"2017-08-23 15:23:48.000000000","message":"that\u0027s why I was complaining about lack of testing of ovsdbapp against neutron master :/","commit_id":"594d8b8b3aa9f8b91b0fd111cd8d8c366068a5b0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"17d13f2b595267bbe7cfedf68375713863f0501e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def test_post_commit_vswitchd_incomplete_timeout(self, *args):"},{"line_number":74,"context_line":"        # Due to timing issues we may rarely hit the global timeout, which"},{"line_number":75,"context_line":"        # raises RuntimeError to match the vsctl implementation"},{"line_number":76,"context_line":"        self.ovs.ovsdb.ovsdb_connection.timeout \u003d 3"},{"line_number":77,"context_line":"        self.assertRaises((exc.TimeoutException, RuntimeError), self._add_br)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_a0b8f429","line":76,"in_reply_to":"7f287b81_feefc284","updated":"2017-08-23 15:47:36.000000000","message":"I agree with Terry we should kill the file, it doesn\u0027t make sense to test something that is not in the repo.\n\nIf we want to save the 1h that the patch is in check queue, we can follow up.\n\nI also agree we need a backwards compatible property as in Jakub\u0027s patch.","commit_id":"594d8b8b3aa9f8b91b0fd111cd8d8c366068a5b0"}]}
