)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0b95acc947c7c1a4d5fbf5730de0f751174786d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sławek Kapłoński \u003cslawek@kaplonski.pl\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-01 08:45:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix cleaning QoS rules for not existing port."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If port update event is received by L2 agent and there is"},{"line_number":10,"context_line":"no QoS policy assigned to such port, agent tries to delete"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_4554de54","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":45},"updated":"2017-09-01 10:33:09.000000000","message":"If this patch goes for another revision, do remove this fullstop","commit_id":"af9896f269e9963b22b47ea3f3248558ca47390e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0b95acc947c7c1a4d5fbf5730de0f751174786d6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If port update event is received by L2 agent and there is"},{"line_number":10,"context_line":"no QoS policy assigned to such port, agent tries to delete"},{"line_number":11,"context_line":"any existing QoS rules from port."},{"line_number":12,"context_line":"For bandwidth limit rules OVS qos driver tries to update"},{"line_number":13,"context_line":"port in OVS database."},{"line_number":14,"context_line":"In case if port not exists in OVS database agent raised"},{"line_number":15,"context_line":"exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_054ed6c0","line":12,"range":{"start_line":12,"start_character":25,"end_line":12,"end_character":26},"updated":"2017-09-01 10:33:09.000000000","message":"nit: a comma here would be great ( again, if this patch goes into a revision )","commit_id":"af9896f269e9963b22b47ea3f3248558ca47390e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0b95acc947c7c1a4d5fbf5730de0f751174786d6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"any existing QoS rules from port."},{"line_number":12,"context_line":"For bandwidth limit rules OVS qos driver tries to update"},{"line_number":13,"context_line":"port in OVS database."},{"line_number":14,"context_line":"In case if port not exists in OVS database agent raised"},{"line_number":15,"context_line":"exception."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch fixes that by checking if port really exists and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f287b81_e54aaaaa","line":14,"range":{"start_line":14,"start_character":49,"end_line":14,"end_character":55},"updated":"2017-09-01 10:33:09.000000000","message":"nit: raises","commit_id":"af9896f269e9963b22b47ea3f3248558ca47390e"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2570e89d51552dc6389437199f1c2631a531f17c","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                    queues\u003dqueues))"},{"line_number":717,"context_line":"        return qos_uuid"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def _delete_ingress_bw_limit_for_port(self, port_name):"},{"line_number":720,"context_line":"        qos \u003d self._find_qos(port_name)"},{"line_number":721,"context_line":"        queue \u003d self._find_queue(port_name, QOS_DEFAULT_QUEUE)"},{"line_number":722,"context_line":"        with self.ovsdb.transaction(check_error\u003dTrue) as txn:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_c1ac7ba0","line":719,"range":{"start_line":719,"start_character":8,"end_line":719,"end_character":42},"updated":"2017-08-30 12:52:25.000000000","message":"Do we really need separate method for this?","commit_id":"64a01748ee072acefde52cf8e8d491b1f969b54d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0dbe6b7ac1c313c6a034fbbc84b42869465984ad","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                    queues\u003dqueues))"},{"line_number":717,"context_line":"        return qos_uuid"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def _delete_ingress_bw_limit_for_port(self, port_name):"},{"line_number":720,"context_line":"        qos \u003d self._find_qos(port_name)"},{"line_number":721,"context_line":"        queue \u003d self._find_queue(port_name, QOS_DEFAULT_QUEUE)"},{"line_number":722,"context_line":"        with self.ovsdb.transaction(check_error\u003dTrue) as txn:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_97ba0e08","line":719,"range":{"start_line":719,"start_character":8,"end_line":719,"end_character":42},"in_reply_to":"7f287b81_44c88ba4","updated":"2017-08-31 17:44:33.000000000","message":"nit: if I were you, I would move the method to after delete_ingress_bw_limit_for_port, to keep the diff to a minimal, and to keep the relevant code closer to where it\u0027s used.","commit_id":"64a01748ee072acefde52cf8e8d491b1f969b54d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1bfa7d54951c446750a2cfdd626c3cbc63ffdcfc","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                    queues\u003dqueues))"},{"line_number":717,"context_line":"        return qos_uuid"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def _delete_ingress_bw_limit_for_port(self, port_name):"},{"line_number":720,"context_line":"        qos \u003d self._find_qos(port_name)"},{"line_number":721,"context_line":"        queue \u003d self._find_queue(port_name, QOS_DEFAULT_QUEUE)"},{"line_number":722,"context_line":"        with self.ovsdb.transaction(check_error\u003dTrue) as txn:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_e83bafc5","line":719,"range":{"start_line":719,"start_character":8,"end_line":719,"end_character":42},"in_reply_to":"7f287b81_97ba0e08","updated":"2017-08-31 20:13:52.000000000","message":"Done","commit_id":"64a01748ee072acefde52cf8e8d491b1f969b54d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b0070341a5e6a8e7a069deecaa4cef1d30deb0c4","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                    queues\u003dqueues))"},{"line_number":717,"context_line":"        return qos_uuid"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def _delete_ingress_bw_limit_for_port(self, port_name):"},{"line_number":720,"context_line":"        qos \u003d self._find_qos(port_name)"},{"line_number":721,"context_line":"        queue \u003d self._find_queue(port_name, QOS_DEFAULT_QUEUE)"},{"line_number":722,"context_line":"        with self.ovsdb.transaction(check_error\u003dTrue) as txn:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_44c88ba4","line":719,"range":{"start_line":719,"start_character":8,"end_line":719,"end_character":42},"in_reply_to":"7f287b81_c1ac7ba0","updated":"2017-08-30 21:14:11.000000000","message":"no, but I added it to make easier unit test for case when port not exists.\nAll other cases (when port really exists in ovs) are tested in functional tests AFAIK but I thought that such simple unit test for case with not existing port would be worth to add and thanks to this separate method test is easier :)","commit_id":"64a01748ee072acefde52cf8e8d491b1f969b54d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f6013caaa4c0dcc9359d8a77ef57201e404b0354","unresolved":false,"context_lines":[{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def delete_egress_bw_limit_for_port(self, port_name):"},{"line_number":667,"context_line":"        if not self.port_exists(port_name):"},{"line_number":668,"context_line":"            LOG.debug(\"Port %s not found. QoS rule already removed\", port_name)"},{"line_number":669,"context_line":"            return"},{"line_number":670,"context_line":"        self._set_egress_bw_limit_for_port("},{"line_number":671,"context_line":"            port_name, 0, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_b5685f87","line":668,"updated":"2017-08-31 21:29:04.000000000","message":"So just one nit - we just did some log cleanup, so I\u0027m just not sure what logging this gets us?","commit_id":"d836fefc5122d8b92429c6e7b18e13b888f7011b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"49f986074d93a9236a32836d491ca6e409985d19","unresolved":false,"context_lines":[{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def delete_egress_bw_limit_for_port(self, port_name):"},{"line_number":667,"context_line":"        if not self.port_exists(port_name):"},{"line_number":668,"context_line":"            LOG.debug(\"Port %s not found. QoS rule already removed\", port_name)"},{"line_number":669,"context_line":"            return"},{"line_number":670,"context_line":"        self._set_egress_bw_limit_for_port("},{"line_number":671,"context_line":"            port_name, 0, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_b8df36d5","line":668,"in_reply_to":"7f287b81_38b906e9","updated":"2017-08-31 22:35:58.000000000","message":"Yeah, that\u0027s probably not of great value.","commit_id":"d836fefc5122d8b92429c6e7b18e13b888f7011b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6dc00866358f270342907ec98a861d43f980d2ce","unresolved":false,"context_lines":[{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def delete_egress_bw_limit_for_port(self, port_name):"},{"line_number":667,"context_line":"        if not self.port_exists(port_name):"},{"line_number":668,"context_line":"            LOG.debug(\"Port %s not found. QoS rule already removed\", port_name)"},{"line_number":669,"context_line":"            return"},{"line_number":670,"context_line":"        self._set_egress_bw_limit_for_port("},{"line_number":671,"context_line":"            port_name, 0, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_38b906e9","line":668,"in_reply_to":"7f287b81_b5685f87","updated":"2017-08-31 22:19:56.000000000","message":"I just wanted to log (e.g. for tests) that such case occurs and port was not found so QoS rule will not be removed.\nIf You think that it\u0027s useless I can of course remove those logging","commit_id":"d836fefc5122d8b92429c6e7b18e13b888f7011b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"09b25d92e4d65f36b945448f24a52e9d6a78e9be","unresolved":false,"context_lines":[{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def delete_egress_bw_limit_for_port(self, port_name):"},{"line_number":667,"context_line":"        if not self.port_exists(port_name):"},{"line_number":668,"context_line":"            LOG.debug(\"Port %s not found. QoS rule already removed\", port_name)"},{"line_number":669,"context_line":"            return"},{"line_number":670,"context_line":"        self._set_egress_bw_limit_for_port("},{"line_number":671,"context_line":"            port_name, 0, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_df1661f2","line":668,"in_reply_to":"7f287b81_b8df36d5","updated":"2017-09-01 08:46:06.000000000","message":"Removed","commit_id":"d836fefc5122d8b92429c6e7b18e13b888f7011b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f6013caaa4c0dcc9359d8a77ef57201e404b0354","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    def delete_ingress_bw_limit_for_port(self, port_name):"},{"line_number":759,"context_line":"        if not self.port_exists(port_name):"},{"line_number":760,"context_line":"            LOG.debug(\"Port %s not found. QoS rule already removed\", port_name)"},{"line_number":761,"context_line":"            return"},{"line_number":762,"context_line":"        self._delete_ingress_bw_limit_for_port(port_name)"},{"line_number":763,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_950323bf","line":760,"updated":"2017-08-31 21:29:04.000000000","message":"Same","commit_id":"d836fefc5122d8b92429c6e7b18e13b888f7011b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"09b25d92e4d65f36b945448f24a52e9d6a78e9be","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    def delete_ingress_bw_limit_for_port(self, port_name):"},{"line_number":759,"context_line":"        if not self.port_exists(port_name):"},{"line_number":760,"context_line":"            LOG.debug(\"Port %s not found. QoS rule already removed\", port_name)"},{"line_number":761,"context_line":"            return"},{"line_number":762,"context_line":"        self._delete_ingress_bw_limit_for_port(port_name)"},{"line_number":763,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_bfd15532","line":760,"in_reply_to":"7f287b81_950323bf","updated":"2017-09-01 08:46:06.000000000","message":"Removed","commit_id":"d836fefc5122d8b92429c6e7b18e13b888f7011b"}]}
