)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9f96871554e54e59734390bb8bc5178facabe25c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"but ip_lib doesn\u0027t support constructing such commands."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Of course, we could extend ip_lib to support this use case, but it seems"},{"line_number":19,"context_line":"like the test fix is of small benefit but high risk for production code."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This patch merely disables the test case if DHCP agent is running in a"},{"line_number":22,"context_line":"namespace. We may revisit it when and if we feel comfortable making"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_2d169b4a","line":19,"range":{"start_line":19,"start_character":24,"end_line":19,"end_character":37},"updated":"2017-08-30 07:01:29.000000000","message":"We\u0027ll need nested namespace support anyway once I craft the patch to run all agents in namespaces.","commit_id":"2f540364542e3f66180338e8aafcb19556bd2eac"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e1549759eb5404c1c09fdeacb197b60b8d4dfc05","unresolved":false,"context_lines":[{"line_number":16,"context_line":"but ip_lib doesn\u0027t support constructing such commands."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Of course, we could extend ip_lib to support this use case, but it seems"},{"line_number":19,"context_line":"like the test fix is of small benefit but high risk for production code."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This patch merely disables the test case if DHCP agent is running in a"},{"line_number":22,"context_line":"namespace. We may revisit it when and if we feel comfortable making"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_83f430f2","line":19,"range":{"start_line":19,"start_character":24,"end_line":19,"end_character":37},"in_reply_to":"7f287b81_2d169b4a","updated":"2017-08-30 17:29:44.000000000","message":"OK, I will add todo then","commit_id":"2f540364542e3f66180338e8aafcb19556bd2eac"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"93ec20d89cf3929e157c957dafda8d0362218a4e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Of course, we could extend ip_lib to support this use case, but"},{"line_number":19,"context_line":"currently we have larger dragons to fight. We will revisit the skip once"},{"line_number":20,"context_line":"all agents are moved to namespaces as planned by jlibosva@."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This patch merely disables the test case if DHCP agent is running in a"},{"line_number":23,"context_line":"namespace. We may revisit it when and if we feel comfortable making"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_6a163eaa","line":20,"range":{"start_line":20,"start_character":49,"end_line":20,"end_character":58},"updated":"2017-09-05 16:33:34.000000000","message":"jlibosva@redhat.com or what is the @ sign? :)","commit_id":"1a5b796b0639593eaee36be5a7b3ac371884d67d"}]}
