)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ade40ae98149bb74328df77617bb196a73cf3f9b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Tempest] Protocol number is added instead of str for sec group rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of providing \u0027icmp\u0027 str in security rule creatioin, we test"},{"line_number":10,"context_line":"that providing appropriate number instead  works as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I094e964c19835d2c66a44abe41c9675fd87ceeee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_53af4829","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":58},"updated":"2017-08-30 09:19:39.000000000","message":"creation","commit_id":"989a5399833a11287d3a79e54ea31ae56f6b45bd"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"8c34d5b49d16ec218f50bc9654a95ed9cf6f61e9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Tempest] Protocol number is added instead of str for sec group rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of providing \u0027icmp\u0027 str in security rule creatioin, we test"},{"line_number":10,"context_line":"that providing appropriate number instead  works as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I094e964c19835d2c66a44abe41c9675fd87ceeee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_1eed47b6","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":58},"in_reply_to":"7f287b81_53af4829","updated":"2017-08-30 09:52:09.000000000","message":"Done","commit_id":"989a5399833a11287d3a79e54ea31ae56f6b45bd"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e89263b79bc39a7d0b2b11c7d0c164f7e829de7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Genadi Chereshnya \u003cgcheresh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-30 12:51:34 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Tempest] Protocol number is added instead of str for sec group rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of providing \u0027icmp\u0027 str in security rule creation, we test"},{"line_number":10,"context_line":"that providing appropriate number instead  works as well."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_779d7b08","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":68},"updated":"2017-08-30 22:18:14.000000000","message":"First line in commit message shouldn\u0027t be longer that 50 characters","commit_id":"f225f0443d1ca0e6c1426fb1e6a1c6e11fef9de3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"266208e16e1cfad678a4e380ee6057c90abbc36d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Genadi Chereshnya \u003cgcheresh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-05 11:32:33 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Tempest] Creating sec group rule with int"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of providing \u0027icmp\u0027 str in security rule creation, we test"},{"line_number":10,"context_line":"that providing appropriate number instead  works as well."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f287b81_73299699","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":42},"updated":"2017-09-05 20:43:04.000000000","message":"I think a better form would be e.g. -\u003e Create security group rule with an integer","commit_id":"b66506e358d3d89853c73ca6f8ab120a602fb738"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"af327b8f0c4029f65e68319e355db4a60cb97d59","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Genadi Chereshnya \u003cgcheresh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-05 11:32:33 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Tempest] Creating sec group rule with int"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of providing \u0027icmp\u0027 str in security rule creation, we test"},{"line_number":10,"context_line":"that providing appropriate number instead  works as well."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f287b81_41bfae60","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":42},"in_reply_to":"7f287b81_73299699","updated":"2017-09-07 09:20:20.000000000","message":"Done","commit_id":"b66506e358d3d89853c73ca6f8ab120a602fb738"}],"neutron/tests/tempest/scenario/test_default_sec_grp.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ade40ae98149bb74328df77617bb196a73cf3f9b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            num_servers\u003d1)"},{"line_number":97,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":98,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":99,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: 1,"},{"line_number":100,"context_line":"                      \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":101,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":102,"context_line":"        secgroup_id \u003d self.os_primary.network_client.list_security_groups()["}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_138c20d5","line":99,"range":{"start_line":99,"start_character":34,"end_line":99,"end_character":35},"updated":"2017-08-30 09:19:39.000000000","message":"small nit: isn\u0027t better to use a neutron-lib constant?\n\nhttps://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L154-L174\n\n\"icmp\" --\u003e constants.PROTO_NUM_ICMP","commit_id":"989a5399833a11287d3a79e54ea31ae56f6b45bd"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"8c34d5b49d16ec218f50bc9654a95ed9cf6f61e9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            num_servers\u003d1)"},{"line_number":97,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":98,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":99,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: 1,"},{"line_number":100,"context_line":"                      \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":101,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":102,"context_line":"        secgroup_id \u003d self.os_primary.network_client.list_security_groups()["}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_332ddca7","line":99,"range":{"start_line":99,"start_character":34,"end_line":99,"end_character":35},"in_reply_to":"7f287b81_138c20d5","updated":"2017-08-30 09:52:09.000000000","message":"Done","commit_id":"989a5399833a11287d3a79e54ea31ae56f6b45bd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ade40ae98149bb74328df77617bb196a73cf3f9b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":98,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":99,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: 1,"},{"line_number":100,"context_line":"                      \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":101,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":102,"context_line":"        secgroup_id \u003d self.os_primary.network_client.list_security_groups()["},{"line_number":103,"context_line":"            \u0027security_groups\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d3c338ec","line":100,"range":{"start_line":100,"start_character":36,"end_line":100,"end_character":43},"updated":"2017-08-30 09:19:39.000000000","message":"small nit: the same --\u003e https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L319","commit_id":"989a5399833a11287d3a79e54ea31ae56f6b45bd"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"8c34d5b49d16ec218f50bc9654a95ed9cf6f61e9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":98,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":99,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: 1,"},{"line_number":100,"context_line":"                      \u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":101,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":102,"context_line":"        secgroup_id \u003d self.os_primary.network_client.list_security_groups()["},{"line_number":103,"context_line":"            \u0027security_groups\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_3ed92321","line":100,"range":{"start_line":100,"start_character":36,"end_line":100,"end_character":43},"in_reply_to":"7f287b81_d3c338ec","updated":"2017-08-30 09:52:09.000000000","message":"Done","commit_id":"989a5399833a11287d3a79e54ea31ae56f6b45bd"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e89263b79bc39a7d0b2b11c7d0c164f7e829de7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from tempest.common import waiters"},{"line_number":16,"context_line":"from tempest.lib import decorators"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":"from neutron.tests.tempest.common import ssh"},{"line_number":20,"context_line":"from neutron.tests.tempest import config"},{"line_number":21,"context_line":"from neutron.tests.tempest.scenario import base"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_775a1b83","line":18,"updated":"2017-08-30 22:18:14.000000000","message":"Now you have two imported modules constants. Please see L22. And also neutron lib imports go in the third party imports section above","commit_id":"f225f0443d1ca0e6c1426fb1e6a1c6e11fef9de3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e89263b79bc39a7d0b2b11c7d0c164f7e829de7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":98,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":99,"context_line":"        rule_list \u003d [{\u0027protocol\u0027: constants.PROTO_NUM_ICMP,"},{"line_number":100,"context_line":"                      \u0027direction\u0027: constants.INGRESS_DIRECTION ,"},{"line_number":101,"context_line":"                      \u0027remote_ip_prefix\u0027: \u00270.0.0.0/0\u0027}]"},{"line_number":102,"context_line":"        secgroup_id \u003d self.os_primary.network_client.list_security_groups()["},{"line_number":103,"context_line":"            \u0027security_groups\u0027][0][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_77e8db7a","line":100,"range":{"start_line":100,"start_character":62,"end_line":100,"end_character":63},"updated":"2017-08-30 22:18:14.000000000","message":"not needed","commit_id":"f225f0443d1ca0e6c1426fb1e6a1c6e11fef9de3"}],"neutron/tests/tempest/scenario/test_security_groups.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b9cc140ca6a47ea493f8ac69db18ef41b3bca09f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from tempest.common import waiters"},{"line_number":16,"context_line":"from tempest.lib import decorators"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":"from neutron.tests.tempest.common import ssh"},{"line_number":20,"context_line":"from neutron.tests.tempest import config"},{"line_number":21,"context_line":"from neutron.tests.tempest.scenario import base"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_b0d4ad48","line":18,"updated":"2017-09-05 00:20:17.000000000","message":"If you move this line right before L15, you pep8 tests will pass. Also, you don\u0027t need to wait for Gerrit results to check pep8 compliance. You can do the check before sending the patchset to gerrit by running in your development system:\n\ntox -e pep8 HEAD~1\n\nThis command will only check the files touched by your pacthset","commit_id":"3b73e0b0b862189007df3d7f24670ce2822f642f"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"a22b6aa876c728b79c67f9edde82caaa5827adf0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from tempest.common import waiters"},{"line_number":16,"context_line":"from tempest.lib import decorators"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":"from neutron.tests.tempest.common import ssh"},{"line_number":20,"context_line":"from neutron.tests.tempest import config"},{"line_number":21,"context_line":"from neutron.tests.tempest.scenario import base"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_f27a35b8","line":18,"in_reply_to":"7f287b81_b0d4ad48","updated":"2017-09-05 08:31:47.000000000","message":"Thanks for comment, Done","commit_id":"3b73e0b0b862189007df3d7f24670ce2822f642f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b9cc140ca6a47ea493f8ac69db18ef41b3bca09f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.check_connectivity(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":74,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":75,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # make sure ICMP connectivity still fails as only ssh rule was added"},{"line_number":78,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":79,"context_line":"                             should_succeed\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_70ce45b5","line":76,"updated":"2017-09-05 00:20:17.000000000","message":"Ditto","commit_id":"3b73e0b0b862189007df3d7f24670ce2822f642f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"eab7be80d4f12949bfa586ec491064232184f0b4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.check_connectivity(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":74,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":75,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # make sure ICMP connectivity still fails as only ssh rule was added"},{"line_number":78,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":79,"context_line":"                             should_succeed\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_f04eb536","line":76,"in_reply_to":"7f287b81_70ce45b5","updated":"2017-09-05 00:30:14.000000000","message":"What I meant here is that this change seems un-related to this patchset. It is recommended that you don\u0027t do gratuitous changes, so reviewers don\u0027t get confused","commit_id":"3b73e0b0b862189007df3d7f24670ce2822f642f"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"a22b6aa876c728b79c67f9edde82caaa5827adf0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.check_connectivity(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":74,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":75,"context_line":"                                self.keypair[\u0027private_key\u0027])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # make sure ICMP connectivity still fails as only ssh rule was added"},{"line_number":78,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":79,"context_line":"                             should_succeed\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_72488586","line":76,"in_reply_to":"7f287b81_f04eb536","updated":"2017-09-05 08:31:47.000000000","message":"This patch is rebased on another patch that this fix goes in there","commit_id":"3b73e0b0b862189007df3d7f24670ce2822f642f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2dba31319b12617e842ac06ec59697dedebbd1dc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], ext_net_ip)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d864\u0027)"},{"line_number":96,"context_line":"    def test_protocol_number_rule(self):"},{"line_number":97,"context_line":"        # protocol number is added instead of str in security rule creation"},{"line_number":98,"context_line":"        server_ssh_clients, fips \u003d self.create_vm_default_sec_grp("},{"line_number":99,"context_line":"            num_servers\u003d1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_d3b4a684","line":96,"updated":"2017-09-06 20:55:11.000000000","message":"this test case should be tagged with security-groups and router required api extensions. (But if you check that for the whole class in the dependency patch, then we can avoid doing it here.)","commit_id":"b66506e358d3d89853c73ca6f8ab120a602fb738"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"af327b8f0c4029f65e68319e355db4a60cb97d59","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], ext_net_ip)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d864\u0027)"},{"line_number":96,"context_line":"    def test_protocol_number_rule(self):"},{"line_number":97,"context_line":"        # protocol number is added instead of str in security rule creation"},{"line_number":98,"context_line":"        server_ssh_clients, fips \u003d self.create_vm_default_sec_grp("},{"line_number":99,"context_line":"            num_servers\u003d1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_46d46420","line":96,"in_reply_to":"7f287b81_d3b4a684","updated":"2017-09-07 09:20:20.000000000","message":"Done","commit_id":"b66506e358d3d89853c73ca6f8ab120a602fb738"}]}