)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0e127d64de5986fb6f93ae3db334bd7b24ceb836","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP][POC] generalize OVSFirewallDriver code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An attempt to make it possible to reuse the driver"},{"line_number":10,"context_line":"code in related projects like neutron-fwaas without"},{"line_number":11,"context_line":"copy-paste approach"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia930caaf78cf58e7af59c6374520f06e5ee379b3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_7c67974e","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":43},"updated":"2017-08-31 08:20:32.000000000","message":"I\u0027m wondering how can you re-use this driver, when the driver interface consumes security groups and ports resources. All flows are generated based on security group rules - do you plan to have some resource for fwaas that will be sg-alike?\n\nWouldn\u0027t it be less painful to implement security groups on router interfaces instead?","commit_id":"937076845bcaeceb22c3147d3360c682e89c123a"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"0f204cf1e625c5b21fdb2fec861a12076cf4da64","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP][POC] generalize OVSFirewallDriver code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An attempt to make it possible to reuse the driver"},{"line_number":10,"context_line":"code in related projects like neutron-fwaas without"},{"line_number":11,"context_line":"copy-paste approach"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia930caaf78cf58e7af59c6374520f06e5ee379b3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_d263ddb0","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":43},"in_reply_to":"7f287b81_7c67974e","updated":"2017-09-02 21:14:57.000000000","message":"As far as I understand the author\u0027s idea, this patch https://review.openstack.org/#/c/447251/ introduces the ability for fwaas to manage vm ports traffic in the way ovsfw driver for security groups does that.\nThe amount of maintenance burden it introduces raised a red flag so I tried to think of another way round (not the \"ovsfw driver code fork before the conj_ip manager\").\n\nAs for implementing SG\u0027s on router interfaces - currently fwaas v2 controls traffic at router port level, but the traffic to vm ports is still managed by neutron security groups (they still have to be configured). I believe that was the idea - to do all stuff with fwaas - but I can\u0027t find a blueprint to prove me right though :(","commit_id":"937076845bcaeceb22c3147d3360c682e89c123a"}],"neutron/agent/linux/openvswitch_firewall/mapping.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"80d6b29361ee25b0f081d1eb48b599312237651b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def __getattr__(self, name):"},{"line_number":28,"context_line":"        return getattr(self.consts_module, name)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Tables used for ovs firewall"},{"line_number":31,"context_line":"    BASE_EGRESS_TABLE \u003d 71"},{"line_number":32,"context_line":"    RULES_EGRESS_TABLE \u003d 72"},{"line_number":33,"context_line":"    ACCEPT_OR_INGRESS_TABLE \u003d 73"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_dfbae108","line":30,"range":{"start_line":30,"start_character":3,"end_line":30,"end_character":34},"updated":"2017-09-01 08:39:07.000000000","message":"Correct me if I\u0027m wrong but what you want is to be able to define your own constants/exceptions/etc with this class.\n\n\"Tables used for ovs firewall\" are already defined so I think you don\u0027t need to redefine here, just in the project (e.g.: fwaas) you need to use the FW.","commit_id":"c9be10a58597c41732b6a2f64007043df4c76bb2"}]}