)]}'
{"neutron/tests/unit/test_config.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d558b420afdfc40a5694e35b9aa24a3b67f91c01","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_load_paste_app_not_found(self):"},{"line_number":49,"context_line":"        self.config(api_paste_config\u003d\u0027no_such_file.conf\u0027)"},{"line_number":50,"context_line":"        self.stubs.Set(cfg.CONF, \u0027find_file\u0027, lambda name: None)"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            config.load_paste_app(\u0027app\u0027)"},{"line_number":53,"context_line":"        except cfg.ConfigFilesNotFoundError as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2F7Eo%3D","line":50,"updated":"2013-10-08 00:44:43.000000000","message":"We\u0027re in the process of phasing out the use of mox.  Please use the mock library to patch cfg.CONF.","commit_id":"0aebfe24112438b23d9fa622a39df6adca38df23"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"87c644eea63a633906fbd1d378ecdaeab75c9525","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_load_paste_app_not_found(self):"},{"line_number":49,"context_line":"        self.config(api_paste_config\u003d\u0027no_such_file.conf\u0027)"},{"line_number":50,"context_line":"        self.stubs.Set(cfg.CONF, \u0027find_file\u0027, lambda name: None)"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            config.load_paste_app(\u0027app\u0027)"},{"line_number":53,"context_line":"        except cfg.ConfigFilesNotFoundError as e:"},{"line_number":54,"context_line":"            self.assertEqual([\u0027no_such_file.conf\u0027], e.config_files)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2F95o%3D","line":51,"updated":"2013-10-07 11:08:02.000000000","message":"Could the following lines be replaced with:\n\nself.assertRaises(cfg.ConfigFilesNotFoundError, config.load_paste_app, \u0027app\u0027)\n\nor using a with clause, if you want to also check the assert value too?","commit_id":"0aebfe24112438b23d9fa622a39df6adca38df23"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c033229758f02251187df412950bac726b73e648","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def test_load_paste_app_not_found(self):"},{"line_number":50,"context_line":"        self.config(api_paste_config\u003d\u0027no_such_file.conf\u0027)"},{"line_number":51,"context_line":"        with mock.patch.object(cfg.CONF, \u0027find_file\u0027) as ff:"},{"line_number":52,"context_line":"            ff.return_value \u003d None"},{"line_number":53,"context_line":"            e \u003d self.assertRaises(cfg.ConfigFilesNotFoundError,"},{"line_number":54,"context_line":"                                  config.load_paste_app, \u0027app\u0027)"},{"line_number":55,"context_line":"            self.assertEqual([\u0027no_such_file.conf\u0027], e.config_files)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F6HU%3D","line":52,"updated":"2013-10-08 07:41:43.000000000","message":"(suggestion only) return_value can be specified in patch/patch.object, so we can change it to the following. It is simpler but it doesn\u0027t matter.\n\n  with mock.patch.object(cfg.CONF, \u0027find_file\u0027, return_value\u003dNone):\n    e \u003d self.assertRaises(....)","commit_id":"bb45292d3a13b446b1968686bf786cbf521d3d51"},{"author":{"_account_id":3068,"name":"Arata Notsu","email":"notsu@virtualtech.jp","username":"arata776"},"change_message_id":"b2f9565bfd2526983a0764c0b5a7152443eb5672","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def test_load_paste_app_not_found(self):"},{"line_number":50,"context_line":"        self.config(api_paste_config\u003d\u0027no_such_file.conf\u0027)"},{"line_number":51,"context_line":"        with mock.patch.object(cfg.CONF, \u0027find_file\u0027) as ff:"},{"line_number":52,"context_line":"            ff.return_value \u003d None"},{"line_number":53,"context_line":"            e \u003d self.assertRaises(cfg.ConfigFilesNotFoundError,"},{"line_number":54,"context_line":"                                  config.load_paste_app, \u0027app\u0027)"},{"line_number":55,"context_line":"            self.assertEqual([\u0027no_such_file.conf\u0027], e.config_files)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F58Q%3D","line":52,"in_reply_to":"AAAATH%2F%2F6HU%3D","updated":"2013-10-08 08:43:05.000000000","message":"Thanks. Also added a check to check find_file is really called.","commit_id":"bb45292d3a13b446b1968686bf786cbf521d3d51"}]}
