)]}'
{"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"07dbf30f9afd008ada8087bf839153cd45791976","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                    # Handle the case were there is no host binding"},{"line_number":768,"context_line":"                    # for the private ports that are associated with"},{"line_number":769,"context_line":"                    # floating ip."},{"line_number":770,"context_line":"                    if not fip[\u0027host\u0027]:"},{"line_number":771,"context_line":"                        fip[l3_const.DVR_SNAT_BOUND] \u003d True"},{"line_number":772,"context_line":"        routers_dict \u003d self._process_routers(context, routers, agent)"},{"line_number":773,"context_line":"        self._process_floating_ips_dvr(context, routers_dict,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_ec91e053","line":770,"updated":"2017-09-07 19:43:16.000000000","message":"Will this not be true for both fip[\u0027host\u0027] \u003d \u0027\u0027 and for fip[\u0027host\u0027] \u003d None","commit_id":"2c6e35d5c23c53cf7b37cbfdf0f73b8f4f3a5f68"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bd4c7f5f893267f86c28a24e29dfde88af1faaf8","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                    # Handle the case were there is no host binding"},{"line_number":768,"context_line":"                    # for the private ports that are associated with"},{"line_number":769,"context_line":"                    # floating ip."},{"line_number":770,"context_line":"                    if not fip[\u0027host\u0027]:"},{"line_number":771,"context_line":"                        fip[l3_const.DVR_SNAT_BOUND] \u003d True"},{"line_number":772,"context_line":"        routers_dict \u003d self._process_routers(context, routers, agent)"},{"line_number":773,"context_line":"        self._process_floating_ips_dvr(context, routers_dict,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_9f2720c8","line":770,"in_reply_to":"7f287b81_ec91e053","updated":"2017-09-07 20:31:33.000000000","message":"It will, but I thought in this case (VM port) that we need to bind the port somewhere, so if nothing is here we need to set dvr_snat_bound.\n\nI took a slightly different approach by always setting fip[\u0027host\u0027] \u003d \u0027\u0027 so that it was always something in _process_floating_ips_dvr() and always sent to agent.","commit_id":"2c6e35d5c23c53cf7b37cbfdf0f73b8f4f3a5f68"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"2f91e1a653b6915f25217a5f98547d870d14f02d","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        Skip if fip_host is unbound, or the agent requesting is not in dvr_snat"},{"line_number":683,"context_line":"        mode and the fip has not been assigned \u0027dvr_snat_bound\u0027 state."},{"line_number":684,"context_line":"        \"\"\""},{"line_number":685,"context_line":"        if fip_host \u003d\u003d l3_const.FLOATING_IP_HOST_UNBOUND:"},{"line_number":686,"context_line":"            return False"},{"line_number":687,"context_line":"        # If fip_host is unbound, then the fip is not in migration,"},{"line_number":688,"context_line":"        # so checking for dest_host is irrelevant.  Skip if is"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff5d4b2f_53094edb","line":685,"updated":"2017-09-19 06:25:30.000000000","message":"The comment says, \"Skip if fip_host is unbound,\" but Line 686 is returning \"False\", which means not skipping, right?","commit_id":"918c6b6769cb3be673efe8adc084e3ac7d8d339a"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"91b7fc0c80b438fc0ff0120832f0d30b1a4b6fa6","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        self, floating_ip, fip_host, agent):"},{"line_number":684,"context_line":"        \"\"\"Function to check if floatingip need to be processed or skipped."},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        Skip if fip_host is unbound, or the agent requesting is not in dvr_snat"},{"line_number":687,"context_line":"        mode and the fip has not been assigned \u0027dvr_snat_bound\u0027 state."},{"line_number":688,"context_line":"        \"\"\""},{"line_number":689,"context_line":"        if fip_host \u003d\u003d l3_const.FLOATING_IP_HOST_UNBOUND:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff5d4b2f_3b2c6846","line":686,"range":{"start_line":686,"start_character":28,"end_line":686,"end_character":36},"updated":"2017-09-19 13:35:40.000000000","message":"Yes here \u0027unbound\u0027 should be empty string \u0027\u0027.\n\u0027Skip if fip_host is \u0027\u0027, or.\nSince the l3_const.FLOATING_IP_HOST_UNBOUND denotes \u0027\u0027.","commit_id":"d172f0f48f6cdc1dafe0934a57810bfa4fa56065"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"51a014998af21b0c0b3f009d1232467939713875","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        self, floating_ip, fip_host, agent):"},{"line_number":684,"context_line":"        \"\"\"Function to check if floatingip need to be processed or skipped."},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        Skip if fip_host is \u0027\u0027, or the agent requesting is not in dvr_snat"},{"line_number":687,"context_line":"        mode and the fip has not been assigned \u0027dvr_snat_bound\u0027 state."},{"line_number":688,"context_line":"        \"\"\""},{"line_number":689,"context_line":"        if fip_host \u003d\u003d l3_const.FLOATING_IP_HOST_UNBOUND:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_1603b944","line":686,"range":{"start_line":686,"start_character":28,"end_line":686,"end_character":30},"updated":"2017-09-19 14:22:18.000000000","message":"I wouldn\u0027t have changed this, \"unbound\" was correct as we are using a constant to denote what unbound is - it\u0027s a string now and not \u0027\u0027.","commit_id":"594744768d7613f2a6d44b033127985709fa7679"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"06f68fc1cb8ec20aaec86c15f749fce1ed8a26d3","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        self, floating_ip, fip_host, agent):"},{"line_number":684,"context_line":"        \"\"\"Function to check if floatingip need to be processed or skipped."},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        Skip if fip_host is \u0027\u0027, or the agent requesting is not in dvr_snat"},{"line_number":687,"context_line":"        mode and the fip has not been assigned \u0027dvr_snat_bound\u0027 state."},{"line_number":688,"context_line":"        \"\"\""},{"line_number":689,"context_line":"        if fip_host \u003d\u003d l3_const.FLOATING_IP_HOST_UNBOUND:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_defe57ad","line":686,"range":{"start_line":686,"start_character":28,"end_line":686,"end_character":30},"in_reply_to":"ff5d4b2f_1603b944","updated":"2017-09-19 15:23:40.000000000","message":"Brian please go ahead and change it back, the reason I changed it is since the constant denotes it an empty string.\nMay be change it to empty string.","commit_id":"594744768d7613f2a6d44b033127985709fa7679"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"51a014998af21b0c0b3f009d1232467939713875","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        mode and the fip has not been assigned \u0027dvr_snat_bound\u0027 state."},{"line_number":688,"context_line":"        \"\"\""},{"line_number":689,"context_line":"        if fip_host \u003d\u003d l3_const.FLOATING_IP_HOST_UNBOUND:"},{"line_number":690,"context_line":"            return False"},{"line_number":691,"context_line":"        # If fip_host is unbound, then the fip is not in migration,"},{"line_number":692,"context_line":"        # so checking for dest_host is irrelevant.  Skip if is"},{"line_number":693,"context_line":"        # bound to the SNAT node."}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_5845df16","line":690,"updated":"2017-09-19 14:22:18.000000000","message":"We might need to change something here, or even rename the function.","commit_id":"594744768d7613f2a6d44b033127985709fa7679"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"51a014998af21b0c0b3f009d1232467939713875","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        agent_mode \u003d self._get_agent_mode(agent)"},{"line_number":695,"context_line":"        return (agent_mode in [const.L3_AGENT_MODE_LEGACY,"},{"line_number":696,"context_line":"                               const.L3_AGENT_MODE_DVR] and"},{"line_number":697,"context_line":"                floating_ip.get(l3_const.DVR_SNAT_BOUND))"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    def _get_fip_agent_gw_ports(self, context, fip_agent_id):"},{"line_number":700,"context_line":"        \"\"\"Return list of floating agent gateway ports for the agent.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_d869cf8b","line":697,"updated":"2017-09-19 14:22:18.000000000","message":"I think when we dropped the \u0027not\u0027 here we inverted the logic, which is why False worked above.  We\u0027ll fix it up.","commit_id":"594744768d7613f2a6d44b033127985709fa7679"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"dad9c49979413025fc6119e3ee7959c38d0ff945","unresolved":false,"context_lines":[{"line_number":653,"context_line":"                router_floatingips.append(floating_ip)"},{"line_number":654,"context_line":"                router[const.FLOATINGIP_KEY] \u003d router_floatingips"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def _skip_floating_ip_for_agent_or_host(self, floating_ip, agent, host):"},{"line_number":657,"context_line":"        \"\"\"Function to check if floating IP needs to not be processed."},{"line_number":658,"context_line":"        \"\"\""},{"line_number":659,"context_line":"        fip_host \u003d self._get_floating_ip_host(floating_ip)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf57530f_9a6c6009","line":656,"range":{"start_line":656,"start_character":9,"end_line":656,"end_character":43},"updated":"2017-09-20 15:50:43.000000000","message":"Suggestion: _skip_floating_ip_for_mismatched_agent_or_host","commit_id":"1c0adcb85cdc2a5149f9be8a846e813f8ba4f485"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ac59a6c2663ed56fdc06f261956e652c8001c8ec","unresolved":false,"context_lines":[{"line_number":653,"context_line":"                router_floatingips.append(floating_ip)"},{"line_number":654,"context_line":"                router[const.FLOATINGIP_KEY] \u003d router_floatingips"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def _skip_floating_ip_for_agent_or_host(self, floating_ip, agent, host):"},{"line_number":657,"context_line":"        \"\"\"Function to check if floating IP needs to not be processed."},{"line_number":658,"context_line":"        \"\"\""},{"line_number":659,"context_line":"        fip_host \u003d self._get_floating_ip_host(floating_ip)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf57530f_261e7d0c","line":656,"range":{"start_line":656,"start_character":9,"end_line":656,"end_character":43},"in_reply_to":"bf57530f_9a6c6009","updated":"2017-09-20 16:46:25.000000000","message":"Done","commit_id":"1c0adcb85cdc2a5149f9be8a846e813f8ba4f485"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"dad9c49979413025fc6119e3ee7959c38d0ff945","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                    floating_ip.get(l3_const.DVR_SNAT_BOUND)):"},{"line_number":668,"context_line":"                return True"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        # Skip if it is unbound"},{"line_number":671,"context_line":"        if fip_host \u003d\u003d l3_const.FLOATING_IP_HOST_UNBOUND:"},{"line_number":672,"context_line":"            return True"},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf57530f_da7898f9","line":670,"range":{"start_line":670,"start_character":8,"end_line":670,"end_character":31},"updated":"2017-09-20 15:50:43.000000000","message":"May this should be the condition that must be checked first, and if it fails, we don\u0027t need to check for other conditions.\nMoving it up would be good.","commit_id":"1c0adcb85cdc2a5149f9be8a846e813f8ba4f485"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ac59a6c2663ed56fdc06f261956e652c8001c8ec","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                    floating_ip.get(l3_const.DVR_SNAT_BOUND)):"},{"line_number":668,"context_line":"                return True"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        # Skip if it is unbound"},{"line_number":671,"context_line":"        if fip_host \u003d\u003d l3_const.FLOATING_IP_HOST_UNBOUND:"},{"line_number":672,"context_line":"            return True"},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf57530f_4b03bc43","line":670,"range":{"start_line":670,"start_character":8,"end_line":670,"end_character":31},"in_reply_to":"bf57530f_da7898f9","updated":"2017-09-20 16:46:25.000000000","message":"Done","commit_id":"1c0adcb85cdc2a5149f9be8a846e813f8ba4f485"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d759ba6a69746bb8a48fcf83cd6270f115fd2a26","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                    floating_ip.get(l3_const.DVR_SNAT_BOUND)):"},{"line_number":668,"context_line":"                return True"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        # Skip if it is unbound"},{"line_number":671,"context_line":"        if fip_host \u003d\u003d l3_const.FLOATING_IP_HOST_UNBOUND:"},{"line_number":672,"context_line":"            return True"},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bf57530f_01bc7903","line":670,"range":{"start_line":670,"start_character":8,"end_line":670,"end_character":31},"updated":"2017-09-20 22:23:12.000000000","message":"Was there any issue in moving this line up. I did see that you moved back to its original position.\nJust to understand?","commit_id":"3cd3f0b73f40c4320876e3fe77404bcd75361a8a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"da8388e760bc1d2f7a42baaa40dcca0172e6f90f","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                    floating_ip.get(l3_const.DVR_SNAT_BOUND)):"},{"line_number":668,"context_line":"                return True"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        # Skip if it is unbound"},{"line_number":671,"context_line":"        if fip_host \u003d\u003d l3_const.FLOATING_IP_HOST_UNBOUND:"},{"line_number":672,"context_line":"            return True"},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f5c4f37_2e409d35","line":670,"range":{"start_line":670,"start_character":8,"end_line":670,"end_character":31},"in_reply_to":"bf57530f_01bc7903","updated":"2017-09-21 13:29:38.000000000","message":"I moved it up and the functional tests failed strangely, I just moved it back to test a theory.  Since they still fail I have more work to do, but I\u0027ll be moving it up again.","commit_id":"3cd3f0b73f40c4320876e3fe77404bcd75361a8a"}]}
